staging: vt6656: Fix calling conditions of vnt_set_bss_mode
Subsystems (2)
PATCH 1/1 staging: vt6656: Fix calling conditions of vnt_set_bss_mode
vnt_set_bss_mode needs to be called on all changes to BSS_CHANGED_BASIC_RATES, BSS_CHANGED_ERP_PREAMBLE and BSS_CHANGED_ERP_SLOT
Remove all other calls and vnt_update_ifs which is called in vnt_set_bss_mode.
Fixes an issue that preamble mode is not being updated correctly.
Fixes c12603576e06 ("staging: vt6656: Only call vnt_set_bss_mode on basic rates change.")
Cc stable <[email protected]>
Signed-off-by Malcolm Priestley <[email protected]>
--- drivers/staging/vt6656/main_usb.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/staging/vt6656/main_usb.c +4 -4
@@ -625,8 +625,6 @@ static int vnt_add_interface(struct ieee80211_hw *hw, struct ieee80211_vif *vif) priv->op_mode = vif->type; -vnt_set_bss_mode (priv); -/* LED blink on TX */ vnt_mac_set_led (priv,LEDSTS_STS ,LEDSTS_INTER );
@@ -706,7 +704,6 @@ static void vnt_bss_info_changed(struct ieee80211_hw *hw, priv->basic_rates = conf->basic_rates;vnt_update_top_rates (priv); -vnt_set_bss_mode (priv);dev_dbg (&priv->usb->dev,"basic rates %x\n" , conf->basic_rates); }
@@ -735,11 +732,14 @@ static void vnt_bss_info_changed(struct ieee80211_hw *hw, priv->short_slot_time = false;vnt_set_short_slot_time (priv); -vnt_update_ifs (priv);vnt_set_vga_gain_offset (priv, priv->bb_vga[0 ]);vnt_update_pre_ed_threshold (priv, false); } +if (changed & (BSS_CHANGED_BASIC_RATES |BSS_CHANGED_ERP_PREAMBLE | +BSS_CHANGED_ERP_SLOT )) +vnt_set_bss_mode (priv); +if (changed & (BSS_CHANGED_TXPOWER |BSS_CHANGED_BANDWIDTH ))vnt_rf_setpower (priv, conf->chandef.chan);
Signature · 1 line
2.25.1
Sorry this was sent twice gmail reported the first one failed.
Regards
Maloclm