Skip to contentSkip to conversation

zynq: fix I2C in SPL

PATCH New Hannes Schmelzer 3 participants 5 messages Feb 14, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 zynq: fix I2C in SPL

The commit 'f48ef0d81aa837a33020f8d61abb3929ba613774' did break I2C support because requesting the clock for the I2C ip-block isn't supported during SPL.

To fixup this we add support requesting clocks for:
- i2c0
- i2c1

---

 drivers/clk/clk_zynq.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/clk/clk_zynq.c +3 -0
index 482f093..9a4e949 100644
@@ -434,6 +434,9 @@ static ulong zynq_clk_get_rate(struct clk *clk)
 	case lqspi_clk ... pcap_clk:
 	case sdio0_clk ... spi1_clk:
 		return zynq_clk_get_peripheral_rate(priv, id, 0);
+	case i2c0_aper_clk ... i2c1_aper_clk:
+		return zynq_clk_get_cpu_rate(priv, cpu_1x_clk);
+
 	default:
 		return -ENXIO;
 	}
Signature · 1 line
2.7.4
#1 lore raw

PATCH 1/1 zynq: fix I2C in SPL

Hi,

first of all I would rephrase subject a little bit.

Something like:
"ARM: zynq: Add missing i2c get_rate for fixing i2c SPL"

Quoted 20 lines · Hannes Schmelzer

The commit 'f48ef0d81aa837a33020f8d61abb3929ba613774' did break I2C support because requesting the clock for the I2C ip-block isn't supported during SPL.

To fixup this we add support requesting clocks for:
- i2c0
- i2c1

---

 drivers/clk/clk_zynq.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/clk/clk_zynq.c +0 -0
index 482f093..9a4e949 100644

drivers/clk/clk_zynq.c static ulong zynq_clk_get_rate(struct clk *clk) · line 439

Quoted 6 lines
drivers/clk/clk_zynq.c +3 -0
@@ -434,6 +434,9 @@ static ulong zynq_clk_get_rate(struct clk *clk)
 	case lqspi_clk ... pcap_clk:
 	case sdio0_clk ... spi1_clk:
 		return zynq_clk_get_peripheral_rate(priv, id, 0);
+	case i2c0_aper_clk ... i2c1_aper_clk:
+		return zynq_clk_get_cpu_rate(priv, cpu_1x_clk);
+

please remove this empty line.

drivers/clk/clk_zynq.c static ulong zynq_clk_get_rate(struct clk *clk) · line 442

Quoted 4 lines
drivers/clk/clk_zynq.c +0 -0
 	default:
 		return -ENXIO;
 	}

I am also curious why you are enabling I2C in SPL. What are you doing with that?

Thanks,
Michal

Signature · 14 lines
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Xilinx Microblaze
Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs
U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP/Versal SoCs


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190214/cb17424d/attachment.sig>
#2 lore raw

[U-Boot] Antwort: Re: [PATCH] zynq: fix I2C in SPL

Quoted 2 lines

Hi,

Hi Michal,

Quoted 5 lines

first of all I would rephrase subject a little bit.

Something like:
"ARM: zynq: Add missing i2c get_rate for fixing i2c SPL"

OK.

Quoted 17 lines · Hannes Schmelzer
Quoted 15 lines

The commit 'f48ef0d81aa837a33020f8d61abb3929ba613774' did break I2C support because requesting the clock for the I2C ip-block isn't supported during SPL.

To fixup this we add support requesting clocks for:
- i2c0
- i2c1

---

 drivers/clk/clk_zynq.c | 3 +++
 1 file changed, 3 insertions(+)
Quoted 13 lines

drivers/clk/clk_zynq.c static ulong zynq_clk_get_rate(struct clk *clk) · line 439

Quoted 11 lines
drivers/clk/clk_zynq.c +3 -0
index 482f093..9a4e949 100644
@@ -434,6 +434,9 @@ static ulong zynq_clk_get_rate(struct clk *clk)
    case lqspi_clk ... pcap_clk:
    case sdio0_clk ... spi1_clk:
       return zynq_clk_get_peripheral_rate(priv, id, 0);
+   case i2c0_aper_clk ... i2c1_aper_clk:
+      return zynq_clk_get_cpu_rate(priv, cpu_1x_clk);
+

please remove this empty line.

OK. I'll send V2 patch.

Quoted 8 lines

drivers/clk/clk_zynq.c static ulong zynq_clk_get_rate(struct clk *clk) · line 442

Quoted 5 lines
drivers/clk/clk_zynq.c +0 -0
    default:
       return -ENXIO;
    }

I am also curious why you are enabling I2C in SPL. What are you doing with that?

I have to turn on very early some voltage rails on my board, where i have to communicate with i2c to a resetcontroller.

Quoted 3 lines

Thanks,
Michal

cheers,
Hannes

#3 lore raw

[U-Boot] Antwort: Re: [PATCH] zynq: fix I2C in SPL

Quoted 50 lines · Hannes Schmelzer
Quoted 2 lines

Hi,

Hi Michal,

Quoted 5 lines

first of all I would rephrase subject a little bit.

Something like:
"ARM: zynq: Add missing i2c get_rate for fixing i2c SPL"

OK.

Quoted 17 lines · Hannes Schmelzer
Quoted 15 lines

The commit 'f48ef0d81aa837a33020f8d61abb3929ba613774' did break I2C support because requesting the clock for the I2C ip-block isn't supported during SPL.

To fixup this we add support requesting clocks for:
- i2c0
- i2c1

---

 drivers/clk/clk_zynq.c | 3 +++
 1 file changed, 3 insertions(+)
Quoted 13 lines

drivers/clk/clk_zynq.c static ulong zynq_clk_get_rate(struct clk *clk) · line 439

Quoted 11 lines
drivers/clk/clk_zynq.c +3 -0
index 482f093..9a4e949 100644
@@ -434,6 +434,9 @@ static ulong zynq_clk_get_rate(struct clk *clk)
    case lqspi_clk ... pcap_clk:
    case sdio0_clk ... spi1_clk:
       return zynq_clk_get_peripheral_rate(priv, id, 0);
+   case i2c0_aper_clk ... i2c1_aper_clk:
+      return zynq_clk_get_cpu_rate(priv, cpu_1x_clk);
+

please remove this empty line.

OK. I'll send V2 patch.

Quoted 6 lines
Quoted 5 lines
drivers/clk/clk_zynq.c +0 -0
    default:
       return -ENXIO;
    }
Quoted 4 lines
Quoted 2 lines

I am also curious why you are enabling I2C in SPL. What are you doing with that?

I have to turn on very early some voltage rails on my board, where i have to communicate with i2c to a resetcontroller.

ok. How does that code look like?
Just dm_i2c_write?

I have never tried i2c in spl.

Thanks,
Michal

Signature · 14 lines
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Xilinx Microblaze
Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs
U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP/Versal SoCs


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190214/71989cf0/attachment.sig>
#4 lore raw

[U-Boot] Antwort: Re: [PATCH] zynq: fix I2C in SPL

Quoted 44 lines · Michal Simek
Quoted 43 lines · Hannes Schmelzer
Quoted 1 line

Hi,

Hi Michal,

Quoted 4 lines

first of all I would rephrase subject a little bit.

Something like:
"ARM: zynq: Add missing i2c get_rate for fixing i2c SPL"

OK.

Quoted 16 lines · Hannes Schmelzer
Quoted 15 lines

The commit 'f48ef0d81aa837a33020f8d61abb3929ba613774' did break I2C support because requesting the clock for the I2C ip-block isn't supported during SPL.

To fixup this we add support requesting clocks for:
- i2c0
- i2c1

---

  drivers/clk/clk_zynq.c | 3 +++
  1 file changed, 3 insertions(+)
Quoted 12 lines

drivers/clk/clk_zynq.c static ulong zynq_clk_get_rate(struct clk *clk) · line 439

Quoted 11 lines
drivers/clk/clk_zynq.c +3 -0
index 482f093..9a4e949 100644
@@ -434,6 +434,9 @@ static ulong zynq_clk_get_rate(struct clk *clk)
     case lqspi_clk ... pcap_clk:
     case sdio0_clk ... spi1_clk:
        return zynq_clk_get_peripheral_rate(priv, id, 0);
+   case i2c0_aper_clk ... i2c1_aper_clk:
+      return zynq_clk_get_cpu_rate(priv, cpu_1x_clk);
+

please remove this empty line.

OK. I'll send V2 patch.

Quoted 4 lines
Quoted 4 lines
drivers/clk/clk_zynq.c +0 -0
     default:
        return -ENXIO;
     }
Quoted 8 lines
Quoted 4 lines
Quoted 2 lines

I am also curious why you are enabling I2C in SPL. What are you doing with that?

I have to turn on very early some voltage rails on my board, where i have to communicate with i2c to a resetcontroller.

ok. How does that code look like?
Just dm_i2c_write?

I have never tried i2c in spl.

hi michal,

here for example:

int board_init(void)    /* spl stage */
{
    u16 u16buf;
    u8 u8buf;
    int rc;
    struct udevice *dev;

    /* peripheral RESET on PSOC reset-controller */
    rc = i2c_get_chip_for_busnum(0, RSTCTRL_ADDR_PSOC, 1, &dev); if (rc == 0) {
        u16buf = RSTCTRL_CTRLSPEC_nPCIRST;
        rc = dm_i2c_write(dev, RSTCTRL_CTRLSPEC,
                  (uint8_t *)&u16buf, sizeof(u16buf));
    } else {
        printf("failed to get i2c chip for PSOC resetcontroller!\n"); }

    return 0;
}

later on my plan is to push my board mainline once development has been finished.

Quoted 2 lines

Thanks,
Michal

cheers,
Hannes