kunit: Fix kunit.py --raw_output option
PATCH 1/1 kunit: Fix kunit.py --raw_output option
Due to the raw_output() function on kunit_parser.py actually being a generator, it only runs if something reads the lines it returns. Since we no-longer do that (parsing doesn't actually happen if raw_output is enabled), it was not printing anything.
--- tools/testing/kunit/kunit_parser.py | 1 - 1 file changed, 1 deletion(-)
tools/testing/kunit/kunit_parser.py +0 -1
@@ -66,7 +66,6 @@ def isolate_kunit_output(kernel_output): def raw_output(kernel_output): for line in kernel_output: print(line) - yield line DIVIDER = '=' * 60
Signature · 1 line
2.29.0.rc1.297.gfa9743e501-goog
Quoted 8 lines · David Gow
Due to the
raw_output()function onkunit_parser.pyactually being a generator, it only runs if something reads the lines it returns. Since we no-longer do that (parsing doesn't actually happen ifraw_outputis enabled), it was not printing anything.Fixes 45ba7a893ad89114e773b3dc32f6431354c465d6 ("kunit: kunit_tool: Separate out config/build/exec/parse")Signed-off-by David Gow <[email protected]>
Thanks for fixing this!
Shuah Khan
maintainerQuoted 8 lines · Brendan Higgins
Quoted 7 lines · David Gow
Due to the
raw_output()function onkunit_parser.pyactually being a generator, it only runs if something reads the lines it returns. Since we no-longer do that (parsing doesn't actually happen ifraw_outputis enabled), it was not printing anything.Fixes 45ba7a893ad89114e773b3dc32f6431354c465d6 ("kunit: kunit_tool: Separate out config/build/exec/parse")
You need just the SHA1 45ba7a893ad8
Fixed this up and applied to linux-kselftest kunit-fixes branch
Quoted 7 lines
Quoted 1 line
Signed-off-by David Gow <[email protected]>Thanks for fixing this!
Reviewed-by Brendan Higgins <[email protected]>Tested-by Brendan Higgins <[email protected]>
thanks,
-- Shuah