Change in openvpn[master]: t_client.sh.in: Do not try to guess the absolute path to LOGDIR
A message that is not in the archive (sent off-list or not yet received): gerrit.1782933852000.I752e03eabec085e47e8d74a9b4fa99e9ff267efb@gerrit.openvpn.net
Attention is currently required from: plaisthos.
Hello plaisthos,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/1764?usp=email
to review the following change.
Change subject: t_client.sh.in: Do not try to guess the absolute path to LOGDIR
......................................................................
t_client.sh.in: Do not try to guess the absolute path to LOGDIR
We know it, we do not need to guess it. Makes it easier to move LOGDIR around.
---
M tests/t_client.sh.in
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/64/1764/1
tests/t_client.sh.in +2 -1
@@ -126,6 +126,7 @@ fi LOGDIR=t_client-`hostname`-`date +%Y%m%d-%H%M%S` +LOGDIR_ABS="$PWD/$LOGDIR" if mkdir $LOGDIR then : else
@@ -383,7 +384,7 @@ printf "$outbuf" ; continue fi - pidfile="${top_builddir}/tests/$LOGDIR/openvpn-$SUF.pid" + pidfile="$LOGDIR_ABS/openvpn-$SUF.pid" openvpn_conf="$openvpn_conf --writepid $pidfile $up" output " run openvpn $openvpn_conf" echo "# ${openvpn} $openvpn_conf" >$LOGDIR/$SUF:openvpn.log
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1764?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I752e03eabec085e47e8d74a9b4fa99e9ff267efb
Gerrit-Change-Number: 1764
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
Attention is currently required from: flichtenheld.
plaisthos has posted comments on this change by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1764?usp=email )
Change subject: t_client.sh.in: Do not try to guess the absolute path to LOGDIR
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1764?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I752e03eabec085e47e8d74a9b4fa99e9ff267efb
Gerrit-Change-Number: 1764
Gerrit-PatchSet: 2
Gerrit-Owner: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: flichtenheld <[email protected]>
Gerrit-Comment-Date: Fri, 07 Aug 2026 11:38:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
PATCH v2 1/1 t_client.sh.in: Do not try to guess the absolute path to LOGDIR
In reply to a message not in the archiveWe know it, we do not need to guess it. Makes it easier to move LOGDIR around.
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1764
---
This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master.
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1764
This mail reflects revision 2 of this Change.
Acked-by according to Gerrit (reflected above):
Arne Schwabe <[email protected]>
tests/t_client.sh.in +2 -1
@@ -126,6 +126,7 @@ fi LOGDIR=t_client-`hostname`-`date +%Y%m%d-%H%M%S` +LOGDIR_ABS="$PWD/$LOGDIR" if mkdir $LOGDIR then : else
@@ -383,7 +384,7 @@ printf "$outbuf" ; continue fi - pidfile="${top_builddir}/tests/$LOGDIR/openvpn-$SUF.pid" + pidfile="$LOGDIR_ABS/openvpn-$SUF.pid" openvpn_conf="$openvpn_conf --writepid $pidfile $up" output " run openvpn $openvpn_conf" echo "# ${openvpn} $openvpn_conf" >$LOGDIR/$SUF:openvpn.log
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
[Openvpn-devel] [PATCH applied] Re: t_client.sh.in: Do not try to guess the absolute path to LOGDIR
For normal "run this in our 'make check' framework" this shouldn't be necessary, but ISTR that it breaks for the client-VMs for t_server - so that might originally even be something I had to fix myself... and it's good that t_client.sh gets a bit more polish.
Your patch has been applied to the master and release/2.7 branch ("test support").
commit b32d1ab45ec93786191e0dac2c8f5549d6c04258 (master) commit 5d81653bf2c9ecbf9d168caa2b60fb65ddf25517 (release/2.7)
Author: Frank Lichtenheld Date: Fri Aug 7 15:14:43 2026 +0200
t_client.sh.in: Do not try to guess the absolute path to LOGDIR
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1764
Message-Id: <[email protected]>
URL: https://www.mail-archive.com/[email protected]/msg38210.html
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/1764?usp=email )
Change subject: t_client.sh.in: Do not try to guess the absolute path to LOGDIR
......................................................................
t_client.sh.in: Do not try to guess the absolute path to LOGDIR
We know it, we do not need to guess it. Makes it easier to move LOGDIR around.
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1764
Message-Id: <[email protected]>
URL: https://www.mail-archive.com/[email protected]/msg38210.html
---
M tests/t_client.sh.in
1 file changed, 2 insertions(+), 1 deletion(-)
tests/t_client.sh.in +2 -1
@@ -110,6 +110,7 @@ fi LOGDIR=t_client-`hostname`-`date +%Y%m%d-%H%M%S` +LOGDIR_ABS="$PWD/$LOGDIR" if mkdir $LOGDIR then : else
@@ -363,7 +364,7 @@ printf "$outbuf" ; continue fi - pidfile="${top_builddir}/tests/$LOGDIR/openvpn-$SUF.pid" + pidfile="$LOGDIR_ABS/openvpn-$SUF.pid" openvpn_conf="$openvpn_conf --writepid $pidfile $up" output " run openvpn $openvpn_conf" echo "# ${openvpn} $openvpn_conf" >$LOGDIR/$SUF:openvpn.log
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1764?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I752e03eabec085e47e8d74a9b4fa99e9ff267efb
Gerrit-Change-Number: 1764
Gerrit-PatchSet: 3
Gerrit-Owner: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
cron2 has uploaded a new patch set (#3) to the change originally created by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1764?usp=email )
The following approvals got outdated and were removed:
Code-Review+2 by plaisthos
Change subject: t_client.sh.in: Do not try to guess the absolute path to LOGDIR
......................................................................
t_client.sh.in: Do not try to guess the absolute path to LOGDIR
We know it, we do not need to guess it. Makes it easier to move LOGDIR around.
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1764
Message-Id: <[email protected]>
URL: https://www.mail-archive.com/[email protected]/msg38210.html
---
M tests/t_client.sh.in
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/64/1764/3
tests/t_client.sh.in +2 -1
@@ -110,6 +110,7 @@ fi LOGDIR=t_client-`hostname`-`date +%Y%m%d-%H%M%S` +LOGDIR_ABS="$PWD/$LOGDIR" if mkdir $LOGDIR then : else
@@ -363,7 +364,7 @@ printf "$outbuf" ; continue fi - pidfile="${top_builddir}/tests/$LOGDIR/openvpn-$SUF.pid" + pidfile="$LOGDIR_ABS/openvpn-$SUF.pid" openvpn_conf="$openvpn_conf --writepid $pidfile $up" output " run openvpn $openvpn_conf" echo "# ${openvpn} $openvpn_conf" >$LOGDIR/$SUF:openvpn.log
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1764?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I752e03eabec085e47e8d74a9b4fa99e9ff267efb
Gerrit-Change-Number: 1764
Gerrit-PatchSet: 3
Gerrit-Owner: flichtenheld <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel