Skip to contentSkip to conversation

Documentation: Fix spelling mistake.

PATCH Applied Eslam Khafagy 4 participants 5 messages Jun 6, 2025 – Jun 7, 2025

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Documentation: Fix spelling mistake.

Fix typo "desination => destination"
in file Documentation/bpf/standardization/instruction-set.rst

---
 Documentation/bpf/standardization/instruction-set.rst | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Documentation/bpf/standardization/instruction-set.rst +2 -2
index fbe975585236..ac950a5bb6ad 100644
@@ -350,9 +350,9 @@ Underflow and overflow are allowed during arithmetic operations, meaning
 the 64-bit or 32-bit value will wrap. If BPF program execution would
 result in division by zero, the destination register is instead set to zero.
 Otherwise, for ``ALU64``, if execution would result in ``LLONG_MIN``
-dividing -1, the desination register is instead set to ``LLONG_MIN``. For
+dividing -1, the destination register is instead set to ``LLONG_MIN``. For
 ``ALU``, if execution would result in ``INT_MIN`` dividing -1, the
-desination register is instead set to ``INT_MIN``.
+destination register is instead set to ``INT_MIN``.
 
 If execution would result in modulo by zero, for ``ALU64`` the value of
 the destination register is unchanged whereas for ``ALU`` the upper
Signature · 1 line
2.43.0
Acked-by on v1 1/1
#1 lore raw
Quoted 7 lines

-----Original Message-----
From: Eslam Khafagy <[email protected]>
Sent: Friday, June 6, 2025 3:05 AM
To: [email protected]; [email protected]
Cc: [email protected]; [email protected];

[email protected];

Quoted 18 lines

Eslam Khafagy <[email protected]>
Subject: [PATCH bpf-next] Documentation: Fix spelling mistake.

Fix typo "desination => destination"
in file Documentation/bpf/standardization/instruction-set.rst

---
 Documentation/bpf/standardization/instruction-set.rst | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Documentation/bpf/standardization/instruction-set.rst +0 -0
index fbe975585236..ac950a5bb6ad 100644
@@ -350,9 +350,9 @@ Underflow and overflow are allowed during arithmetic
Quoted 1 line

operations, meaning the 64-bit or 32-bit value will wrap. If BPF program

execution

Quoted 1 line

would result in division by zero, the destination register is instead set

to zero.

Quoted 1 line

Otherwise, for ``ALU64``, if execution would result in ``LLONG_MIN``

-dividing -1,

Documentation/bpf/standardization/instruction-set.rst

Quoted 4 lines

the desination register is instead set to ``LLONG_MIN``. For

Documentation/bpf/standardization/instruction-set.rst +2 -0
+dividing -1, the destination register is instead set to ``LLONG_MIN``.
+For
 ``ALU``, if execution would result in ``INT_MIN`` dividing -1, the

-desination register

Quoted 4 lines

is instead set to ``INT_MIN``.
+destination register is instead set to ``INT_MIN``.

If execution would result in modulo by zero, for ``ALU64`` the value of

the

Quoted 3 lines

destination register is unchanged whereas for ``ALU`` the upper --
2.43.0

For just the spelling correction:

However the phrase "dividing -1" is one I find confusing. E.g., "INT_MIN dividing -1" sounds like "-1 / INT_MIN" rather than the inverse. Perhaps "divided by" instead of "dividing" assuming the inverse is meant.

Dave

reviewer Acked-by
#2 lore raw
Quoted 5 lines · Dave Thaler
Quoted 5 lines

-----Original Message-----
From: Eslam Khafagy <[email protected]>
Sent: Friday, June 6, 2025 3:05 AM
To: [email protected]; [email protected]
Cc: [email protected]; [email protected];

Quoted 9 lines

[email protected];

Quoted 8 lines

Eslam Khafagy <[email protected]>
Subject: [PATCH bpf-next] Documentation: Fix spelling mistake.

Fix typo "desination => destination"
in file Documentation/bpf/standardization/instruction-set.rst

Quoted 3 lines

However the phrase "dividing -1" is one I find confusing. E.g., "INT_MIN dividing -1" sounds like "-1 / INT_MIN" rather than the inverse. Perhaps "divided by" instead of "dividing" assuming the inverse is meant.

+1, probably worth fixing in a follow-on diff

#3 lore raw
In reply to Dave Thaler
Quoted 3 lines · Dave Thaler

However the phrase "dividing -1" is one I find confusing. E.g., "INT_MIN dividing -1" sounds like "-1 / INT_MIN" rather than the inverse. Perhaps "divided by" instead of "dividing" assuming the inverse is meant.

Good catch. you're right.
Since this paragraph is taking about overflow and underflow.
it makes more sense that what is meant is "INT_MIN / -1" as this actually will overflow. I just sent another patch for this.

#4 lore raw
In reply to Eslam Khafagy
This patch was applied to bpf/bpf-next.git (master) by Alexei Starovoitov <[email protected]>:

Hello:

This patch was applied to bpf/bpf-next.git (master) by Alexei Starovoitov <[email protected]>:

Quoted 8 lines · On Fri, 6 Jun 2025 13:05:11 +0300 you wrote:

Fix typo "desination => destination"
in file Documentation/bpf/standardization/instruction-set.rst

---
 Documentation/bpf/standardization/instruction-set.rst | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Here is the summary with links:
- [bpf-next] Documentation: Fix spelling mistake.

    https://git.kernel.org/bpf/bpf-next/c/e41079f53e87

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html