nvme-fc: change default devloss_tmo to 30s
Subsystems (2)
PATCH 1/1 nvme-fc: change default devloss_tmo to 30s
Transport default devloss_tmo is 60s. However, both lldd's use a driver default devloss_tmo of 30s. Rather having an inconsistency if the transport value is used, set the transport default to 30s.
--- drivers/nvme/host/fc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/nvme/host/fc.c +1 -1
@@ -25,7 +25,7 @@ enum nvme_fc_queue_flags { NVME_FC_Q_LIVE, }; -#define NVME_FC_DEFAULT_DEV_LOSS_TMO 60/* seconds */ +#define NVME_FC_DEFAULT_DEV_LOSS_TMO 30/* seconds */ struct nvme_fc_queue {struct nvme_fc_ctrl *ctrl;
Signature · 7 lines
2.26.1 _______________________________________________ linux-nvme mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-nvme
Quoted 17 lines · James Smart
Transport default
devloss_tmois 60s. However, both lldd's use a driver defaultdevloss_tmoof 30s. Rather having an inconsistency if the transport value is used, set the transport default to 30s.Signed-off-by James Smart <[email protected]>CC Himanshu Madhani <[email protected]>CC Arun Easi <[email protected]>--- drivers/nvme/host/fc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/nvme/host/fc.c +0
-0
drivers/nvme/host/fc.c enum nvme_fc_queue_flags { · line 31
Quoted 8 lines
drivers/nvme/host/fc.c +1
-1@@ -25,7 +25,7 @@ enum nvme_fc_queue_flags { NVME_FC_Q_LIVE, }; -#define NVME_FC_DEFAULT_DEV_LOSS_TMO 60/* seconds */ +#define NVME_FC_DEFAULT_DEV_LOSS_TMO 30/* seconds */ struct nvme_fc_queue {struct nvme_fc_ctrl *ctrl;
Thanks for making it consistent.
Signature · 7 lines
Himanshu Madhani Oracle Linux Engineering _______________________________________________ linux-nvme mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-nvme
Quoted 3 lines · James Smart
Transport default
devloss_tmois 60s. However, both lldd's use a driver defaultdevloss_tmoof 30s. Rather having an inconsistency if the transport value is used, set the transport default to 30s.
Can we just have an interface that queries the LLDD instead of relying on the drivers and the transport having the same value?
_______________________________________________
linux-nvme mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-nvme
Quoted 8 lines · Christoph Hellwig
Quoted 3 lines · James Smart
Transport default
devloss_tmois 60s. However, both lldd's use a driver defaultdevloss_tmoof 30s. Rather having an inconsistency if the transport value is used, set the transport default to 30s.Can we just have an interface that queries the LLDD instead of relying on the drivers and the transport having the same value?
we have that already - not queries, but rather transport can provide it. Guess I can hard-enforce the driver sets a value and eliminate the transport default.
- james
_______________________________________________
linux-nvme mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-nvme