Skip to contentSkip to conversation

nvme-fc: change default devloss_tmo to 30s

PATCH In review James Smart 4 participants 4 messages May 1, 2020 – May 2, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 nvme-fc: change default devloss_tmo to 30s

Transport default devloss_tmo is 60s. However, both lldd's use a driver default devloss_tmo of 30s. Rather having an inconsistency if the transport value is used, set the transport default to 30s.

CC Himanshu Madhani <[email protected]>
CC Arun Easi <[email protected]>
---
 drivers/nvme/host/fc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/nvme/host/fc.c +1 -1
index 1921d2195541..0aa3767cbb1c 100644
@@ -25,7 +25,7 @@ enum nvme_fc_queue_flags {
 	NVME_FC_Q_LIVE,
 };
 
-#define NVME_FC_DEFAULT_DEV_LOSS_TMO	60	/* seconds */
+#define NVME_FC_DEFAULT_DEV_LOSS_TMO	30	/* seconds */
 
 struct nvme_fc_queue {
 	struct nvme_fc_ctrl	*ctrl;
Signature · 7 lines
2.26.1


_______________________________________________
linux-nvme mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-nvme
Reviewed-by on v1 1/1
#1 lore raw
Quoted 17 lines · James Smart

Transport default devloss_tmo is 60s. However, both lldd's use a driver default devloss_tmo of 30s. Rather having an inconsistency if the transport value is used, set the transport default to 30s.

CC Himanshu Madhani <[email protected]>
CC Arun Easi <[email protected]>
---
  drivers/nvme/host/fc.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/nvme/host/fc.c +0 -0
index 1921d2195541..0aa3767cbb1c 100644

drivers/nvme/host/fc.c enum nvme_fc_queue_flags { · line 31

Quoted 8 lines
drivers/nvme/host/fc.c +1 -1
@@ -25,7 +25,7 @@ enum nvme_fc_queue_flags {
  	NVME_FC_Q_LIVE,
  };
 
-#define NVME_FC_DEFAULT_DEV_LOSS_TMO	60	/* seconds */
+#define NVME_FC_DEFAULT_DEV_LOSS_TMO	30	/* seconds */
 
  struct nvme_fc_queue {
  	struct nvme_fc_ctrl	*ctrl;

Thanks for making it consistent.

Signature · 7 lines
Himanshu Madhani
Oracle Linux Engineering

_______________________________________________
linux-nvme mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-nvme
#2 lore raw
In reply to James Smart
Quoted 3 lines · James Smart

Transport default devloss_tmo is 60s. However, both lldd's use a driver default devloss_tmo of 30s. Rather having an inconsistency if the transport value is used, set the transport default to 30s.

Can we just have an interface that queries the LLDD instead of relying on the drivers and the transport having the same value?

_______________________________________________
linux-nvme mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-nvme

#3 lore raw
Quoted 8 lines · Christoph Hellwig
Quoted 3 lines · James Smart

Transport default devloss_tmo is 60s. However, both lldd's use a driver default devloss_tmo of 30s. Rather having an inconsistency if the transport value is used, set the transport default to 30s.

Can we just have an interface that queries the LLDD instead of relying on the drivers and the transport having the same value?

we have that already - not queries, but rather transport can provide it. Guess I can hard-enforce the driver sets a value and eliminate the transport default.

- james

_______________________________________________
linux-nvme mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-nvme