Documentation: networking: switchdev: Update port parent ID section
Subsystems (3)
PATCH 1/1 Documentation: networking: switchdev: Update port parent ID section
Update the section about switchdev drivers having to implement a switchdev_port_attr_get() function to return SWITCHDEV_ATTR_ID_PORT_PARENT_ID since that is no longer valid after commit bccb30254a4a ("net: Get rid of SWITCHDEV_ATTR_ID_PORT_PARENT_ID").
--- Documentation/networking/switchdev.txt | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
Documentation/networking/switchdev.txt +5 -5
@@ -92,11 +92,11 @@ device. Switch ID ^^^^^^^^^ -The switchdev driver must implement the switchdev op switchdev_port_attr_get -for SWITCHDEV_ATTR_ID_PORT_PARENT_ID for each port netdev, returning the same -physical ID for each port of a switch. The ID must be unique between switches -on the same system. The ID does not need to be unique between switches on -different systems. +The switchdev driver must implement the net_device operation +ndo_get_port_parent_id for each port netdev, returning the same physical ID for +each port of a switch. The ID must be unique between switches on the same +system. The ID does not need to be unique between switches on different +systems. The switch ID is used to locate ports on a switch and to know if aggregated ports belong to the same switch.
Signature · 1 line
2.17.1
From: Florian Fainelli <[email protected]>
Date: Wed, 20 Feb 2019 14:58:50 -0800
Quoted 10 lines
Update the section about switchdev drivers having to implement a
switchdev_port_attr_get()function to returnSWITCHDEV_ATTR_ID_PORT_PARENT_IDsince that is no longer valid after commitbccb30254a4a("net: Get rid ofSWITCHDEV_ATTR_ID_PORT_PARENT_ID").Fixes bccb30254a4a ("net: Get rid of SWITCHDEV_ATTR_ID_PORT_PARENT_ID")Reviewed-by Ido Schimmel <[email protected]>Acked-by Jiri Pirko <[email protected]>Signed-off-by Florian Fainelli <[email protected]>
Applied.
Le 2/22/19 à 11:58 AM, David Miller a écrit :
Quoted 9 lines
From: Florian Fainelli <[email protected]>
Date: Wed, 20 Feb 2019 14:58:50 -0800Quoted 6 lines
Update the section about switchdev drivers having to implement a
switchdev_port_attr_get()function to returnSWITCHDEV_ATTR_ID_PORT_PARENT_IDsince that is no longer valid after commitbccb30254a4a("net: Get rid ofSWITCHDEV_ATTR_ID_PORT_PARENT_ID").
Quoted 7 lines
Quoted 4 lines
Fixes bccb30254a4a ("net: Get rid of SWITCHDEV_ATTR_ID_PORT_PARENT_ID")Reviewed-by Ido Schimmel <[email protected]>Acked-by Jiri Pirko <[email protected]>Signed-off-by Florian Fainelli <[email protected]>Applied.
Looks like you applied this to the "net" tree, and I missed prefixing the patch to indicate this was targeted at the "net-next" tree. Are you planning a merge from "net" to "net-next" anytime soon?
Thanks!
Signature · 1 line
Florian
David Miller
maintainerFrom: Florian Fainelli <[email protected]>
Date: Sun, 24 Feb 2019 08:46:59 -0800
Quoted 3 lines
Looks like you applied this to the "net" tree, and I missed prefixing the patch to indicate this was targeted at the "net-next" tree. Are you planning a merge from "net" to "net-next" anytime soon?
Yes, I am working on that right now.
David Miller
maintainerFrom: David Miller <[email protected]>
Date: Sun, 24 Feb 2019 11:26:30 -0800 (PST)
Quoted 8 lines
From: Florian Fainelli <[email protected]>
Date: Sun, 24 Feb 2019 08:46:59 -0800Quoted 3 lines
Looks like you applied this to the "net" tree, and I missed prefixing the patch to indicate this was targeted at the "net-next" tree. Are you planning a merge from "net" to "net-next" anytime soon?
Yes, I am working on that right now.
This is now done.