Skip to contentSkip to conversation

BUILD REGRESSION 0c7a6fd3a0e835b0158a1f52176f5d3858fac110

Devel In review kernel test robot 4 participants 7 messages Dec 30, 2020 – Jan 4, 2021

Subsystems (4)
lore
Share & tools
lore

kernel test robot

author build bot
#0 lore raw

tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git bleeding-edge branch HEAD: 0c7a6fd3a0e835b0158a1f52176f5d3858fac110 Merge branch 'pm-cpuidle-next' into bleeding-edge

Error/Warning reports:

https://lore.kernel.org/linux-acpi/202012180806.uUcdy2LC-lkp(a)intel.com
https://lore.kernel.org/linux-acpi/202012271352.JvNDF17O-lkp(a)intel.com
https://lore.kernel.org/linux-acpi/202012280239.stlWMtr3-lkp(a)intel.com
https://lore.kernel.org/linux-acpi/202012280249.nrNm8Jn3-lkp(a)intel.com

Error/Warning in current branch:

drivers/acpi/platform_profile.c:147:24: warning: address of array 'pprof->choices' will always evaluate to 'true' [-Wpointer-bool-conversion] drivers/acpi/x86/s2idle.c:108:30: warning: variable 'info' set but not used [-Wunused-but-set-variable] drivers/acpi/x86/s2idle.c:138:25: warning: variable 'obj_new' set but not used [-Wunused-but-set-variable] dtpm.c:(.text+0x24c): undefined reference to `__udivdi3'
dtpm.c:(.text+0x2a4): undefined reference to `__udivdi3'
dtpm.c:(.text+0x3bc): undefined reference to `__udivdi3'
dtpm.c:(.text+0x514): undefined reference to `__aeabi_uldivmod'
dtpm.c:(.text+0x52d): undefined reference to `__udivdi3'

Error/Warning ids grouped by kconfigs:

gcc_recent_errors

|-- arm-allmodconfig
|   `-- dtpm.c:(.text):undefined-reference-to-__aeabi_uldivmod
|-- arm-allyesconfig
|   `-- dtpm.c:(.text):undefined-reference-to-__aeabi_uldivmod
|-- h8300-allmodconfig
|   `-- dtpm.c:(.text):undefined-reference-to-__udivdi3
|-- h8300-allyesconfig
|   `-- dtpm.c:(.text):undefined-reference-to-__udivdi3
|-- i386-allyesconfig
|   `-- dtpm.c:(.text):undefined-reference-to-__udivdi3
|-- i386-randconfig-a006-20201229
|   |-- drivers-acpi-x86-s2idle.c:warning:variable-info-set-but-not-used
|   `-- drivers-acpi-x86-s2idle.c:warning:variable-obj_new-set-but-not-used
|-- i386-randconfig-r002-20201229
|   |-- drivers-acpi-x86-s2idle.c:warning:variable-info-set-but-not-used
|   `-- drivers-acpi-x86-s2idle.c:warning:variable-obj_new-set-but-not-used
|-- i386-randconfig-s001-20201229
|   |-- drivers-acpi-x86-s2idle.c:warning:variable-info-set-but-not-used
|   `-- drivers-acpi-x86-s2idle.c:warning:variable-obj_new-set-but-not-used
|-- m68k-allmodconfig
|   `-- dtpm.c:(.text):undefined-reference-to-__udivdi3
|-- m68k-allyesconfig
|   `-- dtpm.c:(.text):undefined-reference-to-__udivdi3
|-- sh-allmodconfig
|   `-- dtpm.c:(.text):undefined-reference-to-__udivdi3
|-- x86_64-randconfig-a002-20201229
|   |-- drivers-acpi-x86-s2idle.c:warning:variable-info-set-but-not-used
|   `-- drivers-acpi-x86-s2idle.c:warning:variable-obj_new-set-but-not-used
|-- x86_64-randconfig-a004-20201229
|   |-- drivers-acpi-x86-s2idle.c:warning:variable-info-set-but-not-used
|   `-- drivers-acpi-x86-s2idle.c:warning:variable-obj_new-set-but-not-used
`-- x86_64-randconfig-s021-20201229
    |-- drivers-acpi-x86-s2idle.c:warning:variable-info-set-but-not-used
    `-- drivers-acpi-x86-s2idle.c:warning:variable-obj_new-set-but-not-used

clang_recent_errors

|-- x86_64-randconfig-a011-20201229
|   `-- drivers-acpi-platform_profile.c:warning:address-of-array-pprof-choices-will-always-evaluate-to-true
|-- x86_64-randconfig-a012-20201229
|   `-- drivers-acpi-platform_profile.c:warning:address-of-array-pprof-choices-will-always-evaluate-to-true
|-- x86_64-randconfig-a013-20201229
|   `-- drivers-acpi-platform_profile.c:warning:address-of-array-pprof-choices-will-always-evaluate-to-true
|-- x86_64-randconfig-a014-20201229
|   `-- drivers-acpi-platform_profile.c:warning:address-of-array-pprof-choices-will-always-evaluate-to-true
|-- x86_64-randconfig-a015-20201229
|   `-- drivers-acpi-platform_profile.c:warning:address-of-array-pprof-choices-will-always-evaluate-to-true

`-- x86_64-randconfig-a016-20201229
`-- drivers-acpi-platform_profile.c:warning:address-of-array-pprof-choices-will-always-evaluate-to-true

elapsed time: 724m

configs tested: 95
configs skipped: 2

gcc tested configs:
arm defconfig
arm64 allyesconfig
arm64 defconfig
arm allyesconfig
arm allmodconfig
sh se7619_defconfig
sh sh7785lcr_defconfig
arm trizeps4_defconfig
mips workpad_defconfig
um x86_64_defconfig
mips cu1000-neo_defconfig
m68k sun3x_defconfig
mips bcm47xx_defconfig
arm mps2_defconfig
mips tb0287_defconfig
s390 debug_defconfig
arm sama5_defconfig
arm s3c2410_defconfig
arm lpc18xx_defconfig
sh microdev_defconfig
arm s5pv210_defconfig
mips tb0226_defconfig
arm pxa910_defconfig
c6x evmc6474_defconfig
ia64 allmodconfig
ia64 defconfig
ia64 allyesconfig
m68k allmodconfig
m68k defconfig
m68k allyesconfig
nios2 defconfig
arc allyesconfig
nds32 allnoconfig
c6x allyesconfig
nds32 defconfig
nios2 allyesconfig
csky defconfig
alpha defconfig

alpha                            allyesconfig
xtensa                           allyesconfig
h8300                            allyesconfig

arc defconfig
sh allmodconfig
parisc defconfig
s390 allyesconfig
parisc allyesconfig
s390 defconfig
i386 allyesconfig
sparc allyesconfig
sparc defconfig
i386 tinyconfig
i386 defconfig

mips                             allyesconfig
mips                             allmodconfig
powerpc                          allyesconfig
powerpc                          allmodconfig
powerpc                           allnoconfig
x86_64               randconfig-a001-20201229
x86_64               randconfig-a006-20201229
x86_64               randconfig-a002-20201229
x86_64               randconfig-a004-20201229
x86_64               randconfig-a003-20201229
x86_64               randconfig-a005-20201229
i386                 randconfig-a002-20201229
i386                 randconfig-a005-20201229
i386                 randconfig-a004-20201229
i386                 randconfig-a006-20201229
i386                 randconfig-a003-20201229
i386                 randconfig-a001-20201229
i386                 randconfig-a014-20201229
i386                 randconfig-a012-20201229
i386                 randconfig-a011-20201229
i386                 randconfig-a016-20201229
i386                 randconfig-a015-20201229
i386                 randconfig-a013-20201229

riscv nommu_k210_defconfig
riscv allyesconfig
riscv nommu_virt_defconfig
riscv allnoconfig
riscv defconfig
riscv rv32_defconfig
riscv allmodconfig
x86_64 rhel
x86_64 allyesconfig
x86_64 rhel-7.6-kselftests
x86_64 defconfig
x86_64 rhel-8.3
x86_64 rhel-8.3-kbuiltin
x86_64 kexec

clang tested configs:

x86_64               randconfig-a014-20201229
x86_64               randconfig-a015-20201229
x86_64               randconfig-a016-20201229
x86_64               randconfig-a012-20201229
x86_64               randconfig-a011-20201229
x86_64               randconfig-a013-20201229

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

#1 lore raw

Hi Daniel,

Quoted 13 lines · kernel test robot

tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git bleeding-edge branch HEAD: 0c7a6fd3a0e835b0158a1f52176f5d3858fac110 Merge branch 'pm-cpuidle-next' into bleeding-edge

Error/Warning reports:

https://lore.kernel.org/linux-acpi/[email protected]
https://lore.kernel.org/linux-acpi/[email protected]
https://lore.kernel.org/linux-acpi/[email protected]
https://lore.kernel.org/linux-acpi/[email protected]

Error/Warning in current branch:

Quoted 8 lines

drivers/acpi/platform_profile.c:147:24: warning: address of array 'pprof->choices' will always evaluate to 'true' [-Wpointer-bool-conversion] drivers/acpi/x86/s2idle.c:108:30: warning: variable 'info' set but not used [-Wunused-but-set-variable] drivers/acpi/x86/s2idle.c:138:25: warning: variable 'obj_new' set but not used [-Wunused-but-set-variable] dtpm.c:(.text+0x24c): undefined reference to `__udivdi3'
dtpm.c:(.text+0x2a4): undefined reference to `__udivdi3'
dtpm.c:(.text+0x3bc): undefined reference to `__udivdi3'
dtpm.c:(.text+0x514): undefined reference to `__aeabi_uldivmod'
dtpm.c:(.text+0x52d): undefined reference to `__udivdi3'

The above build issues come from the DTPM patches.

I was about to send a pull request including those patches later today, but it looks like that would be premature.

Can you have a look at this, please?

Quoted 159 lines

Error/Warning ids grouped by kconfigs:

gcc_recent_errors

|-- arm-allmodconfig
|   `-- dtpm.c:(.text):undefined-reference-to-__aeabi_uldivmod
|-- arm-allyesconfig
|   `-- dtpm.c:(.text):undefined-reference-to-__aeabi_uldivmod
|-- h8300-allmodconfig
|   `-- dtpm.c:(.text):undefined-reference-to-__udivdi3
|-- h8300-allyesconfig
|   `-- dtpm.c:(.text):undefined-reference-to-__udivdi3
|-- i386-allyesconfig
|   `-- dtpm.c:(.text):undefined-reference-to-__udivdi3
|-- i386-randconfig-a006-20201229
|   |-- drivers-acpi-x86-s2idle.c:warning:variable-info-set-but-not-used
|   `-- drivers-acpi-x86-s2idle.c:warning:variable-obj_new-set-but-not-used
|-- i386-randconfig-r002-20201229
|   |-- drivers-acpi-x86-s2idle.c:warning:variable-info-set-but-not-used
|   `-- drivers-acpi-x86-s2idle.c:warning:variable-obj_new-set-but-not-used
|-- i386-randconfig-s001-20201229
|   |-- drivers-acpi-x86-s2idle.c:warning:variable-info-set-but-not-used
|   `-- drivers-acpi-x86-s2idle.c:warning:variable-obj_new-set-but-not-used
|-- m68k-allmodconfig
|   `-- dtpm.c:(.text):undefined-reference-to-__udivdi3
|-- m68k-allyesconfig
|   `-- dtpm.c:(.text):undefined-reference-to-__udivdi3
|-- sh-allmodconfig
|   `-- dtpm.c:(.text):undefined-reference-to-__udivdi3
|-- x86_64-randconfig-a002-20201229
|   |-- drivers-acpi-x86-s2idle.c:warning:variable-info-set-but-not-used
|   `-- drivers-acpi-x86-s2idle.c:warning:variable-obj_new-set-but-not-used
|-- x86_64-randconfig-a004-20201229
|   |-- drivers-acpi-x86-s2idle.c:warning:variable-info-set-but-not-used
|   `-- drivers-acpi-x86-s2idle.c:warning:variable-obj_new-set-but-not-used
`-- x86_64-randconfig-s021-20201229
    |-- drivers-acpi-x86-s2idle.c:warning:variable-info-set-but-not-used
    `-- drivers-acpi-x86-s2idle.c:warning:variable-obj_new-set-but-not-used

clang_recent_errors

|-- x86_64-randconfig-a011-20201229
|   `-- drivers-acpi-platform_profile.c:warning:address-of-array-pprof-choices-will-always-evaluate-to-true
|-- x86_64-randconfig-a012-20201229
|   `-- drivers-acpi-platform_profile.c:warning:address-of-array-pprof-choices-will-always-evaluate-to-true
|-- x86_64-randconfig-a013-20201229
|   `-- drivers-acpi-platform_profile.c:warning:address-of-array-pprof-choices-will-always-evaluate-to-true
|-- x86_64-randconfig-a014-20201229
|   `-- drivers-acpi-platform_profile.c:warning:address-of-array-pprof-choices-will-always-evaluate-to-true
|-- x86_64-randconfig-a015-20201229
|   `-- drivers-acpi-platform_profile.c:warning:address-of-array-pprof-choices-will-always-evaluate-to-true

`-- x86_64-randconfig-a016-20201229
`-- drivers-acpi-platform_profile.c:warning:address-of-array-pprof-choices-will-always-evaluate-to-true

elapsed time: 724m

configs tested: 95
configs skipped: 2

gcc tested configs:
arm defconfig
arm64 allyesconfig
arm64 defconfig
arm allyesconfig
arm allmodconfig
sh se7619_defconfig
sh sh7785lcr_defconfig
arm trizeps4_defconfig
mips workpad_defconfig
um x86_64_defconfig
mips cu1000-neo_defconfig
m68k sun3x_defconfig
mips bcm47xx_defconfig
arm mps2_defconfig
mips tb0287_defconfig
s390 debug_defconfig
arm sama5_defconfig
arm s3c2410_defconfig
arm lpc18xx_defconfig
sh microdev_defconfig
arm s5pv210_defconfig
mips tb0226_defconfig
arm pxa910_defconfig
c6x evmc6474_defconfig
ia64 allmodconfig
ia64 defconfig
ia64 allyesconfig
m68k allmodconfig
m68k defconfig
m68k allyesconfig
nios2 defconfig
arc allyesconfig
nds32 allnoconfig
c6x allyesconfig
nds32 defconfig
nios2 allyesconfig
csky defconfig
alpha defconfig

alpha                            allyesconfig
xtensa                           allyesconfig
h8300                            allyesconfig

arc defconfig
sh allmodconfig
parisc defconfig
s390 allyesconfig
parisc allyesconfig
s390 defconfig
i386 allyesconfig
sparc allyesconfig
sparc defconfig
i386 tinyconfig
i386 defconfig

mips                             allyesconfig
mips                             allmodconfig
powerpc                          allyesconfig
powerpc                          allmodconfig
powerpc                           allnoconfig
x86_64               randconfig-a001-20201229
x86_64               randconfig-a006-20201229
x86_64               randconfig-a002-20201229
x86_64               randconfig-a004-20201229
x86_64               randconfig-a003-20201229
x86_64               randconfig-a005-20201229
i386                 randconfig-a002-20201229
i386                 randconfig-a005-20201229
i386                 randconfig-a004-20201229
i386                 randconfig-a006-20201229
i386                 randconfig-a003-20201229
i386                 randconfig-a001-20201229
i386                 randconfig-a014-20201229
i386                 randconfig-a012-20201229
i386                 randconfig-a011-20201229
i386                 randconfig-a016-20201229
i386                 randconfig-a015-20201229
i386                 randconfig-a013-20201229

riscv nommu_k210_defconfig
riscv allyesconfig
riscv nommu_virt_defconfig
riscv allnoconfig
riscv defconfig
riscv rv32_defconfig
riscv allmodconfig
x86_64 rhel
x86_64 allyesconfig
x86_64 rhel-7.6-kselftests
x86_64 defconfig
x86_64 rhel-8.3
x86_64 rhel-8.3-kbuiltin
x86_64 kexec

clang tested configs:

x86_64               randconfig-a014-20201229
x86_64               randconfig-a015-20201229
x86_64               randconfig-a016-20201229
x86_64               randconfig-a012-20201229
x86_64               randconfig-a011-20201229
x86_64               randconfig-a013-20201229

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/[email protected]

#2 lore raw
Quoted 25 lines · Rafael J. Wysocki

Hi Daniel,

Quoted 13 lines · kernel test robot

tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git bleeding-edge branch HEAD: 0c7a6fd3a0e835b0158a1f52176f5d3858fac110 Merge branch 'pm-cpuidle-next' into bleeding-edge

Error/Warning reports:

https://lore.kernel.org/linux-acpi/[email protected]
https://lore.kernel.org/linux-acpi/[email protected]
https://lore.kernel.org/linux-acpi/[email protected]
https://lore.kernel.org/linux-acpi/[email protected]

Error/Warning in current branch:

Quoted 8 lines

drivers/acpi/platform_profile.c:147:24: warning: address of array 'pprof->choices' will always evaluate to 'true' [-Wpointer-bool-conversion] drivers/acpi/x86/s2idle.c:108:30: warning: variable 'info' set but not used [-Wunused-but-set-variable] drivers/acpi/x86/s2idle.c:138:25: warning: variable 'obj_new' set but not used [-Wunused-but-set-variable] dtpm.c:(.text+0x24c): undefined reference to `__udivdi3'
dtpm.c:(.text+0x2a4): undefined reference to `__udivdi3'
dtpm.c:(.text+0x3bc): undefined reference to `__udivdi3'
dtpm.c:(.text+0x514): undefined reference to `__aeabi_uldivmod'
dtpm.c:(.text+0x52d): undefined reference to `__udivdi3'

Quoted 6 lines

The above build issues come from the DTPM patches.

I was about to send a pull request including those patches later today, but it looks like that would be premature.

Can you have a look at this, please?

I've a patch to fix it. I'm currently testing it.

Quoted 159 lines
Quoted 159 lines

Error/Warning ids grouped by kconfigs:

gcc_recent_errors

|-- arm-allmodconfig
|   `-- dtpm.c:(.text):undefined-reference-to-__aeabi_uldivmod
|-- arm-allyesconfig
|   `-- dtpm.c:(.text):undefined-reference-to-__aeabi_uldivmod
|-- h8300-allmodconfig
|   `-- dtpm.c:(.text):undefined-reference-to-__udivdi3
|-- h8300-allyesconfig
|   `-- dtpm.c:(.text):undefined-reference-to-__udivdi3
|-- i386-allyesconfig
|   `-- dtpm.c:(.text):undefined-reference-to-__udivdi3
|-- i386-randconfig-a006-20201229
|   |-- drivers-acpi-x86-s2idle.c:warning:variable-info-set-but-not-used
|   `-- drivers-acpi-x86-s2idle.c:warning:variable-obj_new-set-but-not-used
|-- i386-randconfig-r002-20201229
|   |-- drivers-acpi-x86-s2idle.c:warning:variable-info-set-but-not-used
|   `-- drivers-acpi-x86-s2idle.c:warning:variable-obj_new-set-but-not-used
|-- i386-randconfig-s001-20201229
|   |-- drivers-acpi-x86-s2idle.c:warning:variable-info-set-but-not-used
|   `-- drivers-acpi-x86-s2idle.c:warning:variable-obj_new-set-but-not-used
|-- m68k-allmodconfig
|   `-- dtpm.c:(.text):undefined-reference-to-__udivdi3
|-- m68k-allyesconfig
|   `-- dtpm.c:(.text):undefined-reference-to-__udivdi3
|-- sh-allmodconfig
|   `-- dtpm.c:(.text):undefined-reference-to-__udivdi3
|-- x86_64-randconfig-a002-20201229
|   |-- drivers-acpi-x86-s2idle.c:warning:variable-info-set-but-not-used
|   `-- drivers-acpi-x86-s2idle.c:warning:variable-obj_new-set-but-not-used
|-- x86_64-randconfig-a004-20201229
|   |-- drivers-acpi-x86-s2idle.c:warning:variable-info-set-but-not-used
|   `-- drivers-acpi-x86-s2idle.c:warning:variable-obj_new-set-but-not-used
`-- x86_64-randconfig-s021-20201229
    |-- drivers-acpi-x86-s2idle.c:warning:variable-info-set-but-not-used
    `-- drivers-acpi-x86-s2idle.c:warning:variable-obj_new-set-but-not-used

clang_recent_errors

|-- x86_64-randconfig-a011-20201229
|   `-- drivers-acpi-platform_profile.c:warning:address-of-array-pprof-choices-will-always-evaluate-to-true
|-- x86_64-randconfig-a012-20201229
|   `-- drivers-acpi-platform_profile.c:warning:address-of-array-pprof-choices-will-always-evaluate-to-true
|-- x86_64-randconfig-a013-20201229
|   `-- drivers-acpi-platform_profile.c:warning:address-of-array-pprof-choices-will-always-evaluate-to-true
|-- x86_64-randconfig-a014-20201229
|   `-- drivers-acpi-platform_profile.c:warning:address-of-array-pprof-choices-will-always-evaluate-to-true
|-- x86_64-randconfig-a015-20201229
|   `-- drivers-acpi-platform_profile.c:warning:address-of-array-pprof-choices-will-always-evaluate-to-true

`-- x86_64-randconfig-a016-20201229
`-- drivers-acpi-platform_profile.c:warning:address-of-array-pprof-choices-will-always-evaluate-to-true

elapsed time: 724m

configs tested: 95
configs skipped: 2

gcc tested configs:
arm defconfig
arm64 allyesconfig
arm64 defconfig
arm allyesconfig
arm allmodconfig
sh se7619_defconfig
sh sh7785lcr_defconfig
arm trizeps4_defconfig
mips workpad_defconfig
um x86_64_defconfig
mips cu1000-neo_defconfig
m68k sun3x_defconfig
mips bcm47xx_defconfig
arm mps2_defconfig
mips tb0287_defconfig
s390 debug_defconfig
arm sama5_defconfig
arm s3c2410_defconfig
arm lpc18xx_defconfig
sh microdev_defconfig
arm s5pv210_defconfig
mips tb0226_defconfig
arm pxa910_defconfig
c6x evmc6474_defconfig
ia64 allmodconfig
ia64 defconfig
ia64 allyesconfig
m68k allmodconfig
m68k defconfig
m68k allyesconfig
nios2 defconfig
arc allyesconfig
nds32 allnoconfig
c6x allyesconfig
nds32 defconfig
nios2 allyesconfig
csky defconfig
alpha defconfig

alpha                            allyesconfig
xtensa                           allyesconfig
h8300                            allyesconfig

arc defconfig
sh allmodconfig
parisc defconfig
s390 allyesconfig
parisc allyesconfig
s390 defconfig
i386 allyesconfig
sparc allyesconfig
sparc defconfig
i386 tinyconfig
i386 defconfig

mips                             allyesconfig
mips                             allmodconfig
powerpc                          allyesconfig
powerpc                          allmodconfig
powerpc                           allnoconfig
x86_64               randconfig-a001-20201229
x86_64               randconfig-a006-20201229
x86_64               randconfig-a002-20201229
x86_64               randconfig-a004-20201229
x86_64               randconfig-a003-20201229
x86_64               randconfig-a005-20201229
i386                 randconfig-a002-20201229
i386                 randconfig-a005-20201229
i386                 randconfig-a004-20201229
i386                 randconfig-a006-20201229
i386                 randconfig-a003-20201229
i386                 randconfig-a001-20201229
i386                 randconfig-a014-20201229
i386                 randconfig-a012-20201229
i386                 randconfig-a011-20201229
i386                 randconfig-a016-20201229
i386                 randconfig-a015-20201229
i386                 randconfig-a013-20201229

riscv nommu_k210_defconfig
riscv allyesconfig
riscv nommu_virt_defconfig
riscv allnoconfig
riscv defconfig
riscv rv32_defconfig
riscv allmodconfig
x86_64 rhel
x86_64 allyesconfig
x86_64 rhel-7.6-kselftests
x86_64 defconfig
x86_64 rhel-8.3
x86_64 rhel-8.3-kbuiltin
x86_64 kexec

clang tested configs:

x86_64               randconfig-a014-20201229
x86_64               randconfig-a015-20201229
x86_64               randconfig-a016-20201229
x86_64               randconfig-a012-20201229
x86_64               randconfig-a011-20201229
x86_64               randconfig-a013-20201229

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/[email protected]

Signature · 5 lines
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
#3 lore raw

PATCH 1/1 powercap/drivers/dtpm: Fix __udivdi3 and __aeabi_uldivmod unresolved symbols

In reply to Rafael J. Wysocki

32 bits architectures do not support u64 division, so the macro DIV_ROUND_CLOSEST is not adequate as the compiler will replace the call to an unexisting function for the platform, leading to an unresolved symbols.

Fix this by using the compatible macros:

DIV64_U64_ROUND_CLOSEST and DIV_ROUND_CLOSEST_ULL.

---
 drivers/powercap/dtpm.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/powercap/dtpm.c +3 -3
index 5b6857e9b064..0abcc439d728 100644
@@ -99,8 +99,8 @@ static void __dtpm_rebalance_weight(struct dtpm *dtpm)
 		pr_debug("Setting weight '%d' for '%s'\n",
 			 child->weight, child->zone.name);
 
-		child->weight = DIV_ROUND_CLOSEST(child->power_max * 1024,
-						  dtpm->power_max);
+		child->weight = DIV64_U64_ROUND_CLOSEST(
+			child->power_max * 1024, dtpm->power_max);
 
 		__dtpm_rebalance_weight(child);
 	}
@@ -272,7 +272,7 @@ static int __set_power_limit_uw(struct dtpm *dtpm, int cid, u64 power_limit)
 			} else if (power_limit == dtpm->power_min) {
 				power = child->power_min;
 			} else {
-				power = DIV_ROUND_CLOSEST(
+				power = DIV_ROUND_CLOSEST_ULL(
 					power_limit * child->weight, 1024);
 			}
 
Signature · 1 line
2.17.1
#4 lore raw

Re: [PATCH] powercap/drivers/dtpm: Fix __udivdi3 and __aeabi_uldivmod unresolved symbols

Quoted 6 lines · Daniel Lezcano

32 bits architectures do not support u64 division, so the macro DIV_ROUND_CLOSEST is not adequate as the compiler will replace the call to an unexisting function for the platform, leading to an unresolved symbols.

Quoted 6 lines

Fix this by using the compatible macros:

DIV64_U64_ROUND_CLOSEST and DIV_ROUND_CLOSEST_ULL.

Applied and pushed into the linux-next branch, thanks!

Quoted 31 lines
---
 drivers/powercap/dtpm.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/powercap/dtpm.c +3 -4
index 5b6857e9b064..0abcc439d728 100644
@@ -99,8 +99,8 @@ static void __dtpm_rebalance_weight(struct dtpm *dtpm)
                pr_debug("Setting weight '%d' for '%s'\n",
                         child->weight, child->zone.name);
 
-               child->weight = DIV_ROUND_CLOSEST(child->power_max * 1024,
-                                                 dtpm->power_max);
+               child->weight = DIV64_U64_ROUND_CLOSEST(
+                       child->power_max * 1024, dtpm->power_max);
 
                __dtpm_rebalance_weight(child);
        }
@@ -272,7 +272,7 @@ static int __set_power_limit_uw(struct dtpm *dtpm, int cid, u64 power_limit)
                        } else if (power_limit == dtpm->power_min) {
                                power = child->power_min;
                        } else {
-                               power = DIV_ROUND_CLOSEST(
+                               power = DIV_ROUND_CLOSEST_ULL(
                                        power_limit * child->weight, 1024);
                        }
 
--

2.17.1

#5 lore raw

Re: [PATCH] powercap/drivers/dtpm: Fix __udivdi3 and __aeabi_uldivmod unresolved symbols

In reply to Daniel Lezcano

Hi Daniel,

Quoted 11 lines · Daniel Lezcano

32 bits architectures do not support u64 division, so the macro DIV_ROUND_CLOSEST is not adequate as the compiler will replace the call to an unexisting function for the platform, leading to an unresolved symbols.

Fix this by using the compatible macros:

DIV64_U64_ROUND_CLOSEST and DIV_ROUND_CLOSEST_ULL.

Thanks for your patch!

drivers/powercap/dtpm.c static void __dtpm_rebalance_weight(struct dtpm *dtpm) · line 103

Quoted 10 lines
drivers/powercap/dtpm.c +2 -2
@@ -99,8 +99,8 @@ static void __dtpm_rebalance_weight(struct dtpm *dtpm)
                pr_debug("Setting weight '%d' for '%s'\n",
                         child->weight, child->zone.name);
 
-               child->weight = DIV_ROUND_CLOSEST(child->power_max * 1024,
-                                                 dtpm->power_max);
+               child->weight = DIV64_U64_ROUND_CLOSEST(
+                       child->power_max * 1024, dtpm->power_max);

Note that 64-by-64 divisions are expensive on 32-bit platforms.

Does dtpm.power_max need to be u64?
The (lack of) documentation for the dtpm structure does not say what is being stored there.

Gr{oetje,eeting}s,

Geert

Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
#6 lore raw

Re: [PATCH] powercap/drivers/dtpm: Fix __udivdi3 and __aeabi_uldivmod unresolved symbols

Hi Geert,

Quoted 24 lines · Geert Uytterhoeven

Hi Daniel,

Quoted 11 lines · Daniel Lezcano

32 bits architectures do not support u64 division, so the macro DIV_ROUND_CLOSEST is not adequate as the compiler will replace the call to an unexisting function for the platform, leading to an unresolved symbols.

Fix this by using the compatible macros:

DIV64_U64_ROUND_CLOSEST and DIV_ROUND_CLOSEST_ULL.

Thanks for your patch!

Quoted 6 lines
drivers/powercap/dtpm.c +0 -0
@@ -99,8 +99,8 @@ static void __dtpm_rebalance_weight(struct dtpm *dtpm)
                pr_debug("Setting weight '%d' for '%s'\n",
                         child->weight, child->zone.name);
 
Quoted 8 lines

drivers/powercap/dtpm.c static void __dtpm_rebalance_weight(struct dtpm *dtpm) · line 103

Quoted 4 lines
drivers/powercap/dtpm.c +2 -2
-               child->weight = DIV_ROUND_CLOSEST(child->power_max * 1024,
-                                                 dtpm->power_max);
+               child->weight = DIV64_U64_ROUND_CLOSEST(
+                       child->power_max * 1024, dtpm->power_max);

Note that 64-by-64 divisions are expensive on 32-bit platforms.

Does dtpm.power_max need to be u64?

The dtpm is based on the powercap framework which deals with microwatts and the functions are expecting u64 values.

The division here happens when there is an update of the dtpm tree which occurs rarely (at boot time or hotplug).

As the power model is in the vast majority on 64b platforms, the effort to optimize to u32 sounds not worth, especially that the 32b platforms supporting the energy model are now obsolete.

Quoted 7 lines

The (lack of) documentation for the dtpm structure does not say what is being stored there.

Gr{oetje,eeting}s,

Geert

Signature · 5 lines
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog