crypto: sun8i-ss - Delete an error message in sun8i_ss_probe()
PATCH 1/1 crypto: sun8i-ss - Delete an error message in sun8i_ss_probe()
From: Markus Elfring <[email protected]>
Date: Sat, 4 Apr 2020 17:34:53 +0200
The function “platform_get_irq” can log an error already. Thus omit a redundant message for the exception handling in the calling function.
This issue was detected by using the Coccinelle software.
--- drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c +1 -3
@@ -537,10 +537,8 @@ static int sun8i_ss_probe(struct platform_device *pdev)return err; irq =platform_get_irq (pdev,0 ); -if (irq <0 ) { -dev_err (ss->dev,"Cannot get SecuritySystem IRQ\n" ); +if (irq <0 )return irq; - } ss->reset =devm_reset_control_get (&pdev->dev,NULL );if (IS_ERR (ss->reset)) {
--
2.26.0
Quoted 31 lines · Markus Elfring
From: Markus Elfring <[email protected]>
Date: Sat, 4 Apr 2020 17:34:53 +0200The function “platform_get_irq” can log an error already. Thus omit a redundant message for the exception handling in the calling function.
This issue was detected by using the Coccinelle software.
Signed-off-by Markus Elfring <[email protected]>--- drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c +1
-4@@ -537,10 +537,8 @@ static int sun8i_ss_probe(struct platform_device *pdev)return err; irq =platform_get_irq (pdev,0 ); -if (irq <0 ) { -dev_err (ss->dev,"Cannot get SecuritySystem IRQ\n" ); +if (irq <0 )return irq; - } ss->reset =devm_reset_control_get (&pdev->dev,NULL );if (IS_ERR (ss->reset)) { --
Quoted 2 lines
2.26.0
Hello
Thanks
Herbert Xu
maintainerQuoted 7 lines · Markus Elfring
From: Markus Elfring <[email protected]>
Date: Sat, 4 Apr 2020 17:34:53 +0200The function “platform_get_irq” can log an error already. Thus omit a redundant message for the exception handling in the calling function.
Quoted 6 lines
This issue was detected by using the Coccinelle software.
Signed-off-by Markus Elfring <[email protected]>--- drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
Patch applied. Thanks.
Signature · 3 lines
Email: Herbert Xu <[email protected]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt