Skip to contentSkip to conversation

btrfs: Fix incorrect log message related barrier

PATCH In review [email protected] 3 participants 3 messages Jul 22, 2025 – Aug 7, 2025 Btrfs file system

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 btrfs: Fix incorrect log message related barrier

From: Kyoji Ogasawara <[email protected]>

Fix a wrong log message that appears when the "nobarrier" mount option is unset.
When "nobarrier" is unset, barrier is actually enabled. However, the log incorrectly stated "turning off barriers".

Fixes eddb1a433f26 ("btrfs: add reconfigure callback for fs_context")
---
 fs/btrfs/super.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/btrfs/super.c +1 -1
index a0c65adce1ab..51b910e2774e 100644
@@ -1453,7 +1453,7 @@ static void btrfs_emit_options(struct btrfs_fs_info *info,
 	btrfs_info_if_unset(info, old, NODATACOW, "setting datacow");
 	btrfs_info_if_unset(info, old, SSD, "not using ssd optimizations");
 	btrfs_info_if_unset(info, old, SSD_SPREAD, "not using spread ssd allocation scheme");
-	btrfs_info_if_unset(info, old, NOBARRIER, "turning off barriers");
+	btrfs_info_if_unset(info, old, NOBARRIER, "turning on barriers");
 	btrfs_info_if_unset(info, old, NOTREELOG, "enabling tree log");
 	btrfs_info_if_unset(info, old, SPACE_CACHE, "disabling disk space caching");
 	btrfs_info_if_unset(info, old, FREE_SPACE_TREE, "disabling free space tree");
Signature · 1 line
2.49.0
Reviewed-by on v2 1/1
#1 lore raw
Quoted 9 lines · 在 2025/7/23 01:08, [email protected] 写道:

From: Kyoji Ogasawara <[email protected]>

Fix a wrong log message that appears when the "nobarrier" mount option is unset.
When "nobarrier" is unset, barrier is actually enabled. However, the log incorrectly stated "turning off barriers".

Fixes eddb1a433f26 ("btrfs: add reconfigure callback for fs_context")

Thanks,
Qu

Quoted 17 lines
---
  fs/btrfs/super.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
fs/btrfs/super.c +1 -1
index a0c65adce1ab..51b910e2774e 100644
@@ -1453,7 +1453,7 @@ static void btrfs_emit_options(struct btrfs_fs_info *info,
  	btrfs_info_if_unset(info, old, NODATACOW, "setting datacow");
  	btrfs_info_if_unset(info, old, SSD, "not using ssd optimizations");
  	btrfs_info_if_unset(info, old, SSD_SPREAD, "not using spread ssd allocation scheme");
-	btrfs_info_if_unset(info, old, NOBARRIER, "turning off barriers");
+	btrfs_info_if_unset(info, old, NOBARRIER, "turning on barriers");
  	btrfs_info_if_unset(info, old, NOTREELOG, "enabling tree log");
  	btrfs_info_if_unset(info, old, SPACE_CACHE, "disabling disk space caching");
  	btrfs_info_if_unset(info, old, FREE_SPACE_TREE, "disabling free space tree");
#2 lore raw
In reply to [email protected]
Quoted 9 lines · On Wed, Jul 23, 2025 at 12:38:37AM +0900, [email protected] wrote:

From: Kyoji Ogasawara <[email protected]>

Fix a wrong log message that appears when the "nobarrier" mount option is unset.
When "nobarrier" is unset, barrier is actually enabled. However, the log incorrectly stated "turning off barriers".

Fixes eddb1a433f26 ("btrfs: add reconfigure callback for fs_context")

Added to for-next, thanks.