Skip to contentSkip to conversation

mmap.2: fix description of treatment of the hint

PATCH In review Jann Horn 4 participants 5 messages Feb 14, 2019 – Feb 27, 2019 Memory management

lore
Share & tools
lore

Jann Horn

author
#0 lore raw

PATCH v2 1/1 mmap.2: fix description of treatment of the hint

The current manpage reads to me as if the kernel will always pick a free space close to the requested address, but that's not the case:

mmap(0x600000000000, 4096, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x600000000000
mmap(0x600000000000, 4096, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x7f5042859000

You can also see this in the various implementations of ->get_unmapped_area() - if the specified address isn't available, the kernel basically ignores the hint (apart from the 5level paging hack).

Clarify how this works a bit.

---
changed in v2:
- be less specific about what the kernel does when the requested address is unavailable to avoid constraining future behavior changes (Michal Hocko)

 man2/mmap.2 | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
man2/mmap.2 +6 -1
index fccfb9b3e..dbcae59be 100644
@@ -71,7 +71,12 @@ If
 .I addr
 is not NULL,
 then the kernel takes it as a hint about where to place the mapping;
-on Linux, the mapping will be created at a nearby page boundary.
+on Linux, the kernel will pick a nearby page boundary (but always above
+or equal to the value specified by
+.IR /proc/sys/vm/mmap_min_addr )
+and attempt to create the mapping there.
+If another mapping already exists there, the kernel picks a new address that
+may or may not depend on the hint.
 .\" Before Linux 2.6.24, the address was rounded up to the next page
 .\" boundary; since 2.6.24, it is rounded down!
 The address of the new mapping is returned as the result of the call.
Signature · 1 line
2.21.0.rc0.258.g878e2cd30e-goog
Acked-by on v2 1/1
#1 lore raw
Quoted 8 lines · Jann Horn

The current manpage reads to me as if the kernel will always pick a free space close to the requested address, but that's not the case:

mmap(0x600000000000, 4096, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x600000000000
mmap(0x600000000000, 4096, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x7f5042859000

Quoted 7 lines

You can also see this in the various implementations of ->get_unmapped_area() - if the specified address isn't available, the kernel basically ignores the hint (apart from the 5level paging hack).

Clarify how this works a bit.

Thanks!

Quoted 29 lines

---
changed in v2:
- be less specific about what the kernel does when the requested address is unavailable to avoid constraining future behavior changes (Michal Hocko)

 man2/mmap.2 | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
man2/mmap.2 +6 -1
index fccfb9b3e..dbcae59be 100644
@@ -71,7 +71,12 @@ If
 .I addr
 is not NULL,
 then the kernel takes it as a hint about where to place the mapping;
-on Linux, the mapping will be created at a nearby page boundary.
+on Linux, the kernel will pick a nearby page boundary (but always above
+or equal to the value specified by
+.IR /proc/sys/vm/mmap_min_addr )
+and attempt to create the mapping there.
+If another mapping already exists there, the kernel picks a new address that
+may or may not depend on the hint.
 .\" Before Linux 2.6.24, the address was rounded up to the next page
 .\" boundary; since 2.6.24, it is rounded down!
 The address of the new mapping is returned as the result of the call.
Signature · 1 line
2.21.0.rc0.258.g878e2cd30e-goog
Signature · 2 lines
Michal Hocko
SUSE Labs
#2 lore raw
In reply to Jann Horn
Quoted 8 lines · Jann Horn

The current manpage reads to me as if the kernel will always pick a free space close to the requested address, but that's not the case:

mmap(0x600000000000, 4096, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x600000000000
mmap(0x600000000000, 4096, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x7f5042859000

Quoted 7 lines

You can also see this in the various implementations of ->get_unmapped_area() - if the specified address isn't available, the kernel basically ignores the hint (apart from the 5level paging hack).

Clarify how this works a bit.

Thanks, Jann. Patch applied. And thanks for the review, Michal.

Cheers,

Michael

Quoted 28 lines

---
changed in v2:
- be less specific about what the kernel does when the requested address is unavailable to avoid constraining future behavior changes (Michal Hocko)

 man2/mmap.2 | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
man2/mmap.2 +6 -1
index fccfb9b3e..dbcae59be 100644
@@ -71,7 +71,12 @@ If
 .I addr
 is not NULL,
 then the kernel takes it as a hint about where to place the mapping;
-on Linux, the mapping will be created at a nearby page boundary.
+on Linux, the kernel will pick a nearby page boundary (but always above
+or equal to the value specified by
+.IR /proc/sys/vm/mmap_min_addr )
+and attempt to create the mapping there.
+If another mapping already exists there, the kernel picks a new address that
+may or may not depend on the hint.
 .\" Before Linux 2.6.24, the address was rounded up to the next page
 .\" boundary; since 2.6.24, it is rounded down!
 The address of the new mapping is returned as the result of the call.
Signature · 3 lines
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
#4 lore raw
Quoted 5 lines · William Kucharski

Thanks for updating the man page!

Thanks for the review, William.

Cheers,

Michael

Signature · 3 lines
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/