Skip to contentSkip to conversation

arm64: dts: mt8173: fix mdp aliases property name

PATCH In review Hsin-Yi Wang 4 participants 6 messages Apr 14, 2020 – May 16, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 arm64: dts: mt8173: fix mdp aliases property name

Fix warning:
Warning (alias_paths): /aliases: aliases property name must include only lowercase and '-'

---
 arch/arm64/boot/dts/mediatek/mt8173.dtsi | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)
arch/arm64/boot/dts/mediatek/mt8173.dtsi +8 -8
index a212bf124e81..d1e9c41004b4 100644
@@ -42,14 +42,14 @@ aliases {
 		dpi0 = &dpi0;
 		dsi0 = &dsi0;
 		dsi1 = &dsi1;
-		mdp_rdma0 = &mdp_rdma0;
-		mdp_rdma1 = &mdp_rdma1;
-		mdp_rsz0 = &mdp_rsz0;
-		mdp_rsz1 = &mdp_rsz1;
-		mdp_rsz2 = &mdp_rsz2;
-		mdp_wdma0 = &mdp_wdma0;
-		mdp_wrot0 = &mdp_wrot0;
-		mdp_wrot1 = &mdp_wrot1;
+		mdp-rdma0 = &mdp_rdma0;
+		mdp-rdma1 = &mdp_rdma1;
+		mdp-rsz0 = &mdp_rsz0;
+		mdp-rsz1 = &mdp_rsz1;
+		mdp-rsz2 = &mdp_rsz2;
+		mdp-wdma0 = &mdp_wdma0;
+		mdp-wrot0 = &mdp_wrot0;
+		mdp-wrot1 = &mdp_wrot1;
 		serial0 = &uart0;
 		serial1 = &uart1;
 		serial2 = &uart2;
Signature · 1 line
2.26.0.110.g2183baf09c-goog
#1 lore raw

PATCH 2/2 media: mtk-mdp: Use correct aliases name

aliases property name must include only lowercase and '-'. Fix in dts and driver.

---
 drivers/media/platform/mtk-mdp/mtk_mdp_comp.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/media/platform/mtk-mdp/mtk_mdp_comp.c +4 -4
index 14991685adb7..58abfbdfb82d 100644
@@ -15,10 +15,10 @@
 
 
 static const char * const mtk_mdp_comp_stem[MTK_MDP_COMP_TYPE_MAX] = {
-	"mdp_rdma",
-	"mdp_rsz",
-	"mdp_wdma",
-	"mdp_wrot",
+	"mdp-rdma",
+	"mdp-rsz",
+	"mdp-wdma",
+	"mdp-wrot",
 };
 
 struct mtk_mdp_comp_match {
Signature · 1 line
2.26.0.110.g2183baf09c-goog
Reviewed-by on v1 2/2
#2 lore raw

Re: [PATCH 2/2] media: mtk-mdp: Use correct aliases name

Hi, Hsin-Yi:

Hsin-Yi Wang <[email protected]> 於 2020年4月14日 週二 上午11:08寫道:

Quoted 4 lines

aliases property name must include only lowercase and '-'. Fix in dts and driver.

Quoted 29 lines
---
 drivers/media/platform/mtk-mdp/mtk_mdp_comp.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/media/platform/mtk-mdp/mtk_mdp_comp.c +4 -5
index 14991685adb7..58abfbdfb82d 100644
@@ -15,10 +15,10 @@
 
 
 static const char * const mtk_mdp_comp_stem[MTK_MDP_COMP_TYPE_MAX] = {
-       "mdp_rdma",
-       "mdp_rsz",
-       "mdp_wdma",
-       "mdp_wrot",
+       "mdp-rdma",
+       "mdp-rsz",
+       "mdp-wdma",
+       "mdp-wrot",
 };
 
 struct mtk_mdp_comp_match {
--

2.26.0.110.g2183baf09c-goog

Quoted 4 lines

_______________________________________________
Linux-mediatek mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-mediatek

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Reviewed-by on v1 1/2
#3 lore raw
In reply to Hsin-Yi Wang

Hi, Hsin-Yi

Hsin-Yi Wang <[email protected]> 於 2020年4月14日 週二 上午11:08寫道:

Quoted 3 lines

Fix warning:
Warning (alias_paths): /aliases: aliases property name must include only lowercase and '-'

Quoted 37 lines
---
 arch/arm64/boot/dts/mediatek/mt8173.dtsi | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)
arch/arm64/boot/dts/mediatek/mt8173.dtsi +8 -9
index a212bf124e81..d1e9c41004b4 100644
@@ -42,14 +42,14 @@ aliases {
                dpi0 = &dpi0;
                dsi0 = &dsi0;
                dsi1 = &dsi1;
-               mdp_rdma0 = &mdp_rdma0;
-               mdp_rdma1 = &mdp_rdma1;
-               mdp_rsz0 = &mdp_rsz0;
-               mdp_rsz1 = &mdp_rsz1;
-               mdp_rsz2 = &mdp_rsz2;
-               mdp_wdma0 = &mdp_wdma0;
-               mdp_wrot0 = &mdp_wrot0;
-               mdp_wrot1 = &mdp_wrot1;
+               mdp-rdma0 = &mdp_rdma0;
+               mdp-rdma1 = &mdp_rdma1;
+               mdp-rsz0 = &mdp_rsz0;
+               mdp-rsz1 = &mdp_rsz1;
+               mdp-rsz2 = &mdp_rsz2;
+               mdp-wdma0 = &mdp_wdma0;
+               mdp-wrot0 = &mdp_wrot0;
+               mdp-wrot1 = &mdp_wrot1;
                serial0 = &uart0;
                serial1 = &uart1;
                serial2 = &uart2;
--

2.26.0.110.g2183baf09c-goog

Quoted 4 lines

_______________________________________________
Linux-mediatek mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-mediatek

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#4 lore raw
In reply to Hsin-Yi Wang
Quoted 7 lines · Hsin-Yi Wang

Fix warning:
Warning (alias_paths): /aliases: aliases property name must include only lowercase and '-'

---
 arch/arm64/boot/dts/mediatek/mt8173.dtsi | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

I'll merge patch 2/2 for 5.8. I assume that this dtsi patch is merged through a mediatek subsystem?

Regards,

Hans

Quoted 19 lines
arch/arm64/boot/dts/mediatek/mt8173.dtsi +1 -8
index a212bf124e81..d1e9c41004b4 100644
@@ -42,14 +42,14 @@ aliases {
 		dpi0 = &dpi0;
 		dsi0 = &dsi0;
 		dsi1 = &dsi1;
-		mdp_rdma0 = &mdp_rdma0;
-		mdp_rdma1 = &mdp_rdma1;
-		mdp_rsz0 = &mdp_rsz0;
-		mdp_rsz1 = &mdp_rsz1;
-		mdp_rsz2 = &mdp_rsz2;
-		mdp_wdma0 = &mdp_wdma0;
-		mdp_wrot0 = &mdp_wrot0;
-		mdp_wrot1 = &mdp_wrot1;
+		mdp-rdma0 = &mdp_rdma0;

arch/arm64/boot/dts/mediatek/mt8173.dtsi aliases { · line 55

Quoted 10 lines
arch/arm64/boot/dts/mediatek/mt8173.dtsi +7 -0
+		mdp-rdma1 = &mdp_rdma1;
+		mdp-rsz0 = &mdp_rsz0;
+		mdp-rsz1 = &mdp_rsz1;
+		mdp-rsz2 = &mdp_rsz2;
+		mdp-wdma0 = &mdp_wdma0;
+		mdp-wrot0 = &mdp_wrot0;
+		mdp-wrot1 = &mdp_wrot1;
 		serial0 = &uart0;
 		serial1 = &uart1;
 		serial2 = &uart2;

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

maintainer
#5 lore raw
Quoted 4 lines · Hans Verkuil
Quoted 3 lines · Hsin-Yi Wang

Fix warning:
Warning (alias_paths): /aliases: aliases property name must include only lowercase and '-'

Quoted 8 lines
Quoted 4 lines
---
 arch/arm64/boot/dts/mediatek/mt8173.dtsi | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

I'll merge patch 2/2 for 5.8. I assume that this dtsi patch is merged through a mediatek subsystem?

Correct. Now queued in v5.7-next/dts64

Thanks!

Quoted 34 lines

Regards,

Hans

Quoted 29 lines
arch/arm64/boot/dts/mediatek/mt8173.dtsi +8 -8
index a212bf124e81..d1e9c41004b4 100644
@@ -42,14 +42,14 @@ aliases {
 		dpi0 = &dpi0;
 		dsi0 = &dsi0;
 		dsi1 = &dsi1;
-		mdp_rdma0 = &mdp_rdma0;
-		mdp_rdma1 = &mdp_rdma1;
-		mdp_rsz0 = &mdp_rsz0;
-		mdp_rsz1 = &mdp_rsz1;
-		mdp_rsz2 = &mdp_rsz2;
-		mdp_wdma0 = &mdp_wdma0;
-		mdp_wrot0 = &mdp_wrot0;
-		mdp_wrot1 = &mdp_wrot1;
+		mdp-rdma0 = &mdp_rdma0;
+		mdp-rdma1 = &mdp_rdma1;
+		mdp-rsz0 = &mdp_rsz0;
+		mdp-rsz1 = &mdp_rsz1;
+		mdp-rsz2 = &mdp_rsz2;
+		mdp-wdma0 = &mdp_wdma0;
+		mdp-wrot0 = &mdp_wrot0;
+		mdp-wrot1 = &mdp_wrot1;
 		serial0 = &uart0;
 		serial1 = &uart1;
 		serial2 = &uart2;