Skip to contentSkip to conversation

mtd: spi-nor: Disable chip erase for S28HS02GT flash

PATCH In review Prasad Kummari 2 participants 2 messages Jul 30, 2024 – Aug 30, 2024 Memory technology devices (MTD)

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 mtd: spi-nor: Disable chip erase for S28HS02GT flash

From: Tejas Bhumkar <[email protected]>

Since the opcode SPINOR_OP_CHIP_ERASE (0xc7) is not supported for the S28HS02GT flash, the NO_CHIP_ERASE flag has been added to enable sector erase functionality instead.

---
Changes in v2:
- corrected commit subject.

 drivers/mtd/spi/spi-nor-ids.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mtd/spi/spi-nor-ids.c +1 -1
index 0908fb954e..1b737a3507 100644
@@ -383,7 +383,7 @@ const struct flash_info spi_nor_ids[] = {
 	{ INFO("s28hl01gt",  0x345a1b,      0, 256 * 1024, 512, SPI_NOR_OCTAL_DTR_READ) },
 	{ INFO("s28hs512t",  0x345b1a,      0, 256 * 1024, 256, SPI_NOR_OCTAL_DTR_READ) },
 	{ INFO("s28hs01gt",  0x345b1b,      0, 256 * 1024, 512, SPI_NOR_OCTAL_DTR_READ) },
-	{ INFO("s28hs02gt",  0x345b1c,      0, 256 * 1024, 1024, SPI_NOR_OCTAL_DTR_READ | SPI_NOR_MULTI_DIE) },
+	{ INFO("s28hs02gt",  0x345b1c,      0, 256 * 1024, 1024, SPI_NOR_OCTAL_DTR_READ | SPI_NOR_MULTI_DIE | NO_CHIP_ERASE) },
 #endif
 #endif
 #ifdef CONFIG_SPI_FLASH_SST		/* SST */
Signature · 1 line
2.25.1
#1 lore raw

Hello,

Quoted 20 lines · Prasad Kummari

From: Tejas Bhumkar <[email protected]>

Since the opcode SPINOR_OP_CHIP_ERASE (0xc7) is not supported for the S28HS02GT flash, the NO_CHIP_ERASE flag has been added to enable sector erase functionality instead.

---
Changes in v2:
- corrected commit subject.

 drivers/mtd/spi/spi-nor-ids.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mtd/spi/spi-nor-ids.c +0 -0
index 0908fb954e..1b737a3507 100644

drivers/mtd/spi/spi-nor-ids.c const struct flash_info spi_nor_ids[] = { · line 386

Quoted 5 lines
drivers/mtd/spi/spi-nor-ids.c +1 -1
@@ -383,7 +383,7 @@ const struct flash_info spi_nor_ids[] = {
 	{ INFO("s28hl01gt",  0x345a1b,      0, 256 * 1024, 512, SPI_NOR_OCTAL_DTR_READ) },
 	{ INFO("s28hs512t",  0x345b1a,      0, 256 * 1024, 256, SPI_NOR_OCTAL_DTR_READ) },
 	{ INFO("s28hs01gt",  0x345b1b,      0, 256 * 1024, 512, SPI_NOR_OCTAL_DTR_READ) },
-	{ INFO("s28hs02gt",  0x345b1c,      0, 256 * 1024, 1024, SPI_NOR_OCTAL_DTR_READ | SPI_NOR_MULTI_DIE) },
+	{ INFO("s28hs02gt",  0x345b1c,      0, 256 * 1024, 1024, SPI_NOR_OCTAL_DTR_READ | SPI_NOR_MULTI_DIE | NO_CHIP_ERASE) },

The 'SPI_NOR_MULTI_DIE' is not defined in mainline u-boot. I have submitted another patch:
https://patchwork.ozlabs.org/project/uboot/patch/[email protected]/

Thanks,
Takahiro Kuwano