Skip to contentSkip to conversation

Add support for XLCDC to sam9x7 SoC family.

PATCH Superseded Manikandan Muralidharan 2 participants 16 messages Aug 25, 2023 – Sep 18, 2023

Subsystems (5)

v4 of 9 Superseded Latest is v9 →

lore
Share & tools
lore

Manikandan Muralidharan

author maintainer
#0 lore raw

v4 cover Add support for XLCDC to sam9x7 SoC family.

This patch series aims to add support for XLCDC IP of sam9x7 SoC family to the DRM subsystem.XLCDC IP has additional registers and new configuration bits compared to the existing register set of HLCDC IP. The new compatible string "microchip,sam9x75-xlcdc" is defined for sam9x75 variant of the sam9x7 SoC family.The is_xlcdc flag under driver data helps to differentiate the XLCDC and existing HLCDC code within the same driver.

changes in v4:
* fixed kernel warnings reported by kernel test robot.

changes in v3:
* Removed de-referencing the value of is_xlcdc flag multiple times in a single function.
* Removed cpu_relax() call when using regmap_read_poll_timeout.
* Updated xfactor and yfactor equations using shift operators
* Defined CSC co-efficients in an array for code readability.

changes in v2:
* Change the driver compatible name from "microchip,sam9x7-xlcdc" to "microchip,sam9x75-xlcdc".
* Move is_xlcdc flag to driver data.
* Remove unsed Macro definitions.
* Add co-developed-bys tags
* Replace regmap_read() with regmap_read_poll_timeout() call
* Split code into two helpers for code readablitity.

Durai Manickam KR (1):
drm: atmel-hlcdc: Define SAM9X7 SoC XLCDC specific registers

Manikandan Muralidharan (7):
mfd: atmel-hlcdc: Add compatible for sam9x75 XLCD controller
drm: atmel-hlcdc: add flag to differentiate XLCDC and HLCDC IP
drm: atmel-hlcdc: add LCD controller layer definition for sam9x75
drm: atmel_hlcdc: Add support for XLCDC in atmel LCD driver
drm: atmel-hlcdc: add DPI mode support for XLCDC
drm: atmel-hlcdc: add vertical and horizontal scaling support for
XLCDC
drm: atmel-hlcdc: add support for DSI output formats

 .../gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c    | 168 +++++++--
 drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c  |  99 +++++
 drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.h  |  48 +++
 .../gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c   | 353 +++++++++++++++---
 drivers/mfd/atmel-hlcdc.c                     |   1 +
 include/linux/mfd/atmel-hlcdc.h               |  10 +
 6 files changed, 584 insertions(+), 95 deletions(-)
Signature · 1 line
2.25.1
author maintainer
#1 lore raw

PATCH v4 1/8 mfd: atmel-hlcdc: Add compatible for sam9x75 XLCD controller

Add compatible for sam9x75 XLCD controller.

---
 drivers/mfd/atmel-hlcdc.c | 1 +
 1 file changed, 1 insertion(+)
drivers/mfd/atmel-hlcdc.c +1 -0
index 3c2414ba4b01..1daa7410468a 100644
@@ -141,6 +141,7 @@ static const struct of_device_id atmel_hlcdc_match[] = {
 	{ .compatible = "atmel,sama5d3-hlcdc" },
 	{ .compatible = "atmel,sama5d4-hlcdc" },
 	{ .compatible = "microchip,sam9x60-hlcdc" },
+	{ .compatible = "microchip,sam9x75-xlcdc" },
 	{ /* sentinel */ },
 };
 MODULE_DEVICE_TABLE(of, atmel_hlcdc_match);
Signature · 1 line
2.25.1
author maintainer
#2 lore raw

PATCH v4 2/8 drm: atmel-hlcdc: add flag to differentiate XLCDC and HLCDC IP

In reply to Manikandan Muralidharan

Add is_xlcdc flag in driver data to differentiate XLCDC and HLCDC code within the atmel-hlcdc driver files.

---
 drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.h | 2 ++
 1 file changed, 2 insertions(+)
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.h +2 -0
index 5b5c774e0edf..d68c79a6eae7 100644
@@ -304,6 +304,7 @@ atmel_hlcdc_layer_to_plane(struct atmel_hlcdc_layer *layer)
  * @conflicting_output_formats: true if RGBXXX output formats conflict with
  *				each other.
  * @fixed_clksrc: true if clock source is fixed
+ * @is_xlcdc: true if XLCDC IP is supported
  * @layers: a layer description table describing available layers
  * @nlayers: layer description table size
  */
@@ -317,6 +318,7 @@ struct atmel_hlcdc_dc_desc {
 	int max_hpw;
 	bool conflicting_output_formats;
 	bool fixed_clksrc;
+	bool is_xlcdc;
 	const struct atmel_hlcdc_layer_desc *layers;
 	int nlayers;
 };
Signature · 1 line
2.25.1
author maintainer
#3 lore raw

PATCH v4 3/8 drm: atmel-hlcdc: add LCD controller layer definition for sam9x75

In reply to Manikandan Muralidharan

Add the LCD controller layer definition and descriptor structure for sam9x75 for the following layers,
- Base Layer
- Overlay1 Layer
- Overlay2 Layer
- High End Overlay

---
 drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 97 ++++++++++++++++++++
 1 file changed, 97 insertions(+)
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c +97 -0
index fa0f9a93d50d..d30aec174aa2 100644
@@ -462,6 +462,99 @@ static const struct atmel_hlcdc_dc_desc atmel_hlcdc_dc_sam9x60 = {
 	.layers = atmel_hlcdc_sam9x60_layers,
 };
 
+static const struct atmel_hlcdc_layer_desc atmel_xlcdc_sam9x75_layers[] = {
+	{
+		.name = "base",
+		.formats = &atmel_hlcdc_plane_rgb_formats,
+		.regs_offset = 0x60,
+		.id = 0,
+		.type = ATMEL_HLCDC_BASE_LAYER,
+		.cfgs_offset = 0x1c,
+		.layout = {
+			.xstride = { 2 },
+			.default_color = 3,
+			.general_config = 4,
+			.disc_pos = 5,
+			.disc_size = 6,
+		},
+		.clut_offset = 0x700,
+	},
+	{
+		.name = "overlay1",
+		.formats = &atmel_hlcdc_plane_rgb_formats,
+		.regs_offset = 0x160,
+		.id = 1,
+		.type = ATMEL_HLCDC_OVERLAY_LAYER,
+		.cfgs_offset = 0x1c,
+		.layout = {
+			.pos = 2,
+			.size = 3,
+			.xstride = { 4 },
+			.pstride = { 5 },
+			.default_color = 6,
+			.chroma_key = 7,
+			.chroma_key_mask = 8,
+			.general_config = 9,
+		},
+		.clut_offset = 0xb00,
+	},
+	{
+		.name = "overlay2",
+		.formats = &atmel_hlcdc_plane_rgb_formats,
+		.regs_offset = 0x260,
+		.id = 2,
+		.type = ATMEL_HLCDC_OVERLAY_LAYER,
+		.cfgs_offset = 0x1c,
+		.layout = {
+			.pos = 2,
+			.size = 3,
+			.xstride = { 4 },
+			.pstride = { 5 },
+			.default_color = 6,
+			.chroma_key = 7,
+			.chroma_key_mask = 8,
+			.general_config = 9,
+		},
+		.clut_offset = 0xf00,
+	},
+	{
+		.name = "high-end-overlay",
+		.formats = &atmel_hlcdc_plane_rgb_and_yuv_formats,
+		.regs_offset = 0x360,
+		.id = 3,
+		.type = ATMEL_HLCDC_OVERLAY_LAYER,
+		.cfgs_offset = 0x30,
+		.layout = {
+			.pos = 2,
+			.size = 3,
+			.memsize = 4,
+			.xstride = { 5, 7 },
+			.pstride = { 6, 8 },
+			.default_color = 9,
+			.chroma_key = 10,
+			.chroma_key_mask = 11,
+			.general_config = 12,
+			.csc = 16,
+			.scaler_config = 23,
+		},
+		.clut_offset = 0x1300,
+	},
+};
+
+static const struct atmel_hlcdc_dc_desc atmel_xlcdc_dc_sam9x75 = {
+	.min_width = 0,
+	.min_height = 0,
+	.max_width = 2048,
+	.max_height = 2048,
+	.max_spw = 0xff,
+	.max_vpw = 0xff,
+	.max_hpw = 0x3ff,
+	.fixed_clksrc = true,
+	.is_xlcdc = true,
+	.nlayers = ARRAY_SIZE(atmel_xlcdc_sam9x75_layers),
+	.layers = atmel_xlcdc_sam9x75_layers,
+};
+
 static const struct of_device_id atmel_hlcdc_of_match[] = {
 	{
 		.compatible = "atmel,at91sam9n12-hlcdc",
@@ -487,6 +580,10 @@ static const struct of_device_id atmel_hlcdc_of_match[] = {
 		.compatible = "microchip,sam9x60-hlcdc",
 		.data = &atmel_hlcdc_dc_sam9x60,
 	},
+	{
+		.compatible = "microchip,sam9x75-xlcdc",
+		.data = &atmel_xlcdc_dc_sam9x75,
+	},
 	{ /* sentinel */ },
 };
 MODULE_DEVICE_TABLE(of, atmel_hlcdc_of_match);
Signature · 1 line
2.25.1
author maintainer
#4 lore raw

PATCH v4 4/8 drm: atmel-hlcdc: Define SAM9X7 SoC XLCDC specific registers

In reply to Manikandan Muralidharan

From: Durai Manickam KR <[email protected]>

The register address of the XLCDC IP used in SAM9X7 SoC family are different from the previous HLCDC.Defining those address space with valid macros.

---
 drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.h | 42 ++++++++++++++++++++
 include/linux/mfd/atmel-hlcdc.h              | 10 +++++
 2 files changed, 52 insertions(+)
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.h +42 -0
index d68c79a6eae7..8b05a54b5fd0 100644
@@ -15,6 +15,7 @@
 
 #include <drm/drm_plane.h>
 
+/* LCD controller common registers */
 #define ATMEL_HLCDC_LAYER_CHER			0x0
 #define ATMEL_HLCDC_LAYER_CHDR			0x4
 #define ATMEL_HLCDC_LAYER_CHSR			0x8
@@ -128,6 +129,47 @@
 
 #define ATMEL_HLCDC_MAX_LAYERS			6
 
+/* XLCDC controller specific registers */
+#define ATMEL_XLCDC_LAYER_ENR			0x10
+#define ATMEL_XLCDC_LAYER_EN			BIT(0)
+
+#define ATMEL_XLCDC_LAYER_IER			0x0
+#define ATMEL_XLCDC_LAYER_IDR			0x4
+#define ATMEL_XLCDC_LAYER_ISR			0xc
+#define ATMEL_XLCDC_LAYER_OVR_IRQ(p)		BIT(2 + (8 * (p)))
+
+#define ATMEL_XLCDC_LAYER_PLANE_ADDR(p)		(((p) * 0x4) + 0x18)
+
+#define ATMEL_XLCDC_LAYER_DMA_CFG		0
+
+#define ATMEL_XLCDC_LAYER_DMA			BIT(0)
+#define ATMEL_XLCDC_LAYER_REP			BIT(1)
+#define ATMEL_XLCDC_LAYER_DISCEN                BIT(4)
+
+#define ATMEL_XLCDC_LAYER_SFACTC_A0_MULT_AS	(4 << 6)
+#define ATMEL_XLCDC_LAYER_SFACTA_ONE		BIT(9)
+#define ATMEL_XLCDC_LAYER_DFACTC_M_A0_MULT_AS	(6 << 11)
+#define ATMEL_XLCDC_LAYER_DFACTA_ONE		BIT(14)
+
+#define ATMEL_XLCDC_LAYER_A0_SHIFT		16
+#define ATMEL_XLCDC_LAYER_A0(x)			\
+	((x) << ATMEL_XLCDC_LAYER_A0_SHIFT)
+
+#define ATMEL_XLCDC_LAYER_VSCALER_LUMA_ENABLE		BIT(0)
+#define ATMEL_XLCDC_LAYER_VSCALER_CHROMA_ENABLE		BIT(1)
+#define ATMEL_XLCDC_LAYER_HSCALER_LUMA_ENABLE		BIT(4)
+#define ATMEL_XLCDC_LAYER_HSCALER_CHROMA_ENABLE		BIT(5)
+
+#define ATMEL_XLCDC_LAYER_VXSYCFG_ONE		BIT(0)
+#define ATMEL_XLCDC_LAYER_VXSYTAP2_ENABLE	BIT(4)
+#define ATMEL_XLCDC_LAYER_VXSCCFG_ONE		BIT(16)
+#define ATMEL_XLCDC_LAYER_VXSCTAP2_ENABLE	BIT(20)
+
+#define ATMEL_XLCDC_LAYER_HXSYCFG_ONE		BIT(0)
+#define ATMEL_XLCDC_LAYER_HXSYTAP2_ENABLE	BIT(4)
+#define ATMEL_XLCDC_LAYER_HXSCCFG_ONE		BIT(16)
+#define ATMEL_XLCDC_LAYER_HXSCTAP2_ENABLE	BIT(20)
+
 /**
  * Atmel HLCDC Layer registers layout structure
  *
include/linux/mfd/atmel-hlcdc.h +10 -0
index a186119a49b5..80d675a03b39 100644
@@ -22,6 +22,8 @@
 #define ATMEL_HLCDC_DITHER		BIT(6)
 #define ATMEL_HLCDC_DISPDLY		BIT(7)
 #define ATMEL_HLCDC_MODE_MASK		GENMASK(9, 8)
+#define ATMEL_XLCDC_MODE_MASK		GENMASK(10, 8)
+#define ATMEL_XLCDC_DPI			BIT(11)
 #define ATMEL_HLCDC_PP			BIT(10)
 #define ATMEL_HLCDC_VSPSU		BIT(12)
 #define ATMEL_HLCDC_VSPHO		BIT(13)
@@ -34,6 +36,12 @@
 #define ATMEL_HLCDC_IDR			0x30
 #define ATMEL_HLCDC_IMR			0x34
 #define ATMEL_HLCDC_ISR			0x38
+#define ATMEL_XLCDC_ATTRE		0x3c
+
+#define ATMEL_XLCDC_BASE_UPDATE		BIT(0)
+#define ATMEL_XLCDC_OVR1_UPDATE		BIT(1)
+#define ATMEL_XLCDC_OVR3_UPDATE		BIT(2)
+#define ATMEL_XLCDC_HEO_UPDATE		BIT(3)
 
 #define ATMEL_HLCDC_CLKPOL		BIT(0)
 #define ATMEL_HLCDC_CLKSEL		BIT(2)
@@ -48,6 +56,8 @@
 #define ATMEL_HLCDC_DISP		BIT(2)
 #define ATMEL_HLCDC_PWM			BIT(3)
 #define ATMEL_HLCDC_SIP			BIT(4)
+#define ATMEL_XLCDC_SD			BIT(5)
+#define ATMEL_XLCDC_CM			BIT(6)
 
 #define ATMEL_HLCDC_SOF			BIT(0)
 #define ATMEL_HLCDC_SYNCDIS		BIT(1)
Signature · 1 line
2.25.1
maintainer
#5 lore raw

Re: [PATCH v4 4/8] drm: atmel-hlcdc: Define SAM9X7 SoC XLCDC specific registers

Quoted 36 lines · Manikandan Muralidharan

From: Durai Manickam KR <[email protected]>

The register address of the XLCDC IP used in SAM9X7 SoC family are different from the previous HLCDC.Defining those address space with valid macros.

---
 drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.h | 42 ++++++++++++++++++++
 include/linux/mfd/atmel-hlcdc.h              | 10 +++++
 2 files changed, 52 insertions(+)
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.h +7 -0
index d68c79a6eae7..8b05a54b5fd0 100644
@@ -15,6 +15,7 @@
 
 #include <drm/drm_plane.h>
 
+/* LCD controller common registers */
 #define ATMEL_HLCDC_LAYER_CHER			0x0
 #define ATMEL_HLCDC_LAYER_CHDR			0x4
 #define ATMEL_HLCDC_LAYER_CHSR			0x8
@@ -128,6 +129,47 @@
 
 #define ATMEL_HLCDC_MAX_LAYERS			6
 
+/* XLCDC controller specific registers */
+#define ATMEL_XLCDC_LAYER_ENR			0x10
+#define ATMEL_XLCDC_LAYER_EN			BIT(0)
+
+#define ATMEL_XLCDC_LAYER_IER			0x0
+#define ATMEL_XLCDC_LAYER_IDR			0x4

drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.h line 147

Quoted 10 lines
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.h +10 -0
+#define ATMEL_XLCDC_LAYER_ISR			0xc
+#define ATMEL_XLCDC_LAYER_OVR_IRQ(p)		BIT(2 + (8 * (p)))
+
+#define ATMEL_XLCDC_LAYER_PLANE_ADDR(p)		(((p) * 0x4) + 0x18)
+
+#define ATMEL_XLCDC_LAYER_DMA_CFG		0
+
+#define ATMEL_XLCDC_LAYER_DMA			BIT(0)
+#define ATMEL_XLCDC_LAYER_REP			BIT(1)
+#define ATMEL_XLCDC_LAYER_DISCEN                BIT(4)

You have spaces after macro name

Quoted 55 lines
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.h +25 -0
+
+#define ATMEL_XLCDC_LAYER_SFACTC_A0_MULT_AS	(4 << 6)
+#define ATMEL_XLCDC_LAYER_SFACTA_ONE		BIT(9)
+#define ATMEL_XLCDC_LAYER_DFACTC_M_A0_MULT_AS	(6 << 11)
+#define ATMEL_XLCDC_LAYER_DFACTA_ONE		BIT(14)
+
+#define ATMEL_XLCDC_LAYER_A0_SHIFT		16
+#define ATMEL_XLCDC_LAYER_A0(x)			\
+	((x) << ATMEL_XLCDC_LAYER_A0_SHIFT)
+
+#define ATMEL_XLCDC_LAYER_VSCALER_LUMA_ENABLE		BIT(0)
+#define ATMEL_XLCDC_LAYER_VSCALER_CHROMA_ENABLE		BIT(1)
+#define ATMEL_XLCDC_LAYER_HSCALER_LUMA_ENABLE		BIT(4)
+#define ATMEL_XLCDC_LAYER_HSCALER_CHROMA_ENABLE		BIT(5)
+
+#define ATMEL_XLCDC_LAYER_VXSYCFG_ONE		BIT(0)
+#define ATMEL_XLCDC_LAYER_VXSYTAP2_ENABLE	BIT(4)
+#define ATMEL_XLCDC_LAYER_VXSCCFG_ONE		BIT(16)
+#define ATMEL_XLCDC_LAYER_VXSCTAP2_ENABLE	BIT(20)
+
+#define ATMEL_XLCDC_LAYER_HXSYCFG_ONE		BIT(0)
+#define ATMEL_XLCDC_LAYER_HXSYTAP2_ENABLE	BIT(4)
+#define ATMEL_XLCDC_LAYER_HXSCCFG_ONE		BIT(16)
+#define ATMEL_XLCDC_LAYER_HXSCTAP2_ENABLE	BIT(20)
+
 /**
  * Atmel HLCDC Layer registers layout structure
  *
include/linux/mfd/atmel-hlcdc.h +8 -0
index a186119a49b5..80d675a03b39 100644
@@ -22,6 +22,8 @@
 #define ATMEL_HLCDC_DITHER		BIT(6)
 #define ATMEL_HLCDC_DISPDLY		BIT(7)
 #define ATMEL_HLCDC_MODE_MASK		GENMASK(9, 8)
+#define ATMEL_XLCDC_MODE_MASK		GENMASK(10, 8)
+#define ATMEL_XLCDC_DPI			BIT(11)
 #define ATMEL_HLCDC_PP			BIT(10)
 #define ATMEL_HLCDC_VSPSU		BIT(12)
 #define ATMEL_HLCDC_VSPHO		BIT(13)
@@ -34,6 +36,12 @@
 #define ATMEL_HLCDC_IDR			0x30
 #define ATMEL_HLCDC_IMR			0x34
 #define ATMEL_HLCDC_ISR			0x38
+#define ATMEL_XLCDC_ATTRE		0x3c
+
+#define ATMEL_XLCDC_BASE_UPDATE		BIT(0)
+#define ATMEL_XLCDC_OVR1_UPDATE		BIT(1)
+#define ATMEL_XLCDC_OVR3_UPDATE		BIT(2)
+#define ATMEL_XLCDC_HEO_UPDATE		BIT(3)
 
 #define ATMEL_HLCDC_CLKPOL		BIT(0)
 #define ATMEL_HLCDC_CLKSEL		BIT(2)

include/linux/mfd/atmel-hlcdc.h line 63

Quoted 8 lines
include/linux/mfd/atmel-hlcdc.h +2 -0
@@ -48,6 +56,8 @@
 #define ATMEL_HLCDC_DISP		BIT(2)
 #define ATMEL_HLCDC_PWM			BIT(3)
 #define ATMEL_HLCDC_SIP			BIT(4)
+#define ATMEL_XLCDC_SD			BIT(5)
+#define ATMEL_XLCDC_CM			BIT(6)
 
 #define ATMEL_HLCDC_SOF			BIT(0)
 #define ATMEL_HLCDC_SYNCDIS		BIT(1)

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

author maintainer
#6 lore raw

PATCH v4 5/8 drm: atmel_hlcdc: Add support for XLCDC in atmel LCD driver

In reply to Manikandan Muralidharan

- XLCDC in SAM9X7 has different sets of registers and additional configuration bits when compared to previous HLCDC IP. Read/write operation on the controller registers is now separated using the XLCDC status flag.
- HEO scaling, window resampling, Alpha blending, YUV-to-RGB
conversion in XLCDC is derived and handled using additional configuration bits and registers.
- Writing one to the Enable fields of each layer in LCD_ATTRE
is required to reflect the values set in Configuration, FBA, Enable registers of each layer

---
 .../gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c    |  25 +-
 .../gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c   | 333 +++++++++++++++---
 2 files changed, 299 insertions(+), 59 deletions(-)
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c +23 -2
index cc5cf4c2faf7..4b11a1de8af4 100644
@@ -79,6 +79,7 @@ static void atmel_hlcdc_crtc_mode_set_nofb(struct drm_crtc *c)
 	unsigned int mask = ATMEL_HLCDC_CLKDIV_MASK | ATMEL_HLCDC_CLKPOL;
 	unsigned int cfg = 0;
 	int div, ret;
+	bool is_xlcdc = crtc->dc->desc->is_xlcdc;
 
 	/* get encoder from crtc */
 	drm_for_each_encoder(en_iter, ddev) {
@@ -164,10 +165,10 @@ static void atmel_hlcdc_crtc_mode_set_nofb(struct drm_crtc *c)
 	state = drm_crtc_state_to_atmel_hlcdc_crtc_state(c->state);
 	cfg = state->output_mode << 8;
 
-	if (adj->flags & DRM_MODE_FLAG_NVSYNC)
+	if (!is_xlcdc && (adj->flags & DRM_MODE_FLAG_NVSYNC))
 		cfg |= ATMEL_HLCDC_VSPOL;
 
-	if (adj->flags & DRM_MODE_FLAG_NHSYNC)
+	if (!is_xlcdc && (adj->flags & DRM_MODE_FLAG_NHSYNC))
 		cfg |= ATMEL_HLCDC_HSPOL;
 
 	regmap_update_bits(regmap, ATMEL_HLCDC_CFG(5),
@@ -202,6 +203,16 @@ static void atmel_hlcdc_crtc_atomic_disable(struct drm_crtc *c,
 
 	pm_runtime_get_sync(dev->dev);
 
+	if (crtc->dc->desc->is_xlcdc) {
+		regmap_write(regmap, ATMEL_HLCDC_DIS, ATMEL_XLCDC_CM);
+		regmap_read_poll_timeout(regmap, ATMEL_HLCDC_SR, status,
+					 !(status & ATMEL_XLCDC_CM), 10, 0);
+
+		regmap_write(regmap, ATMEL_HLCDC_DIS, ATMEL_XLCDC_SD);
+		regmap_read_poll_timeout(regmap, ATMEL_HLCDC_SR, status,
+					 status & ATMEL_XLCDC_SD, 10, 0);
+	}
+
 	regmap_write(regmap, ATMEL_HLCDC_DIS, ATMEL_HLCDC_DISP);
 	while (!regmap_read(regmap, ATMEL_HLCDC_SR, &status) &&
 	       (status & ATMEL_HLCDC_DISP))
@@ -256,6 +267,16 @@ static void atmel_hlcdc_crtc_atomic_enable(struct drm_crtc *c,
 	       !(status & ATMEL_HLCDC_DISP))
 		cpu_relax();
 
+	if (crtc->dc->desc->is_xlcdc) {
+		regmap_write(regmap, ATMEL_HLCDC_EN, ATMEL_XLCDC_CM);
+		regmap_read_poll_timeout(regmap, ATMEL_HLCDC_SR, status,
+					 status & ATMEL_XLCDC_CM, 10, 0);
+
+		regmap_write(regmap, ATMEL_HLCDC_EN, ATMEL_XLCDC_SD);
+		regmap_read_poll_timeout(regmap, ATMEL_HLCDC_SR, status,
+					 !(status & ATMEL_XLCDC_SD), 10, 0);
+	}
+
 	pm_runtime_put_sync(dev->dev);
 
 }
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +276 -57

428 lines not on this page · raw message

Signature · 1 line
2.25.1
maintainer
#7 lore raw

Re: [PATCH v4 5/8] drm: atmel_hlcdc: Add support for XLCDC in atmel LCD driver

Hi, Manikandan,

Quoted 47 lines · Manikandan Muralidharan

- XLCDC in SAM9X7 has different sets of registers and additional configuration bits when compared to previous HLCDC IP. Read/write operation on the controller registers is now separated using the XLCDC status flag.
- HEO scaling, window resampling, Alpha blending, YUV-to-RGB
conversion in XLCDC is derived and handled using additional configuration bits and registers.
- Writing one to the Enable fields of each layer in LCD_ATTRE
is required to reflect the values set in Configuration, FBA, Enable registers of each layer

---
 .../gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c    |  25 +-
 .../gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c   | 333 +++++++++++++++---
 2 files changed, 299 insertions(+), 59 deletions(-)
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c +3 -2
index cc5cf4c2faf7..4b11a1de8af4 100644
@@ -79,6 +79,7 @@ static void atmel_hlcdc_crtc_mode_set_nofb(struct drm_crtc *c)
 	unsigned int mask = ATMEL_HLCDC_CLKDIV_MASK | ATMEL_HLCDC_CLKPOL;
 	unsigned int cfg = 0;
 	int div, ret;
+	bool is_xlcdc = crtc->dc->desc->is_xlcdc;
 
 	/* get encoder from crtc */
 	drm_for_each_encoder(en_iter, ddev) {
@@ -164,10 +165,10 @@ static void atmel_hlcdc_crtc_mode_set_nofb(struct drm_crtc *c)
 	state = drm_crtc_state_to_atmel_hlcdc_crtc_state(c->state);
 	cfg = state->output_mode << 8;
 
-	if (adj->flags & DRM_MODE_FLAG_NVSYNC)
+	if (!is_xlcdc && (adj->flags & DRM_MODE_FLAG_NVSYNC))
 		cfg |= ATMEL_HLCDC_VSPOL;
 
-	if (adj->flags & DRM_MODE_FLAG_NHSYNC)
+	if (!is_xlcdc && (adj->flags & DRM_MODE_FLAG_NHSYNC))
 		cfg |= ATMEL_HLCDC_HSPOL;
 
 	regmap_update_bits(regmap, ATMEL_HLCDC_CFG(5),

drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c static void atmel_hlcdc_crtc_atomic_disable(struct drm_crtc *c, · line 209

Quoted 7 lines
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c +4 -0
@@ -202,6 +203,16 @@ static void atmel_hlcdc_crtc_atomic_disable(struct drm_crtc *c,
 
 	pm_runtime_get_sync(dev->dev);
 
+	if (crtc->dc->desc->is_xlcdc) {
+		regmap_write(regmap, ATMEL_HLCDC_DIS, ATMEL_XLCDC_CM);
+		regmap_read_poll_timeout(regmap, ATMEL_HLCDC_SR, status,
+					 !(status & ATMEL_XLCDC_CM), 10, 0);

You may want to check the return value of regmap_read_poll_timeout(). Otherwise your setup may fail.

Also, regmap_read_poll_timeout() may sleep, the other settings in this functions are done with bussy looping, is there a reason for that?

drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c static void atmel_hlcdc_crtc_atomic_disable(struct drm_crtc *c, · line 213

Quoted 4 lines
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c +4 -0
+
+		regmap_write(regmap, ATMEL_HLCDC_DIS, ATMEL_XLCDC_SD);
+		regmap_read_poll_timeout(regmap, ATMEL_HLCDC_SR, status,
+					 status & ATMEL_XLCDC_SD, 10, 0);

Same here.

Quoted 37 lines
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c +12 -0
+	}
+
 	regmap_write(regmap, ATMEL_HLCDC_DIS, ATMEL_HLCDC_DISP);
 	while (!regmap_read(regmap, ATMEL_HLCDC_SR, &status) &&
 	       (status & ATMEL_HLCDC_DISP))
@@ -256,6 +267,16 @@ static void atmel_hlcdc_crtc_atomic_enable(struct drm_crtc *c,
 	       !(status & ATMEL_HLCDC_DISP))
 		cpu_relax();
 
+	if (crtc->dc->desc->is_xlcdc) {
+		regmap_write(regmap, ATMEL_HLCDC_EN, ATMEL_XLCDC_CM);
+		regmap_read_poll_timeout(regmap, ATMEL_HLCDC_SR, status,
+					 status & ATMEL_XLCDC_CM, 10, 0);
+
+		regmap_write(regmap, ATMEL_HLCDC_EN, ATMEL_XLCDC_SD);
+		regmap_read_poll_timeout(regmap, ATMEL_HLCDC_SR, status,
+					 !(status & ATMEL_XLCDC_SD), 10, 0);
+	}
+
 	pm_runtime_put_sync(dev->dev);
 
 }
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +7 -0
index daa508504f47..26caf4cddfa4 100644
@@ -330,11 +330,59 @@ static void atmel_hlcdc_plane_setup_scaler(struct atmel_hlcdc_plane *plane,
 								     yfactor));
 }
 
+static void atmel_xlcdc_plane_setup_scaler(struct atmel_hlcdc_plane *plane,
+					   struct atmel_hlcdc_plane_state *state)
+{
+	const struct atmel_hlcdc_layer_desc *desc = plane->layer.desc;
+	u32 xfactor, yfactor;
+
+	if (!desc->layout.scaler_config)

drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c static void atmel_hlcdc_plane_setup_scaler(struct atmel_hlcdc_plane *plane, · line 349

Quoted 10 lines
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +10 -0
+		return;
+
+	if (state->crtc_w == state->src_w && state->crtc_h == state->src_h) {
+		atmel_hlcdc_layer_write_cfg(&plane->layer,
+					    desc->layout.scaler_config, 0);
+		return;
+	}
+
+	/* xfactor = round[(2^20 * XMEMSIZE)/XSIZE)] */
+	xfactor = (u32)(((1 << 20) * state->src_w) / state->crtc_w);

Could ((1 << 20) * state->src_w) overflow?

drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c static void atmel_hlcdc_plane_setup_scaler(struct atmel_hlcdc_plane *plane, · line 352

Quoted 3 lines
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +3 -0
+
+	/* yfactor = round[(2^20 * YMEMSIZE)/YSIZE)] */
+	yfactor = (u32)(((1 << 20) * state->src_h) / state->crtc_h);

Same here.

Quoted 15 lines
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +15 -0
+
+	atmel_hlcdc_layer_write_cfg(&plane->layer, desc->layout.scaler_config,
+				    ATMEL_XLCDC_LAYER_VSCALER_LUMA_ENABLE |
+				    ATMEL_XLCDC_LAYER_VSCALER_CHROMA_ENABLE |
+				    ATMEL_XLCDC_LAYER_HSCALER_LUMA_ENABLE |
+				    ATMEL_XLCDC_LAYER_HSCALER_CHROMA_ENABLE);
+
+	atmel_hlcdc_layer_write_cfg(&plane->layer, desc->layout.scaler_config + 1,
+				    yfactor);
+	atmel_hlcdc_layer_write_cfg(&plane->layer, desc->layout.scaler_config + 3,
+				    xfactor);
+
+	/* As per YCbCr window resampling configuration */
+	if (state->base.fb->format->format == DRM_FORMAT_YUV420) {
+		atmel_hlcdc_layer_write_cfg(&plane->layer, desc->layout.scaler_config + 2,

drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c static void atmel_hlcdc_plane_setup_scaler(struct atmel_hlcdc_plane *plane, · line 377

Quoted 10 lines
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +10 -0
+					    yfactor / 2);
+		atmel_hlcdc_layer_write_cfg(&plane->layer, desc->layout.scaler_config + 4,
+					    xfactor / 2);
+	} else {
+		/* As per ARGB window resampling configuration */
+		atmel_hlcdc_layer_write_cfg(&plane->layer, desc->layout.scaler_config + 2,
+					    yfactor);
+		atmel_hlcdc_layer_write_cfg(&plane->layer, desc->layout.scaler_config + 4,
+					    xfactor);
+	}

This can be written as follows:

if (state->base.fb->format->format == DRM_FORMAT_YUV420) {
	yfactor /= 2);
	xfactor /= 2);
}
atmel_hlcdc_layer_write_cfg(&plane->layer, desc->layout.scaler_config + 2,
			    yfactor);
atmel_hlcdc_layer_write_cfg(&plane->layer, desc->layout.scaler_config + 4,
			    xfactor);
Quoted 12 lines
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +3 -0
+}
+
 static void
 atmel_hlcdc_plane_update_pos_and_size(struct atmel_hlcdc_plane *plane,
 				      struct atmel_hlcdc_plane_state *state)
 {
 	const struct atmel_hlcdc_layer_desc *desc = plane->layer.desc;
+	struct atmel_hlcdc_dc *dc = plane->base.dev->dev_private;
 
 	if (desc->layout.size)
 		atmel_hlcdc_layer_write_cfg(&plane->layer, desc->layout.size,

drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c atmel_hlcdc_plane_update_pos_and_size(struct atmel_hlcdc_plane *plane, · line 406

Quoted 8 lines
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +4 -1
@@ -352,7 +400,10 @@ atmel_hlcdc_plane_update_pos_and_size(struct atmel_hlcdc_plane *plane,
 					ATMEL_HLCDC_LAYER_POS(state->crtc_x,
 							      state->crtc_y));
 
-	atmel_hlcdc_plane_setup_scaler(plane, state);
+	if (dc->desc->is_xlcdc)
+		atmel_xlcdc_plane_setup_scaler(plane, state);
+	else
+		atmel_hlcdc_plane_setup_scaler(plane, state);

What if you embedd the plane_setup_scaller function in struct atmel_hlcdc_dc_desc and define per lcdc variant the proper function you can have here something like:

	dc->desc->plane_setup_scaler();

This is valid for other places in this patch (see below).

Quoted 46 lines
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +34 -0
 }
 
 static void
@@ -393,6 +444,40 @@ atmel_hlcdc_plane_update_general_settings(struct atmel_hlcdc_plane *plane,
 				    cfg);
 }
 
+static void
+atmel_xlcdc_plane_update_general_settings(struct atmel_hlcdc_plane *plane,
+					  struct atmel_hlcdc_plane_state *state)
+{
+	unsigned int cfg;
+	const struct atmel_hlcdc_layer_desc *desc = plane->layer.desc;
+	const struct drm_format_info *format = state->base.fb->format;
+
+	atmel_hlcdc_layer_write_cfg(&plane->layer, ATMEL_XLCDC_LAYER_DMA_CFG,
+				    ATMEL_HLCDC_LAYER_DMA_BLEN_INCR16 | state->ahb_id);
+
+	cfg = ATMEL_XLCDC_LAYER_DMA | ATMEL_XLCDC_LAYER_REP;
+
+	if (plane->base.type != DRM_PLANE_TYPE_PRIMARY) {
+		/*
+		 * Alpha Blending bits specific to SAM9X7 SoC
+		 */
+		cfg |= ATMEL_XLCDC_LAYER_SFACTC_A0_MULT_AS |
+		       ATMEL_XLCDC_LAYER_SFACTA_ONE |
+		       ATMEL_XLCDC_LAYER_DFACTC_M_A0_MULT_AS |
+		       ATMEL_XLCDC_LAYER_DFACTA_ONE;
+		if (format->has_alpha)
+			cfg |= ATMEL_XLCDC_LAYER_A0(0xff);
+		else
+			cfg |= ATMEL_XLCDC_LAYER_A0(state->base.alpha);
+	}
+
+	if (state->disc_h && state->disc_w)
+		cfg |= ATMEL_XLCDC_LAYER_DISCEN;
+
+	atmel_hlcdc_layer_write_cfg(&plane->layer, desc->layout.general_config,
+				    cfg);
+}
+
 static void atmel_hlcdc_plane_update_format(struct atmel_hlcdc_plane *plane,
 					struct atmel_hlcdc_plane_state *state)
 {
@@ -437,36 +522,55 @@ static void atmel_hlcdc_plane_update_clut(struct atmel_hlcdc_plane *plane,
 	}

drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c static void atmel_hlcdc_plane_update_clut(struct atmel_hlcdc_plane *plane, · line 532

Quoted 10 lines
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +8 -0
 }
 
+static void update_hlcdc_buffers(struct atmel_hlcdc_plane *plane,
+				 struct atmel_hlcdc_plane_state *state, u32 sr, int i)
+{
+	atmel_hlcdc_layer_write_reg(&plane->layer,
+				    ATMEL_HLCDC_LAYER_PLANE_HEAD(i),
+				    state->dscrs[i]->self);
+
+	if (!(sr & ATMEL_HLCDC_LAYER_EN)) {

To avoid extra indenting:

	if (sr & ATMEL_HLCDC_LAYER_EN)
		return;
Quoted 13 lines
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +13 -0
+		atmel_hlcdc_layer_write_reg(&plane->layer,
+					    ATMEL_HLCDC_LAYER_PLANE_ADDR(i),
+					    state->dscrs[i]->addr);
+		atmel_hlcdc_layer_write_reg(&plane->layer,
+					    ATMEL_HLCDC_LAYER_PLANE_CTRL(i),
+					    state->dscrs[i]->ctrl);
+		atmel_hlcdc_layer_write_reg(&plane->layer,
+					    ATMEL_HLCDC_LAYER_PLANE_NEXT(i),
+					    state->dscrs[i]->self);
+	}
+}
+
+static void update_xlcdc_buffers(struct atmel_hlcdc_plane *plane,

drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c static void atmel_hlcdc_plane_update_clut(struct atmel_hlcdc_plane *plane, · line 554

Quoted 10 lines
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +8 -1
+				 struct atmel_hlcdc_plane_state *state, int i)
+{
+	atmel_hlcdc_layer_write_reg(&plane->layer,
+				    ATMEL_XLCDC_LAYER_PLANE_ADDR(i),
+				    state->dscrs[i]->addr);
+}
+
 static void atmel_hlcdc_plane_update_buffers(struct atmel_hlcdc_plane *plane,
-					struct atmel_hlcdc_plane_state *state)
+					     struct atmel_hlcdc_plane_state *state)

update_hlcdc_buffers() and update_xlcdc_buffers() could also be members in the struct atmel_hlcdc_dc_desc and called accordingly where needed w/o checking is_xlcdc.

Quoted 25 lines
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +3 -10
 {
 	const struct atmel_hlcdc_layer_desc *desc = plane->layer.desc;
+	struct atmel_hlcdc_dc *dc = plane->base.dev->dev_private;
 	struct drm_framebuffer *fb = state->base.fb;
 	u32 sr;
 	int i;
 
-	sr = atmel_hlcdc_layer_read_reg(&plane->layer, ATMEL_HLCDC_LAYER_CHSR);
+	if (!dc->desc->is_xlcdc)
+		sr = atmel_hlcdc_layer_read_reg(&plane->layer, ATMEL_HLCDC_LAYER_CHSR);
 
 	for (i = 0; i < state->nplanes; i++) {
 		struct drm_gem_dma_object *gem = drm_fb_dma_get_gem_obj(fb, i);
 
 		state->dscrs[i]->addr = gem->dma_addr + state->offsets[i];
 
-		atmel_hlcdc_layer_write_reg(&plane->layer,
-					    ATMEL_HLCDC_LAYER_PLANE_HEAD(i),
-					    state->dscrs[i]->self);
-
-		if (!(sr & ATMEL_HLCDC_LAYER_EN)) {
-			atmel_hlcdc_layer_write_reg(&plane->layer,
-					ATMEL_HLCDC_LAYER_PLANE_ADDR(i),
-					state->dscrs[i]->addr);
-			atmel_hlcdc_layer_write_reg(&plane->layer,

drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c static void atmel_hlcdc_plane_update_clut(struct atmel_hlcdc_plane *plane, · line 573

Quoted 10 lines
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +4 -6
-					ATMEL_HLCDC_LAYER_PLANE_CTRL(i),
-					state->dscrs[i]->ctrl);
-			atmel_hlcdc_layer_write_reg(&plane->layer,
-					ATMEL_HLCDC_LAYER_PLANE_NEXT(i),
-					state->dscrs[i]->self);
-		}
+		if (dc->desc->is_xlcdc)
+			update_xlcdc_buffers(plane, state, i);
+		else
+			update_hlcdc_buffers(plane, state, sr, i);

And here you can have something like:

		dc->desc->update_lcdc_buffers();
Quoted 34 lines
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +15 -4
 		if (desc->layout.xstride[i])
 			atmel_hlcdc_layer_write_cfg(&plane->layer,
@@ -712,11 +816,8 @@ static int atmel_hlcdc_plane_atomic_check(struct drm_plane *p,
 	return 0;
 }
 
-static void atmel_hlcdc_plane_atomic_disable(struct drm_plane *p,
-					     struct drm_atomic_state *state)
+static void hlcdc_atomic_disable(struct atmel_hlcdc_plane *plane)
 {
-	struct atmel_hlcdc_plane *plane = drm_plane_to_atmel_hlcdc_plane(p);
-
 	/* Disable interrupts */
 	atmel_hlcdc_layer_write_reg(&plane->layer, ATMEL_HLCDC_LAYER_IDR,
 				    0xffffffff);
@@ -731,6 +832,72 @@ static void atmel_hlcdc_plane_atomic_disable(struct drm_plane *p,
 	atmel_hlcdc_layer_read_reg(&plane->layer, ATMEL_HLCDC_LAYER_ISR);
 }
 
+static void xlcdc_atomic_disable(struct atmel_hlcdc_plane *plane)
+{
+	/* Disable interrupts */
+	atmel_hlcdc_layer_write_reg(&plane->layer, ATMEL_XLCDC_LAYER_IDR,
+				    0xffffffff);
+
+	/* Disable the layer */
+	atmel_hlcdc_layer_write_reg(&plane->layer,
+				    ATMEL_XLCDC_LAYER_ENR, 0);
+
+	/* Clear all pending interrupts */
+	atmel_hlcdc_layer_read_reg(&plane->layer, ATMEL_XLCDC_LAYER_ISR);
+}
+

drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c static void atmel_hlcdc_plane_atomic_disable(struct drm_plane *p, · line 858

Quoted 10 lines
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +10 -0
+static void atmel_hlcdc_plane_atomic_disable(struct drm_plane *p,
+					     struct drm_atomic_state *state)
+{
+	struct atmel_hlcdc_plane *plane = drm_plane_to_atmel_hlcdc_plane(p);
+	struct atmel_hlcdc_dc *dc = plane->base.dev->dev_private;
+
+	if (dc->desc->is_xlcdc)
+		xlcdc_atomic_disable(plane);
+	else
+		hlcdc_atomic_disable(plane);
	dc->desc->lcdc_atomic_disable();
Quoted 55 lines
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +43 -1
+}
+
+static void hlcdc_atomic_update(struct atmel_hlcdc_plane *plane)
+{
+	u32 sr;
+
+	/* Enable the overrun interrupts. */
+	atmel_hlcdc_layer_write_reg(&plane->layer, ATMEL_HLCDC_LAYER_IER,
+				    ATMEL_HLCDC_LAYER_OVR_IRQ(0) |
+				    ATMEL_HLCDC_LAYER_OVR_IRQ(1) |
+				    ATMEL_HLCDC_LAYER_OVR_IRQ(2));
+
+	/* Apply the new config at the next SOF event. */
+	sr = atmel_hlcdc_layer_read_reg(&plane->layer, ATMEL_HLCDC_LAYER_CHSR);
+	atmel_hlcdc_layer_write_reg(&plane->layer, ATMEL_HLCDC_LAYER_CHER,
+				    ATMEL_HLCDC_LAYER_UPDATE |
+				    (sr & ATMEL_HLCDC_LAYER_EN ?
+				    ATMEL_HLCDC_LAYER_A2Q : ATMEL_HLCDC_LAYER_EN));
+}
+
+static void xlcdc_atomic_update(struct atmel_hlcdc_plane *plane,
+				struct atmel_hlcdc_dc *dc)
+{
+	/* Enable the overrun interrupts. */
+	atmel_hlcdc_layer_write_reg(&plane->layer, ATMEL_XLCDC_LAYER_IER,
+				    ATMEL_XLCDC_LAYER_OVR_IRQ(0) |
+				    ATMEL_XLCDC_LAYER_OVR_IRQ(1) |
+				    ATMEL_XLCDC_LAYER_OVR_IRQ(2));
+
+	atmel_hlcdc_layer_write_reg(&plane->layer, ATMEL_XLCDC_LAYER_ENR,
+				    ATMEL_XLCDC_LAYER_EN);
+
+	/*
+	 * Updating XLCDC_xxxCFGx, XLCDC_xxxFBA and XLCDC_xxxEN,
+	 * (where xxx indicates each layer) requires writing one to the
+	 * Update Attribute field for each layer in LCDC_ATTRE register for SAM9X7.
+	 */
+	regmap_write(dc->hlcdc->regmap, ATMEL_XLCDC_ATTRE, ATMEL_XLCDC_BASE_UPDATE |
+		     ATMEL_XLCDC_OVR1_UPDATE | ATMEL_XLCDC_OVR3_UPDATE |
+		     ATMEL_XLCDC_HEO_UPDATE);
+}
+
 static void atmel_hlcdc_plane_atomic_update(struct drm_plane *p,
 					    struct drm_atomic_state *state)
 {
@@ -739,7 +906,7 @@ static void atmel_hlcdc_plane_atomic_update(struct drm_plane *p,
 	struct atmel_hlcdc_plane *plane = drm_plane_to_atmel_hlcdc_plane(p);
 	struct atmel_hlcdc_plane_state *hstate =
 			drm_plane_state_to_atmel_hlcdc_plane_state(new_s);
-	u32 sr;
+	struct atmel_hlcdc_dc *dc = p->dev->dev_private;
 
 	if (!new_s->crtc || !new_s->fb)
 		return;

drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c static void atmel_hlcdc_plane_atomic_update(struct drm_plane *p, · line 923

Quoted 8 lines
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +4 -1
@@ -750,29 +917,67 @@ static void atmel_hlcdc_plane_atomic_update(struct drm_plane *p,
 	}
 
 	atmel_hlcdc_plane_update_pos_and_size(plane, hstate);
-	atmel_hlcdc_plane_update_general_settings(plane, hstate);
+	if (dc->desc->is_xlcdc)
+		atmel_xlcdc_plane_update_general_settings(plane, hstate);
+	else
+		atmel_hlcdc_plane_update_general_settings(plane, hstate);
	dc->desc->lcdc_plane_update_general_settigns();
Quoted 4 lines
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +0 -0
 	atmel_hlcdc_plane_update_format(plane, hstate);
 	atmel_hlcdc_plane_update_clut(plane, hstate);
 	atmel_hlcdc_plane_update_buffers(plane, hstate);
 	atmel_hlcdc_plane_update_disc_area(plane, hstate);

drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c static void atmel_hlcdc_plane_atomic_update(struct drm_plane *p, · line 932

Quoted 10 lines
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +4 -5
 
-	/* Enable the overrun interrupts. */
-	atmel_hlcdc_layer_write_reg(&plane->layer, ATMEL_HLCDC_LAYER_IER,
-				    ATMEL_HLCDC_LAYER_OVR_IRQ(0) |
-				    ATMEL_HLCDC_LAYER_OVR_IRQ(1) |
-				    ATMEL_HLCDC_LAYER_OVR_IRQ(2));
+	if (dc->desc->is_xlcdc)
+		xlcdc_atomic_update(plane, dc);
+	else
+		hlcdc_atomic_update(plane);
	dc->desc->lcdc_atomic_update();

drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c static void atmel_hlcdc_plane_atomic_update(struct drm_plane *p, · line 939

Quoted 13 lines
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +6 -6
+}
 
-	/* Apply the new config at the next SOF event. */
-	sr = atmel_hlcdc_layer_read_reg(&plane->layer, ATMEL_HLCDC_LAYER_CHSR);
-	atmel_hlcdc_layer_write_reg(&plane->layer, ATMEL_HLCDC_LAYER_CHER,
-			ATMEL_HLCDC_LAYER_UPDATE |
-			(sr & ATMEL_HLCDC_LAYER_EN ?
-			 ATMEL_HLCDC_LAYER_A2Q : ATMEL_HLCDC_LAYER_EN));
+u32 hlcdc_csc_coeffs[] = {
+	0x4c900091,
+	0x7a5f5090,
+	0x40040890
+};

You can move this in function where it is used and declare it static.

drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c static void atmel_hlcdc_plane_atomic_update(struct drm_plane *p, · line 949

Quoted 10 lines
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +10 -0
+
+u32 xlcdc_csc_coeffs[] = {
+	0x00000488,
+	0x00000648,
+	0x1EA00480,
+	0x00001D28,
+	0x08100480,
+	0x00000000,
+	0x00000007
+};

Same here.

drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c static void atmel_hlcdc_plane_atomic_update(struct drm_plane *p, · line 958

Quoted 9 lines
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +9 -0
+
+static void hlcdc_csc_init(struct atmel_hlcdc_plane *plane,
+			   const struct atmel_hlcdc_layer_desc *desc)
+{
+	/*
+	 * TODO: declare a "yuv-to-rgb-conv-factors" property to let
+	 * userspace modify these factors (using a BLOB property ?).
+	 */
+	for (int i = 0; i < ARRAY_SIZE(hlcdc_csc_coeffs); i++)

{ at the end of for statement.

drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c static void atmel_hlcdc_plane_atomic_update(struct drm_plane *p, · line 961

Quoted 3 lines
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +3 -0
+		atmel_hlcdc_layer_write_cfg(&plane->layer,
+					    desc->layout.csc + i,
+					    hlcdc_csc_coeffs[i]);

} here

drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c static void atmel_hlcdc_plane_atomic_update(struct drm_plane *p, · line 974

Quoted 13 lines
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +13 -0
+}
+
+static void xlcdc_csc_init(struct atmel_hlcdc_plane *plane,
+			   const struct atmel_hlcdc_layer_desc *desc)
+{
+	/*
+	 * yuv-to-rgb-conv-factors are now defined from LCDC_HEOCFG16 to
+	 * LCDC_HEOCFG21 registers in SAM9X7.
+	 */
+	for (int i = 0; i < ARRAY_SIZE(xlcdc_csc_coeffs); i++)
+		atmel_hlcdc_layer_write_cfg(&plane->layer,
+					    desc->layout.csc + i,
+					    xlcdc_csc_coeffs[i]);

Ditto

Quoted 23 lines
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +1 -10
 }
 
 static int atmel_hlcdc_plane_init_properties(struct atmel_hlcdc_plane *plane)
 {
 	const struct atmel_hlcdc_layer_desc *desc = plane->layer.desc;
+	struct atmel_hlcdc_dc *dc = plane->base.dev->dev_private;
 
 	if (desc->type == ATMEL_HLCDC_OVERLAY_LAYER ||
 	    desc->type == ATMEL_HLCDC_CURSOR_LAYER) {
@@ -796,31 +1001,19 @@ static int atmel_hlcdc_plane_init_properties(struct atmel_hlcdc_plane *plane)
 			return ret;
 	}
 
-	if (desc->layout.csc) {
-		/*
-		 * TODO: decare a "yuv-to-rgb-conv-factors" property to let
-		 * userspace modify these factors (using a BLOB property ?).
-		 */
-		atmel_hlcdc_layer_write_cfg(&plane->layer,
-					    desc->layout.csc,
-					    0x4c900091);
-		atmel_hlcdc_layer_write_cfg(&plane->layer,
-					    desc->layout.csc + 1,

drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c static int atmel_hlcdc_plane_init_properties(struct atmel_hlcdc_plane *plane) · line 1008

Quoted 10 lines
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +5 -5
-					    0x7a5f5090);
-		atmel_hlcdc_layer_write_cfg(&plane->layer,
-					    desc->layout.csc + 2,
-					    0x40040890);
-	}
+	if (dc->desc->is_xlcdc && desc->layout.csc)
+		xlcdc_csc_init(plane, desc);
+	else
+		if (desc->layout.csc)
+			hlcdc_csc_init(plane, desc);
	if (desc->layout.csc)
		dc->desc->lcdc_csc_init();
Quoted 17 lines
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +3 -5
 	return 0;
 }
 
-void atmel_hlcdc_plane_irq(struct atmel_hlcdc_plane *plane)
+static void hlcdc_irq_dbg(struct atmel_hlcdc_plane *plane,
+			  const struct atmel_hlcdc_layer_desc *desc)
 {
-	const struct atmel_hlcdc_layer_desc *desc = plane->layer.desc;
-	u32 isr;
-
-	isr = atmel_hlcdc_layer_read_reg(&plane->layer, ATMEL_HLCDC_LAYER_ISR);
+	u32 isr = atmel_hlcdc_layer_read_reg(&plane->layer, ATMEL_HLCDC_LAYER_ISR);
 
 	/*
 	 * There's not much we can do in case of overrun except informing

drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c void atmel_hlcdc_plane_irq(struct atmel_hlcdc_plane *plane) · line 1026

Quoted 6 lines
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +1 -2
@@ -830,8 +1023,34 @@ void atmel_hlcdc_plane_irq(struct atmel_hlcdc_plane *plane)
 	if (isr &
 	    (ATMEL_HLCDC_LAYER_OVR_IRQ(0) | ATMEL_HLCDC_LAYER_OVR_IRQ(1) |
 	     ATMEL_HLCDC_LAYER_OVR_IRQ(2)))
-		dev_dbg(plane->base.dev->dev, "overrun on plane %s\n",
-			desc->name);
+		pr_warn("%s: overrun on plane %s\n", __func__, desc->name);

Why changing to pr_warn? why not dev_warn, if any?

Quoted 6 lines
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +6 -0
+}
+
+static void xlcdc_irq_dbg(struct atmel_hlcdc_plane *plane,
+			  const struct atmel_hlcdc_layer_desc *desc)
+{
+	u32 isr = atmel_hlcdc_layer_read_reg(&plane->layer, ATMEL_XLCDC_LAYER_ISR);

drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c void atmel_hlcdc_plane_irq(struct atmel_hlcdc_plane *plane) · line 1042

Quoted 10 lines
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +10 -0
+
+	/*
+	 * There's not much we can do in case of overrun except informing
+	 * the user. However, we are in interrupt context here, hence the
+	 * use of dev_dbg().
+	 */
+	if (isr &
+	    (ATMEL_XLCDC_LAYER_OVR_IRQ(0) | ATMEL_XLCDC_LAYER_OVR_IRQ(1) |
+	     ATMEL_XLCDC_LAYER_OVR_IRQ(2)))
+		pr_warn("%s: overrun on plane %s\n", __func__, desc->name);

dev_warn() ?

drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c void atmel_hlcdc_plane_irq(struct atmel_hlcdc_plane *plane) · line 1053

Quoted 11 lines
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +11 -0
+}
+
+void atmel_hlcdc_plane_irq(struct atmel_hlcdc_plane *plane)
+{
+	const struct atmel_hlcdc_layer_desc *desc = plane->layer.desc;
+	struct atmel_hlcdc_dc *dc = plane->base.dev->dev_private;
+
+	if (dc->desc->is_xlcdc)
+		xlcdc_irq_dbg(plane, desc);
+	else
+		hlcdc_irq_dbg(plane, desc);
	dc->desc->lcdc_irq_dbg() ?

drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c void atmel_hlcdc_plane_irq(struct atmel_hlcdc_plane *plane) · line 1056

Quoted 3 lines
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +0 -0
 }
 
 static const struct drm_plane_helper_funcs atmel_hlcdc_layer_plane_helper_funcs = {

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

author maintainer
#8 lore raw

Re: [PATCH v4 5/8] drm: atmel_hlcdc: Add support for XLCDC in atmel LCD driver

Quoted 65 lines · claudiu beznea

[You don't often get email from [email protected]. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]

EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe

Hi, Manikandan,

Quoted 47 lines · Manikandan Muralidharan

- XLCDC in SAM9X7 has different sets of registers and additional configuration bits when compared to previous HLCDC IP. Read/write operation on the controller registers is now separated using the XLCDC status flag.
- HEO scaling, window resampling, Alpha blending, YUV-to-RGB
conversion in XLCDC is derived and handled using additional configuration bits and registers.
- Writing one to the Enable fields of each layer in LCD_ATTRE
is required to reflect the values set in Configuration, FBA, Enable registers of each layer

---
  .../gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c    |  25 +-
  .../gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c   | 333 +++++++++++++++---
  2 files changed, 299 insertions(+), 59 deletions(-)
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c +3 -2
index cc5cf4c2faf7..4b11a1de8af4 100644
@@ -79,6 +79,7 @@ static void atmel_hlcdc_crtc_mode_set_nofb(struct drm_crtc *c)
       unsigned int mask = ATMEL_HLCDC_CLKDIV_MASK | ATMEL_HLCDC_CLKPOL;
       unsigned int cfg = 0;
       int div, ret;
+     bool is_xlcdc = crtc->dc->desc->is_xlcdc;
 
       /* get encoder from crtc */
       drm_for_each_encoder(en_iter, ddev) {
@@ -164,10 +165,10 @@ static void atmel_hlcdc_crtc_mode_set_nofb(struct drm_crtc *c)
       state = drm_crtc_state_to_atmel_hlcdc_crtc_state(c->state);
       cfg = state->output_mode << 8;
 
-     if (adj->flags & DRM_MODE_FLAG_NVSYNC)
+     if (!is_xlcdc && (adj->flags & DRM_MODE_FLAG_NVSYNC))
               cfg |= ATMEL_HLCDC_VSPOL;
 
-     if (adj->flags & DRM_MODE_FLAG_NHSYNC)
+     if (!is_xlcdc && (adj->flags & DRM_MODE_FLAG_NHSYNC))
               cfg |= ATMEL_HLCDC_HSPOL;
 
       regmap_update_bits(regmap, ATMEL_HLCDC_CFG(5),

drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c static void atmel_hlcdc_crtc_atomic_disable(struct drm_crtc *c, · line 209

Quoted 7 lines
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c +4 -0
@@ -202,6 +203,16 @@ static void atmel_hlcdc_crtc_atomic_disable(struct drm_crtc *c,
 
       pm_runtime_get_sync(dev->dev);
 
+     if (crtc->dc->desc->is_xlcdc) {
+             regmap_write(regmap, ATMEL_HLCDC_DIS, ATMEL_XLCDC_CM);
+             regmap_read_poll_timeout(regmap, ATMEL_HLCDC_SR, status,
+                                      !(status & ATMEL_XLCDC_CM), 10, 0);

You may want to check the return value of regmap_read_poll_timeout(). Otherwise your setup may fail.

Quoted 3 lines

Also, regmap_read_poll_timeout() may sleep, the other settings in this functions are done with bussy looping, is there a reason for that? Hi Claudiu

Not sure if a non-zero timeout_us coud be sufficient for this operation, considering the next power-up and power-down sequence following the current step.
Any suggestion on the value of timeout_us is appreciable.

Quoted 48 lines

drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c static void atmel_hlcdc_crtc_atomic_disable(struct drm_crtc *c, · line 213

Quoted 4 lines
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c +4 -0
+
+             regmap_write(regmap, ATMEL_HLCDC_DIS, ATMEL_XLCDC_SD);
+             regmap_read_poll_timeout(regmap, ATMEL_HLCDC_SR, status,
+                                      status & ATMEL_XLCDC_SD, 10, 0);

Same here.

Quoted 41 lines
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c +12 -0
+     }
+
       regmap_write(regmap, ATMEL_HLCDC_DIS, ATMEL_HLCDC_DISP);
       while (!regmap_read(regmap, ATMEL_HLCDC_SR, &status) &&
              (status & ATMEL_HLCDC_DISP))
@@ -256,6 +267,16 @@ static void atmel_hlcdc_crtc_atomic_enable(struct drm_crtc *c,
              !(status & ATMEL_HLCDC_DISP))
               cpu_relax();
 
+     if (crtc->dc->desc->is_xlcdc) {
+             regmap_write(regmap, ATMEL_HLCDC_EN, ATMEL_XLCDC_CM);
+             regmap_read_poll_timeout(regmap, ATMEL_HLCDC_SR, status,
+                                      status & ATMEL_XLCDC_CM, 10, 0);
+
+             regmap_write(regmap, ATMEL_HLCDC_EN, ATMEL_XLCDC_SD);
+             regmap_read_poll_timeout(regmap, ATMEL_HLCDC_SR, status,
+                                      !(status & ATMEL_XLCDC_SD), 10, 0);
+     }
+
       pm_runtime_put_sync(dev->dev);
 
  }
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +11 -0
index daa508504f47..26caf4cddfa4 100644
@@ -330,11 +330,59 @@ static void atmel_hlcdc_plane_setup_scaler(struct atmel_hlcdc_plane *plane,
                                                                    yfactor));
  }
 
+static void atmel_xlcdc_plane_setup_scaler(struct atmel_hlcdc_plane *plane,
+                                        struct atmel_hlcdc_plane_state *state)
+{
+     const struct atmel_hlcdc_layer_desc *desc = plane->layer.desc;
+     u32 xfactor, yfactor;
+
+     if (!desc->layout.scaler_config)
+             return;
+
+     if (state->crtc_w == state->src_w && state->crtc_h == state->src_h) {
+             atmel_hlcdc_layer_write_cfg(&plane->layer,
Quoted 8 lines

drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c static void atmel_hlcdc_plane_setup_scaler(struct atmel_hlcdc_plane *plane, · line 349

Quoted 6 lines
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +6 -0
+                                         desc->layout.scaler_config, 0);
+             return;
+     }
+
+     /* xfactor = round[(2^20 * XMEMSIZE)/XSIZE)] */
+     xfactor = (u32)(((1 << 20) * state->src_w) / state->crtc_w);

Could ((1 << 20) * state->src_w) overflow?

It is within the limits, state->src_w will contain a 11bit reg value at max.

Quoted 69 lines

drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c static void atmel_hlcdc_plane_setup_scaler(struct atmel_hlcdc_plane *plane, · line 352

Quoted 4 lines
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +3 -0
+
+     /* yfactor = round[(2^20 * YMEMSIZE)/YSIZE)] */
+     yfactor = (u32)(((1 << 20) * state->src_h) / state->crtc_h);

Same here.

Quoted 15 lines
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +15 -0
+
+     atmel_hlcdc_layer_write_cfg(&plane->layer, desc->layout.scaler_config,
+                                 ATMEL_XLCDC_LAYER_VSCALER_LUMA_ENABLE |
+                                 ATMEL_XLCDC_LAYER_VSCALER_CHROMA_ENABLE |
+                                 ATMEL_XLCDC_LAYER_HSCALER_LUMA_ENABLE |
+                                 ATMEL_XLCDC_LAYER_HSCALER_CHROMA_ENABLE);
+
+     atmel_hlcdc_layer_write_cfg(&plane->layer, desc->layout.scaler_config + 1,
+                                 yfactor);
+     atmel_hlcdc_layer_write_cfg(&plane->layer, desc->layout.scaler_config + 3,
+                                 xfactor);
+
+     /* As per YCbCr window resampling configuration */
+     if (state->base.fb->format->format == DRM_FORMAT_YUV420) {
+             atmel_hlcdc_layer_write_cfg(&plane->layer, desc->layout.scaler_config + 2,

drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c static void atmel_hlcdc_plane_setup_scaler(struct atmel_hlcdc_plane *plane, · line 377

Quoted 10 lines
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +10 -0
+                                         yfactor / 2);
+             atmel_hlcdc_layer_write_cfg(&plane->layer, desc->layout.scaler_config + 4,
+                                         xfactor / 2);
+     } else {
+             /* As per ARGB window resampling configuration */
+             atmel_hlcdc_layer_write_cfg(&plane->layer, desc->layout.scaler_config + 2,
+                                         yfactor);
+             atmel_hlcdc_layer_write_cfg(&plane->layer, desc->layout.scaler_config + 4,
+                                         xfactor);
+     }

This can be written as follows:

if (state->base.fb->format->format == DRM_FORMAT_YUV420) {
         yfactor /= 2);
         xfactor /= 2);
}
atmel_hlcdc_layer_write_cfg(&plane->layer, desc->layout.scaler_config + 2,
                             yfactor);
atmel_hlcdc_layer_write_cfg(&plane->layer, desc->layout.scaler_config + 4,
                             xfactor);
Quoted 12 lines
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +3 -0
+}
+
  static void
  atmel_hlcdc_plane_update_pos_and_size(struct atmel_hlcdc_plane *plane,
                                     struct atmel_hlcdc_plane_state *state)
  {
       const struct atmel_hlcdc_layer_desc *desc = plane->layer.desc;
+     struct atmel_hlcdc_dc *dc = plane->base.dev->dev_private;
 
       if (desc->layout.size)
               atmel_hlcdc_layer_write_cfg(&plane->layer, desc->layout.size,

drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c atmel_hlcdc_plane_update_pos_and_size(struct atmel_hlcdc_plane *plane, · line 406

Quoted 8 lines
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +4 -1
@@ -352,7 +400,10 @@ atmel_hlcdc_plane_update_pos_and_size(struct atmel_hlcdc_plane *plane,
                                       ATMEL_HLCDC_LAYER_POS(state->crtc_x,
                                                             state->crtc_y));
 
-     atmel_hlcdc_plane_setup_scaler(plane, state);
+     if (dc->desc->is_xlcdc)
+             atmel_xlcdc_plane_setup_scaler(plane, state);
+     else
+             atmel_hlcdc_plane_setup_scaler(plane, state);

What if you embedd the plane_setup_scaller function in struct atmel_hlcdc_dc_desc and define per lcdc variant the proper function you can have here something like:

Quoted 3 lines
         dc->desc->plane_setup_scaler();

This is valid for other places in this patch (see below).

Sure, I will try to incoperate this change.

Quoted 420 lines
Quoted 47 lines
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +34 -0
  }
 
  static void
@@ -393,6 +444,40 @@ atmel_hlcdc_plane_update_general_settings(struct atmel_hlcdc_plane *plane,
                                   cfg);
  }
 
+static void
+atmel_xlcdc_plane_update_general_settings(struct atmel_hlcdc_plane *plane,
+                                       struct atmel_hlcdc_plane_state *state)
+{
+     unsigned int cfg;
+     const struct atmel_hlcdc_layer_desc *desc = plane->layer.desc;
+     const struct drm_format_info *format = state->base.fb->format;
+
+     atmel_hlcdc_layer_write_cfg(&plane->layer, ATMEL_XLCDC_LAYER_DMA_CFG,
+                                 ATMEL_HLCDC_LAYER_DMA_BLEN_INCR16 | state->ahb_id);
+
+     cfg = ATMEL_XLCDC_LAYER_DMA | ATMEL_XLCDC_LAYER_REP;
+
+     if (plane->base.type != DRM_PLANE_TYPE_PRIMARY) {
+             /*
+              * Alpha Blending bits specific to SAM9X7 SoC
+              */
+             cfg |= ATMEL_XLCDC_LAYER_SFACTC_A0_MULT_AS |
+                    ATMEL_XLCDC_LAYER_SFACTA_ONE |
+                    ATMEL_XLCDC_LAYER_DFACTC_M_A0_MULT_AS |
+                    ATMEL_XLCDC_LAYER_DFACTA_ONE;
+             if (format->has_alpha)
+                     cfg |= ATMEL_XLCDC_LAYER_A0(0xff);
+             else
+                     cfg |= ATMEL_XLCDC_LAYER_A0(state->base.alpha);
+     }
+
+     if (state->disc_h && state->disc_w)
+             cfg |= ATMEL_XLCDC_LAYER_DISCEN;
+
+     atmel_hlcdc_layer_write_cfg(&plane->layer, desc->layout.general_config,
+                                 cfg);
+}
+
  static void atmel_hlcdc_plane_update_format(struct atmel_hlcdc_plane *plane,
                                       struct atmel_hlcdc_plane_state *state)
  {
@@ -437,36 +522,55 @@ static void atmel_hlcdc_plane_update_clut(struct atmel_hlcdc_plane *plane,
       }

drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c static void atmel_hlcdc_plane_update_clut(struct atmel_hlcdc_plane *plane, · line 532

Quoted 10 lines
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +8 -0
  }
 
+static void update_hlcdc_buffers(struct atmel_hlcdc_plane *plane,
+                              struct atmel_hlcdc_plane_state *state, u32 sr, int i)
+{
+     atmel_hlcdc_layer_write_reg(&plane->layer,
+                                 ATMEL_HLCDC_LAYER_PLANE_HEAD(i),
+                                 state->dscrs[i]->self);
+
+     if (!(sr & ATMEL_HLCDC_LAYER_EN)) {

To avoid extra indenting:
if (sr & ATMEL_HLCDC_LAYER_EN)
return;

Quoted 13 lines
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +13 -0
+             atmel_hlcdc_layer_write_reg(&plane->layer,
+                                         ATMEL_HLCDC_LAYER_PLANE_ADDR(i),
+                                         state->dscrs[i]->addr);
+             atmel_hlcdc_layer_write_reg(&plane->layer,
+                                         ATMEL_HLCDC_LAYER_PLANE_CTRL(i),
+                                         state->dscrs[i]->ctrl);
+             atmel_hlcdc_layer_write_reg(&plane->layer,
+                                         ATMEL_HLCDC_LAYER_PLANE_NEXT(i),
+                                         state->dscrs[i]->self);
+     }
+}
+
+static void update_xlcdc_buffers(struct atmel_hlcdc_plane *plane,

drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c static void atmel_hlcdc_plane_update_clut(struct atmel_hlcdc_plane *plane, · line 554

Quoted 10 lines
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +8 -1
+                              struct atmel_hlcdc_plane_state *state, int i)
+{
+     atmel_hlcdc_layer_write_reg(&plane->layer,
+                                 ATMEL_XLCDC_LAYER_PLANE_ADDR(i),
+                                 state->dscrs[i]->addr);
+}
+
  static void atmel_hlcdc_plane_update_buffers(struct atmel_hlcdc_plane *plane,
-                                     struct atmel_hlcdc_plane_state *state)
+                                          struct atmel_hlcdc_plane_state *state)

update_hlcdc_buffers() and update_xlcdc_buffers() could also be members in the struct atmel_hlcdc_dc_desc and called accordingly where needed w/o checking is_xlcdc.

Quoted 25 lines
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +3 -10
  {
       const struct atmel_hlcdc_layer_desc *desc = plane->layer.desc;
+     struct atmel_hlcdc_dc *dc = plane->base.dev->dev_private;
       struct drm_framebuffer *fb = state->base.fb;
       u32 sr;
       int i;
 
-     sr = atmel_hlcdc_layer_read_reg(&plane->layer, ATMEL_HLCDC_LAYER_CHSR);
+     if (!dc->desc->is_xlcdc)
+             sr = atmel_hlcdc_layer_read_reg(&plane->layer, ATMEL_HLCDC_LAYER_CHSR);
 
       for (i = 0; i < state->nplanes; i++) {
               struct drm_gem_dma_object *gem = drm_fb_dma_get_gem_obj(fb, i);
 
               state->dscrs[i]->addr = gem->dma_addr + state->offsets[i];
 
-             atmel_hlcdc_layer_write_reg(&plane->layer,
-                                         ATMEL_HLCDC_LAYER_PLANE_HEAD(i),
-                                         state->dscrs[i]->self);
-
-             if (!(sr & ATMEL_HLCDC_LAYER_EN)) {
-                     atmel_hlcdc_layer_write_reg(&plane->layer,
-                                     ATMEL_HLCDC_LAYER_PLANE_ADDR(i),
-                                     state->dscrs[i]->addr);
-                     atmel_hlcdc_layer_write_reg(&plane->layer,

drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c static void atmel_hlcdc_plane_update_clut(struct atmel_hlcdc_plane *plane, · line 573

Quoted 10 lines
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +4 -6
-                                     ATMEL_HLCDC_LAYER_PLANE_CTRL(i),
-                                     state->dscrs[i]->ctrl);
-                     atmel_hlcdc_layer_write_reg(&plane->layer,
-                                     ATMEL_HLCDC_LAYER_PLANE_NEXT(i),
-                                     state->dscrs[i]->self);
-             }
+             if (dc->desc->is_xlcdc)
+                     update_xlcdc_buffers(plane, state, i);
+             else
+                     update_hlcdc_buffers(plane, state, sr, i);

And here you can have something like:

                 dc->desc->update_lcdc_buffers();
Quoted 34 lines
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +15 -4
               if (desc->layout.xstride[i])
                       atmel_hlcdc_layer_write_cfg(&plane->layer,
@@ -712,11 +816,8 @@ static int atmel_hlcdc_plane_atomic_check(struct drm_plane *p,
       return 0;
  }
 
-static void atmel_hlcdc_plane_atomic_disable(struct drm_plane *p,
-                                          struct drm_atomic_state *state)
+static void hlcdc_atomic_disable(struct atmel_hlcdc_plane *plane)
  {
-     struct atmel_hlcdc_plane *plane = drm_plane_to_atmel_hlcdc_plane(p);
-
       /* Disable interrupts */
       atmel_hlcdc_layer_write_reg(&plane->layer, ATMEL_HLCDC_LAYER_IDR,
                                   0xffffffff);
@@ -731,6 +832,72 @@ static void atmel_hlcdc_plane_atomic_disable(struct drm_plane *p,
       atmel_hlcdc_layer_read_reg(&plane->layer, ATMEL_HLCDC_LAYER_ISR);
  }
 
+static void xlcdc_atomic_disable(struct atmel_hlcdc_plane *plane)
+{
+     /* Disable interrupts */
+     atmel_hlcdc_layer_write_reg(&plane->layer, ATMEL_XLCDC_LAYER_IDR,
+                                 0xffffffff);
+
+     /* Disable the layer */
+     atmel_hlcdc_layer_write_reg(&plane->layer,
+                                 ATMEL_XLCDC_LAYER_ENR, 0);
+
+     /* Clear all pending interrupts */
+     atmel_hlcdc_layer_read_reg(&plane->layer, ATMEL_XLCDC_LAYER_ISR);
+}
+

drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c static void atmel_hlcdc_plane_atomic_disable(struct drm_plane *p, · line 858

Quoted 10 lines
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +10 -0
+static void atmel_hlcdc_plane_atomic_disable(struct drm_plane *p,
+                                          struct drm_atomic_state *state)
+{
+     struct atmel_hlcdc_plane *plane = drm_plane_to_atmel_hlcdc_plane(p);
+     struct atmel_hlcdc_dc *dc = plane->base.dev->dev_private;
+
+     if (dc->desc->is_xlcdc)
+             xlcdc_atomic_disable(plane);
+     else
+             hlcdc_atomic_disable(plane);
         dc->desc->lcdc_atomic_disable();
Quoted 55 lines
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +43 -1
+}
+
+static void hlcdc_atomic_update(struct atmel_hlcdc_plane *plane)
+{
+     u32 sr;
+
+     /* Enable the overrun interrupts. */
+     atmel_hlcdc_layer_write_reg(&plane->layer, ATMEL_HLCDC_LAYER_IER,
+                                 ATMEL_HLCDC_LAYER_OVR_IRQ(0) |
+                                 ATMEL_HLCDC_LAYER_OVR_IRQ(1) |
+                                 ATMEL_HLCDC_LAYER_OVR_IRQ(2));
+
+     /* Apply the new config at the next SOF event. */
+     sr = atmel_hlcdc_layer_read_reg(&plane->layer, ATMEL_HLCDC_LAYER_CHSR);
+     atmel_hlcdc_layer_write_reg(&plane->layer, ATMEL_HLCDC_LAYER_CHER,
+                                 ATMEL_HLCDC_LAYER_UPDATE |
+                                 (sr & ATMEL_HLCDC_LAYER_EN ?
+                                 ATMEL_HLCDC_LAYER_A2Q : ATMEL_HLCDC_LAYER_EN));
+}
+
+static void xlcdc_atomic_update(struct atmel_hlcdc_plane *plane,
+                             struct atmel_hlcdc_dc *dc)
+{
+     /* Enable the overrun interrupts. */
+     atmel_hlcdc_layer_write_reg(&plane->layer, ATMEL_XLCDC_LAYER_IER,
+                                 ATMEL_XLCDC_LAYER_OVR_IRQ(0) |
+                                 ATMEL_XLCDC_LAYER_OVR_IRQ(1) |
+                                 ATMEL_XLCDC_LAYER_OVR_IRQ(2));
+
+     atmel_hlcdc_layer_write_reg(&plane->layer, ATMEL_XLCDC_LAYER_ENR,
+                                 ATMEL_XLCDC_LAYER_EN);
+
+     /*
+      * Updating XLCDC_xxxCFGx, XLCDC_xxxFBA and XLCDC_xxxEN,
+      * (where xxx indicates each layer) requires writing one to the
+      * Update Attribute field for each layer in LCDC_ATTRE register for SAM9X7.
+      */
+     regmap_write(dc->hlcdc->regmap, ATMEL_XLCDC_ATTRE, ATMEL_XLCDC_BASE_UPDATE |
+                  ATMEL_XLCDC_OVR1_UPDATE | ATMEL_XLCDC_OVR3_UPDATE |
+                  ATMEL_XLCDC_HEO_UPDATE);
+}
+
  static void atmel_hlcdc_plane_atomic_update(struct drm_plane *p,
                                           struct drm_atomic_state *state)
  {
@@ -739,7 +906,7 @@ static void atmel_hlcdc_plane_atomic_update(struct drm_plane *p,
       struct atmel_hlcdc_plane *plane = drm_plane_to_atmel_hlcdc_plane(p);
       struct atmel_hlcdc_plane_state *hstate =
                       drm_plane_state_to_atmel_hlcdc_plane_state(new_s);
-     u32 sr;
+     struct atmel_hlcdc_dc *dc = p->dev->dev_private;
 
       if (!new_s->crtc || !new_s->fb)
               return;

drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c static void atmel_hlcdc_plane_atomic_update(struct drm_plane *p, · line 923

Quoted 8 lines
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +4 -1
@@ -750,29 +917,67 @@ static void atmel_hlcdc_plane_atomic_update(struct drm_plane *p,
       }
 
       atmel_hlcdc_plane_update_pos_and_size(plane, hstate);
-     atmel_hlcdc_plane_update_general_settings(plane, hstate);
+     if (dc->desc->is_xlcdc)
+             atmel_xlcdc_plane_update_general_settings(plane, hstate);
+     else
+             atmel_hlcdc_plane_update_general_settings(plane, hstate);
         dc->desc->lcdc_plane_update_general_settigns();
Quoted 4 lines
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +0 -0
       atmel_hlcdc_plane_update_format(plane, hstate);
       atmel_hlcdc_plane_update_clut(plane, hstate);
       atmel_hlcdc_plane_update_buffers(plane, hstate);
       atmel_hlcdc_plane_update_disc_area(plane, hstate);

drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c static void atmel_hlcdc_plane_atomic_update(struct drm_plane *p, · line 932

Quoted 10 lines
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +4 -5
 
-     /* Enable the overrun interrupts. */
-     atmel_hlcdc_layer_write_reg(&plane->layer, ATMEL_HLCDC_LAYER_IER,
-                                 ATMEL_HLCDC_LAYER_OVR_IRQ(0) |
-                                 ATMEL_HLCDC_LAYER_OVR_IRQ(1) |
-                                 ATMEL_HLCDC_LAYER_OVR_IRQ(2));
+     if (dc->desc->is_xlcdc)
+             xlcdc_atomic_update(plane, dc);
+     else
+             hlcdc_atomic_update(plane);
         dc->desc->lcdc_atomic_update();

drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c static void atmel_hlcdc_plane_atomic_update(struct drm_plane *p, · line 939

Quoted 13 lines
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +6 -6
+}
 
-     /* Apply the new config at the next SOF event. */
-     sr = atmel_hlcdc_layer_read_reg(&plane->layer, ATMEL_HLCDC_LAYER_CHSR);
-     atmel_hlcdc_layer_write_reg(&plane->layer, ATMEL_HLCDC_LAYER_CHER,
-                     ATMEL_HLCDC_LAYER_UPDATE |
-                     (sr & ATMEL_HLCDC_LAYER_EN ?
-                      ATMEL_HLCDC_LAYER_A2Q : ATMEL_HLCDC_LAYER_EN));
+u32 hlcdc_csc_coeffs[] = {
+     0x4c900091,
+     0x7a5f5090,
+     0x40040890
+};

You can move this in function where it is used and declare it static.

drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c static void atmel_hlcdc_plane_atomic_update(struct drm_plane *p, · line 949

Quoted 10 lines
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +10 -0
+
+u32 xlcdc_csc_coeffs[] = {
+     0x00000488,
+     0x00000648,
+     0x1EA00480,
+     0x00001D28,
+     0x08100480,
+     0x00000000,
+     0x00000007
+};

Same here.

drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c static void atmel_hlcdc_plane_atomic_update(struct drm_plane *p, · line 958

Quoted 9 lines
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +9 -0
+
+static void hlcdc_csc_init(struct atmel_hlcdc_plane *plane,
+                        const struct atmel_hlcdc_layer_desc *desc)
+{
+     /*
+      * TODO: declare a "yuv-to-rgb-conv-factors" property to let
+      * userspace modify these factors (using a BLOB property ?).
+      */
+     for (int i = 0; i < ARRAY_SIZE(hlcdc_csc_coeffs); i++)

{ at the end of for statement.

drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c static void atmel_hlcdc_plane_atomic_update(struct drm_plane *p, · line 961

Quoted 3 lines
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +3 -0
+             atmel_hlcdc_layer_write_cfg(&plane->layer,
+                                         desc->layout.csc + i,
+                                         hlcdc_csc_coeffs[i]);

} here

drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c static void atmel_hlcdc_plane_atomic_update(struct drm_plane *p, · line 974

Quoted 13 lines
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +13 -0
+}
+
+static void xlcdc_csc_init(struct atmel_hlcdc_plane *plane,
+                        const struct atmel_hlcdc_layer_desc *desc)
+{
+     /*
+      * yuv-to-rgb-conv-factors are now defined from LCDC_HEOCFG16 to
+      * LCDC_HEOCFG21 registers in SAM9X7.
+      */
+     for (int i = 0; i < ARRAY_SIZE(xlcdc_csc_coeffs); i++)
+             atmel_hlcdc_layer_write_cfg(&plane->layer,
+                                         desc->layout.csc + i,
+                                         xlcdc_csc_coeffs[i]);

Ditto

Quoted 23 lines
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +1 -10
  }
 
  static int atmel_hlcdc_plane_init_properties(struct atmel_hlcdc_plane *plane)
  {
       const struct atmel_hlcdc_layer_desc *desc = plane->layer.desc;
+     struct atmel_hlcdc_dc *dc = plane->base.dev->dev_private;
 
       if (desc->type == ATMEL_HLCDC_OVERLAY_LAYER ||
           desc->type == ATMEL_HLCDC_CURSOR_LAYER) {
@@ -796,31 +1001,19 @@ static int atmel_hlcdc_plane_init_properties(struct atmel_hlcdc_plane *plane)
                       return ret;
       }
 
-     if (desc->layout.csc) {
-             /*
-              * TODO: decare a "yuv-to-rgb-conv-factors" property to let
-              * userspace modify these factors (using a BLOB property ?).
-              */
-             atmel_hlcdc_layer_write_cfg(&plane->layer,
-                                         desc->layout.csc,
-                                         0x4c900091);
-             atmel_hlcdc_layer_write_cfg(&plane->layer,
-                                         desc->layout.csc + 1,

drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c static int atmel_hlcdc_plane_init_properties(struct atmel_hlcdc_plane *plane) · line 1008

Quoted 10 lines
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +5 -5
-                                         0x7a5f5090);
-             atmel_hlcdc_layer_write_cfg(&plane->layer,
-                                         desc->layout.csc + 2,
-                                         0x40040890);
-     }
+     if (dc->desc->is_xlcdc && desc->layout.csc)
+             xlcdc_csc_init(plane, desc);
+     else
+             if (desc->layout.csc)
+                     hlcdc_csc_init(plane, desc);
         if (desc->layout.csc)
                 dc->desc->lcdc_csc_init();
Quoted 17 lines
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +3 -5
       return 0;
  }
 
-void atmel_hlcdc_plane_irq(struct atmel_hlcdc_plane *plane)
+static void hlcdc_irq_dbg(struct atmel_hlcdc_plane *plane,
+                       const struct atmel_hlcdc_layer_desc *desc)
  {
-     const struct atmel_hlcdc_layer_desc *desc = plane->layer.desc;
-     u32 isr;
-
-     isr = atmel_hlcdc_layer_read_reg(&plane->layer, ATMEL_HLCDC_LAYER_ISR);
+     u32 isr = atmel_hlcdc_layer_read_reg(&plane->layer, ATMEL_HLCDC_LAYER_ISR);
 
       /*
        * There's not much we can do in case of overrun except informing

drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c void atmel_hlcdc_plane_irq(struct atmel_hlcdc_plane *plane) · line 1026

Quoted 6 lines
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +1 -2
@@ -830,8 +1023,34 @@ void atmel_hlcdc_plane_irq(struct atmel_hlcdc_plane *plane)
       if (isr &
           (ATMEL_HLCDC_LAYER_OVR_IRQ(0) | ATMEL_HLCDC_LAYER_OVR_IRQ(1) |
            ATMEL_HLCDC_LAYER_OVR_IRQ(2)))
-             dev_dbg(plane->base.dev->dev, "overrun on plane %s\n",
-                     desc->name);
+             pr_warn("%s: overrun on plane %s\n", __func__, desc->name);

Why changing to pr_warn? why not dev_warn, if any?

Quoted 6 lines
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +6 -0
+}
+
+static void xlcdc_irq_dbg(struct atmel_hlcdc_plane *plane,
+                       const struct atmel_hlcdc_layer_desc *desc)
+{
+     u32 isr = atmel_hlcdc_layer_read_reg(&plane->layer, ATMEL_XLCDC_LAYER_ISR);

drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c void atmel_hlcdc_plane_irq(struct atmel_hlcdc_plane *plane) · line 1042

Quoted 10 lines
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +10 -0
+
+     /*
+      * There's not much we can do in case of overrun except informing
+      * the user. However, we are in interrupt context here, hence the
+      * use of dev_dbg().
+      */
+     if (isr &
+         (ATMEL_XLCDC_LAYER_OVR_IRQ(0) | ATMEL_XLCDC_LAYER_OVR_IRQ(1) |
+          ATMEL_XLCDC_LAYER_OVR_IRQ(2)))
+             pr_warn("%s: overrun on plane %s\n", __func__, desc->name);

dev_warn() ?

drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c void atmel_hlcdc_plane_irq(struct atmel_hlcdc_plane *plane) · line 1053

Quoted 11 lines
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +11 -0
+}
+
+void atmel_hlcdc_plane_irq(struct atmel_hlcdc_plane *plane)
+{
+     const struct atmel_hlcdc_layer_desc *desc = plane->layer.desc;
+     struct atmel_hlcdc_dc *dc = plane->base.dev->dev_private;
+
+     if (dc->desc->is_xlcdc)
+             xlcdc_irq_dbg(plane, desc);
+     else
+             hlcdc_irq_dbg(plane, desc);
         dc->desc->lcdc_irq_dbg() ?
Quoted 3 lines
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +0 -0
  }
 
  static const struct drm_plane_helper_funcs atmel_hlcdc_layer_plane_helper_funcs = {
Signature · 2 lines
Thanks and Regards,
Manikandan M.
maintainer
#9 lore raw

Re: [PATCH v4 5/8] drm: atmel_hlcdc: Add support for XLCDC in atmel LCD driver

Quoted 66 lines · On 12.09.2023 13:44, [email protected] wrote:
Quoted 65 lines · claudiu beznea

[You don't often get email from [email protected]. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]

EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe

Hi, Manikandan,

Quoted 47 lines · Manikandan Muralidharan

- XLCDC in SAM9X7 has different sets of registers and additional configuration bits when compared to previous HLCDC IP. Read/write operation on the controller registers is now separated using the XLCDC status flag.
- HEO scaling, window resampling, Alpha blending, YUV-to-RGB
conversion in XLCDC is derived and handled using additional configuration bits and registers.
- Writing one to the Enable fields of each layer in LCD_ATTRE
is required to reflect the values set in Configuration, FBA, Enable registers of each layer

---
  .../gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c    |  25 +-
  .../gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c   | 333 +++++++++++++++---
  2 files changed, 299 insertions(+), 59 deletions(-)
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c +3 -2
index cc5cf4c2faf7..4b11a1de8af4 100644
@@ -79,6 +79,7 @@ static void atmel_hlcdc_crtc_mode_set_nofb(struct drm_crtc *c)
       unsigned int mask = ATMEL_HLCDC_CLKDIV_MASK | ATMEL_HLCDC_CLKPOL;
       unsigned int cfg = 0;
       int div, ret;
+     bool is_xlcdc = crtc->dc->desc->is_xlcdc;
 
       /* get encoder from crtc */
       drm_for_each_encoder(en_iter, ddev) {
@@ -164,10 +165,10 @@ static void atmel_hlcdc_crtc_mode_set_nofb(struct drm_crtc *c)
       state = drm_crtc_state_to_atmel_hlcdc_crtc_state(c->state);
       cfg = state->output_mode << 8;
 
-     if (adj->flags & DRM_MODE_FLAG_NVSYNC)
+     if (!is_xlcdc && (adj->flags & DRM_MODE_FLAG_NVSYNC))
               cfg |= ATMEL_HLCDC_VSPOL;
 
-     if (adj->flags & DRM_MODE_FLAG_NHSYNC)
+     if (!is_xlcdc && (adj->flags & DRM_MODE_FLAG_NHSYNC))
               cfg |= ATMEL_HLCDC_HSPOL;
 
       regmap_update_bits(regmap, ATMEL_HLCDC_CFG(5),

drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c static void atmel_hlcdc_crtc_atomic_disable(struct drm_crtc *c, · line 209

Quoted 7 lines
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c +4 -0
@@ -202,6 +203,16 @@ static void atmel_hlcdc_crtc_atomic_disable(struct drm_crtc *c,
 
       pm_runtime_get_sync(dev->dev);
 
+     if (crtc->dc->desc->is_xlcdc) {
+             regmap_write(regmap, ATMEL_HLCDC_DIS, ATMEL_XLCDC_CM);
+             regmap_read_poll_timeout(regmap, ATMEL_HLCDC_SR, status,
+                                      !(status & ATMEL_XLCDC_CM), 10, 0);

You may want to check the return value of regmap_read_poll_timeout(). Otherwise your setup may fail.

Quoted 8 lines
Quoted 3 lines

Also, regmap_read_poll_timeout() may sleep, the other settings in this functions are done with bussy looping, is there a reason for that? Hi Claudiu

Not sure if a non-zero timeout_us coud be sufficient for this operation, considering the next power-up and power-down sequence following the current step.
Any suggestion on the value of timeout_us is appreciable.

Ok, haven't noticed that the timeout is zero.

Quoted 551 lines
Quoted 48 lines

drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c static void atmel_hlcdc_crtc_atomic_disable(struct drm_crtc *c, · line 213

Quoted 4 lines
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c +4 -0
+
+             regmap_write(regmap, ATMEL_HLCDC_DIS, ATMEL_XLCDC_SD);
+             regmap_read_poll_timeout(regmap, ATMEL_HLCDC_SR, status,
+                                      status & ATMEL_XLCDC_SD, 10, 0);

Same here.

Quoted 41 lines
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c +12 -0
+     }
+
       regmap_write(regmap, ATMEL_HLCDC_DIS, ATMEL_HLCDC_DISP);
       while (!regmap_read(regmap, ATMEL_HLCDC_SR, &status) &&
              (status & ATMEL_HLCDC_DISP))
@@ -256,6 +267,16 @@ static void atmel_hlcdc_crtc_atomic_enable(struct drm_crtc *c,
              !(status & ATMEL_HLCDC_DISP))
               cpu_relax();
 
+     if (crtc->dc->desc->is_xlcdc) {
+             regmap_write(regmap, ATMEL_HLCDC_EN, ATMEL_XLCDC_CM);
+             regmap_read_poll_timeout(regmap, ATMEL_HLCDC_SR, status,
+                                      status & ATMEL_XLCDC_CM, 10, 0);
+
+             regmap_write(regmap, ATMEL_HLCDC_EN, ATMEL_XLCDC_SD);
+             regmap_read_poll_timeout(regmap, ATMEL_HLCDC_SR, status,
+                                      !(status & ATMEL_XLCDC_SD), 10, 0);
+     }
+
       pm_runtime_put_sync(dev->dev);
 
  }
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +11 -0
index daa508504f47..26caf4cddfa4 100644
@@ -330,11 +330,59 @@ static void atmel_hlcdc_plane_setup_scaler(struct atmel_hlcdc_plane *plane,
                                                                    yfactor));
  }
 
+static void atmel_xlcdc_plane_setup_scaler(struct atmel_hlcdc_plane *plane,
+                                        struct atmel_hlcdc_plane_state *state)
+{
+     const struct atmel_hlcdc_layer_desc *desc = plane->layer.desc;
+     u32 xfactor, yfactor;
+
+     if (!desc->layout.scaler_config)
+             return;
+
+     if (state->crtc_w == state->src_w && state->crtc_h == state->src_h) {
+             atmel_hlcdc_layer_write_cfg(&plane->layer,
Quoted 8 lines

drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c static void atmel_hlcdc_plane_setup_scaler(struct atmel_hlcdc_plane *plane, · line 349

Quoted 6 lines
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +6 -0
+                                         desc->layout.scaler_config, 0);
+             return;
+     }
+
+     /* xfactor = round[(2^20 * XMEMSIZE)/XSIZE)] */
+     xfactor = (u32)(((1 << 20) * state->src_w) / state->crtc_w);

Could ((1 << 20) * state->src_w) overflow?

It is within the limits, state->src_w will contain a 11bit reg value at max.

Quoted 69 lines

drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c static void atmel_hlcdc_plane_setup_scaler(struct atmel_hlcdc_plane *plane, · line 352

Quoted 4 lines
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +3 -0
+
+     /* yfactor = round[(2^20 * YMEMSIZE)/YSIZE)] */
+     yfactor = (u32)(((1 << 20) * state->src_h) / state->crtc_h);

Same here.

Quoted 15 lines
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +15 -0
+
+     atmel_hlcdc_layer_write_cfg(&plane->layer, desc->layout.scaler_config,
+                                 ATMEL_XLCDC_LAYER_VSCALER_LUMA_ENABLE |
+                                 ATMEL_XLCDC_LAYER_VSCALER_CHROMA_ENABLE |
+                                 ATMEL_XLCDC_LAYER_HSCALER_LUMA_ENABLE |
+                                 ATMEL_XLCDC_LAYER_HSCALER_CHROMA_ENABLE);
+
+     atmel_hlcdc_layer_write_cfg(&plane->layer, desc->layout.scaler_config + 1,
+                                 yfactor);
+     atmel_hlcdc_layer_write_cfg(&plane->layer, desc->layout.scaler_config + 3,
+                                 xfactor);
+
+     /* As per YCbCr window resampling configuration */
+     if (state->base.fb->format->format == DRM_FORMAT_YUV420) {
+             atmel_hlcdc_layer_write_cfg(&plane->layer, desc->layout.scaler_config + 2,

drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c static void atmel_hlcdc_plane_setup_scaler(struct atmel_hlcdc_plane *plane, · line 377

Quoted 10 lines
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +10 -0
+                                         yfactor / 2);
+             atmel_hlcdc_layer_write_cfg(&plane->layer, desc->layout.scaler_config + 4,
+                                         xfactor / 2);
+     } else {
+             /* As per ARGB window resampling configuration */
+             atmel_hlcdc_layer_write_cfg(&plane->layer, desc->layout.scaler_config + 2,
+                                         yfactor);
+             atmel_hlcdc_layer_write_cfg(&plane->layer, desc->layout.scaler_config + 4,
+                                         xfactor);
+     }

This can be written as follows:

if (state->base.fb->format->format == DRM_FORMAT_YUV420) {
         yfactor /= 2);
         xfactor /= 2);
}
atmel_hlcdc_layer_write_cfg(&plane->layer, desc->layout.scaler_config + 2,
                             yfactor);
atmel_hlcdc_layer_write_cfg(&plane->layer, desc->layout.scaler_config + 4,
                             xfactor);
Quoted 12 lines
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +3 -0
+}
+
  static void
  atmel_hlcdc_plane_update_pos_and_size(struct atmel_hlcdc_plane *plane,
                                     struct atmel_hlcdc_plane_state *state)
  {
       const struct atmel_hlcdc_layer_desc *desc = plane->layer.desc;
+     struct atmel_hlcdc_dc *dc = plane->base.dev->dev_private;
 
       if (desc->layout.size)
               atmel_hlcdc_layer_write_cfg(&plane->layer, desc->layout.size,

drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c atmel_hlcdc_plane_update_pos_and_size(struct atmel_hlcdc_plane *plane, · line 406

Quoted 8 lines
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +4 -1
@@ -352,7 +400,10 @@ atmel_hlcdc_plane_update_pos_and_size(struct atmel_hlcdc_plane *plane,
                                       ATMEL_HLCDC_LAYER_POS(state->crtc_x,
                                                             state->crtc_y));
 
-     atmel_hlcdc_plane_setup_scaler(plane, state);
+     if (dc->desc->is_xlcdc)
+             atmel_xlcdc_plane_setup_scaler(plane, state);
+     else
+             atmel_hlcdc_plane_setup_scaler(plane, state);

What if you embedd the plane_setup_scaller function in struct atmel_hlcdc_dc_desc and define per lcdc variant the proper function you can have here something like:

Quoted 3 lines
         dc->desc->plane_setup_scaler();

This is valid for other places in this patch (see below).

Sure, I will try to incoperate this change.

Quoted 420 lines
Quoted 47 lines
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +34 -0
  }
 
  static void
@@ -393,6 +444,40 @@ atmel_hlcdc_plane_update_general_settings(struct atmel_hlcdc_plane *plane,
                                   cfg);
  }
 
+static void
+atmel_xlcdc_plane_update_general_settings(struct atmel_hlcdc_plane *plane,
+                                       struct atmel_hlcdc_plane_state *state)
+{
+     unsigned int cfg;
+     const struct atmel_hlcdc_layer_desc *desc = plane->layer.desc;
+     const struct drm_format_info *format = state->base.fb->format;
+
+     atmel_hlcdc_layer_write_cfg(&plane->layer, ATMEL_XLCDC_LAYER_DMA_CFG,
+                                 ATMEL_HLCDC_LAYER_DMA_BLEN_INCR16 | state->ahb_id);
+
+     cfg = ATMEL_XLCDC_LAYER_DMA | ATMEL_XLCDC_LAYER_REP;
+
+     if (plane->base.type != DRM_PLANE_TYPE_PRIMARY) {
+             /*
+              * Alpha Blending bits specific to SAM9X7 SoC
+              */
+             cfg |= ATMEL_XLCDC_LAYER_SFACTC_A0_MULT_AS |
+                    ATMEL_XLCDC_LAYER_SFACTA_ONE |
+                    ATMEL_XLCDC_LAYER_DFACTC_M_A0_MULT_AS |
+                    ATMEL_XLCDC_LAYER_DFACTA_ONE;
+             if (format->has_alpha)
+                     cfg |= ATMEL_XLCDC_LAYER_A0(0xff);
+             else
+                     cfg |= ATMEL_XLCDC_LAYER_A0(state->base.alpha);
+     }
+
+     if (state->disc_h && state->disc_w)
+             cfg |= ATMEL_XLCDC_LAYER_DISCEN;
+
+     atmel_hlcdc_layer_write_cfg(&plane->layer, desc->layout.general_config,
+                                 cfg);
+}
+
  static void atmel_hlcdc_plane_update_format(struct atmel_hlcdc_plane *plane,
                                       struct atmel_hlcdc_plane_state *state)
  {
@@ -437,36 +522,55 @@ static void atmel_hlcdc_plane_update_clut(struct atmel_hlcdc_plane *plane,
       }

drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c static void atmel_hlcdc_plane_update_clut(struct atmel_hlcdc_plane *plane, · line 532

Quoted 10 lines
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +8 -0
  }
 
+static void update_hlcdc_buffers(struct atmel_hlcdc_plane *plane,
+                              struct atmel_hlcdc_plane_state *state, u32 sr, int i)
+{
+     atmel_hlcdc_layer_write_reg(&plane->layer,
+                                 ATMEL_HLCDC_LAYER_PLANE_HEAD(i),
+                                 state->dscrs[i]->self);
+
+     if (!(sr & ATMEL_HLCDC_LAYER_EN)) {

To avoid extra indenting:
if (sr & ATMEL_HLCDC_LAYER_EN)
return;

Quoted 13 lines
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +13 -0
+             atmel_hlcdc_layer_write_reg(&plane->layer,
+                                         ATMEL_HLCDC_LAYER_PLANE_ADDR(i),
+                                         state->dscrs[i]->addr);
+             atmel_hlcdc_layer_write_reg(&plane->layer,
+                                         ATMEL_HLCDC_LAYER_PLANE_CTRL(i),
+                                         state->dscrs[i]->ctrl);
+             atmel_hlcdc_layer_write_reg(&plane->layer,
+                                         ATMEL_HLCDC_LAYER_PLANE_NEXT(i),
+                                         state->dscrs[i]->self);
+     }
+}
+
+static void update_xlcdc_buffers(struct atmel_hlcdc_plane *plane,

drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c static void atmel_hlcdc_plane_update_clut(struct atmel_hlcdc_plane *plane, · line 554

Quoted 10 lines
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +8 -1
+                              struct atmel_hlcdc_plane_state *state, int i)
+{
+     atmel_hlcdc_layer_write_reg(&plane->layer,
+                                 ATMEL_XLCDC_LAYER_PLANE_ADDR(i),
+                                 state->dscrs[i]->addr);
+}
+
  static void atmel_hlcdc_plane_update_buffers(struct atmel_hlcdc_plane *plane,
-                                     struct atmel_hlcdc_plane_state *state)
+                                          struct atmel_hlcdc_plane_state *state)

update_hlcdc_buffers() and update_xlcdc_buffers() could also be members in the struct atmel_hlcdc_dc_desc and called accordingly where needed w/o checking is_xlcdc.

Quoted 25 lines
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +3 -10
  {
       const struct atmel_hlcdc_layer_desc *desc = plane->layer.desc;
+     struct atmel_hlcdc_dc *dc = plane->base.dev->dev_private;
       struct drm_framebuffer *fb = state->base.fb;
       u32 sr;
       int i;
 
-     sr = atmel_hlcdc_layer_read_reg(&plane->layer, ATMEL_HLCDC_LAYER_CHSR);
+     if (!dc->desc->is_xlcdc)
+             sr = atmel_hlcdc_layer_read_reg(&plane->layer, ATMEL_HLCDC_LAYER_CHSR);
 
       for (i = 0; i < state->nplanes; i++) {
               struct drm_gem_dma_object *gem = drm_fb_dma_get_gem_obj(fb, i);
 
               state->dscrs[i]->addr = gem->dma_addr + state->offsets[i];
 
-             atmel_hlcdc_layer_write_reg(&plane->layer,
-                                         ATMEL_HLCDC_LAYER_PLANE_HEAD(i),
-                                         state->dscrs[i]->self);
-
-             if (!(sr & ATMEL_HLCDC_LAYER_EN)) {
-                     atmel_hlcdc_layer_write_reg(&plane->layer,
-                                     ATMEL_HLCDC_LAYER_PLANE_ADDR(i),
-                                     state->dscrs[i]->addr);
-                     atmel_hlcdc_layer_write_reg(&plane->layer,

drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c static void atmel_hlcdc_plane_update_clut(struct atmel_hlcdc_plane *plane, · line 573

Quoted 10 lines
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +4 -6
-                                     ATMEL_HLCDC_LAYER_PLANE_CTRL(i),
-                                     state->dscrs[i]->ctrl);
-                     atmel_hlcdc_layer_write_reg(&plane->layer,
-                                     ATMEL_HLCDC_LAYER_PLANE_NEXT(i),
-                                     state->dscrs[i]->self);
-             }
+             if (dc->desc->is_xlcdc)
+                     update_xlcdc_buffers(plane, state, i);
+             else
+                     update_hlcdc_buffers(plane, state, sr, i);

And here you can have something like:

                 dc->desc->update_lcdc_buffers();
Quoted 34 lines
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +15 -4
               if (desc->layout.xstride[i])
                       atmel_hlcdc_layer_write_cfg(&plane->layer,
@@ -712,11 +816,8 @@ static int atmel_hlcdc_plane_atomic_check(struct drm_plane *p,
       return 0;
  }
 
-static void atmel_hlcdc_plane_atomic_disable(struct drm_plane *p,
-                                          struct drm_atomic_state *state)
+static void hlcdc_atomic_disable(struct atmel_hlcdc_plane *plane)
  {
-     struct atmel_hlcdc_plane *plane = drm_plane_to_atmel_hlcdc_plane(p);
-
       /* Disable interrupts */
       atmel_hlcdc_layer_write_reg(&plane->layer, ATMEL_HLCDC_LAYER_IDR,
                                   0xffffffff);
@@ -731,6 +832,72 @@ static void atmel_hlcdc_plane_atomic_disable(struct drm_plane *p,
       atmel_hlcdc_layer_read_reg(&plane->layer, ATMEL_HLCDC_LAYER_ISR);
  }
 
+static void xlcdc_atomic_disable(struct atmel_hlcdc_plane *plane)
+{
+     /* Disable interrupts */
+     atmel_hlcdc_layer_write_reg(&plane->layer, ATMEL_XLCDC_LAYER_IDR,
+                                 0xffffffff);
+
+     /* Disable the layer */
+     atmel_hlcdc_layer_write_reg(&plane->layer,
+                                 ATMEL_XLCDC_LAYER_ENR, 0);
+
+     /* Clear all pending interrupts */
+     atmel_hlcdc_layer_read_reg(&plane->layer, ATMEL_XLCDC_LAYER_ISR);
+}
+

drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c static void atmel_hlcdc_plane_atomic_disable(struct drm_plane *p, · line 858

Quoted 10 lines
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +10 -0
+static void atmel_hlcdc_plane_atomic_disable(struct drm_plane *p,
+                                          struct drm_atomic_state *state)
+{
+     struct atmel_hlcdc_plane *plane = drm_plane_to_atmel_hlcdc_plane(p);
+     struct atmel_hlcdc_dc *dc = plane->base.dev->dev_private;
+
+     if (dc->desc->is_xlcdc)
+             xlcdc_atomic_disable(plane);
+     else
+             hlcdc_atomic_disable(plane);
         dc->desc->lcdc_atomic_disable();
Quoted 55 lines
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +43 -1
+}
+
+static void hlcdc_atomic_update(struct atmel_hlcdc_plane *plane)
+{
+     u32 sr;
+
+     /* Enable the overrun interrupts. */
+     atmel_hlcdc_layer_write_reg(&plane->layer, ATMEL_HLCDC_LAYER_IER,
+                                 ATMEL_HLCDC_LAYER_OVR_IRQ(0) |
+                                 ATMEL_HLCDC_LAYER_OVR_IRQ(1) |
+                                 ATMEL_HLCDC_LAYER_OVR_IRQ(2));
+
+     /* Apply the new config at the next SOF event. */
+     sr = atmel_hlcdc_layer_read_reg(&plane->layer, ATMEL_HLCDC_LAYER_CHSR);
+     atmel_hlcdc_layer_write_reg(&plane->layer, ATMEL_HLCDC_LAYER_CHER,
+                                 ATMEL_HLCDC_LAYER_UPDATE |
+                                 (sr & ATMEL_HLCDC_LAYER_EN ?
+                                 ATMEL_HLCDC_LAYER_A2Q : ATMEL_HLCDC_LAYER_EN));
+}
+
+static void xlcdc_atomic_update(struct atmel_hlcdc_plane *plane,
+                             struct atmel_hlcdc_dc *dc)
+{
+     /* Enable the overrun interrupts. */
+     atmel_hlcdc_layer_write_reg(&plane->layer, ATMEL_XLCDC_LAYER_IER,
+                                 ATMEL_XLCDC_LAYER_OVR_IRQ(0) |
+                                 ATMEL_XLCDC_LAYER_OVR_IRQ(1) |
+                                 ATMEL_XLCDC_LAYER_OVR_IRQ(2));
+
+     atmel_hlcdc_layer_write_reg(&plane->layer, ATMEL_XLCDC_LAYER_ENR,
+                                 ATMEL_XLCDC_LAYER_EN);
+
+     /*
+      * Updating XLCDC_xxxCFGx, XLCDC_xxxFBA and XLCDC_xxxEN,
+      * (where xxx indicates each layer) requires writing one to the
+      * Update Attribute field for each layer in LCDC_ATTRE register for SAM9X7.
+      */
+     regmap_write(dc->hlcdc->regmap, ATMEL_XLCDC_ATTRE, ATMEL_XLCDC_BASE_UPDATE |
+                  ATMEL_XLCDC_OVR1_UPDATE | ATMEL_XLCDC_OVR3_UPDATE |
+                  ATMEL_XLCDC_HEO_UPDATE);
+}
+
  static void atmel_hlcdc_plane_atomic_update(struct drm_plane *p,
                                           struct drm_atomic_state *state)
  {
@@ -739,7 +906,7 @@ static void atmel_hlcdc_plane_atomic_update(struct drm_plane *p,
       struct atmel_hlcdc_plane *plane = drm_plane_to_atmel_hlcdc_plane(p);
       struct atmel_hlcdc_plane_state *hstate =
                       drm_plane_state_to_atmel_hlcdc_plane_state(new_s);
-     u32 sr;
+     struct atmel_hlcdc_dc *dc = p->dev->dev_private;
 
       if (!new_s->crtc || !new_s->fb)
               return;

drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c static void atmel_hlcdc_plane_atomic_update(struct drm_plane *p, · line 923

Quoted 8 lines
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +4 -1
@@ -750,29 +917,67 @@ static void atmel_hlcdc_plane_atomic_update(struct drm_plane *p,
       }
 
       atmel_hlcdc_plane_update_pos_and_size(plane, hstate);
-     atmel_hlcdc_plane_update_general_settings(plane, hstate);
+     if (dc->desc->is_xlcdc)
+             atmel_xlcdc_plane_update_general_settings(plane, hstate);
+     else
+             atmel_hlcdc_plane_update_general_settings(plane, hstate);
         dc->desc->lcdc_plane_update_general_settigns();
Quoted 4 lines
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +0 -0
       atmel_hlcdc_plane_update_format(plane, hstate);
       atmel_hlcdc_plane_update_clut(plane, hstate);
       atmel_hlcdc_plane_update_buffers(plane, hstate);
       atmel_hlcdc_plane_update_disc_area(plane, hstate);

drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c static void atmel_hlcdc_plane_atomic_update(struct drm_plane *p, · line 932

Quoted 10 lines
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +4 -5
 
-     /* Enable the overrun interrupts. */
-     atmel_hlcdc_layer_write_reg(&plane->layer, ATMEL_HLCDC_LAYER_IER,
-                                 ATMEL_HLCDC_LAYER_OVR_IRQ(0) |
-                                 ATMEL_HLCDC_LAYER_OVR_IRQ(1) |
-                                 ATMEL_HLCDC_LAYER_OVR_IRQ(2));
+     if (dc->desc->is_xlcdc)
+             xlcdc_atomic_update(plane, dc);
+     else
+             hlcdc_atomic_update(plane);
         dc->desc->lcdc_atomic_update();

drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c static void atmel_hlcdc_plane_atomic_update(struct drm_plane *p, · line 939

Quoted 13 lines
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +6 -6
+}
 
-     /* Apply the new config at the next SOF event. */
-     sr = atmel_hlcdc_layer_read_reg(&plane->layer, ATMEL_HLCDC_LAYER_CHSR);
-     atmel_hlcdc_layer_write_reg(&plane->layer, ATMEL_HLCDC_LAYER_CHER,
-                     ATMEL_HLCDC_LAYER_UPDATE |
-                     (sr & ATMEL_HLCDC_LAYER_EN ?
-                      ATMEL_HLCDC_LAYER_A2Q : ATMEL_HLCDC_LAYER_EN));
+u32 hlcdc_csc_coeffs[] = {
+     0x4c900091,
+     0x7a5f5090,
+     0x40040890
+};

You can move this in function where it is used and declare it static.

drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c static void atmel_hlcdc_plane_atomic_update(struct drm_plane *p, · line 949

Quoted 10 lines
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +10 -0
+
+u32 xlcdc_csc_coeffs[] = {
+     0x00000488,
+     0x00000648,
+     0x1EA00480,
+     0x00001D28,
+     0x08100480,
+     0x00000000,
+     0x00000007
+};

Same here.

drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c static void atmel_hlcdc_plane_atomic_update(struct drm_plane *p, · line 958

Quoted 9 lines
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +9 -0
+
+static void hlcdc_csc_init(struct atmel_hlcdc_plane *plane,
+                        const struct atmel_hlcdc_layer_desc *desc)
+{
+     /*
+      * TODO: declare a "yuv-to-rgb-conv-factors" property to let
+      * userspace modify these factors (using a BLOB property ?).
+      */
+     for (int i = 0; i < ARRAY_SIZE(hlcdc_csc_coeffs); i++)

{ at the end of for statement.

drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c static void atmel_hlcdc_plane_atomic_update(struct drm_plane *p, · line 961

Quoted 3 lines
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +3 -0
+             atmel_hlcdc_layer_write_cfg(&plane->layer,
+                                         desc->layout.csc + i,
+                                         hlcdc_csc_coeffs[i]);

} here

drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c static void atmel_hlcdc_plane_atomic_update(struct drm_plane *p, · line 974

Quoted 13 lines
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +13 -0
+}
+
+static void xlcdc_csc_init(struct atmel_hlcdc_plane *plane,
+                        const struct atmel_hlcdc_layer_desc *desc)
+{
+     /*
+      * yuv-to-rgb-conv-factors are now defined from LCDC_HEOCFG16 to
+      * LCDC_HEOCFG21 registers in SAM9X7.
+      */
+     for (int i = 0; i < ARRAY_SIZE(xlcdc_csc_coeffs); i++)
+             atmel_hlcdc_layer_write_cfg(&plane->layer,
+                                         desc->layout.csc + i,
+                                         xlcdc_csc_coeffs[i]);

Ditto

Quoted 23 lines
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +1 -10
  }
 
  static int atmel_hlcdc_plane_init_properties(struct atmel_hlcdc_plane *plane)
  {
       const struct atmel_hlcdc_layer_desc *desc = plane->layer.desc;
+     struct atmel_hlcdc_dc *dc = plane->base.dev->dev_private;
 
       if (desc->type == ATMEL_HLCDC_OVERLAY_LAYER ||
           desc->type == ATMEL_HLCDC_CURSOR_LAYER) {
@@ -796,31 +1001,19 @@ static int atmel_hlcdc_plane_init_properties(struct atmel_hlcdc_plane *plane)
                       return ret;
       }
 
-     if (desc->layout.csc) {
-             /*
-              * TODO: decare a "yuv-to-rgb-conv-factors" property to let
-              * userspace modify these factors (using a BLOB property ?).
-              */
-             atmel_hlcdc_layer_write_cfg(&plane->layer,
-                                         desc->layout.csc,
-                                         0x4c900091);
-             atmel_hlcdc_layer_write_cfg(&plane->layer,
-                                         desc->layout.csc + 1,

drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c static int atmel_hlcdc_plane_init_properties(struct atmel_hlcdc_plane *plane) · line 1008

Quoted 10 lines
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +5 -5
-                                         0x7a5f5090);
-             atmel_hlcdc_layer_write_cfg(&plane->layer,
-                                         desc->layout.csc + 2,
-                                         0x40040890);
-     }
+     if (dc->desc->is_xlcdc && desc->layout.csc)
+             xlcdc_csc_init(plane, desc);
+     else
+             if (desc->layout.csc)
+                     hlcdc_csc_init(plane, desc);
         if (desc->layout.csc)
                 dc->desc->lcdc_csc_init();
Quoted 17 lines
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +3 -5
       return 0;
  }
 
-void atmel_hlcdc_plane_irq(struct atmel_hlcdc_plane *plane)
+static void hlcdc_irq_dbg(struct atmel_hlcdc_plane *plane,
+                       const struct atmel_hlcdc_layer_desc *desc)
  {
-     const struct atmel_hlcdc_layer_desc *desc = plane->layer.desc;
-     u32 isr;
-
-     isr = atmel_hlcdc_layer_read_reg(&plane->layer, ATMEL_HLCDC_LAYER_ISR);
+     u32 isr = atmel_hlcdc_layer_read_reg(&plane->layer, ATMEL_HLCDC_LAYER_ISR);
 
       /*
        * There's not much we can do in case of overrun except informing

drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c void atmel_hlcdc_plane_irq(struct atmel_hlcdc_plane *plane) · line 1026

Quoted 6 lines
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +1 -2
@@ -830,8 +1023,34 @@ void atmel_hlcdc_plane_irq(struct atmel_hlcdc_plane *plane)
       if (isr &
           (ATMEL_HLCDC_LAYER_OVR_IRQ(0) | ATMEL_HLCDC_LAYER_OVR_IRQ(1) |
            ATMEL_HLCDC_LAYER_OVR_IRQ(2)))
-             dev_dbg(plane->base.dev->dev, "overrun on plane %s\n",
-                     desc->name);
+             pr_warn("%s: overrun on plane %s\n", __func__, desc->name);

Why changing to pr_warn? why not dev_warn, if any?

Quoted 6 lines
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +6 -0
+}
+
+static void xlcdc_irq_dbg(struct atmel_hlcdc_plane *plane,
+                       const struct atmel_hlcdc_layer_desc *desc)
+{
+     u32 isr = atmel_hlcdc_layer_read_reg(&plane->layer, ATMEL_XLCDC_LAYER_ISR);

drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c void atmel_hlcdc_plane_irq(struct atmel_hlcdc_plane *plane) · line 1042

Quoted 10 lines
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +10 -0
+
+     /*
+      * There's not much we can do in case of overrun except informing
+      * the user. However, we are in interrupt context here, hence the
+      * use of dev_dbg().
+      */
+     if (isr &
+         (ATMEL_XLCDC_LAYER_OVR_IRQ(0) | ATMEL_XLCDC_LAYER_OVR_IRQ(1) |
+          ATMEL_XLCDC_LAYER_OVR_IRQ(2)))
+             pr_warn("%s: overrun on plane %s\n", __func__, desc->name);

dev_warn() ?

drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c void atmel_hlcdc_plane_irq(struct atmel_hlcdc_plane *plane) · line 1053

Quoted 11 lines
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +11 -0
+}
+
+void atmel_hlcdc_plane_irq(struct atmel_hlcdc_plane *plane)
+{
+     const struct atmel_hlcdc_layer_desc *desc = plane->layer.desc;
+     struct atmel_hlcdc_dc *dc = plane->base.dev->dev_private;
+
+     if (dc->desc->is_xlcdc)
+             xlcdc_irq_dbg(plane, desc);
+     else
+             hlcdc_irq_dbg(plane, desc);
         dc->desc->lcdc_irq_dbg() ?
Quoted 3 lines
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +0 -0
  }
 
  static const struct drm_plane_helper_funcs atmel_hlcdc_layer_plane_helper_funcs = {
author maintainer
#10 lore raw

PATCH v4 6/8 drm: atmel-hlcdc: add DPI mode support for XLCDC

In reply to Manikandan Muralidharan

Add support for Display Pixel Interface (DPI) Compatible Mode support in atmel-hlcdc driver for XLCDC IP along with legacy pixel mapping.DPI mode BIT is configured in LCDC_CFG5 register.

[[email protected]: update DPI mode bit using is_xlcdc flag]
---
 .../gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c    | 22 ++++++++++++++++---
 1 file changed, 19 insertions(+), 3 deletions(-)
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c +19 -3
index 4b11a1de8af4..c3d0c60ba419 100644
@@ -30,10 +30,12 @@
  *
  * @base: base CRTC state
  * @output_mode: RGBXXX output mode
+ * @dpi: output DPI mode
  */
 struct atmel_hlcdc_crtc_state {
 	struct drm_crtc_state base;
 	unsigned int output_mode;
+	bool dpi;
 };
 
 static inline struct atmel_hlcdc_crtc_state *
@@ -164,6 +166,8 @@ static void atmel_hlcdc_crtc_mode_set_nofb(struct drm_crtc *c)
 
 	state = drm_crtc_state_to_atmel_hlcdc_crtc_state(c->state);
 	cfg = state->output_mode << 8;
+	if (is_xlcdc)
+		cfg |= state->dpi << 11;
 
 	if (!is_xlcdc && (adj->flags & DRM_MODE_FLAG_NVSYNC))
 		cfg |= ATMEL_HLCDC_VSPOL;
@@ -176,7 +180,9 @@ static void atmel_hlcdc_crtc_mode_set_nofb(struct drm_crtc *c)
 			   ATMEL_HLCDC_VSPDLYS | ATMEL_HLCDC_VSPDLYE |
 			   ATMEL_HLCDC_DISPPOL | ATMEL_HLCDC_DISPDLY |
 			   ATMEL_HLCDC_VSPSU | ATMEL_HLCDC_VSPHO |
-			   ATMEL_HLCDC_GUARDTIME_MASK | ATMEL_HLCDC_MODE_MASK,
+			   ATMEL_HLCDC_GUARDTIME_MASK |
+			   (is_xlcdc ? ATMEL_XLCDC_MODE_MASK |
+			   ATMEL_XLCDC_DPI : ATMEL_HLCDC_MODE_MASK),
 			   cfg);
 
 	clk_disable_unprepare(crtc->dc->hlcdc->sys_clk);
@@ -366,7 +372,15 @@ static int atmel_hlcdc_crtc_select_output_mode(struct drm_crtc_state *state)
 
 	hstate = drm_crtc_state_to_atmel_hlcdc_crtc_state(state);
 	hstate->output_mode = fls(output_fmts) - 1;
-
+	if (crtc->dc->desc->is_xlcdc) {
+		/* check if MIPI DPI bit needs to be set */
+		if (fls(output_fmts) > 3) {
+			hstate->output_mode -= 4;
+			hstate->dpi = true;
+		} else {
+			hstate->dpi = false;
+		}
+	}
 	return 0;
 }
 
@@ -470,7 +484,7 @@ static struct drm_crtc_state *
 atmel_hlcdc_crtc_duplicate_state(struct drm_crtc *crtc)
 {
 	struct atmel_hlcdc_crtc_state *state, *cur;
-
+	struct atmel_hlcdc_crtc *c = drm_crtc_to_atmel_hlcdc_crtc(crtc);
 	if (WARN_ON(!crtc->state))
 		return NULL;
 
@@ -481,6 +495,8 @@ atmel_hlcdc_crtc_duplicate_state(struct drm_crtc *crtc)
 
 	cur = drm_crtc_state_to_atmel_hlcdc_crtc_state(crtc->state);
 	state->output_mode = cur->output_mode;
+	if (c->dc->desc->is_xlcdc)
+		state->dpi = cur->dpi;
 
 	return &state->base;
 }
Signature · 1 line
2.25.1
maintainer
#11 lore raw

Re: [PATCH v4 6/8] drm: atmel-hlcdc: add DPI mode support for XLCDC

Quoted 16 lines · Manikandan Muralidharan

Add support for Display Pixel Interface (DPI) Compatible Mode support in atmel-hlcdc driver for XLCDC IP along with legacy pixel mapping.DPI mode BIT is configured in LCDC_CFG5 register.

[[email protected]: update DPI mode bit using is_xlcdc flag]
---
 .../gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c    | 22 ++++++++++++++++---
 1 file changed, 19 insertions(+), 3 deletions(-)
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c +0 -0
index 4b11a1de8af4..c3d0c60ba419 100644

drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c line 38

Quoted 9 lines
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c +2 -0
@@ -30,10 +30,12 @@
  *
  * @base: base CRTC state
  * @output_mode: RGBXXX output mode
+ * @dpi: output DPI mode
  */
 struct atmel_hlcdc_crtc_state {
 	struct drm_crtc_state base;
 	unsigned int output_mode;
+	bool dpi;

To avoid confusion, better use u8 to avoid shifting a boolean value in configuration phase.

Quoted 50 lines
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c +15 -3
 };
 
 static inline struct atmel_hlcdc_crtc_state *
@@ -164,6 +166,8 @@ static void atmel_hlcdc_crtc_mode_set_nofb(struct drm_crtc *c)
 
 	state = drm_crtc_state_to_atmel_hlcdc_crtc_state(c->state);
 	cfg = state->output_mode << 8;
+	if (is_xlcdc)
+		cfg |= state->dpi << 11;
 
 	if (!is_xlcdc && (adj->flags & DRM_MODE_FLAG_NVSYNC))
 		cfg |= ATMEL_HLCDC_VSPOL;
@@ -176,7 +180,9 @@ static void atmel_hlcdc_crtc_mode_set_nofb(struct drm_crtc *c)
 			   ATMEL_HLCDC_VSPDLYS | ATMEL_HLCDC_VSPDLYE |
 			   ATMEL_HLCDC_DISPPOL | ATMEL_HLCDC_DISPDLY |
 			   ATMEL_HLCDC_VSPSU | ATMEL_HLCDC_VSPHO |
-			   ATMEL_HLCDC_GUARDTIME_MASK | ATMEL_HLCDC_MODE_MASK,
+			   ATMEL_HLCDC_GUARDTIME_MASK |
+			   (is_xlcdc ? ATMEL_XLCDC_MODE_MASK |
+			   ATMEL_XLCDC_DPI : ATMEL_HLCDC_MODE_MASK),
 			   cfg);
 
 	clk_disable_unprepare(crtc->dc->hlcdc->sys_clk);
@@ -366,7 +372,15 @@ static int atmel_hlcdc_crtc_select_output_mode(struct drm_crtc_state *state)
 
 	hstate = drm_crtc_state_to_atmel_hlcdc_crtc_state(state);
 	hstate->output_mode = fls(output_fmts) - 1;
-
+	if (crtc->dc->desc->is_xlcdc) {
+		/* check if MIPI DPI bit needs to be set */
+		if (fls(output_fmts) > 3) {
+			hstate->output_mode -= 4;
+			hstate->dpi = true;
+		} else {
+			hstate->dpi = false;
+		}
+	}
 	return 0;
 }
 
@@ -470,7 +484,7 @@ static struct drm_crtc_state *
 atmel_hlcdc_crtc_duplicate_state(struct drm_crtc *crtc)
 {
 	struct atmel_hlcdc_crtc_state *state, *cur;
-
+	struct atmel_hlcdc_crtc *c = drm_crtc_to_atmel_hlcdc_crtc(crtc);
 	if (WARN_ON(!crtc->state))
 		return NULL;
 

drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c atmel_hlcdc_crtc_duplicate_state(struct drm_crtc *crtc) · line 502

Quoted 8 lines
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c +2 -0
@@ -481,6 +495,8 @@ atmel_hlcdc_crtc_duplicate_state(struct drm_crtc *crtc)
 
 	cur = drm_crtc_state_to_atmel_hlcdc_crtc_state(crtc->state);
 	state->output_mode = cur->output_mode;
+	if (c->dc->desc->is_xlcdc)
+		state->dpi = cur->dpi;
 
 	return &state->base;
 }

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

author maintainer
#12 lore raw

PATCH v4 7/8 drm: atmel-hlcdc: add vertical and horizontal scaling support for XLCDC

In reply to Manikandan Muralidharan

update the LCDC_HEOCFG30 and LCDC_HEOCFG31 registers of XLCDC IP which supports vertical and horizontal scaling with Bilinear and Bicubic co-efficients taps for Chroma and Luma componenets of the Pixel.

---
 drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c  |  2 ++
 drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.h  |  4 ++++
 .../gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c   | 20 +++++++++++++++++++
 3 files changed, 26 insertions(+)
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c +2 -0
index d30aec174aa2..ae3e1a813482 100644
@@ -536,6 +536,8 @@ static const struct atmel_hlcdc_layer_desc atmel_xlcdc_sam9x75_layers[] = {
 			.general_config = 12,
 			.csc = 16,
 			.scaler_config = 23,
+			.vxs_config = 30,
+			.hxs_config = 31,
 		},
 		.clut_offset = 0x1300,
 	},
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.h +4 -0
index 8b05a54b5fd0..27074a4c5aec 100644
@@ -198,6 +198,8 @@
  * @disc_pos: discard area position register
  * @disc_size: discard area size register
  * @csc: color space conversion register
+ * @vxs_config: vertical scalar filter taps control register
+ * @hxs_config: horizontal scalar filter taps control register
  */
 struct atmel_hlcdc_layer_cfg_layout {
 	int xstride[ATMEL_HLCDC_LAYER_MAX_PLANES];
@@ -217,6 +219,8 @@ struct atmel_hlcdc_layer_cfg_layout {
 	int disc_pos;
 	int disc_size;
 	int csc;
+	int vxs_config;
+	int hxs_config;
 };
 
 /**
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +20 -0
index 26caf4cddfa4..a06ae2dc5909 100644
@@ -972,6 +972,26 @@ static void xlcdc_csc_init(struct atmel_hlcdc_plane *plane,
 		atmel_hlcdc_layer_write_cfg(&plane->layer,
 					    desc->layout.csc + i,
 					    xlcdc_csc_coeffs[i]);
+
+	if (desc->layout.vxs_config && desc->layout.hxs_config) {
+		/*
+		 * Updating vxs.config and hxs.config fixes the
+		 * Green Color Issue in SAM9X7 EGT Video Player App
+		 */
+		atmel_hlcdc_layer_write_cfg(&plane->layer,
+					    desc->layout.vxs_config,
+					    ATMEL_XLCDC_LAYER_VXSYCFG_ONE |
+					    ATMEL_XLCDC_LAYER_VXSYTAP2_ENABLE |
+					    ATMEL_XLCDC_LAYER_VXSCCFG_ONE |
+					    ATMEL_XLCDC_LAYER_VXSCTAP2_ENABLE);
+
+		atmel_hlcdc_layer_write_cfg(&plane->layer,
+					    desc->layout.hxs_config,
+					    ATMEL_XLCDC_LAYER_HXSYCFG_ONE |
+					    ATMEL_XLCDC_LAYER_HXSYTAP2_ENABLE |
+					    ATMEL_XLCDC_LAYER_HXSCCFG_ONE |
+					    ATMEL_XLCDC_LAYER_HXSCTAP2_ENABLE);
+	}
 }
 
 static int atmel_hlcdc_plane_init_properties(struct atmel_hlcdc_plane *plane)
Signature · 1 line
2.25.1
maintainer
#13 lore raw

Re: [PATCH v4 7/8] drm: atmel-hlcdc: add vertical and horizontal scaling support for XLCDC

Quoted 1 line · Manikandan Muralidharan

update the LCDC_HEOCFG30 and LCDC_HEOCFG31 registers of XLCDC IP which

s/update/Update

Quoted 66 lines

supports vertical and horizontal scaling with Bilinear and Bicubic co-efficients taps for Chroma and Luma componenets of the Pixel.

---
 drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c  |  2 ++
 drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.h  |  4 ++++
 .../gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c   | 20 +++++++++++++++++++
 3 files changed, 26 insertions(+)
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c +2 -0
index d30aec174aa2..ae3e1a813482 100644
@@ -536,6 +536,8 @@ static const struct atmel_hlcdc_layer_desc atmel_xlcdc_sam9x75_layers[] = {
 			.general_config = 12,
 			.csc = 16,
 			.scaler_config = 23,
+			.vxs_config = 30,
+			.hxs_config = 31,
 		},
 		.clut_offset = 0x1300,
 	},
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.h +4 -0
index 8b05a54b5fd0..27074a4c5aec 100644
@@ -198,6 +198,8 @@
  * @disc_pos: discard area position register
  * @disc_size: discard area size register
  * @csc: color space conversion register
+ * @vxs_config: vertical scalar filter taps control register
+ * @hxs_config: horizontal scalar filter taps control register
  */
 struct atmel_hlcdc_layer_cfg_layout {
 	int xstride[ATMEL_HLCDC_LAYER_MAX_PLANES];
@@ -217,6 +219,8 @@ struct atmel_hlcdc_layer_cfg_layout {
 	int disc_pos;
 	int disc_size;
 	int csc;
+	int vxs_config;
+	int hxs_config;
 };
 
 /**
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +13 -0
index 26caf4cddfa4..a06ae2dc5909 100644
@@ -972,6 +972,26 @@ static void xlcdc_csc_init(struct atmel_hlcdc_plane *plane,
 		atmel_hlcdc_layer_write_cfg(&plane->layer,
 					    desc->layout.csc + i,
 					    xlcdc_csc_coeffs[i]);
+
+	if (desc->layout.vxs_config && desc->layout.hxs_config) {
+		/*
+		 * Updating vxs.config and hxs.config fixes the
+		 * Green Color Issue in SAM9X7 EGT Video Player App
+		 */
+		atmel_hlcdc_layer_write_cfg(&plane->layer,
+					    desc->layout.vxs_config,
+					    ATMEL_XLCDC_LAYER_VXSYCFG_ONE |
+					    ATMEL_XLCDC_LAYER_VXSYTAP2_ENABLE |
+					    ATMEL_XLCDC_LAYER_VXSCCFG_ONE |
+					    ATMEL_XLCDC_LAYER_VXSCTAP2_ENABLE);
+

drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c static void xlcdc_csc_init(struct atmel_hlcdc_plane *plane, · line 997

Quoted 10 lines
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +7 -0
+		atmel_hlcdc_layer_write_cfg(&plane->layer,
+					    desc->layout.hxs_config,
+					    ATMEL_XLCDC_LAYER_HXSYCFG_ONE |
+					    ATMEL_XLCDC_LAYER_HXSYTAP2_ENABLE |
+					    ATMEL_XLCDC_LAYER_HXSCCFG_ONE |
+					    ATMEL_XLCDC_LAYER_HXSCTAP2_ENABLE);
+	}
 }
 
 static int atmel_hlcdc_plane_init_properties(struct atmel_hlcdc_plane *plane)

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

author maintainer
#14 lore raw

PATCH v4 8/8 drm: atmel-hlcdc: add support for DSI output formats

In reply to Manikandan Muralidharan

Add support for the following DPI mode if the encoder type is DSI as per the XLCDC IP datasheet:
- 16BPPCFG1
- 16BPPCFG2
- 16BPPCFG3
- 18BPPCFG1
- 18BPPCFG2
- 24BPP

[[email protected]: update output format using is_xlcdc flag]
---
 .../gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c    | 123 +++++++++++++-----
 1 file changed, 89 insertions(+), 34 deletions(-)
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c +89 -34
index c3d0c60ba419..0d10f84c82d8 100644
@@ -287,11 +287,18 @@ static void atmel_hlcdc_crtc_atomic_enable(struct drm_crtc *c,
 
 }
 
-#define ATMEL_HLCDC_RGB444_OUTPUT	BIT(0)
-#define ATMEL_HLCDC_RGB565_OUTPUT	BIT(1)
-#define ATMEL_HLCDC_RGB666_OUTPUT	BIT(2)
-#define ATMEL_HLCDC_RGB888_OUTPUT	BIT(3)
-#define ATMEL_HLCDC_OUTPUT_MODE_MASK	GENMASK(3, 0)
+#define ATMEL_HLCDC_RGB444_OUTPUT		BIT(0)
+#define ATMEL_HLCDC_RGB565_OUTPUT		BIT(1)
+#define ATMEL_HLCDC_RGB666_OUTPUT		BIT(2)
+#define ATMEL_HLCDC_RGB888_OUTPUT		BIT(3)
+#define ATMEL_HLCDC_DPI_RGB565C1_OUTPUT		BIT(4)
+#define ATMEL_HLCDC_DPI_RGB565C2_OUTPUT		BIT(5)
+#define ATMEL_HLCDC_DPI_RGB565C3_OUTPUT		BIT(6)
+#define ATMEL_HLCDC_DPI_RGB666C1_OUTPUT		BIT(7)
+#define ATMEL_HLCDC_DPI_RGB666C2_OUTPUT		BIT(8)
+#define ATMEL_HLCDC_DPI_RGB888_OUTPUT		BIT(9)
+#define ATMEL_HLCDC_OUTPUT_MODE_MASK		GENMASK(3, 0)
+#define ATMEL_XLCDC_OUTPUT_MODE_MASK		GENMASK(9, 0)
 
 static int atmel_hlcdc_connector_output_mode(struct drm_connector_state *state)
 {
@@ -305,37 +312,83 @@ static int atmel_hlcdc_connector_output_mode(struct drm_connector_state *state)
 	if (!encoder)
 		encoder = connector->encoder;
 
-	switch (atmel_hlcdc_encoder_get_bus_fmt(encoder)) {
-	case 0:
-		break;
-	case MEDIA_BUS_FMT_RGB444_1X12:
-		return ATMEL_HLCDC_RGB444_OUTPUT;
-	case MEDIA_BUS_FMT_RGB565_1X16:
-		return ATMEL_HLCDC_RGB565_OUTPUT;
-	case MEDIA_BUS_FMT_RGB666_1X18:
-		return ATMEL_HLCDC_RGB666_OUTPUT;
-	case MEDIA_BUS_FMT_RGB888_1X24:
-		return ATMEL_HLCDC_RGB888_OUTPUT;
-	default:
-		return -EINVAL;
-	}
-
-	for (j = 0; j < info->num_bus_formats; j++) {
-		switch (info->bus_formats[j]) {
-		case MEDIA_BUS_FMT_RGB444_1X12:
-			supported_fmts |= ATMEL_HLCDC_RGB444_OUTPUT;
+	if (encoder->encoder_type == DRM_MODE_ENCODER_DSI) {
+		/*
+		 * atmel-hlcdc to support DSI formats with DSI video pipeline
+		 * when DRM_MODE_ENCODER_DSI type is set by
+		 * connector driver component.
+		 */
+		switch (atmel_hlcdc_encoder_get_bus_fmt(encoder)) {
+		case 0:
 			break;
 		case MEDIA_BUS_FMT_RGB565_1X16:
-			supported_fmts |= ATMEL_HLCDC_RGB565_OUTPUT;
-			break;
+			return ATMEL_HLCDC_DPI_RGB565C1_OUTPUT;
 		case MEDIA_BUS_FMT_RGB666_1X18:
-			supported_fmts |= ATMEL_HLCDC_RGB666_OUTPUT;
-			break;
+			return ATMEL_HLCDC_DPI_RGB666C1_OUTPUT;
+		case MEDIA_BUS_FMT_RGB666_1X24_CPADHI:
+			return ATMEL_HLCDC_DPI_RGB666C2_OUTPUT;
 		case MEDIA_BUS_FMT_RGB888_1X24:
-			supported_fmts |= ATMEL_HLCDC_RGB888_OUTPUT;
-			break;
+			return ATMEL_HLCDC_DPI_RGB888_OUTPUT;
 		default:
+			return -EINVAL;
+		}
+
+		for (j = 0; j < info->num_bus_formats; j++) {
+			switch (info->bus_formats[j]) {
+			case MEDIA_BUS_FMT_RGB565_1X16:
+				supported_fmts |=
+					ATMEL_HLCDC_DPI_RGB565C1_OUTPUT;
+				break;
+			case MEDIA_BUS_FMT_RGB666_1X18:
+				supported_fmts |=
+					ATMEL_HLCDC_DPI_RGB666C1_OUTPUT;
+				break;
+			case MEDIA_BUS_FMT_RGB666_1X24_CPADHI:
+				supported_fmts |=
+					ATMEL_HLCDC_DPI_RGB666C2_OUTPUT;
+				break;
+			case MEDIA_BUS_FMT_RGB888_1X24:
+				supported_fmts |=
+					ATMEL_HLCDC_DPI_RGB888_OUTPUT;
+				break;
+			default:
+				break;
+			}
+		}
+
+	} else {
+		switch (atmel_hlcdc_encoder_get_bus_fmt(encoder)) {
+		case 0:
 			break;
+		case MEDIA_BUS_FMT_RGB444_1X12:
+			return ATMEL_HLCDC_RGB444_OUTPUT;
+		case MEDIA_BUS_FMT_RGB565_1X16:
+			return ATMEL_HLCDC_RGB565_OUTPUT;
+		case MEDIA_BUS_FMT_RGB666_1X18:
+			return ATMEL_HLCDC_RGB666_OUTPUT;
+		case MEDIA_BUS_FMT_RGB888_1X24:
+			return ATMEL_HLCDC_RGB888_OUTPUT;
+		default:
+			return -EINVAL;
+		}
+
+		for (j = 0; j < info->num_bus_formats; j++) {
+			switch (info->bus_formats[j]) {
+			case MEDIA_BUS_FMT_RGB444_1X12:
+				supported_fmts |= ATMEL_HLCDC_RGB444_OUTPUT;
+				break;
+			case MEDIA_BUS_FMT_RGB565_1X16:
+				supported_fmts |= ATMEL_HLCDC_RGB565_OUTPUT;
+				break;
+			case MEDIA_BUS_FMT_RGB666_1X18:
+				supported_fmts |= ATMEL_HLCDC_RGB666_OUTPUT;
+				break;
+			case MEDIA_BUS_FMT_RGB888_1X24:
+				supported_fmts |= ATMEL_HLCDC_RGB888_OUTPUT;
+				break;
+			default:
+				break;
+			}
 		}
 	}
 
@@ -344,14 +397,16 @@ static int atmel_hlcdc_connector_output_mode(struct drm_connector_state *state)
 
 static int atmel_hlcdc_crtc_select_output_mode(struct drm_crtc_state *state)
 {
-	unsigned int output_fmts = ATMEL_HLCDC_OUTPUT_MODE_MASK;
+	unsigned int output_fmts;
 	struct atmel_hlcdc_crtc_state *hstate;
 	struct drm_connector_state *cstate;
 	struct drm_connector *connector;
-	struct atmel_hlcdc_crtc *crtc;
+	struct atmel_hlcdc_crtc *crtc = drm_crtc_to_atmel_hlcdc_crtc(state->crtc);
 	int i;
+	bool is_xlcdc = crtc->dc->desc->is_xlcdc;
 
-	crtc = drm_crtc_to_atmel_hlcdc_crtc(state->crtc);
+	output_fmts = is_xlcdc ? ATMEL_XLCDC_OUTPUT_MODE_MASK :
+		      ATMEL_HLCDC_OUTPUT_MODE_MASK;
 
 	for_each_new_connector_in_state(state->state, connector, cstate, i) {
 		unsigned int supported_fmts = 0;
@@ -372,7 +427,7 @@ static int atmel_hlcdc_crtc_select_output_mode(struct drm_crtc_state *state)
 
 	hstate = drm_crtc_state_to_atmel_hlcdc_crtc_state(state);
 	hstate->output_mode = fls(output_fmts) - 1;
-	if (crtc->dc->desc->is_xlcdc) {
+	if (is_xlcdc) {
 		/* check if MIPI DPI bit needs to be set */
 		if (fls(output_fmts) > 3) {
 			hstate->output_mode -= 4;
Signature · 1 line
2.25.1
maintainer
#15 lore raw

Re: [PATCH v4 8/8] drm: atmel-hlcdc: add support for DSI output formats

Quoted 107 lines · Manikandan Muralidharan

Add support for the following DPI mode if the encoder type is DSI as per the XLCDC IP datasheet:
- 16BPPCFG1
- 16BPPCFG2
- 16BPPCFG3
- 18BPPCFG1
- 18BPPCFG2
- 24BPP

[[email protected]: update output format using is_xlcdc flag]
---
 .../gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c    | 123 +++++++++++++-----
 1 file changed, 89 insertions(+), 34 deletions(-)
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c +41 -30
index c3d0c60ba419..0d10f84c82d8 100644
@@ -287,11 +287,18 @@ static void atmel_hlcdc_crtc_atomic_enable(struct drm_crtc *c,
 
 }
 
-#define ATMEL_HLCDC_RGB444_OUTPUT	BIT(0)
-#define ATMEL_HLCDC_RGB565_OUTPUT	BIT(1)
-#define ATMEL_HLCDC_RGB666_OUTPUT	BIT(2)
-#define ATMEL_HLCDC_RGB888_OUTPUT	BIT(3)
-#define ATMEL_HLCDC_OUTPUT_MODE_MASK	GENMASK(3, 0)
+#define ATMEL_HLCDC_RGB444_OUTPUT		BIT(0)
+#define ATMEL_HLCDC_RGB565_OUTPUT		BIT(1)
+#define ATMEL_HLCDC_RGB666_OUTPUT		BIT(2)
+#define ATMEL_HLCDC_RGB888_OUTPUT		BIT(3)
+#define ATMEL_HLCDC_DPI_RGB565C1_OUTPUT		BIT(4)
+#define ATMEL_HLCDC_DPI_RGB565C2_OUTPUT		BIT(5)
+#define ATMEL_HLCDC_DPI_RGB565C3_OUTPUT		BIT(6)
+#define ATMEL_HLCDC_DPI_RGB666C1_OUTPUT		BIT(7)
+#define ATMEL_HLCDC_DPI_RGB666C2_OUTPUT		BIT(8)
+#define ATMEL_HLCDC_DPI_RGB888_OUTPUT		BIT(9)
+#define ATMEL_HLCDC_OUTPUT_MODE_MASK		GENMASK(3, 0)
+#define ATMEL_XLCDC_OUTPUT_MODE_MASK		GENMASK(9, 0)
 
 static int atmel_hlcdc_connector_output_mode(struct drm_connector_state *state)
 {
@@ -305,37 +312,83 @@ static int atmel_hlcdc_connector_output_mode(struct drm_connector_state *state)
 	if (!encoder)
 		encoder = connector->encoder;
 
-	switch (atmel_hlcdc_encoder_get_bus_fmt(encoder)) {
-	case 0:
-		break;
-	case MEDIA_BUS_FMT_RGB444_1X12:
-		return ATMEL_HLCDC_RGB444_OUTPUT;
-	case MEDIA_BUS_FMT_RGB565_1X16:
-		return ATMEL_HLCDC_RGB565_OUTPUT;
-	case MEDIA_BUS_FMT_RGB666_1X18:
-		return ATMEL_HLCDC_RGB666_OUTPUT;
-	case MEDIA_BUS_FMT_RGB888_1X24:
-		return ATMEL_HLCDC_RGB888_OUTPUT;
-	default:
-		return -EINVAL;
-	}
-
-	for (j = 0; j < info->num_bus_formats; j++) {
-		switch (info->bus_formats[j]) {
-		case MEDIA_BUS_FMT_RGB444_1X12:
-			supported_fmts |= ATMEL_HLCDC_RGB444_OUTPUT;
+	if (encoder->encoder_type == DRM_MODE_ENCODER_DSI) {
+		/*
+		 * atmel-hlcdc to support DSI formats with DSI video pipeline
+		 * when DRM_MODE_ENCODER_DSI type is set by
+		 * connector driver component.
+		 */
+		switch (atmel_hlcdc_encoder_get_bus_fmt(encoder)) {
+		case 0:
 			break;
 		case MEDIA_BUS_FMT_RGB565_1X16:
-			supported_fmts |= ATMEL_HLCDC_RGB565_OUTPUT;
-			break;
+			return ATMEL_HLCDC_DPI_RGB565C1_OUTPUT;
 		case MEDIA_BUS_FMT_RGB666_1X18:
-			supported_fmts |= ATMEL_HLCDC_RGB666_OUTPUT;
-			break;
+			return ATMEL_HLCDC_DPI_RGB666C1_OUTPUT;
+		case MEDIA_BUS_FMT_RGB666_1X24_CPADHI:
+			return ATMEL_HLCDC_DPI_RGB666C2_OUTPUT;
 		case MEDIA_BUS_FMT_RGB888_1X24:
-			supported_fmts |= ATMEL_HLCDC_RGB888_OUTPUT;
-			break;
+			return ATMEL_HLCDC_DPI_RGB888_OUTPUT;
 		default:
+			return -EINVAL;
+		}
+
+		for (j = 0; j < info->num_bus_formats; j++) {
+			switch (info->bus_formats[j]) {
+			case MEDIA_BUS_FMT_RGB565_1X16:
+				supported_fmts |=
+					ATMEL_HLCDC_DPI_RGB565C1_OUTPUT;
+				break;
+			case MEDIA_BUS_FMT_RGB666_1X18:
+				supported_fmts |=
+					ATMEL_HLCDC_DPI_RGB666C1_OUTPUT;
+				break;
+			case MEDIA_BUS_FMT_RGB666_1X24_CPADHI:
+				supported_fmts |=
+					ATMEL_HLCDC_DPI_RGB666C2_OUTPUT;

drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c static int atmel_hlcdc_connector_output_mode(struct drm_connector_state *state) · line 358

Quoted 10 lines
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c +10 -0
+				break;
+			case MEDIA_BUS_FMT_RGB888_1X24:
+				supported_fmts |=
+					ATMEL_HLCDC_DPI_RGB888_OUTPUT;
+				break;
+			default:
+				break;
+			}
+		}
+

blank line here.

Quoted 57 lines
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c +37 -3
+	} else {
+		switch (atmel_hlcdc_encoder_get_bus_fmt(encoder)) {
+		case 0:
 			break;
+		case MEDIA_BUS_FMT_RGB444_1X12:
+			return ATMEL_HLCDC_RGB444_OUTPUT;
+		case MEDIA_BUS_FMT_RGB565_1X16:
+			return ATMEL_HLCDC_RGB565_OUTPUT;
+		case MEDIA_BUS_FMT_RGB666_1X18:
+			return ATMEL_HLCDC_RGB666_OUTPUT;
+		case MEDIA_BUS_FMT_RGB888_1X24:
+			return ATMEL_HLCDC_RGB888_OUTPUT;
+		default:
+			return -EINVAL;
+		}
+
+		for (j = 0; j < info->num_bus_formats; j++) {
+			switch (info->bus_formats[j]) {
+			case MEDIA_BUS_FMT_RGB444_1X12:
+				supported_fmts |= ATMEL_HLCDC_RGB444_OUTPUT;
+				break;
+			case MEDIA_BUS_FMT_RGB565_1X16:
+				supported_fmts |= ATMEL_HLCDC_RGB565_OUTPUT;
+				break;
+			case MEDIA_BUS_FMT_RGB666_1X18:
+				supported_fmts |= ATMEL_HLCDC_RGB666_OUTPUT;
+				break;
+			case MEDIA_BUS_FMT_RGB888_1X24:
+				supported_fmts |= ATMEL_HLCDC_RGB888_OUTPUT;
+				break;
+			default:
+				break;
+			}
 		}
 	}
 
@@ -344,14 +397,16 @@ static int atmel_hlcdc_connector_output_mode(struct drm_connector_state *state)
 
 static int atmel_hlcdc_crtc_select_output_mode(struct drm_crtc_state *state)
 {
-	unsigned int output_fmts = ATMEL_HLCDC_OUTPUT_MODE_MASK;
+	unsigned int output_fmts;
 	struct atmel_hlcdc_crtc_state *hstate;
 	struct drm_connector_state *cstate;
 	struct drm_connector *connector;
-	struct atmel_hlcdc_crtc *crtc;
+	struct atmel_hlcdc_crtc *crtc = drm_crtc_to_atmel_hlcdc_crtc(state->crtc);
 	int i;
+	bool is_xlcdc = crtc->dc->desc->is_xlcdc;
 
-	crtc = drm_crtc_to_atmel_hlcdc_crtc(state->crtc);
+	output_fmts = is_xlcdc ? ATMEL_XLCDC_OUTPUT_MODE_MASK :
+		      ATMEL_HLCDC_OUTPUT_MODE_MASK;
 
 	for_each_new_connector_in_state(state->state, connector, cstate, i) {
 		unsigned int supported_fmts = 0;

drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c static int atmel_hlcdc_crtc_select_output_mode(struct drm_crtc_state *state) · line 433

Quoted 8 lines
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c +1 -1
@@ -372,7 +427,7 @@ static int atmel_hlcdc_crtc_select_output_mode(struct drm_crtc_state *state)
 
 	hstate = drm_crtc_state_to_atmel_hlcdc_crtc_state(state);
 	hstate->output_mode = fls(output_fmts) - 1;
-	if (crtc->dc->desc->is_xlcdc) {
+	if (is_xlcdc) {
 		/* check if MIPI DPI bit needs to be set */
 		if (fls(output_fmts) > 3) {
 			hstate->output_mode -= 4;

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel