Skip to contentSkip to conversation

Revert "checkpatch: add check for keyword 'boolean' in Kconfig definitions"

PATCH In review Masahiro Yamada 2 participants 3 messages Jan 26, 2021 – Jan 28, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Revert "checkpatch: add check for keyword 'boolean' in Kconfig definitions"

This reverts commit 327953e9af6c59ad111b28359e59e3ec0cbd71b6.

You cannot use 'boolean' since commit b92d804a5179 ("kconfig: drop 'boolean' keyword").

This check is no longer needed.

---

 scripts/checkpatch.pl | 7 -------
 1 file changed, 7 deletions(-)
scripts/checkpatch.pl +0 -7
index 92e888ed939f..1afe3af1cc09 100755
@@ -3390,13 +3390,6 @@ sub process {
 			}
 		}
 
-# discourage the use of boolean for type definition attributes of Kconfig options
-		if ($realfile =~ /Kconfig/ &&
-		    $line =~ /^\+\s*\bboolean\b/) {
-			WARN("CONFIG_TYPE_BOOLEAN",
-			     "Use of boolean is deprecated, please use bool instead.\n" . $herecurr);
-		}
-
 		if (($realfile =~ /Makefile.*/ || $realfile =~ /Kbuild.*/) &&
 		    ($line =~ /\+(EXTRA_[A-Z]+FLAGS).*/)) {
 			my $flag = $1;
Signature · 1 line
2.27.0
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 6 lines · Masahiro Yamada

This reverts commit 327953e9af6c59ad111b28359e59e3ec0cbd71b6.

You cannot use 'boolean' since commit b92d804a5179 ("kconfig: drop 'boolean' keyword").

This check is no longer needed.

Thanks.

Quoted 1 line

scripts/checkpatch.pl

Quoted 1 line
scripts/checkpatch.pl +0 -0

[]

Quoted 14 lines
scripts/checkpatch.pl +0 -0
@@ -3390,13 +3390,6 @@ sub process {
  			}
  		}

scripts/checkpatch.pl +0 -7
-# discourage the use of boolean for type definition attributes of Kconfig options
-		if ($realfile =~ /Kconfig/ &&
-		    $line =~ /^\+\s*\bboolean\b/) {
-			WARN("CONFIG_TYPE_BOOLEAN",
-			     "Use of boolean is deprecated, please use bool instead.\n" . $herecurr);
-		}
-

  if (($realfile =~ /Makefile.*/ || $realfile =~ /Kbuild.*/) && ($line =~ /\+(EXTRA_[A-Z]+FLAGS).*/)) {
  my $flag = $1;

#2 lore raw
Quoted 9 lines · Joe Perches
Quoted 6 lines · Masahiro Yamada

This reverts commit 327953e9af6c59ad111b28359e59e3ec0cbd71b6.

You cannot use 'boolean' since commit b92d804a5179 ("kconfig: drop 'boolean' keyword").

This check is no longer needed.

Applied to linux-kbuild.

Quoted 24 lines

Thanks.

Quoted 1 line

scripts/checkpatch.pl

Quoted 1 line
scripts/checkpatch.pl +0 -0

[]

Quoted 14 lines
scripts/checkpatch.pl +0 -7
@@ -3390,13 +3390,6 @@ sub process {
                      }
              }
 
-# discourage the use of boolean for type definition attributes of Kconfig options
-             if ($realfile =~ /Kconfig/ &&
-                 $line =~ /^\+\s*\bboolean\b/) {
-                     WARN("CONFIG_TYPE_BOOLEAN",
-                          "Use of boolean is deprecated, please use bool instead.\n" . $herecurr);
-             }
-
              if (($realfile =~ /Makefile.*/ || $realfile =~ /Kbuild.*/) &&
                  ($line =~ /\+(EXTRA_[A-Z]+FLAGS).*/)) {
                      my $flag = $1;
Signature · 2 lines
Best Regards
Masahiro Yamada