Skip to contentSkip to conversation

Question about EMMC CMDQ HOST CONTROLLER INTERFACE (CQHCI) DRIVER

DISCUSSION Adrian Hunter 3 participants 9 messages Nov 8, 2022 – Nov 10, 2022 1 message not in the archive MMC, SD and SDIO

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw
Quoted 10 lines · Jyan Chou [周芷安]

Hello Adrian Hunter,

We are now using the upstream code of EMMC CMDQ HOST CONTROLLER INTERFACE (CQHCI) DRIVER, but we found that the existing driver cannot support the limitation of Synopsys IP.

Synopsys IP has a description on their data book " While using DMA, the host memory data buffer size and start address must not exceed 128 MB".

I am wondering whether there is a method or patch that can fix this boundary limitation. Thanks.
Best Regards,
Jyan Chou

Hello Jyan Chou

I am not clear on what the exact limitation is. The driver never uses buffers as big as 128 MB. To restrict DMA to low memory addresses a DMA mask can be used.

But perhaps you mean not to cross a 128 MB boundary?

Please cc your questions to the linux kernel mmc mailing list: [email protected] because others can answer too.

Regards
Adrian

#2 lore raw
Quoted 6 lines · Adrian Hunter
Quoted 5 lines · Jyan Chou [周芷安]

Hello Adrian Hunter,

We are now using the upstream code of EMMC CMDQ HOST CONTROLLER INTERFACE (CQHCI) DRIVER, but we found that the existing driver cannot support the limitation of Synopsys IP.

Synopsys IP has a description on their data book " While using DMA, the host memory data buffer size and start address must not exceed 128 MB".

Synopsys-based SDHCI IP does have a limitation of 128MB boundary. But it has already been solved by upstream driver.

FYI:

commit b85c997d2cfefe7d1f706b85ae46e35a50e3131c ("mmc: sdhci-of-dwcmshc: solve 128MB DMA boundary limitation")

Quoted 18 lines
Quoted 5 lines

I am wondering whether there is a method or patch that can fix this boundary limitation. Thanks.
Best Regards,
Jyan Chou

Hello Jyan Chou

I am not clear on what the exact limitation is. The driver never uses buffers as big as 128 MB. To restrict DMA to low memory addresses a DMA mask can be used.

But perhaps you mean not to cross a 128 MB boundary?

Please cc your questions to the linux kernel mmc mailing list: [email protected] because others can answer too.

Regards
Adrian

#3 lore raw
Quoted 6 lines · Shawn Lin
Quoted 5 lines · Adrian Hunter
Quoted 4 lines · Jyan Chou [周芷安]

Hello Adrian Hunter,

We are now using the upstream code of EMMC CMDQ HOST CONTROLLER INTERFACE (CQHCI) DRIVER, but we found that the existing driver cannot support the limitation of Synopsys IP.

Quoted 8 lines
Quoted 1 line
Quoted 1 line

Synopsys IP has a description on their data book " While using DMA, the host memory data buffer size and start address must not exceed 128 MB".

Synopsys-based SDHCI IP does have a limitation of 128MB boundary. But it has already been solved by upstream driver.

FYI:

commit b85c997d2cfefe7d1f706b85ae46e35a50e3131c ("mmc: sdhci-of-dwcmshc: solve 128MB DMA boundary limitation")

CQHCI has its own DMA descriptors, so maybe a similar change is needed for CQHCI?

Quoted 19 lines
Quoted 19 lines
Quoted 6 lines

I am wondering whether there is a method or patch that can fix this boundary limitation. Thanks.
Best Regards,
Jyan Chou

Hello Jyan Chou

I am not clear on what the exact limitation is.  The driver never uses buffers as big as 128 MB. To restrict DMA to low memory addresses a DMA mask can be used.

But perhaps you mean not to cross a 128 MB boundary?

Please cc your questions to the linux kernel mmc mailing list: [email protected] because others can answer too.

Regards
Adrian

#4 lore raw

+ Jisheng Zhang

Quoted 9 lines · Adrian Hunter
Quoted 8 lines · Shawn Lin
Quoted 6 lines · Adrian Hunter
Quoted 5 lines · Jyan Chou [周芷安]

Hello Adrian Hunter,

We are now using the upstream code of EMMC CMDQ HOST CONTROLLER INTERFACE (CQHCI) DRIVER, but we found that the existing driver cannot support the limitation of Synopsys IP.

Synopsys IP has a description on their data book " While using DMA, the host memory data buffer size and start address must not exceed 128 MB".

Quoted 8 lines
Quoted 6 lines

Synopsys-based SDHCI IP does have a limitation of 128MB boundary. But it has already been solved by upstream driver.

FYI:

commit b85c997d2cfefe7d1f706b85ae46e35a50e3131c ("mmc: sdhci-of-dwcmshc: solve 128MB DMA boundary limitation")

CQHCI has its own DMA descriptors, so maybe a similar change is needed for CQHCI?

I didn't find this limitation in synopsys DW IP databook.

Quoted 21 lines
Quoted 20 lines
Quoted 20 lines
Quoted 7 lines

I am wondering whether there is a method or patch that can fix this boundary limitation. Thanks.
Best Regards,
Jyan Chou

Hello Jyan Chou

I am not clear on what the exact limitation is.  The driver never uses buffers as big as 128 MB. To restrict DMA to low memory addresses a DMA mask can be used.

But perhaps you mean not to cross a 128 MB boundary?

Please cc your questions to the linux kernel mmc mailing list: [email protected] because others can answer too.

Regards
Adrian

#5 lore raw
Quoted 1 line

CQHCI has its own DMA descriptors, so maybe a similar change is needed for CQHCI?

I didn't find this limitation in synopsys DW IP databook.

Quoted 1 line
Quoted 1 line

I found it on page 84

-----Original Message-----
From: Shawn Lin <[email protected]>
Sent: Tuesday, November 8, 2022 5:15 PM
To: Adrian Hunter <[email protected]>
Cc: [email protected]; linux-mmc <[email protected]>; Jyan Chou [周芷安] <[email protected]>; [email protected]
Subject: Re: Question about EMMC CMDQ HOST CONTROLLER INTERFACE (CQHCI) DRIVER

+ Jisheng Zhang

Quoted 12 lines · Adrian Hunter
Quoted 11 lines · Shawn Lin
Quoted 6 lines · Adrian Hunter
Quoted 5 lines · Jyan Chou [周芷安]

Hello Adrian Hunter,

We are now using the upstream code of EMMC CMDQ HOST CONTROLLER INTERFACE (CQHCI) DRIVER, but we found that the existing driver cannot support the limitation of Synopsys IP.

Synopsys IP has a description on their data book " While using DMA, the host memory data buffer size and start address must not exceed 128 MB".

Synopsys-based SDHCI IP does have a limitation of 128MB boundary. But it has already been solved by upstream driver.

Quoted 6 lines
Quoted 4 lines

FYI:

commit b85c997d2cfefe7d1f706b85ae46e35a50e3131c ("mmc:
sdhci-of-dwcmshc: solve 128MB DMA boundary limitation")

CQHCI has its own DMA descriptors, so maybe a similar change is needed for CQHCI?

I didn't find this limitation in synopsys DW IP databook.

Quoted 13 lines
Quoted 13 lines
Quoted 13 lines
Quoted 7 lines

I am wondering whether there is a method or patch that can fix this boundary limitation. Thanks.
Best Regards,
Jyan Chou

Hello Jyan Chou

I am not clear on what the exact limitation is.  The driver never uses buffers as big as 128 MB. To restrict DMA to low memory addresses a DMA mask can be used.

Quoted 8 lines
Quoted 7 lines
Quoted 7 lines

But perhaps you mean not to cross a 128 MB boundary?

Please cc your questions to the linux kernel mmc mailing list:
[email protected] because others can answer too.

Regards
Adrian

------Please consider the environment before printing this e-mail.

#6 lore raw
Quoted 4 lines · Jyan Chou [周芷安]
Quoted 1 line

CQHCI has its own DMA descriptors, so maybe a similar change is needed for CQHCI?

I didn't find this limitation in synopsys DW IP databook.

Quoted 1 line
Quoted 1 line

I found it on page 84

I see, but it wasn't clear to me if this description on P84 is for CQ engine part as well. But seems yes after checking with the IP vendor. So you do need a similar change for CQHCI in cqhci_host_alloc_tdl.

Quoted 55 lines

-----Original Message-----
From: Shawn Lin <[email protected]>
Sent: Tuesday, November 8, 2022 5:15 PM
To: Adrian Hunter <[email protected]>
Cc: [email protected]; linux-mmc <[email protected]>; Jyan Chou [周芷安] <[email protected]>; [email protected]
Subject: Re: Question about EMMC CMDQ HOST CONTROLLER INTERFACE (CQHCI) DRIVER

+ Jisheng Zhang

Quoted 12 lines · Adrian Hunter
Quoted 11 lines · Shawn Lin
Quoted 6 lines · Adrian Hunter
Quoted 5 lines · Jyan Chou [周芷安]

Hello Adrian Hunter,

We are now using the upstream code of EMMC CMDQ HOST CONTROLLER INTERFACE (CQHCI) DRIVER, but we found that the existing driver cannot support the limitation of Synopsys IP.

Synopsys IP has a description on their data book " While using DMA, the host memory data buffer size and start address must not exceed 128 MB".

Synopsys-based SDHCI IP does have a limitation of 128MB boundary. But it has already been solved by upstream driver.

Quoted 6 lines
Quoted 4 lines

FYI:

commit b85c997d2cfefe7d1f706b85ae46e35a50e3131c ("mmc:
sdhci-of-dwcmshc: solve 128MB DMA boundary limitation")

CQHCI has its own DMA descriptors, so maybe a similar change is needed for CQHCI?

I didn't find this limitation in synopsys DW IP databook.

Quoted 13 lines
Quoted 13 lines
Quoted 13 lines
Quoted 7 lines

I am wondering whether there is a method or patch that can fix this boundary limitation. Thanks.
Best Regards,
Jyan Chou

Hello Jyan Chou

I am not clear on what the exact limitation is.  The driver never uses buffers as big as 128 MB. To restrict DMA to low memory addresses a DMA mask can be used.

Quoted 8 lines
Quoted 7 lines
Quoted 7 lines

But perhaps you mean not to cross a 128 MB boundary?

Please cc your questions to the linux kernel mmc mailing list:
[email protected] because others can answer too.

Regards
Adrian

------Please consider the environment before printing this e-mail.

#7 lore raw
Quoted 4 lines

CQHCI has its own DMA descriptors, so maybe a similar change is needed for CQHCI? So you do need a similar change for CQHCI

Quoted 1 line

According to these comments, it is acceptable for us to update a patch to solve the limitation of 128MB boundary ?

We have a patch and it works well on cmdq case. Thanks.

-----Original Message-----
From: Shawn Lin <[email protected]>
Sent: Wednesday, November 9, 2022 11:46 AM
To: Jyan Chou [周芷安] <[email protected]>
Cc: [email protected]; linux-mmc <[email protected]>; [email protected]; Adrian Hunter <[email protected]>
Subject: Re: Question about EMMC CMDQ HOST CONTROLLER INTERFACE (CQHCI) DRIVER

Quoted 4 lines · Jyan Chou [周芷安]
Quoted 1 line

CQHCI has its own DMA descriptors, so maybe a similar change is needed for CQHCI?

I didn't find this limitation in synopsys DW IP databook.

Quoted 1 line
Quoted 1 line

I found it on page 84

I see, but it wasn't clear to me if this description on P84 is for CQ engine part as well. But seems yes after checking with the IP vendor. So you do need a similar change for CQHCI in cqhci_host_alloc_tdl.

Quoted 57 lines

-----Original Message-----
From: Shawn Lin <[email protected]>
Sent: Tuesday, November 8, 2022 5:15 PM
To: Adrian Hunter <[email protected]>
Cc: [email protected]; linux-mmc <[email protected]>; Jyan Chou [周芷安] <[email protected]>; [email protected]
Subject: Re: Question about EMMC CMDQ HOST CONTROLLER INTERFACE (CQHCI) DRIVER

+ Jisheng Zhang

Quoted 12 lines · Adrian Hunter
Quoted 11 lines · Shawn Lin
Quoted 6 lines · Adrian Hunter
Quoted 5 lines · Jyan Chou [周芷安]

Hello Adrian Hunter,

We are now using the upstream code of EMMC CMDQ HOST CONTROLLER INTERFACE (CQHCI) DRIVER, but we found that the existing driver cannot support the limitation of Synopsys IP.

Synopsys IP has a description on their data book " While using DMA, the host memory data buffer size and start address must not exceed 128 MB".

Synopsys-based SDHCI IP does have a limitation of 128MB boundary. But it has already been solved by upstream driver.

Quoted 6 lines
Quoted 4 lines

FYI:

commit b85c997d2cfefe7d1f706b85ae46e35a50e3131c ("mmc:
sdhci-of-dwcmshc: solve 128MB DMA boundary limitation")

CQHCI has its own DMA descriptors, so maybe a similar change is needed for CQHCI?

I didn't find this limitation in synopsys DW IP databook.

Quoted 13 lines
Quoted 13 lines
Quoted 13 lines
Quoted 7 lines

I am wondering whether there is a method or patch that can fix this boundary limitation. Thanks.
Best Regards,
Jyan Chou

Hello Jyan Chou

I am not clear on what the exact limitation is.  The driver never uses buffers as big as 128 MB. To restrict DMA to low memory addresses a DMA mask can be used.

Quoted 8 lines
Quoted 7 lines
Quoted 7 lines

But perhaps you mean not to cross a 128 MB boundary?

Please cc your questions to the linux kernel mmc mailing list:
[email protected] because others can answer too.

Regards
Adrian

------Please consider the environment before printing this e-mail.

#8 lore raw
Quoted 6 lines · Jyan Chou [周芷安]
Quoted 4 lines

CQHCI has its own DMA descriptors, so maybe a similar change is needed for CQHCI? So you do need a similar change for CQHCI

Quoted 1 line

According to these comments, it is acceptable for us to update a patch to solve the limitation of 128MB boundary ?

We have a patch and it works well on cmdq case. Thanks.

If you have a patch, you can of course submit it.

Quoted 75 lines

-----Original Message-----
From: Shawn Lin <[email protected]>
Sent: Wednesday, November 9, 2022 11:46 AM
To: Jyan Chou [周芷安] <[email protected]>
Cc: [email protected]; linux-mmc <[email protected]>; [email protected]; Adrian Hunter <[email protected]>
Subject: Re: Question about EMMC CMDQ HOST CONTROLLER INTERFACE (CQHCI) DRIVER

Quoted 4 lines · Jyan Chou [周芷安]
Quoted 1 line

CQHCI has its own DMA descriptors, so maybe a similar change is needed for CQHCI?

I didn't find this limitation in synopsys DW IP databook.

Quoted 1 line
Quoted 1 line

I found it on page 84

I see, but it wasn't clear to me if this description on P84 is for CQ engine part as well. But seems yes after checking with the IP vendor. So you do need a similar change for CQHCI in cqhci_host_alloc_tdl.

Quoted 57 lines

-----Original Message-----
From: Shawn Lin <[email protected]>
Sent: Tuesday, November 8, 2022 5:15 PM
To: Adrian Hunter <[email protected]>
Cc: [email protected]; linux-mmc <[email protected]>; Jyan Chou [周芷安] <[email protected]>; [email protected]
Subject: Re: Question about EMMC CMDQ HOST CONTROLLER INTERFACE (CQHCI) DRIVER

+ Jisheng Zhang

Quoted 12 lines · Adrian Hunter
Quoted 11 lines · Shawn Lin
Quoted 6 lines · Adrian Hunter
Quoted 5 lines · Jyan Chou [周芷安]

Hello Adrian Hunter,

We are now using the upstream code of EMMC CMDQ HOST CONTROLLER INTERFACE (CQHCI) DRIVER, but we found that the existing driver cannot support the limitation of Synopsys IP.

Synopsys IP has a description on their data book " While using DMA, the host memory data buffer size and start address must not exceed 128 MB".

Synopsys-based SDHCI IP does have a limitation of 128MB boundary. But it has already been solved by upstream driver.

Quoted 6 lines
Quoted 4 lines

FYI:

commit b85c997d2cfefe7d1f706b85ae46e35a50e3131c ("mmc:
sdhci-of-dwcmshc: solve 128MB DMA boundary limitation")

CQHCI has its own DMA descriptors, so maybe a similar change is needed for CQHCI?

I didn't find this limitation in synopsys DW IP databook.

Quoted 13 lines
Quoted 13 lines
Quoted 13 lines
Quoted 7 lines

I am wondering whether there is a method or patch that can fix this boundary limitation. Thanks.
Best Regards,
Jyan Chou

Hello Jyan Chou

I am not clear on what the exact limitation is.  The driver never uses buffers as big as 128 MB. To restrict DMA to low memory addresses a DMA mask can be used.

Quoted 8 lines
Quoted 7 lines
Quoted 7 lines

But perhaps you mean not to cross a 128 MB boundary?

Please cc your questions to the linux kernel mmc mailing list:
[email protected] because others can answer too.

Regards
Adrian

------Please consider the environment before printing this e-mail.

#9 lore raw
In reply to Shawn Lin

Hello,

But we found that this commit b85c997d2cfefe7d1f706b85ae46e35a50e3131c ("mmc: sdhci-of-dwcmshc: solve 128MB DMA boundary limitation") is supported for sdhci host driver, not for eMMC driver

-----Original Message-----
From: Shawn Lin <[email protected]>
Sent: Tuesday, November 8, 2022 4:28 PM
To: Jyan Chou [周芷安] <[email protected]>
Cc: [email protected]; linux-mmc <[email protected]>; Adrian Hunter <[email protected]>
Subject: Re: Question about EMMC CMDQ HOST CONTROLLER INTERFACE (CQHCI) DRIVER

Quoted 6 lines · Adrian Hunter
Quoted 5 lines · Jyan Chou [周芷安]

Hello Adrian Hunter,

We are now using the upstream code of EMMC CMDQ HOST CONTROLLER INTERFACE (CQHCI) DRIVER, but we found that the existing driver cannot support the limitation of Synopsys IP.

Synopsys IP has a description on their data book " While using DMA, the host memory data buffer size and start address must not exceed 128 MB".

Synopsys-based SDHCI IP does have a limitation of 128MB boundary. But it has already been solved by upstream driver.

FYI:

commit b85c997d2cfefe7d1f706b85ae46e35a50e3131c ("mmc: sdhci-of-dwcmshc:
solve 128MB DMA boundary limitation")

Quoted 11 lines
Quoted 5 lines

I am wondering whether there is a method or patch that can fix this boundary limitation. Thanks.
Best Regards,
Jyan Chou

Hello Jyan Chou

I am not clear on what the exact limitation is. The driver never uses buffers as big as 128 MB. To restrict DMA to low memory addresses a DMA mask can be used.

Quoted 7 lines

But perhaps you mean not to cross a 128 MB boundary?

Please cc your questions to the linux kernel mmc mailing list:
[email protected] because others can answer too.

Regards
Adrian

------Please consider the environment before printing this e-mail.