Skip to contentSkip to conversation

xen/build: fix xen/tools/binfile

PATCH In review Juergen Gross 2 participants 2 messages May 29, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xen/build: fix xen/tools/binfile

xen/tools/binfile contains a bash specific command (let). This leads to build failures on systems not using bash as /bin/sh.

Replace "let SHIFT=$OPTIND-1" by "SHIFT=$((OPTIND-1))".

---
 xen/tools/binfile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
xen/tools/binfile +1 -1
index df0301183f..23099c49bf 100755
@@ -17,7 +17,7 @@ while getopts "ia:" opt; do
         ;;
     esac
 done
-let "SHIFT=$OPTIND-1"
+SHIFT=$((OPTIND-1))
 shift $SHIFT
 
 target=$1
Signature · 1 line
2.26.2
#1 lore raw
Quoted 6 lines · Juergen Gross

xen/tools/binfile contains a bash specific command (let). This leads to build failures on systems not using bash as /bin/sh.

Replace "let SHIFT=$OPTIND-1" by "SHIFT=$((OPTIND-1))".

A/T-by and pushed.  Thanks for the quick turnaround.

~Andrew