Skip to contentSkip to conversation

bnxt: logging cleanups

PATCH In review Stephen Hemminger 3 participants 6 messages Mar 11, 2019 – Mar 15, 2019 Network drivers

lore
Share & tools
lore
#0 lore raw

cover bnxt: logging cleanups

This reduces the logging in this driver and makes it work like others.

Stephen Hemminger (3):
net/bnxt: change PTP message to DEBUG level
net/bnxt: do not double space version message
net/bnxt: use NOTICE as default log level

 drivers/net/bnxt/bnxt_ethdev.c | 4 ++--
 drivers/net/bnxt/bnxt_hwrm.c   | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/3 net/bnxt: change PTP message to DEBUG level

This message doesn't need to be at INFO level, it is a normal situation and only useful for debugging.

---
 drivers/net/bnxt/bnxt_hwrm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/bnxt/bnxt_hwrm.c +1 -1
index 999976054d41..eb5c41ebb0ba 100644
@@ -591,7 +591,7 @@ static int __bnxt_hwrm_func_qcaps(struct bnxt *bp)
 		bp->pf.total_vnics = rte_le_to_cpu_16(resp->max_vnics);
 		if (flags & HWRM_FUNC_QCAPS_OUTPUT_FLAGS_PTP_SUPPORTED) {
 			bp->flags |= BNXT_FLAG_PTP_SUPPORTED;
-			PMD_DRV_LOG(INFO, "PTP SUPPORTED\n");
+			PMD_DRV_LOG(DEBUG, "PTP SUPPORTED\n");
 			HWRM_UNLOCK();
 			bnxt_hwrm_ptp_qcfg(bp);
 		}
Signature · 1 line
2.17.1
#2 lore raw

PATCH 2/3 net/bnxt: do not double space version message

In reply to Stephen Hemminger

The version message is double spaced in the log.

---
 drivers/net/bnxt/bnxt_ethdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/bnxt/bnxt_ethdev.c +1 -1
index 189527207f9a..c5f7cf9cb9ec 100644
@@ -30,7 +30,7 @@
 
 #define DRV_MODULE_NAME		"bnxt"
 static const char bnxt_version[] =
-	"Broadcom NetXtreme driver " DRV_MODULE_NAME "\n";
+	"Broadcom NetXtreme driver " DRV_MODULE_NAME;
 int bnxt_logtype_driver;
 
 #define PCI_VENDOR_ID_BROADCOM 0x14E4
Signature · 1 line
2.17.1
#3 lore raw

PATCH 3/3 net/bnxt: use NOTICE as default log level

In reply to Stephen Hemminger

Make bnxt driver consistent with all other network drivers by setting default to NOTICE for log level.

---
 drivers/net/bnxt/bnxt_ethdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/bnxt/bnxt_ethdev.c +1 -1
index c5f7cf9cb9ec..b5d8128cf3ed 100644
@@ -3571,7 +3571,7 @@ RTE_INIT(bnxt_init_log)
 {
 	bnxt_logtype_driver = rte_log_register("pmd.net.bnxt.driver");
 	if (bnxt_logtype_driver >= 0)
-		rte_log_set_level(bnxt_logtype_driver, RTE_LOG_INFO);
+		rte_log_set_level(bnxt_logtype_driver, RTE_LOG_NOTICE);
 }
 
 RTE_PMD_REGISTER_PCI(net_bnxt, bnxt_rte_pmd);
Signature · 1 line
2.17.1
Acked-by on the v1 series
#4 lore raw
In reply to Stephen Hemminger
Quoted 8 lines · Stephen Hemminger

This reduces the logging in this driver and makes it work like others.

Stephen Hemminger (3):
net/bnxt: change PTP message to DEBUG level
net/bnxt: do not double space version message
net/bnxt: use NOTICE as default log level

Quoted 9 lines
 drivers/net/bnxt/bnxt_ethdev.c | 4 ++--
 drivers/net/bnxt/bnxt_hwrm.c   | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

--
2.17.1

#5 lore raw
Quoted 6 lines · Ajit Khaparde
Quoted 3 lines · Stephen Hemminger

This reduces the logging in this driver and makes it work like others.

Quoted 6 lines
Quoted 5 lines

Stephen Hemminger (3):
net/bnxt: change PTP message to DEBUG level
net/bnxt: do not double space version message
net/bnxt: use NOTICE as default log level

Series applied to dpdk-next-net/master, thanks.