Skip to contentSkip to conversation

Input: synaptics - Enable RMI on HP Envy 13-ad105ng

PATCH In review Yussuf Khalil 2 participants 3 messages Mar 7, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Input: synaptics - Enable RMI on HP Envy 13-ad105ng

This laptop (and perhaps other variants of the same model) reports an SMBus-capable Synaptics touchpad. Everything (including suspend and resume) works fine when RMI is enabled via the kernel command line, so let's add it to the whitelist.

---
 drivers/input/mouse/synaptics.c | 1 +
 1 file changed, 1 insertion(+)
drivers/input/mouse/synaptics.c +1 -0
index 2c666fb34625..4d2036209b45 100644
@@ -186,6 +186,7 @@ static const char * const smbus_pnp_ids[] = {
 	"SYN3052", /* HP EliteBook 840 G4 */
 	"SYN3221", /* HP 15-ay000 */
 	"SYN323d", /* HP Spectre X360 13-w013dx */
+	"SYN3257", /* HP Envy 13-ad105ng */
 	NULL
 };
 
Signature · 1 line
2.24.1
maintainer
#1 lore raw

Hi Yussuf,

Quoted 4 lines · Yussuf Khalil

This laptop (and perhaps other variants of the same model) reports an SMBus-capable Synaptics touchpad. Everything (including suspend and resume) works fine when RMI is enabled via the kernel command line, so let's add it to the whitelist.

Are there issues with the touchpad when it works in the legacy (PS/2) mode? I will be applying your patch, I just need to understand if it needs to go into stable series, or we can just get it into 5.6 and later versions.

Thanks!

Signature · 1 line
Dmitry
#2 lore raw

Hi Dmitry,

I currently don't have access to the device anymore, but apart from missing gesture functionality, it seemed to have some issues with selecting text by clicking and moving the cursor when running in PS/2 mode, so I guess it might be good to push the patch to stable.

Regards
Yussuf Khalil

Quoted 15 lines

Hi Yussuf,

Quoted 4 lines · Yussuf Khalil

This laptop (and perhaps other variants of the same model) reports an SMBus-capable Synaptics touchpad. Everything (including suspend and resume) works fine when RMI is enabled via the kernel command line, so let's add it to the whitelist.

Are there issues with the touchpad when it works in the legacy (PS/2) mode? I will be applying your patch, I just need to understand if it needs to go into stable series, or we can just get it into 5.6 and later versions.

Thanks!