Skip to contentSkip to conversation

leds: trigger: stop exporting trigger_list

PATCH Applied Heiner Kallweit 2 participants 6 messages Jan 31, 2024 – Feb 8, 2024 LED

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 leds: trigger: stop exporting trigger_list

682e98564ffb ("leds: trigger: panic: Simplify led_trigger_set_panic") removed the last external user of variable trigger_list. So stop exporting it.
If in future a need should arise again to access this variable, I think we better add some accessor instead of exporting the variable directly.

---
applies on top of for-leds-next

---
 drivers/leds/led-triggers.c | 2 +-
 drivers/leds/leds.h         | 1 -
 2 files changed, 1 insertion(+), 2 deletions(-)
drivers/leds/led-triggers.c +1 -1
index 71cb0aee5..371000770 100644
@@ -23,7 +23,7 @@
  * Nests outside led_cdev->trigger_lock
  */
 static DECLARE_RWSEM(triggers_list_lock);
-LIST_HEAD(trigger_list);
+static LIST_HEAD(trigger_list);
 
  /* Used by LED Class */
 
drivers/leds/leds.h +0 -1
index 345062cca..1138e2ab8 100644
@@ -30,7 +30,6 @@ ssize_t led_trigger_write(struct file *filp, struct kobject *kobj,
 
 extern struct rw_semaphore leds_list_lock;
 extern struct list_head leds_list;
-extern struct list_head trigger_list;
 extern const char * const led_colors[LED_COLOR_ID_MAX];
 
 #endif	/* __LEDS_H_INCLUDED */
Signature · 1 line
2.43.0
maintainer Applied
#1 lore raw

Re: (subset) [PATCH] leds: trigger: stop exporting trigger_list

Quoted 8 lines · Heiner Kallweit

682e98564ffb ("leds: trigger: panic: Simplify led_trigger_set_panic") removed the last external user of variable trigger_list. So stop exporting it.
If in future a need should arise again to access this variable, I think we better add some accessor instead of exporting the variable directly.

[...]

Applied, thanks!

[1/1] leds: trigger: stop exporting trigger_list

      commit: 6171582edb46889769d994cca81cf0f0fdd8c66f

--
Lee Jones [李琼斯]

maintainer
#2 lore raw

Re: (subset) [PATCH] leds: trigger: stop exporting trigger_list

Quoted 8 lines · Lee Jones
Quoted 7 lines · Heiner Kallweit

682e98564ffb ("leds: trigger: panic: Simplify led_trigger_set_panic") removed the last external user of variable trigger_list. So stop exporting it.
If in future a need should arise again to access this variable, I think we better add some accessor instead of exporting the variable directly.

Quoted 6 lines
Quoted 1 line

[...]

Applied, thanks!

[1/1] leds: trigger: stop exporting trigger_list

      commit: 6171582edb46889769d994cca81cf0f0fdd8c66f

I fixed the chechpatch.pl error for you and changed the subject line to match the format expected by the LED subsystem. Please correct these yourself in subsequent contributions. Thanks.

Signature · 1 line
Lee Jones [李琼斯]
#3 lore raw

Re: (subset) [PATCH] leds: trigger: stop exporting trigger_list

Quoted 12 lines · Lee Jones
Quoted 10 lines · Lee Jones
Quoted 8 lines · Heiner Kallweit

682e98564ffb ("leds: trigger: panic: Simplify led_trigger_set_panic") removed the last external user of variable trigger_list. So stop exporting it.
If in future a need should arise again to access this variable, I think we better add some accessor instead of exporting the variable directly.

[...]

Quoted 9 lines
Quoted 4 lines

Applied, thanks!

[1/1] leds: trigger: stop exporting trigger_list

      commit: 6171582edb46889769d994cca81cf0f0fdd8c66f

I fixed the chechpatch.pl error for you and changed the subject line to match the format expected by the LED subsystem. Please correct these yourself in subsequent contributions. Thanks.

Sure. What was wrong with subject line?

maintainer
#4 lore raw

Re: (subset) [PATCH] leds: trigger: stop exporting trigger_list

Quoted 15 lines · Heiner Kallweit
Quoted 14 lines · Lee Jones
Quoted 12 lines · Lee Jones
Quoted 8 lines · Heiner Kallweit

682e98564ffb ("leds: trigger: panic: Simplify led_trigger_set_panic") removed the last external user of variable trigger_list. So stop exporting it.
If in future a need should arise again to access this variable, I think we better add some accessor instead of exporting the variable directly.

[...]

Applied, thanks!

Quoted 8 lines
Quoted 7 lines
Quoted 2 lines

[1/1] leds: trigger: stop exporting trigger_list

      commit: 6171582edb46889769d994cca81cf0f0fdd8c66f

I fixed the chechpatch.pl error for you and changed the subject line to match the format expected by the LED subsystem. Please correct these yourself in subsequent contributions. Thanks.

Sure. What was wrong with subject line?

Descriptions after the leds: <device>: start with an uppercase char.

It's nitty, but consistency helps me sleep at night! :)

Signature · 1 line
Lee Jones [李琼斯]
#5 lore raw

Re: (subset) [PATCH] leds: trigger: stop exporting trigger_list

Quoted 24 lines · Lee Jones
Quoted 22 lines · Heiner Kallweit
Quoted 21 lines · Lee Jones
Quoted 8 lines · Lee Jones
Quoted 7 lines · Heiner Kallweit

682e98564ffb ("leds: trigger: panic: Simplify led_trigger_set_panic") removed the last external user of variable trigger_list. So stop exporting it.
If in future a need should arise again to access this variable, I think we better add some accessor instead of exporting the variable directly.

Quoted 6 lines
Quoted 1 line

[...]

Applied, thanks!

[1/1] leds: trigger: stop exporting trigger_list

      commit: 6171582edb46889769d994cca81cf0f0fdd8c66f

I fixed the chechpatch.pl error for you and changed the subject line to match the format expected by the LED subsystem. Please correct these yourself in subsequent contributions. Thanks.

Quoted 6 lines
Quoted 1 line

Sure. What was wrong with subject line?

Descriptions after the leds: <device>: start with an uppercase char.

It's nitty, but consistency helps me sleep at night! :)

Ah, ok. Thanks.