Skip to contentSkip to conversation

dt-bindings: rtc: at91: rename rtt bindings file

PATCH In review Alexandre Belloni 3 participants 5 messages Mar 8, 2022 – Mar 23, 2022

Subsystems (3)
lore
Share & tools
lore

Alexandre Belloni

author maintainer
#0 lore raw

PATCH 1/1 dt-bindings: rtc: at91: rename rtt bindings file

atmel,at91sam9-rtc is a confuing name for this file as it is documenting the RTT used as an RTC and not the other regular RTC (atmel,at91rm9200-rtc and atmel,at91sam9x5-rtc)

---
 .../rtc/{atmel,at91sam9-rtc.yaml => atmel,at91sam9260-rtt.yaml}   | 0
 1 file changed, 0 insertions(+), 0 deletions(-)
 rename Documentation/devicetree/bindings/rtc/{atmel,at91sam9-rtc.yaml => atmel,at91sam9260-rtt.yaml} (100%)
Documentation/devicetree/bindings/rtc/atmel,at91sam9260-rtt.yaml renamed from Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.yaml +0 -0
similarity index 100%
rename from Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.yaml
rename to Documentation/devicetree/bindings/rtc/atmel,at91sam9260-rtt.yaml
Signature · 1 line
2.35.1
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 1 line · Alexandre Belloni

atmel,at91sam9-rtc is a confuing name for this file as it is documenting

confusing ^

Quoted 4 lines

the RTT used as an RTC and not the other regular RTC (atmel,at91rm9200-rtc and atmel,at91sam9x5-rtc)

Yes, clearer indeed:

True that this driver's name was confusing from day 1...

Thanks Alexandre, best regards,
Nicolas

Quoted 12 lines
---
  .../rtc/{atmel,at91sam9-rtc.yaml => atmel,at91sam9260-rtt.yaml}   | 0
  1 file changed, 0 insertions(+), 0 deletions(-)

rename Documentation/devicetree/bindings/rtc/{atmel,at91sam9-rtc.yaml => atmel,at91sam9260-rtt.yaml} (100%)

Documentation/devicetree/bindings/rtc/atmel,at91sam9260-rtt.yaml renamed from Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.yaml +0 -1
similarity index 100%
rename from Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.yaml
rename to Documentation/devicetree/bindings/rtc/atmel,at91sam9260-rtt.yaml
--

2.35.1

Signature · 1 line
Nicolas Ferre
#2 lore raw
In reply to Alexandre Belloni

Documentation/devicetree/bindings/rtc/atmel,at91sam9260-rtt.yaml

Quoted 15 lines · Alexandre Belloni

atmel,at91sam9-rtc is a confuing name for this file as it is documenting the RTT used as an RTC and not the other regular RTC (atmel,at91rm9200-rtc and atmel,at91sam9x5-rtc)

---
 .../rtc/{atmel,at91sam9-rtc.yaml => atmel,at91sam9260-rtt.yaml}   | 0
 1 file changed, 0 insertions(+), 0 deletions(-)
 rename Documentation/devicetree/bindings/rtc/{atmel,at91sam9-rtc.yaml => atmel,at91sam9260-rtt.yaml} (100%)
Documentation/devicetree/bindings/rtc/atmel,at91sam9260-rtt.yaml renamed from Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.yaml +0 -0
similarity index 100%
rename from Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.yaml
rename to Documentation/devicetree/bindings/rtc/atmel,at91sam9260-rtt.yaml

Now failing in -next:

./Documentation/devicetree/bindings/rtc/atmel,at91sam9260-rtt.yaml:
$id: relative path/filename doesn't match actual path or filename
expected: http://devicetree.org/schemas/rtc/atmel,at91sam9260-rtt.yaml#

#3 lore raw
Quoted 21 lines · Rob Herring

Documentation/devicetree/bindings/rtc/atmel,at91sam9260-rtt.yaml

Quoted 15 lines · Alexandre Belloni

atmel,at91sam9-rtc is a confuing name for this file as it is documenting the RTT used as an RTC and not the other regular RTC (atmel,at91rm9200-rtc and atmel,at91sam9x5-rtc)

---
 .../rtc/{atmel,at91sam9-rtc.yaml => atmel,at91sam9260-rtt.yaml}   | 0
 1 file changed, 0 insertions(+), 0 deletions(-)
 rename Documentation/devicetree/bindings/rtc/{atmel,at91sam9-rtc.yaml => atmel,at91sam9260-rtt.yaml} (100%)
Documentation/devicetree/bindings/rtc/atmel,at91sam9260-rtt.yaml renamed from Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.yaml +0 -0
similarity index 100%
rename from Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.yaml
rename to Documentation/devicetree/bindings/rtc/atmel,at91sam9260-rtt.yaml

Now failing in -next:

Quoted 3 lines

./Documentation/devicetree/bindings/rtc/atmel,at91sam9260-rtt.yaml:
$id: relative path/filename doesn't match actual path or filename
expected: http://devicetree.org/schemas/rtc/atmel,at91sam9260-rtt.yaml#

Still failing...

Rob

author maintainer
#4 lore raw
Quoted 22 lines · Rob Herring
Quoted 21 lines · Rob Herring

Documentation/devicetree/bindings/rtc/atmel,at91sam9260-rtt.yaml

Quoted 15 lines · Alexandre Belloni

atmel,at91sam9-rtc is a confuing name for this file as it is documenting the RTT used as an RTC and not the other regular RTC (atmel,at91rm9200-rtc and atmel,at91sam9x5-rtc)

---
 .../rtc/{atmel,at91sam9-rtc.yaml => atmel,at91sam9260-rtt.yaml}   | 0
 1 file changed, 0 insertions(+), 0 deletions(-)
 rename Documentation/devicetree/bindings/rtc/{atmel,at91sam9-rtc.yaml => atmel,at91sam9260-rtt.yaml} (100%)
Documentation/devicetree/bindings/rtc/atmel,at91sam9260-rtt.yaml renamed from Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.yaml +0 -0
similarity index 100%
rename from Documentation/devicetree/bindings/rtc/atmel,at91sam9-rtc.yaml
rename to Documentation/devicetree/bindings/rtc/atmel,at91sam9260-rtt.yaml

Now failing in -next:

Quoted 5 lines
Quoted 3 lines

./Documentation/devicetree/bindings/rtc/atmel,at91sam9260-rtt.yaml:
$id: relative path/filename doesn't match actual path or filename
expected: http://devicetree.org/schemas/rtc/atmel,at91sam9260-rtt.yaml#

Still failing...

Sorry, this is fixed now.

Quoted 2 lines

Rob

Signature · 3 lines
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com