thermal: tegra: Fix dereference of pointer tz before it is null checked
Subsystems (3)
PATCH 1/1 thermal: tegra: Fix dereference of pointer tz before it is null checked
Currently pointer tz is dereferenced before it is being null checked leading to a potential null pointer deferernce issue. Fix this by only defererencing it once it has been null checked.
--- drivers/thermal/tegra/soctherm.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-)
drivers/thermal/tegra/soctherm.c +9 -4
@@ -585,14 +585,19 @@ static int tsensor_group_thermtrip_get(struct tegra_soctherm *ts, int id)static int tegra_thermctl_set_trip_temp (struct thermal_zone_device *tz,const struct thermal_trip *trip,int temp) { -struct tegra_thermctl_zone *zone =thermal_zone_device_priv (tz); -struct tegra_soctherm *ts = zone->ts; -const struct tegra_tsensor_group *sg = zone->sg; -struct device *dev = zone->dev; +struct tegra_thermctl_zone *zone; +struct tegra_soctherm *ts; +const struct tegra_tsensor_group *sg; +struct device *dev;if (!tz)return -EINVAL ; + zone =thermal_zone_device_priv (tz); + ts = zone->ts; + sg = zone->sg; + dev = zone->dev; +if (trip->type ==THERMAL_TRIP_CRITICAL ) {/* * If thermtrips property is set in DT,
Signature · 1 line
2.50.0
Quoted 2 lines
Currently pointer tz is dereferenced before it is being null checked leading to a potential null pointer deferernce issue. Fix this by
…
dereference?
Regards,
Markus
Shall I send a V2, or can this be fixed up when it's applied?
Quoted 7 lines · Markus Elfring
Quoted 2 lines
Currently pointer tz is dereferenced before it is being null checked leading to a potential null pointer deferernce issue. Fix this by
…
dereference?Regards,
Markus
Quoted 3 lines · Colin Ian King
Currently pointer tz is dereferenced before it is being null checked leading to a potential null pointer deferernce issue. Fix this by only defererencing it once it has been null checked.
Actually the callback should assume tz is never NULL because the caller does:
ret = tz->ops.set_trip_temp(tz, trip, temp);
So removing the NULL pointer check is safe here.
Quoted 35 lines
Fixes 6fc2e1a5f98f ("thermal/drivers/tegra: Switch to new of API")Signed-off-by Colin Ian King <[email protected]>--- drivers/thermal/tegra/soctherm.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-)drivers/thermal/tegra/soctherm.c +9
-4@@ -585,14 +585,19 @@ static int tsensor_group_thermtrip_get(struct tegra_soctherm *ts, int id)static int tegra_thermctl_set_trip_temp (struct thermal_zone_device *tz,const struct thermal_trip *trip,int temp) { -struct tegra_thermctl_zone *zone =thermal_zone_device_priv (tz); -struct tegra_soctherm *ts = zone->ts; -const struct tegra_tsensor_group *sg = zone->sg; -struct device *dev = zone->dev; +struct tegra_thermctl_zone *zone; +struct tegra_soctherm *ts; +const struct tegra_tsensor_group *sg; +struct device *dev;if (!tz)return -EINVAL ; + zone =thermal_zone_device_priv (tz); + ts = zone->ts; + sg = zone->sg; + dev = zone->dev; +if (trip->type ==THERMAL_TRIP_CRITICAL ) {/* * If thermtrips property is set in DT,
Signature · 5 lines
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog