nvmet-tcp: fix kernel crash if commands allocation fails
Subsystems (2)
PATCH 1/1 nvmet-tcp: fix kernel crash if commands allocation fails
If the commands allocation fails in nvmet_tcp_alloc_cmds() the kernel crashes in nvmet_tcp_release_queue_work() because of a NULL pointer dereference.
nvmet: failed to install queue 0 cntlid 1 ret 6
Unable to handle kernel NULL pointer dereference at
virtual address 0000000000000008Fix the bug by setting queue->nr_cmds to zero in case nvmet_tcp_alloc_cmd() fails.
Signed-off-by Maurizio Lombardi <[email protected]>
--- drivers/nvme/target/tcp.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/nvme/target/tcp.c +3 -1
@@ -2146,8 +2146,10 @@ static u16 nvmet_tcp_install_queue(struct nvmet_sq *sq) } queue->nr_cmds = sq->size *2 ; -if (nvmet_tcp_alloc_cmds (queue)) +if (nvmet_tcp_alloc_cmds (queue)) { + queue->nr_cmds =0 ;return NVME_SC_INTERNAL ; + }return 0 ; }
Signature · 1 line
2.43.5
Jens Axboe
maintainerQuoted 10 lines · Maurizio Lombardi
If the commands allocation fails in
nvmet_tcp_alloc_cmds()the kernel crashes innvmet_tcp_release_queue_work()because of a NULL pointer dereference.nvmet: failed to install queue 0 cntlid 1 ret 6
Unable to handle kernel NULL pointer dereference at virtual address 0000000000000008Fix the bug by setting
queue->nr_cmdsto zero in casenvmet_tcp_alloc_cmd()fails.
Please add an appropriate fixes tag.
Signature · 1 line
Jens Axboe