Skip to contentSkip to conversation

Raspberry PI 4 V3D enablement

PATCH Superseded Peter Robinson 6 participants 22 messages Jun 1, 2022 – Jun 3, 2022

Subsystems (7)

v5 of 6 Superseded Latest is v6 →

lore
Share & tools
lore
#0 lore raw

v5 cover Raspberry PI 4 V3D enablement

This is a follow up from my v4 patchset. The power management pieces have been split out to a separate independent set of patches by Stefan [1]. This version 5 of the DRM patches are independent and given the V3D driver has been upstream for some time the two patches to enable it in defconfigs can be taken at anytime independent of the enablement for the Raspberry Pi 4.

I've tested this using mesa 22.0.x and Wayland/Gnome on Fedora 36, it's more or less stable with basic testing.

Changes since v4:
- Fixes for device tree and bindings
- Split out the power management changes into an independent set
- Rebase to 5.18
- Individual changes in patches

[1] https://www.spinics.net/lists/arm-kernel/msg980342.html

Nicolas Saenz Julienne (1):
arm64: config: Enable DRM_V3D

Peter Robinson (5):
dt-bindings: gpu: v3d: Add BCM2711's compatible
drm/v3d: Get rid of pm code
drm/v3d: Add support for bcm2711
ARM: dts: bcm2711: Enable V3D
ARM: configs: Enable DRM_V3D

 .../devicetree/bindings/gpu/brcm,bcm-v3d.yaml  |  1 +
 arch/arm/boot/dts/bcm2711-rpi.dtsi             |  4 ++++
 arch/arm/boot/dts/bcm2711.dtsi                 | 11 +++++++++++
 arch/arm/configs/bcm2835_defconfig             |  1 +
 arch/arm/configs/multi_v7_defconfig            |  1 +
 arch/arm64/configs/defconfig                   |  1 +
 drivers/gpu/drm/v3d/Kconfig                    |  2 +-
 drivers/gpu/drm/v3d/v3d_debugfs.c              | 18 +-----------------
 drivers/gpu/drm/v3d/v3d_drv.c                  | 12 +-----------
 drivers/gpu/drm/v3d/v3d_gem.c                  | 12 +-----------
 10 files changed, 23 insertions(+), 40 deletions(-)
Signature · 1 line
2.36.1
#1 lore raw

PATCH v5 1/6 dt-bindings: gpu: v3d: Add BCM2711's compatible

BCM2711, Raspberry Pi 4's SoC, contains a V3D core. So add its specific compatible to the bindings.

---
Changes since v5:
- Change compatible to align downstream and othee HW, reorder to suit

 Documentation/devicetree/bindings/gpu/brcm,bcm-v3d.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/gpu/brcm,bcm-v3d.yaml +1 -0
index e6485f7b046f..217c42874f41 100644
@@ -16,6 +16,7 @@ properties:
 
   compatible:
     enum:
+      - brcm,2711-v3d
       - brcm,7268-v3d
       - brcm,7278-v3d
 
Signature · 1 line
2.36.1
maintainer Acked-by on v5 1/6
#3 lore raw

Re: [PATCH v5 1/6] dt-bindings: gpu: v3d: Add BCM2711's compatible

In reply to Peter Robinson
Quoted 12 lines · Peter Robinson

BCM2711, Raspberry Pi 4's SoC, contains a V3D core. So add its specific compatible to the bindings.

---
Changes since v5:
- Change compatible to align downstream and othee HW, reorder to suit

 Documentation/devicetree/bindings/gpu/brcm,bcm-v3d.yaml | 1 +
 1 file changed, 1 insertion(+)
Reviewed-by on v5 1/6
#4 lore raw

Re: [PATCH v5 1/6] dt-bindings: gpu: v3d: Add BCM2711's compatible

In reply to Peter Robinson

Hello Peter,

Quoted 6 lines · Peter Robinson

BCM2711, Raspberry Pi 4's SoC, contains a V3D core. So add its specific compatible to the bindings.

---

Signature · 5 lines
Best regards,

Javier Martinez Canillas
Linux Engineering
Red Hat
#5 lore raw

PATCH v5 2/6 drm/v3d: Get rid of pm code

In reply to Peter Robinson

Runtime PM doesn't seem to work correctly on this driver. On top of that, commit 8b6864e3e138 ("drm/v3d/v3d_drv: Remove unused static variable 'v3d_v3d_pm_ops'") hints that it most likely never did as the driver's PM ops were not hooked-up.

So, in order to support regular operation with V3D on BCM2711 (Raspberry Pi 4), get rid of the PM code. PM will be reinstated once we figure out the underlying issues.

---
Changes since v5:
- Rebase

Changes since v3:
- Minor updates for rebase

 drivers/gpu/drm/v3d/v3d_debugfs.c | 18 +-----------------
 drivers/gpu/drm/v3d/v3d_drv.c     | 11 -----------
 drivers/gpu/drm/v3d/v3d_gem.c     | 12 +-----------
 3 files changed, 2 insertions(+), 39 deletions(-)
drivers/gpu/drm/v3d/v3d_debugfs.c +1 -17
index 29fd13109e43..efbde124c296 100644
@@ -4,7 +4,6 @@
 #include <linux/circ_buf.h>
 #include <linux/ctype.h>
 #include <linux/debugfs.h>
-#include <linux/pm_runtime.h>
 #include <linux/seq_file.h>
 #include <linux/string_helpers.h>
 
@@ -131,11 +130,7 @@ static int v3d_v3d_debugfs_ident(struct seq_file *m, void *unused)
 	struct drm_device *dev = node->minor->dev;
 	struct v3d_dev *v3d = to_v3d_dev(dev);
 	u32 ident0, ident1, ident2, ident3, cores;
-	int ret, core;
-
-	ret = pm_runtime_get_sync(v3d->drm.dev);
-	if (ret < 0)
-		return ret;
+	int core;
 
 	ident0 = V3D_READ(V3D_HUB_IDENT0);
 	ident1 = V3D_READ(V3D_HUB_IDENT1);
@@ -188,9 +183,6 @@ static int v3d_v3d_debugfs_ident(struct seq_file *m, void *unused)
 			   (misccfg & V3D_MISCCFG_OVRTMUOUT) != 0);
 	}
 
-	pm_runtime_mark_last_busy(v3d->drm.dev);
-	pm_runtime_put_autosuspend(v3d->drm.dev);
-
 	return 0;
 }
 
@@ -218,11 +210,6 @@ static int v3d_measure_clock(struct seq_file *m, void *unused)
 	uint32_t cycles;
 	int core = 0;
 	int measure_ms = 1000;
-	int ret;
-
-	ret = pm_runtime_get_sync(v3d->drm.dev);
-	if (ret < 0)
-		return ret;
 
 	if (v3d->ver >= 40) {
 		V3D_CORE_WRITE(core, V3D_V4_PCTR_0_SRC_0_3,
@@ -246,9 +233,6 @@ static int v3d_measure_clock(struct seq_file *m, void *unused)
 		   cycles / (measure_ms * 1000),
 		   (cycles / (measure_ms * 100)) % 10);
 
-	pm_runtime_mark_last_busy(v3d->drm.dev);
-	pm_runtime_put_autosuspend(v3d->drm.dev);
-
 	return 0;
 }
 
drivers/gpu/drm/v3d/v3d_drv.c +0 -11
index 1afcd54fbbd5..56d5f831e48b 100644
@@ -19,7 +19,6 @@
 #include <linux/module.h>
 #include <linux/of_platform.h>
 #include <linux/platform_device.h>
-#include <linux/pm_runtime.h>
 #include <linux/reset.h>
 
 #include <drm/drm_drv.h>
@@ -43,7 +42,6 @@ static int v3d_get_param_ioctl(struct drm_device *dev, void *data,
 {
 	struct v3d_dev *v3d = to_v3d_dev(dev);
 	struct drm_v3d_get_param *args = data;
-	int ret;
 	static const u32 reg_map[] = {
 		[DRM_V3D_PARAM_V3D_UIFCFG] = V3D_HUB_UIFCFG,
 		[DRM_V3D_PARAM_V3D_HUB_IDENT1] = V3D_HUB_IDENT1,
@@ -69,17 +67,12 @@ static int v3d_get_param_ioctl(struct drm_device *dev, void *data,
 		if (args->value != 0)
 			return -EINVAL;
 
-		ret = pm_runtime_get_sync(v3d->drm.dev);
-		if (ret < 0)
-			return ret;
 		if (args->param >= DRM_V3D_PARAM_V3D_CORE0_IDENT0 &&
 		    args->param <= DRM_V3D_PARAM_V3D_CORE0_IDENT2) {
 			args->value = V3D_CORE_READ(0, offset);
 		} else {
 			args->value = V3D_READ(offset);
 		}
-		pm_runtime_mark_last_busy(v3d->drm.dev);
-		pm_runtime_put_autosuspend(v3d->drm.dev);
 		return 0;
 	}
 
@@ -280,10 +273,6 @@ static int v3d_platform_drm_probe(struct platform_device *pdev)
 		return -ENOMEM;
 	}
 
-	pm_runtime_use_autosuspend(dev);
-	pm_runtime_set_autosuspend_delay(dev, 50);
-	pm_runtime_enable(dev);
-
 	ret = v3d_gem_init(drm);
 	if (ret)
 		goto dma_free;
drivers/gpu/drm/v3d/v3d_gem.c +1 -11
index 92bc0faee84f..7026214a09f0 100644
@@ -6,7 +6,6 @@
 #include <linux/io.h>
 #include <linux/module.h>
 #include <linux/platform_device.h>
-#include <linux/pm_runtime.h>
 #include <linux/reset.h>
 #include <linux/sched/signal.h>
 #include <linux/uaccess.h>
@@ -367,9 +366,6 @@ v3d_job_free(struct kref *ref)
 	dma_fence_put(job->irq_fence);
 	dma_fence_put(job->done_fence);
 
-	pm_runtime_mark_last_busy(job->v3d->drm.dev);
-	pm_runtime_put_autosuspend(job->v3d->drm.dev);
-
 	if (job->perfmon)
 		v3d_perfmon_put(job->perfmon);
 
@@ -471,14 +467,10 @@ v3d_job_init(struct v3d_dev *v3d, struct drm_file *file_priv,
 	job->v3d = v3d;
 	job->free = free;
 
-	ret = pm_runtime_get_sync(v3d->drm.dev);
-	if (ret < 0)
-		goto fail;
-
 	ret = drm_sched_job_init(&job->base, &v3d_priv->sched_entity[queue],
 				 v3d_priv);
 	if (ret)
-		goto fail_job;
+		goto fail;
 
 	if (has_multisync) {
 		if (se->in_sync_count && se->wait_stage == queue) {
@@ -509,8 +501,6 @@ v3d_job_init(struct v3d_dev *v3d, struct drm_file *file_priv,
 
 fail_deps:
 	drm_sched_job_cleanup(&job->base);
-fail_job:
-	pm_runtime_put_autosuspend(v3d->drm.dev);
 fail:
 	kfree(*container);
 	*container = NULL;
Signature · 1 line
2.36.1
#6 lore raw

Re: [PATCH v5 2/6] drm/v3d: Get rid of pm code

Quoted 5 lines · Peter Robinson

Runtime PM doesn't seem to work correctly on this driver. On top of that, commit 8b6864e3e138 ("drm/v3d/v3d_drv: Remove unused static variable 'v3d_v3d_pm_ops'") hints that it most likely never did as the driver's PM ops were not hooked-up.

Quoted 7 lines

So, in order to support regular operation with V3D on BCM2711 (Raspberry Pi 4), get rid of the PM code. PM will be reinstated once we figure out the underlying issues.

If I remember right, I had runtime PM working on non-2711 hardware. I never managed to get anyone to help with why 2711's power-on would fail, and rpi just cranked the clock down as low as it would go as the power management solution downstream.

I'm not sure what the right thing to do is, given all that. Just some context.

Reviewed-by on v5 2/6
#7 lore raw

Re: [PATCH v5 2/6] drm/v3d: Get rid of pm code

In reply to Peter Robinson
Quoted 5 lines · Peter Robinson

Runtime PM doesn't seem to work correctly on this driver. On top of that, commit 8b6864e3e138 ("drm/v3d/v3d_drv: Remove unused static variable 'v3d_v3d_pm_ops'") hints that it most likely never did as the driver's PM ops were not hooked-up.

Quoted 7 lines

So, in order to support regular operation with V3D on BCM2711 (Raspberry Pi 4), get rid of the PM code. PM will be reinstated once we figure out the underlying issues.

---

This makes sense to me.

Signature · 5 lines
Best regards,

Javier Martinez Canillas
Linux Engineering
Red Hat
#8 lore raw

Re: [PATCH v5 2/6] drm/v3d: Get rid of pm code

In reply to Peter Robinson
Quoted 5 lines · Peter Robinson

Runtime PM doesn't seem to work correctly on this driver. On top of that, commit 8b6864e3e138 ("drm/v3d/v3d_drv: Remove unused static variable 'v3d_v3d_pm_ops'") hints that it most likely never did as the driver's PM ops were not hooked-up.

Quoted 7 lines

So, in order to support regular operation with V3D on BCM2711 (Raspberry Pi 4), get rid of the PM code. PM will be reinstated once we figure out the underlying issues.

---

Hi Florian, any thoughts on this?
Are brcm,7268-v3d and brcm,7278-v3d using runtime PM downstream?

Nicolas

#9 lore raw

PATCH v5 3/6 drm/v3d: Add support for bcm2711

In reply to Peter Robinson

Add compatible string and Kconfig options for bcm2711.

---
Changes since v5:
- Change compatible to align downstream and othee HW, reorder to suit

 drivers/gpu/drm/v3d/Kconfig   | 2 +-
 drivers/gpu/drm/v3d/v3d_drv.c | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/v3d/Kconfig +1 -1
index e973ec487484..01d91c829107 100644
@@ -1,7 +1,7 @@
 # SPDX-License-Identifier: GPL-2.0-only
 config DRM_V3D
 	tristate "Broadcom V3D 3.x and newer"
-	depends on ARCH_BCM || ARCH_BRCMSTB || COMPILE_TEST
+	depends on ARCH_BCM || ARCH_BRCMSTB || ARCH_BCM2835 || COMPILE_TEST
 	depends on DRM
 	depends on COMMON_CLK
 	depends on MMU
drivers/gpu/drm/v3d/v3d_drv.c +1 -0
index 56d5f831e48b..8c7f910daa28 100644
@@ -191,6 +191,7 @@ static const struct drm_driver v3d_drm_driver = {
 };
 
 static const struct of_device_id v3d_of_match[] = {
+	{ .compatible = "brcm,2711-v3d" },
 	{ .compatible = "brcm,7268-v3d" },
 	{ .compatible = "brcm,7278-v3d" },
 	{},
Signature · 1 line
2.36.1
Reviewed-by on v5 3/6
#10 lore raw

Re: [PATCH v5 3/6] drm/v3d: Add support for bcm2711

[add Melissa]

Am 01.06.22 um 13:02 schrieb Peter Robinson:

Quoted 4 lines

Add compatible string and Kconfig options for bcm2711.

Quoted 33 lines

---
Changes since v5:
- Change compatible to align downstream and othee HW, reorder to suit

  drivers/gpu/drm/v3d/Kconfig   | 2 +-
  drivers/gpu/drm/v3d/v3d_drv.c | 1 +
  2 files changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/v3d/Kconfig +1 -1
index e973ec487484..01d91c829107 100644
@@ -1,7 +1,7 @@
  # SPDX-License-Identifier: GPL-2.0-only
  config DRM_V3D
  	tristate "Broadcom V3D 3.x and newer"
-	depends on ARCH_BCM || ARCH_BRCMSTB || COMPILE_TEST
+	depends on ARCH_BCM || ARCH_BRCMSTB || ARCH_BCM2835 || COMPILE_TEST
  	depends on DRM
  	depends on COMMON_CLK
  	depends on MMU
drivers/gpu/drm/v3d/v3d_drv.c +1 -0
index 56d5f831e48b..8c7f910daa28 100644
@@ -191,6 +191,7 @@ static const struct drm_driver v3d_drm_driver = {
  };
 
  static const struct of_device_id v3d_of_match[] = {
+	{ .compatible = "brcm,2711-v3d" },
  	{ .compatible = "brcm,7268-v3d" },
  	{ .compatible = "brcm,7278-v3d" },
  	{},
Reviewed-by on v5 3/6
#11 lore raw

Re: [PATCH v5 3/6] drm/v3d: Add support for bcm2711

In reply to Peter Robinson
Quoted 5 lines · Peter Robinson

Add compatible string and Kconfig options for bcm2711.

---

I've one small nit though.

[snip]

drivers/gpu/drm/v3d/Kconfig line 4

Quoted 5 lines

# SPDX-License-Identifier: GPL-2.0-only
config DRM_V3D

drivers/gpu/drm/v3d/Kconfig +1 -1
 	tristate "Broadcom V3D 3.x and newer"
-	depends on ARCH_BCM || ARCH_BRCMSTB || COMPILE_TEST
+	depends on ARCH_BCM || ARCH_BRCMSTB || ARCH_BCM2835 || COMPILE_TEST

The help text for this Kconfig symbol currently says:

help
Choose this option if you have a system that has a Broadcom V3D 3.x or newer GPU, such as BCM7268.

Maybe you can add "... as BCM7268 or BCM2711." ?

Signature · 5 lines
Best regards,

Javier Martinez Canillas
Linux Engineering
Red Hat
#12 lore raw

PATCH v5 4/6 ARM: dts: bcm2711: Enable V3D

In reply to Peter Robinson

This adds the entry for V3D for bcm2711 (used in the Raspberry Pi 4) and the associated firmware clock entry.

---
Changes since v5:
- Move the firmware clock to bcm2711-rpi.dtsi

 arch/arm/boot/dts/bcm2711-rpi.dtsi |  4 ++++
 arch/arm/boot/dts/bcm2711.dtsi     | 11 +++++++++++
 2 files changed, 15 insertions(+)
arch/arm/boot/dts/bcm2711-rpi.dtsi +4 -0
index ca266c5d9f9b..98817a6675b9 100644
@@ -69,6 +69,10 @@ blconfig: nvram@0 {
 	};
 };
 
+&v3d {
+	clocks = <&firmware_clocks 5>;
+};
+
 &vchiq {
 	interrupts = <GIC_SPI 34 IRQ_TYPE_LEVEL_HIGH>;
 };
arch/arm/boot/dts/bcm2711.dtsi +11 -0
index 89af57482bc8..177662257b16 100644
@@ -601,6 +601,17 @@ genet_mdio: mdio@e14 {
 				#size-cells = <0x0>;
 			};
 		};
+
+		v3d: gpu@7ec00000 {
+			compatible = "brcm,bcm2711-v3d";
+			reg = <0x0 0x7ec00000 0x4000>,
+			      <0x0 0x7ec04000 0x4000>;
+			reg-names = "hub", "core0";
+
+			power-domains = <&pm BCM2835_POWER_DOMAIN_GRAFX_V3D>;
+			resets = <&pm BCM2835_RESET_V3D>;
+			interrupts = <GIC_SPI 74 IRQ_TYPE_LEVEL_HIGH>;
+		};
 	};
 };
 
Signature · 1 line
2.36.1
#13 lore raw

Re: [PATCH v5 4/6] ARM: dts: bcm2711: Enable V3D

Hi Peter,

Am 01.06.22 um 13:02 schrieb Peter Robinson:

Quoted 33 lines

This adds the entry for V3D for bcm2711 (used in the Raspberry Pi 4) and the associated firmware clock entry.

---
Changes since v5:
- Move the firmware clock to bcm2711-rpi.dtsi

  arch/arm/boot/dts/bcm2711-rpi.dtsi |  4 ++++
  arch/arm/boot/dts/bcm2711.dtsi     | 11 +++++++++++
  2 files changed, 15 insertions(+)
arch/arm/boot/dts/bcm2711-rpi.dtsi +4 -0
index ca266c5d9f9b..98817a6675b9 100644
@@ -69,6 +69,10 @@ blconfig: nvram@0 {
  	};
  };
 
+&v3d {
+	clocks = <&firmware_clocks 5>;
+};
+
  &vchiq {
  	interrupts = <GIC_SPI 34 IRQ_TYPE_LEVEL_HIGH>;
  };
arch/arm/boot/dts/bcm2711.dtsi +0 -0
index 89af57482bc8..177662257b16 100644

arch/arm/boot/dts/bcm2711.dtsi genet_mdio: mdio@e14 { · line 606

Quoted 6 lines
arch/arm/boot/dts/bcm2711.dtsi +3 -0
@@ -601,6 +601,17 @@ genet_mdio: mdio@e14 {
  				#size-cells = <0x0>;
  			};
  		};
+
+		v3d: gpu@7ec00000 {
+			compatible = "brcm,bcm2711-v3d";

unfortunately this doesn't match with patch #3 anymore. Except of this everything looks good here.

Stefan

Quoted 11 lines
arch/arm/boot/dts/bcm2711.dtsi +8 -0
+			reg = <0x0 0x7ec00000 0x4000>,
+			      <0x0 0x7ec04000 0x4000>;
+			reg-names = "hub", "core0";
+
+			power-domains = <&pm BCM2835_POWER_DOMAIN_GRAFX_V3D>;
+			resets = <&pm BCM2835_RESET_V3D>;
+			interrupts = <GIC_SPI 74 IRQ_TYPE_LEVEL_HIGH>;
+		};
  	};
  };
 
#14 lore raw

Re: [PATCH v5 4/6] ARM: dts: bcm2711: Enable V3D

Hi Stefan,

Quoted 35 lines

Am 01.06.22 um 13:02 schrieb Peter Robinson:

Quoted 34 lines

This adds the entry for V3D for bcm2711 (used in the Raspberry Pi 4) and the associated firmware clock entry.

---
Changes since v5:
- Move the firmware clock to bcm2711-rpi.dtsi

  arch/arm/boot/dts/bcm2711-rpi.dtsi |  4 ++++
  arch/arm/boot/dts/bcm2711.dtsi     | 11 +++++++++++
  2 files changed, 15 insertions(+)
arch/arm/boot/dts/bcm2711-rpi.dtsi +4 -0
index ca266c5d9f9b..98817a6675b9 100644
@@ -69,6 +69,10 @@ blconfig: nvram@0 {
      };
  };
 
+&v3d {
+     clocks = <&firmware_clocks 5>;
+};
+
  &vchiq {
      interrupts = <GIC_SPI 34 IRQ_TYPE_LEVEL_HIGH>;
  };
arch/arm/boot/dts/bcm2711.dtsi +0 -0
index 89af57482bc8..177662257b16 100644
@@ -601,6 +601,17 @@ genet_mdio: mdio@e14 {
                              #size-cells = <0x0>;
Quoted 8 lines

arch/arm/boot/dts/bcm2711.dtsi genet_mdio: mdio@e14 { · line 606

Quoted 5 lines
arch/arm/boot/dts/bcm2711.dtsi +3 -0
                      };
              };
+
+             v3d: gpu@7ec00000 {
+                     compatible = "brcm,bcm2711-v3d";

unfortunately this doesn't match with patch #3 anymore. Except of this everything looks good here.

Good catch, have updated locally, I'll send out a new rev tomorrow, will give it a day to see if there's other feedback,

P

Quoted 13 lines

Stefan

Quoted 11 lines
arch/arm/boot/dts/bcm2711.dtsi +8 -0
+                     reg = <0x0 0x7ec00000 0x4000>,
+                           <0x0 0x7ec04000 0x4000>;
+                     reg-names = "hub", "core0";
+
+                     power-domains = <&pm BCM2835_POWER_DOMAIN_GRAFX_V3D>;
+                     resets = <&pm BCM2835_RESET_V3D>;
+                     interrupts = <GIC_SPI 74 IRQ_TYPE_LEVEL_HIGH>;
+             };
      };
  };
 
Reviewed-by on v5 4/6
#15 lore raw

Re: [PATCH v5 4/6] ARM: dts: bcm2711: Enable V3D

In reply to Peter Robinson
Quoted 6 lines · Peter Robinson

This adds the entry for V3D for bcm2711 (used in the Raspberry Pi 4) and the associated firmware clock entry.

---

Once you fix the typo mentioned by Stefan already:

Signature · 5 lines
Best regards,

Javier Martinez Canillas
Linux Engineering
Red Hat
#16 lore raw

PATCH v5 5/6 ARM: configs: Enable DRM_V3D

In reply to Peter Robinson

BCM2711, the SoC used on the Raspberry Pi 4 has a different 3D render GPU IP than its predecessors. Enable it it on multi v7 and bcm2835 configs.

---
Changes since v5:
- Added to bcm2835_defconfig

 arch/arm/configs/bcm2835_defconfig  | 1 +
 arch/arm/configs/multi_v7_defconfig | 1 +
 2 files changed, 2 insertions(+)
arch/arm/configs/bcm2835_defconfig +1 -0
index a9ed79b7f871..9270512c14ea 100644
@@ -106,6 +106,7 @@ CONFIG_REGULATOR_GPIO=y
 CONFIG_MEDIA_SUPPORT=y
 CONFIG_MEDIA_CAMERA_SUPPORT=y
 CONFIG_DRM=y
+CONFIG_DRM_V3D=y
 CONFIG_DRM_VC4=y
 CONFIG_FB_SIMPLE=y
 CONFIG_FRAMEBUFFER_CONSOLE=y
arch/arm/configs/multi_v7_defconfig +1 -0
index d6a6811f0539..e2db5cdc66b7 100644
@@ -731,6 +731,7 @@ CONFIG_DRM_IMX_PARALLEL_DISPLAY=m
 CONFIG_DRM_IMX_TVE=m
 CONFIG_DRM_IMX_LDB=m
 CONFIG_DRM_IMX_HDMI=m
+CONFIG_DRM_V3D=m
 CONFIG_DRM_VC4=m
 CONFIG_DRM_ETNAVIV=m
 CONFIG_DRM_MXSFB=m
Signature · 1 line
2.36.1
Reviewed-by on v5 5/6
#18 lore raw

Re: [PATCH v5 5/6] ARM: configs: Enable DRM_V3D

In reply to Peter Robinson
Quoted 7 lines · Peter Robinson

BCM2711, the SoC used on the Raspberry Pi 4 has a different 3D render GPU IP than its predecessors. Enable it it on multi v7 and bcm2835 configs.

---

Signature · 5 lines
Best regards,

Javier Martinez Canillas
Linux Engineering
Red Hat
#19 lore raw

PATCH v5 6/6 arm64: config: Enable DRM_V3D

In reply to Peter Robinson

From: Nicolas Saenz Julienne <[email protected]>

BCM2711, the SoC used on the Raspberry Pi 4 has a different GPU than its predecessors. Enable it.

---
 arch/arm64/configs/defconfig | 1 +
 1 file changed, 1 insertion(+)
arch/arm64/configs/defconfig +1 -0
index 50aa3d75ab4f..446bac1ef774 100644
@@ -738,6 +738,7 @@ CONFIG_DRM_I2C_ADV7511_AUDIO=y
 CONFIG_DRM_DW_HDMI_AHB_AUDIO=m
 CONFIG_DRM_DW_HDMI_CEC=m
 CONFIG_DRM_IMX_DCSS=m
+CONFIG_DRM_V3D=m
 CONFIG_DRM_VC4=m
 CONFIG_DRM_ETNAVIV=m
 CONFIG_DRM_HISI_HIBMC=m
Signature · 1 line
2.36.1
Reviewed-by on v5 6/6
#21 lore raw

Re: [PATCH v5 6/6] arm64: config: Enable DRM_V3D

In reply to Peter Robinson
Quoted 8 lines · Peter Robinson

From: Nicolas Saenz Julienne <[email protected]>

BCM2711, the SoC used on the Raspberry Pi 4 has a different GPU than its predecessors. Enable it.

---

Signature · 5 lines
Best regards,

Javier Martinez Canillas
Linux Engineering
Red Hat