Skip to contentSkip to conversation

classes-global/insane: Skip sstate creation for do_image_qa

PATCH In review Joshua Watt 3 participants 3 messages Dec 1, 2023

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 classes-global/insane: Skip sstate creation for do_image_qa

do_image_qa doens't produce any actual sstate output, so it should skip the sstate creation (similar to do_image_qa)

[YOCTO #15289]

---
 meta/classes-global/insane.bbclass | 1 +
 1 file changed, 1 insertion(+)
meta/classes-global/insane.bbclass +1 -0
index b78bb6f445d..5ce4216f3e0 100644
@@ -1556,6 +1556,7 @@ python do_recipe_qa() {
 addtask do_recipe_qa before do_fetch do_package_qa do_build
 
 SSTATETASKS += "do_recipe_qa"
+SSTATE_SKIP_CREATION:task-recipe-qa = '1'
 do_recipe_qa[sstate-inputdirs] = ""
 do_recipe_qa[sstate-outputdirs] = ""
 python do_recipe_qa_setscene () {
Signature · 1 line
2.34.1
#1 lore raw

Please see my latest comment in the bug, I don't think recipe_qa is to blame, and it's not going to solve the issue.

Also, we do plan to actually register the outcome of recipe_qa into sstate, that's why there's a placeholder for it

Alex

Quoted 26 lines · Joshua Watt

do_image_qa doens't produce any actual sstate output, so it should skip the sstate creation (similar to do_image_qa)

[YOCTO #15289]

---
 meta/classes-global/insane.bbclass | 1 +
 1 file changed, 1 insertion(+)
meta/classes-global/insane.bbclass +1 -1
index b78bb6f445d..5ce4216f3e0 100644
@@ -1556,6 +1556,7 @@ python do_recipe_qa() {
 addtask do_recipe_qa before do_fetch do_package_qa do_build
 
 SSTATETASKS += "do_recipe_qa"
+SSTATE_SKIP_CREATION:task-recipe-qa = '1'
 do_recipe_qa[sstate-inputdirs] = ""
 do_recipe_qa[sstate-outputdirs] = ""
 python do_recipe_qa_setscene () {
--

2.34.1

#2 lore raw
In reply to Joshua Watt
Quoted 9 lines · Joshua Watt

do_image_qa doens't produce any actual sstate output, so it should skip the sstate creation (similar to do_image_qa)

[YOCTO #15289]

---
 meta/classes-global/insane.bbclass | 1 +
 1 file changed, 1 insertion(+)

The fact it has run and exists is a marker in itself even if there is no content (package_qa is similar) so I'm not convinced this patch is right.

Cheers,

Richard