dt-bindings: eeprom: at24: Fix ST M24C64-D compatible schema
Subsystems (3)
Rob Herring
maintainerPATCH 1/1 dt-bindings: eeprom: at24: Fix ST M24C64-D compatible schema
The schema for the ST M24C64-D compatible string doesn't work. Validation fails as the 'd-wl' suffix is not added to the preceeding schema which defines the entries and vendors. The actual users are incorrect as well because the vendor is listed as Atmel whereas the part is made by ST.
As this part doesn't appear to have multiple vendors, move it to its own entry.
--- Documentation/devicetree/bindings/eeprom/at24.yaml | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)
Documentation/devicetree/bindings/eeprom/at24.yaml +1 -4
@@ -68,14 +68,10 @@ properties: pattern: cs16$ - items: pattern: c32$ - - items: - pattern: c32d-wl$ - items: pattern: cs32$ - items: pattern: c64$ - - items: - pattern: c64d-wl$ - items: pattern: cs64$ - items:
@@ -136,6 +132,7 @@ properties: - renesas,r1ex24128 - samsung,s524ad0xd1 - const: atmel,24c128 + - pattern: '^atmel,24c(32|64)d-wl$' # Actual vendor is st label: description: Descriptive name of the EEPROM.
Signature · 1 line
2.43.0
Quoted 6 lines · Rob Herring
The schema for the ST M24C64-D compatible string doesn't work. Validation fails as the 'd-wl' suffix is not added to the preceeding schema which defines the entries and vendors. The actual users are incorrect as well because the vendor is listed as Atmel whereas the part is made by ST.
Quoted 6 lines
As this part doesn't appear to have multiple vendors, move it to its own entry.
Fixes 0997ff1fc143 ("dt-bindings: at24: add ST M24C64-D Additional Write lockable page")Fixes c761068f484c ("dt-bindings: at24: add ST M24C32-D Additional Write lockable page")Signed-off-by Rob Herring <[email protected]>
For what it is worth:
Quoted 6 lines · Rob Herring
The schema for the ST M24C64-D compatible string doesn't work. Validation fails as the 'd-wl' suffix is not added to the preceeding schema which defines the entries and vendors. The actual users are incorrect as well because the vendor is listed as Atmel whereas the part is made by ST.
Quoted 6 lines
As this part doesn't appear to have multiple vendors, move it to its own entry.
Fixes 0997ff1fc143 ("dt-bindings: at24: add ST M24C64-D Additional Write lockable page")Fixes c761068f484c ("dt-bindings: at24: add ST M24C32-D Additional Write lockable page")Signed-off-by Rob Herring <[email protected]>
Bartosz Golaszewski
AppliedQuoted 45 lines · Rob Herring
The schema for the ST M24C64-D compatible string doesn't work. Validation fails as the 'd-wl' suffix is not added to the preceeding schema which defines the entries and vendors. The actual users are incorrect as well because the vendor is listed as Atmel whereas the part is made by ST.
As this part doesn't appear to have multiple vendors, move it to its own entry.
Fixes 0997ff1fc143 ("dt-bindings: at24: add ST M24C64-D Additional Write lockable page")Fixes c761068f484c ("dt-bindings: at24: add ST M24C32-D Additional Write lockable page")Signed-off-by Rob Herring <[email protected]>--- Documentation/devicetree/bindings/eeprom/at24.yaml | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)Documentation/devicetree/bindings/eeprom/at24.yaml +1
-5@@ -68,14 +68,10 @@ properties: pattern: cs16$ - items: pattern: c32$ - - items: - pattern: c32d-wl$ - items: pattern: cs32$ - items: pattern: c64$ - - items: - pattern: c64d-wl$ - items: pattern: cs64$ - items:@@ -136,6 +132,7 @@ properties: - renesas,r1ex24128 - samsung,s524ad0xd1 - const: atmel,24c128 + - pattern: '^atmel,24c(32|64)d-wl$' # Actual vendor is st label: description: Descriptive name of the EEPROM. --
Quoted 2 lines
2.43.0
Applied, thanks!
Bart