Skip to contentSkip to conversation

soc: ti: add k3 platforms chipid module driver

PATCH Applied Grygorii Strashko 4 participants 8 messages May 12, 2020 – May 29, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

v4 cover soc: ti: add k3 platforms chipid module driver

Hi All,

This series introduces TI K3 Multicore SoC platforms chipid module driver which provides identification support of the TI K3 SoCs (family, revision) and register this information with the SoC bus. It is available under /sys/devices/soc0/ for user space, and can be checked, where needed, in Kernel using soc_device_match().
It is also required for introducing support for new revisions of K3 AM65x/J721E SoCs.

Example J721E:

  # cat /sys/devices/soc0/{machine,family,revision}
  Texas Instruments K3 J721E SoC
  J721E
  SR1.0

Example AM65x:

  # cat /sys/devices/soc0/{machine,family,revision}
  Texas Instruments AM654 Base Board
  AM65X
  SR1.0

Changes in v4:
- convert to platform_driver as suggested by Arnd Bergmann <[email protected]>

Changes in v3:
- add handling of kasprintf() fail

Changes in v2:
- pr_debug() replaced with pr_info() to show SoC info on init
- minor format change
- split series on driver and platform changes
- add Reviewed-by: Lokesh Vutla <[email protected]>

v3: https://lkml.org/lkml/2020/5/8/357
v2: https://lkml.org/lkml/2020/5/5/1193
v1: https://lwn.net/Articles/818577/

Grygorii Strashko (2):
dt-bindings: soc: ti: add binding for k3 platforms chipid module
soc: ti: add k3 platforms chipid module driver

 .../bindings/soc/ti/k3-socinfo.yaml           |  40 +++++
 drivers/soc/ti/Kconfig                        |  10 ++
 drivers/soc/ti/Makefile                       |   1 +
 drivers/soc/ti/k3-socinfo.c                   | 152 ++++++++++++++++++
 4 files changed, 203 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/soc/ti/k3-socinfo.yaml
 create mode 100644 drivers/soc/ti/k3-socinfo.c
Signature · 1 line
2.17.1
#1 lore raw

PATCH v4 1/2 dt-bindings: soc: ti: add binding for k3 platforms chipid module

Add DT binding for Texas Instruments K3 Multicore SoC platforms chipid module which is represented by CTRLMMR_xxx_JTAGID register and contains information about SoC id and revision.

---
 .../bindings/soc/ti/k3-socinfo.yaml           | 40 +++++++++++++++++++
 1 file changed, 40 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/soc/ti/k3-socinfo.yaml
Documentation/devicetree/bindings/soc/ti/k3-socinfo.yaml new file +40 -0
new file mode 100644
index 000000000000..a1a8423b2e2e
@@ -0,0 +1,40 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/soc/ti/k3-socinfo.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Texas Instruments K3 Multicore SoC platforms chipid module
+
+maintainers:
+  - Tero Kristo <[email protected]>
+  - Nishanth Menon <[email protected]>
+
+description: |
+  Texas Instruments (ARM64) K3 Multicore SoC platforms chipid module is
+  represented by CTRLMMR_xxx_JTAGID register which contains information about
+  SoC id and revision.
+
+properties:
+  $nodename:
+    pattern: "^chipid@[0-9a-f]+$"
+
+  compatible:
+    items:
+      - const: ti,am654-chipid
+
+  reg:
+    maxItems: 1
+
+required:
+  - compatible
+  - reg
+
+additionalProperties: false
+
+examples:
+  - |
+    chipid@43000014 {
+        compatible = "ti,am654-chipid";
+        reg = <0x43000014 0x4>;
+    };
Signature · 1 line
2.17.1
maintainer Reviewed-by on v4 1/2
#2 lore raw

Re: [PATCH v4 1/2] dt-bindings: soc: ti: add binding for k3 platforms chipid module

Quoted 4 lines · Grygorii Strashko

Add DT binding for Texas Instruments K3 Multicore SoC platforms chipid module which is represented by CTRLMMR_xxx_JTAGID register and contains information about SoC id and revision.

Quoted 8 lines
---
 .../bindings/soc/ti/k3-socinfo.yaml           | 40 +++++++++++++++++++
 1 file changed, 40 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/soc/ti/k3-socinfo.yaml
#3 lore raw

PATCH v4 2/2 soc: ti: add k3 platforms chipid module driver

In reply to Grygorii Strashko

The Texas Instruments K3 Multicore SoC platforms have chipid module which is represented by CTRLMMR_xxx_JTAGID register and contains information about SoC id and revision.
Bits:
31-28 VARIANT Device variant

  27-12 PARTNO  Part number
  11-1  MFG     Indicates TI as manufacturer (0x17)
  1             Always 1

This patch adds corresponding driver to identify the TI K3 SoC family and revision, and registers this information with the SoC bus. It is available under /sys/devices/soc0/ for user space, and can be checked, where needed, in Kernel using soc_device_match().

Identification is done by:
- checking MFG to be TI ID
- retrieving Device variant (revision)
- retrieving Part number and convert it to the family
- retrieving machine from DT "/model"

Example J721E:

  # cat /sys/devices/soc0/{machine,family,revision}
  Texas Instruments K3 J721E SoC
  J721E
  SR1.0

Example AM65x:

  # cat /sys/devices/soc0/{machine,family,revision}
  Texas Instruments AM654 Base Board
  AM65X
  SR1.0
---
 drivers/soc/ti/Kconfig      |  10 +++
 drivers/soc/ti/Makefile     |   1 +
 drivers/soc/ti/k3-socinfo.c | 152 ++++++++++++++++++++++++++++++++++++
 3 files changed, 163 insertions(+)
 create mode 100644 drivers/soc/ti/k3-socinfo.c
drivers/soc/ti/Kconfig +10 -0
index 4486e055794c..e192fb788836 100644
@@ -91,6 +91,16 @@ config TI_K3_RINGACC
 	  and a consumer. There is one RINGACC module per NAVSS on TI AM65x SoCs
 	  If unsure, say N.
 
+config TI_K3_SOCINFO
+	bool
+	depends on ARCH_K3 || COMPILE_TEST
+	select SOC_BUS
+	select MFD_SYSCON
+	help
+	  Include support for the SoC bus socinfo for the TI K3 Multicore SoC
+	  platforms to provide information about the SoC family and
+	  variant to user space.
+
 endif # SOC_TI
 
 config TI_SCI_INTA_MSI_DOMAIN
drivers/soc/ti/Makefile +1 -0
index bec827937a5f..1110e5c98685 100644
@@ -11,3 +11,4 @@ obj-$(CONFIG_WKUP_M3_IPC)		+= wkup_m3_ipc.o
 obj-$(CONFIG_TI_SCI_PM_DOMAINS)		+= ti_sci_pm_domains.o
 obj-$(CONFIG_TI_SCI_INTA_MSI_DOMAIN)	+= ti_sci_inta_msi.o
 obj-$(CONFIG_TI_K3_RINGACC)		+= k3-ringacc.o
+obj-$(CONFIG_TI_K3_SOCINFO)		+= k3-socinfo.o
drivers/soc/ti/k3-socinfo.c new file +152 -0

152 lines not on this page · raw message

Signature · 1 line
2.17.1
#4 lore raw
In reply to Grygorii Strashko

Hi Santosh,

Quoted 42 lines · Grygorii Strashko

Hi All,

This series introduces TI K3 Multicore SoC platforms chipid module driver which provides identification support of the TI K3 SoCs (family, revision) and register this information with the SoC bus. It is available under /sys/devices/soc0/ for user space, and can be checked, where needed, in Kernel using soc_device_match().
It is also required for introducing support for new revisions of K3 AM65x/J721E SoCs.

Example J721E:

   # cat /sys/devices/soc0/{machine,family,revision}
   Texas Instruments K3 J721E SoC
   J721E
   SR1.0

Example AM65x:

   # cat /sys/devices/soc0/{machine,family,revision}
   Texas Instruments AM654 Base Board
   AM65X
   SR1.0

Changes in v4:
- convert to platform_driver as suggested by Arnd Bergmann <[email protected]>

Changes in v3:
- add handling of kasprintf() fail

Changes in v2:
- pr_debug() replaced with pr_info() to show SoC info on init
- minor format change
- split series on driver and platform changes
- add Reviewed-by: Lokesh Vutla <[email protected]>

v3: https://lkml.org/lkml/2020/5/8/357
v2: https://lkml.org/lkml/2020/5/5/1193
v1: https://lwn.net/Articles/818577/

Grygorii Strashko (2):
dt-bindings: soc: ti: add binding for k3 platforms chipid module
soc: ti: add k3 platforms chipid module driver

Quoted 8 lines
  .../bindings/soc/ti/k3-socinfo.yaml           |  40 +++++
  drivers/soc/ti/Kconfig                        |  10 ++
  drivers/soc/ti/Makefile                       |   1 +
  drivers/soc/ti/k3-socinfo.c                   | 152 ++++++++++++++++++
  4 files changed, 203 insertions(+)

create mode 100644 Documentation/devicetree/bindings/soc/ti/k3-socinfo.yaml create mode 100644 drivers/soc/ti/k3-socinfo.c

Any chances you can pick this up?

Signature · 2 lines
Best regards,
grygorii
#5 lore raw
Quoted 11 lines · Grygorii Strashko
Quoted 8 lines · Grygorii Strashko
  .../bindings/soc/ti/k3-socinfo.yaml           |  40 +++++
  drivers/soc/ti/Kconfig                        |  10 ++
  drivers/soc/ti/Makefile                       |   1 +
  drivers/soc/ti/k3-socinfo.c                   | 152 ++++++++++++++++++
  4 files changed, 203 insertions(+)

create mode 100644 Documentation/devicetree/bindings/soc/ti/k3-socinfo.yaml create mode 100644 drivers/soc/ti/k3-socinfo.c

Quoted 1 line

Any chances you can pick this up?

I merged a version of this driver from Santosh's pull request into the arm/drviers tree yesterday.

Is there something missing?

Arnd

#6 lore raw
Quoted 13 lines · Arnd Bergmann
Quoted 11 lines · Grygorii Strashko
Quoted 8 lines · Grygorii Strashko
   .../bindings/soc/ti/k3-socinfo.yaml           |  40 +++++
   drivers/soc/ti/Kconfig                        |  10 ++
   drivers/soc/ti/Makefile                       |   1 +
   drivers/soc/ti/k3-socinfo.c                   | 152 ++++++++++++++++++
   4 files changed, 203 insertions(+)

create mode 100644 Documentation/devicetree/bindings/soc/ti/k3-socinfo.yaml create mode 100644 drivers/soc/ti/k3-socinfo.c

Quoted 7 lines
Quoted 1 line

Any chances you can pick this up?

I merged a version of this driver from Santosh's pull request into the arm/drviers tree yesterday.

Is there something missing?

Nope. I was going to reply on the thread but missed it.

Regards,
Santosh

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#7 lore raw
Quoted 14 lines · On 29/05/2020 22:19, [email protected] wrote:
Quoted 13 lines · Arnd Bergmann
Quoted 11 lines · Grygorii Strashko
Quoted 8 lines · Grygorii Strashko

   .../bindings/soc/ti/k3-socinfo.yaml           |  40 +++++ drivers/soc/ti/Kconfig                        |  10 ++ drivers/soc/ti/Makefile                       |   1 + drivers/soc/ti/k3-socinfo.c                   | 152 ++++++++++++++++++

   4 files changed, 203 insertions(+)

   create mode 100644 Documentation/devicetree/bindings/soc/ti/k3-socinfo.yaml create mode 100644 drivers/soc/ti/k3-socinfo.c

Quoted 8 lines
Quoted 7 lines
Quoted 1 line

Any chances you can pick this up?

I merged a version of this driver from Santosh's pull request into the arm/drviers tree yesterday.

Is there something missing?

Nope. I was going to reply on the thread but missed it.

Oh. Thanks. I've missed that it was already picked up.

Thanks again.

Signature · 7 lines
Best regards,
grygorii

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel