Skip to contentSkip to conversation

wifi: rtw88: TX QOS Null data the same way as Null data

PATCH In review Bitterblue Smith 2 participants 3 messages Mar 18 – Mar 30 Realtek wireless driver (rtw88)

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 wifi: rtw88: TX QOS Null data the same way as Null data

When filling out the TX descriptor, Null data frames are treated like management frames, but QOS Null data frames are treated like normal data frames. Somehow this causes a problem for the firmware.

When connected to a network in the 2.4 GHz band, wpa_supplicant (or NetworkManager?) triggers a scan every five minutes. During these scans mac80211 transmits many QOS Null frames in quick succession. Because these frames are marked with IEEE80211_TX_CTL_REQ_TX_STATUS, rtw88 asks the firmware to report the TX ACK status for each of these frames. Sometimes the firmware can't process the TX status requests quickly enough, they add up, it only processes some of them, and then marks every subsequent TX status report with the wrong number.

The symptom is that after a while the warning "failed to get tx report from firmware" appears every five minutes.

This problem apparently happens only with the older RTL8723D, RTL8821A, RTL8812A, and probably RTL8703B chips.

Treat QOS Null data frames the same way as Null data frames. This seems to avoid the problem.

Tested with RTL8821AU, RTL8723DU, RTL8811CU, and RTL8812BU.

---
v2:
- Completely different approach: avoid the problem instead of ignoring the effects. v1 was here:
https://lore.kernel.org/linux-wireless/[email protected]/

---
 drivers/net/wireless/realtek/rtw88/tx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/wireless/realtek/rtw88/tx.c +1 -1
index c04ff31d0f1e..e2d288186b30 100644
@@ -424,7 +424,7 @@ void rtw_tx_pkt_info_update(struct rtw_dev *rtwdev,
 		pkt_info->mac_id = rtwvif->mac_id;
 	}
 
-	if (ieee80211_is_mgmt(fc) || ieee80211_is_nullfunc(fc))
+	if (ieee80211_is_mgmt(fc) || ieee80211_is_any_nullfunc(fc))
 		rtw_tx_mgmt_pkt_info_update(rtwdev, pkt_info, sta, skb);
 	else if (ieee80211_is_data(fc))
 		rtw_tx_data_pkt_info_update(rtwdev, pkt_info, sta, skb);
Signature · 1 line
2.53.0
maintainer Acked-by on v2 1/1
#1 lore raw
Quoted 19 lines · Bitterblue Smith

When filling out the TX descriptor, Null data frames are treated like management frames, but QOS Null data frames are treated like normal data frames. Somehow this causes a problem for the firmware.

When connected to a network in the 2.4 GHz band, wpa_supplicant (or NetworkManager?) triggers a scan every five minutes. During these scans mac80211 transmits many QOS Null frames in quick succession. Because these frames are marked with IEEE80211_TX_CTL_REQ_TX_STATUS, rtw88 asks the firmware to report the TX ACK status for each of these frames. Sometimes the firmware can't process the TX status requests quickly enough, they add up, it only processes some of them, and then marks every subsequent TX status report with the wrong number.

The symptom is that after a while the warning "failed to get tx report from firmware" appears every five minutes.

This problem apparently happens only with the older RTL8723D, RTL8821A, RTL8812A, and probably RTL8703B chips.

Quoted 6 lines

Treat QOS Null data frames the same way as Null data frames. This seems to avoid the problem.

Tested with RTL8821AU, RTL8723DU, RTL8811CU, and RTL8812BU.

maintainer
#2 lore raw
In reply to Bitterblue Smith
Quoted 19 lines · Bitterblue Smith

When filling out the TX descriptor, Null data frames are treated like management frames, but QOS Null data frames are treated like normal data frames. Somehow this causes a problem for the firmware.

When connected to a network in the 2.4 GHz band, wpa_supplicant (or NetworkManager?) triggers a scan every five minutes. During these scans mac80211 transmits many QOS Null frames in quick succession. Because these frames are marked with IEEE80211_TX_CTL_REQ_TX_STATUS, rtw88 asks the firmware to report the TX ACK status for each of these frames. Sometimes the firmware can't process the TX status requests quickly enough, they add up, it only processes some of them, and then marks every subsequent TX status report with the wrong number.

The symptom is that after a while the warning "failed to get tx report from firmware" appears every five minutes.

This problem apparently happens only with the older RTL8723D, RTL8821A, RTL8812A, and probably RTL8703B chips.

Quoted 7 lines

Treat QOS Null data frames the same way as Null data frames. This seems to avoid the problem.

Tested with RTL8821AU, RTL8723DU, RTL8811CU, and RTL8812BU.

1 patch(es) applied to rtw-next branch of rtw.git, thanks.

737e980e1298 wifi: rtw88: TX QOS Null data the same way as Null data

---
https://github.com/pkshih/rtw.git