Skip to contentSkip to conversation

32-bit Meson: add missing /chosen/stdout-path

PATCH New Martin Blumenstingl 3 participants 8 messages Oct 28, 2018 – Nov 15, 2018

Subsystems (2)
lore
Share & tools
lore

Martin Blumenstingl

author reviewer
#0 lore raw

cover 32-bit Meson: add missing /chosen/stdout-path

Some boards don't have the /chosen/stdout-path property yet. Support for these boards is far from being complete and I don't have any of those for testing. Whenever someone reports an issue with one of these boards I would like an output with the "earlycon" kernel argument. However, this only works when the board sets the /chosen/stdout-path property.

None of these were tested manually, but since it's the same for all existing (32-bit and 64-bit) boards it's safe to assume that this will work.

Martin Blumenstingl (3):
ARM: dts: meson6: atv1200: add the /chosen/stdout-path property
ARM: dts: meson8: minix-neo-x8: add the /chosen/stdout-path property
ARM: dts: meson8b: mxq: add the /chosen/stdout-path property

 arch/arm/boot/dts/meson6-atv1200.dts      | 4 ++++
 arch/arm/boot/dts/meson8-minix-neo-x8.dts | 4 ++++
 arch/arm/boot/dts/meson8b-mxq.dts         | 4 ++++
 3 files changed, 12 insertions(+)
Signature · 1 line
2.19.1
author reviewer
#1 lore raw

PATCH 1/3 ARM: dts: meson6: atv1200: add the /chosen/stdout-path property

Support for Meson6 SoCs is currently very limited. It's often unclear why such a device does not boot. To debug this the "earlycon" kernel parameter can be used (without any arguments). However, this requires the board to define a /chosen/stdout-path property in it's .dts.

---
 arch/arm/boot/dts/meson6-atv1200.dts | 4 ++++
 1 file changed, 4 insertions(+)
arch/arm/boot/dts/meson6-atv1200.dts +4 -0
index 9444b0d9628f..fc48cff71ddf 100644
@@ -56,6 +56,10 @@
 		serial0 = &uart_AO;
 	};
 
+	chosen {
+		stdout-path = "serial0:115200n8";
+	};
+
 	memory {
 		reg = <0x40000000 0x80000000>;
 	};
Signature · 1 line
2.19.1
#2 lore raw

PATCH 1/3 ARM: dts: meson6: atv1200: add the /chosen/stdout-path property

Quoted 16 lines · Martin Blumenstingl

Support for Meson6 SoCs is currently very limited. It's often unclear why such a device does not boot. To debug this the "earlycon" kernel parameter can be used (without any arguments). However, this requires the board to define a /chosen/stdout-path property in it's .dts.

---
 arch/arm/boot/dts/meson6-atv1200.dts | 4 ++++
 1 file changed, 4 insertions(+)
arch/arm/boot/dts/meson6-atv1200.dts +0 -0
index 9444b0d9628f..fc48cff71ddf 100644

arch/arm/boot/dts/meson6-atv1200.dts line 65

Quoted 10 lines
arch/arm/boot/dts/meson6-atv1200.dts +4 -0
@@ -56,6 +56,10 @@
 		serial0 = &uart_AO;
 	};
 
+	chosen {
+		stdout-path = "serial0:115200n8";
+	};
+
 	memory {
 		reg = <0x40000000 0x80000000>;
 	};
author reviewer
#3 lore raw

PATCH 2/3 ARM: dts: meson8: minix-neo-x8: add the /chosen/stdout-path property

In reply to Martin Blumenstingl

Support for this board is currently very limited. To debug any potential issues on this board the "earlycon" kernel parameter can be used (without any arguments). However, this requires the board to define a /chosen/stdout-path property in it's .dts.

---
 arch/arm/boot/dts/meson8-minix-neo-x8.dts | 4 ++++
 1 file changed, 4 insertions(+)
arch/arm/boot/dts/meson8-minix-neo-x8.dts +4 -0
index 8bceb8d343f6..55fb090a40ef 100644
@@ -52,6 +52,10 @@
 		serial0 = &uart_AO;
 	};
 
+	chosen {
+		stdout-path = "serial0:115200n8";
+	};
+
 	memory {
 		reg = <0x40000000 0x80000000>;
 	};
Signature · 1 line
2.19.1
#4 lore raw

PATCH 2/3 ARM: dts: meson8: minix-neo-x8: add the /chosen/stdout-path property

Quoted 16 lines · Martin Blumenstingl

Support for this board is currently very limited. To debug any potential issues on this board the "earlycon" kernel parameter can be used (without any arguments). However, this requires the board to define a /chosen/stdout-path property in it's .dts.

---
 arch/arm/boot/dts/meson8-minix-neo-x8.dts | 4 ++++
 1 file changed, 4 insertions(+)
arch/arm/boot/dts/meson8-minix-neo-x8.dts +0 -0
index 8bceb8d343f6..55fb090a40ef 100644

arch/arm/boot/dts/meson8-minix-neo-x8.dts line 61

Quoted 10 lines
arch/arm/boot/dts/meson8-minix-neo-x8.dts +4 -0
@@ -52,6 +52,10 @@
 		serial0 = &uart_AO;
 	};
 
+	chosen {
+		stdout-path = "serial0:115200n8";
+	};
+
 	memory {
 		reg = <0x40000000 0x80000000>;
 	};
author reviewer
#5 lore raw

PATCH 3/3 ARM: dts: meson8b: mxq: add the /chosen/stdout-path property

In reply to Martin Blumenstingl

Support for this board is currently very limited. To debug any potential issues on this board the "earlycon" kernel parameter can be used (without any arguments). However, this requires the board to define a /chosen/stdout-path property in it's .dts.

---
 arch/arm/boot/dts/meson8b-mxq.dts | 4 ++++
 1 file changed, 4 insertions(+)
arch/arm/boot/dts/meson8b-mxq.dts +4 -0
index c7fdaeabbe7b..5c9b76af8d42 100644
@@ -55,6 +55,10 @@
 		serial0 = &uart_AO;
 	};
 
+	chosen {
+		stdout-path = "serial0:115200n8";
+	};
+
 	memory {
 		reg = <0x40000000 0x40000000>;
 	};
Signature · 1 line
2.19.1
#6 lore raw

PATCH 3/3 ARM: dts: meson8b: mxq: add the /chosen/stdout-path property

Quoted 16 lines · Martin Blumenstingl

Support for this board is currently very limited. To debug any potential issues on this board the "earlycon" kernel parameter can be used (without any arguments). However, this requires the board to define a /chosen/stdout-path property in it's .dts.

---
 arch/arm/boot/dts/meson8b-mxq.dts | 4 ++++
 1 file changed, 4 insertions(+)
arch/arm/boot/dts/meson8b-mxq.dts +0 -0
index c7fdaeabbe7b..5c9b76af8d42 100644

arch/arm/boot/dts/meson8b-mxq.dts line 64

Quoted 10 lines
arch/arm/boot/dts/meson8b-mxq.dts +4 -0
@@ -55,6 +55,10 @@
 		serial0 = &uart_AO;
 	};
 
+	chosen {
+		stdout-path = "serial0:115200n8";
+	};
+
 	memory {
 		reg = <0x40000000 0x40000000>;
 	};
maintainer Applied
#7 lore raw

cover 32-bit Meson: add missing /chosen/stdout-path

In reply to Martin Blumenstingl
Quoted 10 lines · Martin Blumenstingl

Some boards don't have the /chosen/stdout-path property yet. Support for these boards is far from being complete and I don't have any of those for testing. Whenever someone reports an issue with one of these boards I would like an output with the "earlycon" kernel argument. However, this only works when the board sets the /chosen/stdout-path property.

None of these were tested manually, but since it's the same for all existing (32-bit and 64-bit) boards it's safe to assume that this will work.

Queued for v4.21, with Neil's acks (branch: v4.21/dt)

Kevin