Broken compiling under 2.6.12-rc2 on my machine

Hi there,

I have applied 2.6.12-rc2 patches against 2.6.11 and gone to compile and it fails...

Here is what I have done:
make menuconfig ARCH=um
Added in hostfs, UML networking - daemon (but also tried with these off, no difference)
make linux ARCH=um

Output:

  HOSTCC  usr/gen_init_cpio
  CHK     usr/initramfs_list
  UPD     usr/initramfs_list
  CPIO    usr/initramfs_data.cpio
  GZIP    usr/initramfs_data.cpio.gz
  AS      usr/initramfs_data.o
  LD      usr/built-in.o
  CC      arch/um/kernel/checksum.o
  QUOTE   arch/um/kernel/config.tmp
  QUOTE   arch/um/kernel/config.c

sed: -e expression #4, char 2: Extra characters after command make[1]: *** [arch/um/kernel/config.c] Error 1
make: *** [arch/um/kernel] Error 2

and here is the file arch/um/kernel/.config.tmp.cmd that gets created which I am guessing has the sed error cmd_arch/um/kernel/config.tmp := sed -e 's/"/\\"/g' -e 's/^/"/' -e 's/$$/\\n"/' /home/iam4/linuxsrc/linux-2.6.12-rc2/.config > arch/um/kernel/config.tmp

config.c also is 0 characters length

I can supply any other files needed.
System is Debian Woody, gcc 2.95.4

I don't know much yet about sed or the kernel build process but can look into if nobody else makes sense of this. Just thought it was good to get it out there considering it doesn't compile and rc2 has just come out.

And UML does compile under 2.6.11 with a patch for gcc (which is include in 2.6.12-rc4). Haven't yet tried 2.6.12-rc1 but can do later if this will help.

Ian

-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
_______________________________________________
User-mode-linux-devel mailing list [email protected]
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel

Quoted 3 lines

And UML does compile under 2.6.11 with a patch for gcc (which is include in 2.6.12-rc4). Haven't yet tried 2.6.12-rc1 but can do later if this will help.

I'm confused: what?

Quoted 2 lines · Ian McDonald

Hi there,

I'm trying to track this down and fix it, but mine didn't even get that far, it died with:

CC arch/um/kernel/ptrace.o
arch/um/kernel/ptrace.c: In function `send_sigtrap':
arch/um/kernel/ptrace.c:324: warning: implicit declaration of function `REGS_SP'
arch/um/kernel/ptrace.c:324: error: union has no member named skas' arch/um/kernel/ptrace.c:324: error: invalid lvalue in unary &' arch/um/kernel/ptrace.c:324: warning: implicit declaration of function `REGS_IP'
arch/um/kernel/ptrace.c:324: error: union has no member named skas' arch/um/kernel/ptrace.c:324: error: invalid lvalue in unary &' make[1]: *** [arch/um/kernel/ptrace.o] Error 1

Quoted 4 lines

sed: -e expression #4, char 2: Extra characters after command make[1]: *** [arch/um/kernel/config.c] Error 1
make: *** [arch/um/kernel] Error 2

Quoted 5 lines

and here is the file arch/um/kernel/.config.tmp.cmd that gets created which I am guessing has the sed error cmd_arch/um/kernel/config.tmp := sed -e 's/"/\\"/g' -e 's/^/"/' -e 's/$$/\\n"/' /home/iam4/linuxsrc/linux-2.6.12-rc2/.config > arch/um/kernel/config.tmp

There is no expression #4 in that. It has three expressions (-e arguments) and a filename...

Quoted 1 line

System is Debian Woody,

Quoted 4 lines

I don't know much yet about sed or the kernel build process but can look into if nobody else makes sense of this. Just thought it was good to get it out there considering it doesn't compile and rc2 has just come out.

I know sed. I wrote and maintain the current busybox sed implementation. I just don't know what the build's doing.

Could you send me your .config?

Quoted 1 line

And UML does compile under 2.6.11 with a patch for gcc

Quoted 3 lines

(which is
include in 2.6.12-rc4). Haven't yet tried 2.6.12-rc1 but can do later if this will help.

Quoted 10 lines

Quoted 9 lines

sed: -e expression #4, char 2: Extra characters after command make[1]: *** [arch/um/kernel/config.c] Error 1
make: *** [arch/um/kernel] Error 2

and here is the file arch/um/kernel/.config.tmp.cmd that gets created which I am guessing has the sed error cmd_arch/um/kernel/config.tmp := sed -e 's/"/\\"/g' -e 's/^/"/' -e 's/$$/\\n"/' /home/iam4/linuxsrc/linux-2.6.12-rc2/.config > arch/um/kernel/config.tmp

Quoted 2 lines

There is no expression #4 in that. It has three expressions (-e arguments) and a filename...

Ian, good catch, but you're quoting the wrong .cmd file. config.tmp is built correctly, config.c is not, so you should quote .config.c.cmd.

Anyway, from looking at what you quote, it's identical to the code in arch/um/kernel/Makefile. Quoting the correct code:

quiet_cmd_quote2 = QUOTE $@

cmd_quote2 = sed -e '/CONFIG/{'          \
                  -e 's/"CONFIG"\;/""/'        \
                  -e 'r $(obj)/config.tmp'     \
                  -e 'a""\;'                   \
                  -e '}'                       \
                  $< > $@

As you see, there is a fourth expression, *here*. But it's -e '}'.

This patch went in after 2.6.11, I'm noticing - wow, are releases getting so slow?

Quoted 1 line

Quoted 1 line

System is Debian Woody,

Can you post your sed version? and Rob, can you then test it and fix the code?

Please save the correct config.c currently created and check it for reference.

Quoted 7 lines

Quoted 4 lines

I don't know much yet about sed or the kernel build process but can look into if nobody else makes sense of this. Just thought it was good to get it out there considering it doesn't compile and rc2 has just come out.

I know sed. I wrote and maintain the current busybox sed implementation. I just don't know what the build's doing.

Explained above.

Quoted 1 line

Could you send me your .config?

Quoted 2 lines

Quoted 2 lines

And UML does compile under 2.6.11 with a patch for gcc

The __va_copy fix, right? I'm trying to merge that in 2.6.11.7, it's under review. The only problem is that somebody complains about the fact Linux still supports 2.95. Luckily for you, Linus already shut them off once, so the support won't go away soon.

Quoted 3 lines

Quoted 3 lines

(which is
include in 2.6.12-rc4). Haven't yet tried 2.6.12-rc1 but can do later if this will help.

You mean -rc2, ok.

Quoted 9 lines

As you see, there is a fourth expression, *here*. But it's -e '}'.

This patch went in after 2.6.11, I'm noticing - wow, are releases getting so slow?

Quoted 1 line

Quoted 1 line

System is Debian Woody,

Can you post your sed version? and Rob, can you then test it and fix the code?

GNU sed version 3.02

Quoted 6 lines

Quoted 1 line

Quoted 1 line

And UML does compile under 2.6.11 with a patch for gcc

The __va_copy fix, right? I'm trying to merge that in 2.6.11.7, it's under review. The only problem is that somebody complains about the fact Linux still supports 2.95. Luckily for you, Linus already shut them off once, so the support won't go away soon.

Yes lucky for me as I don't have root access to my box here and can't alter....

Quoted 8 lines

Quoted 5 lines

Quoted 3 lines

Quoted 3 lines

"Rob" == Rob Landley <[email protected]> writes:

System is Debian Woody,

Can you post your sed version? and Rob, can you then test it

and fix the > code?

GNU sed version 3.02

Quoted 8 lines

Quoted 8 lines

Quoted 4 lines

Quoted 2 lines

Quoted 2 lines

"Rob" == Rob Landley <[email protected]> writes:
System is Debian Woody,

Can you post your sed version? and Rob, can you then test it

and fix the > code?

GNU sed version 3.02

Rob> That said, the change I posted earlier would probably make it Rob> work. The question is, do we care? Documentation/Changes Rob> doesn't list a required sed version (even though other things Rob> in the kernel build use it), but perhaps it should.

Well, for Woody users there is always a backports sed - anyone using 2.6 with woody needs at least module-init-tools from backports so one more package won't matter, even though one could be compiling 2.6 on a 2.4 system.

Anyway, from looking at what you quote, it's identical to the code in arch/um/kernel/Makefile. Quoting the correct code:

quiet_cmd_quote2 = QUOTE $@

cmd_quote2 = sed -e '/CONFIG/{'          \
                  -e 's/"CONFIG"\;/""/'        \
                  -e 'r $(obj)/config.tmp'     \
                  -e 'a""\;'                   \
                  -e '}'                       \
                  $< > $@

As you see, there is a fourth expression, *here*. But it's -e '}'.

This patch went in after 2.6.11, I'm noticing - wow, are releases getting so slow?

Quoted 1 line

Quoted 1 line

System is Debian Woody,

Can you post your sed version? and Rob, can you then test it and fix the code? Please save the correct config.c currently created and check it for reference.

Quoted 13 lines · Blaisorblade

Anyway, from looking at what you quote, it's identical to the code in arch/um/kernel/Makefile. Quoting the correct code:

quiet_cmd_quote2 = QUOTE $@

cmd_quote2 = sed -e '/CONFIG/{'          \
                  -e 's/"CONFIG"\;/""/'        \
                  -e 'r $(obj)/config.tmp'     \
                  -e 'a""\;'                   \
                  -e '}'                       \
                  $< > $@

As you see, there is a fourth expression, *here*. But it's -e '}'.

Quoted 8 lines

This patch went in after 2.6.11, I'm noticing - wow, are releases getting so slow?

Quoted 1 line

Quoted 1 line

System is Debian Woody,

Can you post your sed version? and Rob, can you then test it and fix the code? Please save the correct config.c currently created and check it for reference.

I enabled SKAS mode and the build finished. The sed bit didn't break for me:

  CHK     usr/initramfs_list
  QUOTE   arch/um/kernel/config.tmp
  QUOTE   arch/um/kernel/config.c
  CC      arch/um/kernel/config.o

And I'm using knoppix, which is based on debian.

From the error message, it seems to be complaining about the "a" command. If you're using a really really really old version of sed, it might insist on a gratuitous line break before the line to be added. (I know it did back in the 1970's, but I didn't think anything remotely modern had that limitation.) So try splitting the command in half like this:

cmd_quote2 = sed -e '/CONFIG/{'          \
                  -e 's/"CONFIG"\;/""/'        \
                  -e 'r $(obj)/config.tmp'     \
                  -e 'a \'                   \
                  -e '""\;'                  \
                  -e '}'                       \
                  $< > $@

I just tried that here and it behaved the same way as the other version, for me...

Quoted 6 lines

  CHK     usr/initramfs_list
  QUOTE   arch/um/kernel/config.tmp
  QUOTE   arch/um/kernel/config.c
  CC      arch/um/kernel/config.o

And I'm using knoppix, which is based on debian.

But with updated packages (i.e. unstable/testing). If the patch is so little and without downsides, there's no point in not merging it.

Quoted 14 lines

From the error message, it seems to be complaining about the "a" command. If you're using a really really really old version of sed, it might insist on a gratuitous line break before the line to be added. (I know it did back in the 1970's, but I didn't think anything remotely modern had that limitation.) So try splitting the command in half like this:

cmd_quote2 = sed -e '/CONFIG/{'          \
                  -e 's/"CONFIG"\;/""/'        \
                  -e 'r $(obj)/config.tmp'     \
                  -e 'a \'                   \
                  -e '""\;'                  \
                  -e '}'                       \
                  $< > $@

Quoted 2 lines

I just tried that here and it behaved the same way as the other version, for me...

Ok, Rob, finish handling this issue this and email me the patch (with a suitable changelog) when it's ready.

Quoted 10 lines · Blaisorblade

Anyway, from looking at what you quote, it's identical to the code in arch/um/kernel/Makefile. Quoting the correct code:

quiet_cmd_quote2 = QUOTE $@

cmd_quote2 = sed -e '/CONFIG/{'          \
                  -e 's/"CONFIG"\;/""/'        \
                  -e 'r $(obj)/config.tmp'     \
                  -e 'a""\;'                   \
                  -e '}'                       \
                  $< > $@

Quoted 11 lines · Rob Landley

Quoted 10 lines · Blaisorblade

Anyway, from looking at what you quote, it's identical to the code in arch/um/kernel/Makefile. Quoting the correct code:

quiet_cmd_quote2 = QUOTE $@

cmd_quote2 = sed -e '/CONFIG/{'          \
                  -e 's/"CONFIG"\;/""/'        \
                  -e 'r $(obj)/config.tmp'     \
                  -e 'a""\;'                   \
                  -e '}'                       \
                  $< > $@

Btw, can you please explain me why both you and me didn't notice that config.tmp is not needed? Yesterday while at bed I thought to the world "pipe" and achieved enlightenment... Am I missing something?

I'll send the patch, unless I get a NACK.
--
Paolo Giarrusso, aka Blaisorblade
Linux registered user n. 292729
http://www.user-mode-linux.org/~blaisorblade

OK.

Tested this change to arch/um/kernel/Makefile:

cmd_quote2 = sed -e '/CONFIG/{'          \
                 -e 's/"CONFIG"\;/""/'        \
                 -e 'r $(obj)/config.tmp'     \
                 -e 'a \'                   \
                 -e '""\;'                  \
                 -e '}'                       \
                 $< > $@

and can report that it fixes my problems.

I can also report that vacopy patch works (which is also in 2.6.11.7 I notice but I haven't tested yet - I will post a note when I have but that may be next week) and syscall patch works (which is not yet in 2.6.11.x).

Paolo I agree from my angle that this should go forwards as a confirmed patch.

Old versions of sed from 1998 (predating the first release of gcc 2.95, but still in use by debian stable) don't understand the single-line version of the sed append command. Since newer versions of sed still understand the... ahem, "vintage" form of the command, change it to use that.

Signed-off-by Rob Landley <[email protected]>

Acked-by Ian McDonald <[email protected]>

--- linux-2.6.11.old/arch/um/kernel/Makefile 2005-04-08 01:06:15.000000000
-0400

Quoted 9 lines · Rob Landley

Old versions of sed from 1998 (predating the first release of gcc 2.95, but still in use by debian stable) don't understand the single-line version of the sed append command. Since newer versions of sed still understand the... ahem, "vintage" form of the command, change it to use that.

Signed-off-by Rob Landley <[email protected]>

Acked-by Ian McDonald <[email protected]>

Quoted 2 lines

--- linux-2.6.11.old/arch/um/kernel/Makefile 2005-04-08
01:06:15.000000000 -0400

Note that your mailer wrapper the patch (only the first line), the saved file is wrapped like above. And Kmail doesn't mangle inline patches on saving (I've tested it multiple times). If you can't fix this, next time use attachments (with display as inline) with "7bit" encoding (i.e. not encoded).

Quoted 11 lines · Rob Landley

Quoted 10 lines · Blaisorblade

Anyway, from looking at what you quote, it's identical to the code in arch/um/kernel/Makefile. Quoting the correct code:

quiet_cmd_quote2 = QUOTE $@

cmd_quote2 = sed -e '/CONFIG/{'          \
                  -e 's/"CONFIG"\;/""/'        \
                  -e 'r $(obj)/config.tmp'     \
                  -e 'a""\;'                   \
                  -e '}'                       \
                  $< > $@

Btw, can you please explain me why both you and me didn't notice that config.tmp is not needed? Yesterday while at bed I thought to the world "pipe" and achieved enlightenment... Am I missing something?

I'll send the patch, unless I get a NACK.

If you can get the sed "r" command to read from a pipe, by my guest. (I mentioned originally that there was probably a cleaner way to do it, but I wasn't seeing it at the time...)

Quoted 3 lines · Rob Landley

If you can get the sed "r" command to read from a pipe, by my guest. (I mentioned originally that there was probably a cleaner way to do it, but I wasn't seeing it at the time...)

P.S. I terms of mentioning my obligatory "really disgusting solution to an otherwise seemingly impossible problem", I'd like to point to the existence of "/proc/self/fd/0".

But in comparison, the temp file doesn't really look all that bad... :)

Quoted 3 lines

P.S. I terms of mentioning my obligatory "really disgusting solution to an otherwise seemingly impossible problem", I'd like to point to the existence of "/proc/self/fd/0".

I was thinking to it too... but it wouldn't work... ouch, it would! Ok, sed is not reading from stdin but from a file...

Quoted 1 line

But in comparison, the temp file doesn't really look all that bad... :)

Hmm, instead I prefer this rather than the tmp file. However it's not that important, after all.