Skip to contentSkip to conversation

dt-bindings: arm: aspeed: add Inventec starscream-bmc

PATCH In review Chen.PJ 陳柏任 TAO 3 participants 5 messages May 16, 2023 – May 31, 2023

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 dt-bindings: arm: aspeed: add Inventec starscream-bmc

Document the new compatibles used on Inventec starscream-bmc

---
 Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml +1 -0
index 1b585e554791..fb4ce5df2fa0 100644
@@ -82,6 +82,7 @@ properties:
               - ibm,everest-bmc
               - ibm,rainier-bmc
               - ibm,tacoma-bmc
+              - inventec,starscream-bmc
               - inventec,transformer-bmc
               - jabil,rbp-bmc
               - nuvia,dc-scm-bmc
Signature · 1 line
2.25.1
#1 lore raw
Quoted 2 lines · Chen.PJ 陳柏任 TAO

Document the new compatibles used on Inventec starscream-bmc

Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel.

You missed at least DT list (maybe more), so this won't be tested. Please resend and include all necessary entries.

You actually ignored all maintainers...

Best regards,
Krzysztof

#2 lore raw

PATCH 1/1 dt-bindings: arm: aspeed: add Inventec starscream-bmc

In reply to Chen.PJ 陳柏任 TAO

Document the new compatibles used on Inventec starscream-bmc

---
 Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml +1 -0
index 1b585e554791..fb4ce5df2fa0 100644
@@ -82,6 +82,7 @@ properties:
               - ibm,everest-bmc
               - ibm,rainier-bmc
               - ibm,tacoma-bmc
+              - inventec,starscream-bmc
               - inventec,transformer-bmc
               - jabil,rbp-bmc
               - nuvia,dc-scm-bmc
Signature · 1 line
2.25.1
Acked-by on v1 1/1
#3 lore raw
Quoted 4 lines · Chen.PJ ??? TAO

Document the new compatibles used on Inventec starscream-bmc

---

Please always sent such patches together with DTS which introduces the user.

---

This is an automated instruction, just in case, because many review tags are being ignored. If you do not know the process, here is a short explanation:

Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions, under or above your Signed-off-by tag. Tools like b4 can help here. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for acks received on the version they apply.

https://elixir.bootlin.com/linux/v5.17/source/Documentation/process/submitting-patches.rst#L540

Best regards,
Krzysztof

#4 lore raw

PATCH v4 2/2 ARM: dts: aspeed: Adding Inventec Starscream BMC

In reply to Chen.PJ 陳柏任 TAO

Initial introduction of Inventec Starscream x86 family equipped with AST2600 BMC SoC.

---
V3 -> V4:
- Reply with devicetree binding
V2 -> V3:
- Rename the node name to generic.
V1 -> V2:
- Correct License description
- Remove not supported device
- Using openbmc-flash-layout.dtsi
- Correct device format

---
 arch/arm/boot/dts/Makefile                    |   1 +
 .../dts/aspeed-bmc-inventec-starscream.dts    | 485 ++++++++++++++++++
 2 files changed, 486 insertions(+)
 create mode 100644 arch/arm/boot/dts/aspeed-bmc-inventec-starscream.dts
arch/arm/boot/dts/Makefile +1 -0
index eb681903d50b..6a897ff40ff0 100644
@@ -1629,6 +1629,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += \
 	aspeed-bmc-quanta-q71l.dtb \
 	aspeed-bmc-quanta-s6q.dtb \
 	aspeed-bmc-supermicro-x11spi.dtb \
+	aspeed-bmc-inventec-starscream.dtb \
 	aspeed-bmc-inventec-transformers.dtb \
 	aspeed-bmc-tyan-s7106.dtb \
 	aspeed-bmc-tyan-s8036.dtb \
arch/arm/boot/dts/aspeed-bmc-inventec-starscream.dts new file +485 -0

485 lines not on this page · raw message

Signature · 1 line
2.25.1