drm/i915: Allow set context SSEU on platforms after gen 11
Subsystems (2)
PATCH 1/1 drm/i915: Allow set context SSEU on platforms after gen 11
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110559
--- drivers/gpu/drm/i915/gem/i915_gem_context.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/gem/i915_gem_context.c +1 -1
@@ -1310,7 +1310,7 @@ static int set_sseu(struct i915_gem_context *ctx,if (args->size <sizeof (user_sseu))return -EINVAL ; -if (!IS_GEN (i915,11 )) +if (INTEL_GEN (i915) <11 )return -ENODEV ; if (copy_from_user(&user_sseu, u64_to_user_ptr(args->value),
Signature · 6 lines
2.22.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for drm/i915: Allow set context SSEU on platforms after gen 11
== Series Details ==
== Series Details ==
Series: drm/i915: Allow set context SSEU on platforms after gen 11
URL : https://patchwork.freedesktop.org/series/66870/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6917 -> Patchwork_14447
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14447/
Known issues
------------
Here are the changes found in Patchwork_14447 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@debugfs_test@read_all_entries:
- fi-icl-u3: [PASS][1] -> [DMESG-WARN][2] ([fdo#107724]) +1 similar issue
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6917/fi-icl-u3/igt@debugfs_test@read_all_entries.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14447/fi-icl-u3/igt@debugfs_test@read_all_entries.html
* igt@i915_module_load@reload:
- fi-icl-u3: [PASS][3] -> [DMESG-WARN][4] ([fdo#107724] / [fdo#111214])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6917/fi-icl-u3/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14447/fi-icl-u3/igt@[email protected]
* igt@i915_selftest@live_hangcheck:
- fi-icl-u3: [PASS][5] -> [INCOMPLETE][6] ([fdo#107713] / [fdo#108569])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6917/fi-icl-u3/igt@i915_selftest@live_hangcheck.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14447/fi-icl-u3/igt@i915_selftest@live_hangcheck.html
* igt@kms_chamelium@dp-edid-read:
- fi-icl-u2: [PASS][7] -> [FAIL][8] ([fdo#109483] / [fdo#109635 ])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6917/fi-icl-u2/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14447/fi-icl-u2/igt@[email protected]
* igt@kms_frontbuffer_tracking@basic:
- fi-icl-u2: [PASS][9] -> [FAIL][10] ([fdo#103167])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6917/fi-icl-u2/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14447/fi-icl-u2/igt@[email protected]
#### Possible fixes ####
* igt@gem_ctx_create@basic-files:
- {fi-tgl-u}: [INCOMPLETE][11] ([fdo#111735]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6917/fi-tgl-u/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14447/fi-tgl-u/igt@[email protected]
* igt@gem_exec_suspend@basic-s3:
- fi-blb-e6850: [INCOMPLETE][13] ([fdo#107718]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6917/fi-blb-e6850/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14447/fi-blb-e6850/igt@[email protected]
* igt@gem_mmap_gtt@basic-write-no-prefault:
- fi-icl-u3: [DMESG-WARN][15] ([fdo#107724]) -> [PASS][16] +1 similar issue
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6917/fi-icl-u3/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14447/fi-icl-u3/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
[fdo#109483]: https://bugs.freedesktop.org/show_bug.cgi?id=109483
[fdo#109635 ]: https://bugs.freedesktop.org/show_bug.cgi?id=109635
[fdo#111214]: https://bugs.freedesktop.org/show_bug.cgi?id=111214
[fdo#111735]: https://bugs.freedesktop.org/show_bug.cgi?id=111735
Participating hosts (53 -> 47)
------------------------------
Additional (1): fi-bxt-dsi
Missing (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-icl-y fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_6917 -> Patchwork_14447
CI-20190529: 20190529
CI_DRM_6917: 7ca2b123ae999133223b882e3190955897df8b03 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5191: 63e30122cadaf2798ae2bd44a56cee81a27fbc40 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_14447: 807439de93492cd02c3b104effc28780aea605b8 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
807439de9349 drm/i915: Allow set context SSEU on platforms after gen 11
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14447/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: ✓ Fi.CI.BAT: success for drm/i915: Allow set context SSEU on platforms after gen 11
Quoted 114 lines · Patchwork
== Series Details ==
Series: drm/i915: Allow set context SSEU on platforms after gen 11
URL : https://patchwork.freedesktop.org/series/66870/
State : success== Summary ==
CI Bug Log - changes from
CI_DRM_6917->Patchwork_14447
====================================================Summary
-------**SUCCESS**
No regressions found.
External URL:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14447/Known issues
------------Here are the changes found in
Patchwork_14447that come from known
issues:### IGT changes ###
#### Issues hit ####
* igt@debugfs_test@read_all_entries:
- fi-icl-u3: [PASS][1] -> [DMESG-WARN][2] ([fdo#107724])
+1 similar issue
[1]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6917/fi-icl-u3/igt@debugfs_test@read_all_entries.html
[2]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14447/fi-icl-u3/igt@debugfs_test@read_all_entries.html* igt@i915_module_load@reload:
- fi-icl-u3: [PASS][3] -> [DMESG-WARN][4] ([fdo#107724]
/ [fdo#111214])
[3]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6917/fi-icl-u3/igt@[email protected]
[4]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14447/fi-icl-u3/igt@[email protected]* igt@i915_selftest@live_hangcheck:
- fi-icl-u3: [PASS][5] -> [INCOMPLETE][6] ([fdo#107713]
/ [fdo#108569])
[5]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6917/fi-icl-u3/igt@i915_selftest@live_hangcheck.html
[6]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14447/fi-icl-u3/igt@i915_selftest@live_hangcheck.html* igt@kms_chamelium@dp-edid-read:
- fi-icl-u2: [PASS][7] -> [FAIL][8] ([fdo#109483] /
[fdo#109635 ])
[7]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6917/fi-icl-u2/igt@[email protected]
[8]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14447/fi-icl-u2/igt@[email protected]* igt@kms_frontbuffer_tracking@basic:
- fi-icl-u2: [PASS][9] -> [FAIL][10] ([fdo#103167])
[9]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6917/fi-icl-u2/igt@[email protected]
[10]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14447/fi-icl-u2/igt@[email protected]#### Possible fixes ####
* igt@gem_ctx_create@basic-files:
- {fi-tgl-u}: [INCOMPLETE][11] ([fdo#111735]) ->
[PASS][12]
[11]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6917/fi-tgl-u/igt@[email protected]
[12]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14447/fi-tgl-u/igt@[email protected]* igt@gem_exec_suspend@basic-s3:
- fi-blb-e6850: [INCOMPLETE][13] ([fdo#107718]) ->
[PASS][14]
[13]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6917/fi-blb-e6850/igt@[email protected]
[14]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14447/fi-blb-e6850/igt@[email protected]* igt@gem_mmap_gtt@basic-write-no-prefault:
- fi-icl-u3: [DMESG-WARN][15] ([fdo#107724]) ->
[PASS][16] +1 similar issue
[15]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6917/fi-icl-u3/igt@[email protected]
[16]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14447/fi-icl-u3/igt@[email protected]{name}: This element is suppressed. This means it is ignored when
computing
the status of the difference (SUCCESS, WARNING, or
FAILURE).[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
[fdo#109483]: https://bugs.freedesktop.org/show_bug.cgi?id=109483
[fdo#109635 ]: https://bugs.freedesktop.org/show_bug.cgi?id=109635
[fdo#111214]: https://bugs.freedesktop.org/show_bug.cgi?id=111214
[fdo#111735]: https://bugs.freedesktop.org/show_bug.cgi?id=111735
Quoted 6 lines
Participating hosts (53 -> 47)
------------------------------Additional (1): fi-bxt-dsi
Missing (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan
fi-icl-y fi-byt-clapper fi-bdw-samus
Hi Martin,
Is there an easy way to tell if these missing machines are a result of changes made to the patches here vs something else in the test infrastructure?
Thanks,
Stuart
Quoted 19 lines
Build changes
-------------* CI: CI-20190529 -> None
* Linux:CI_DRM_6917->Patchwork_14447CI-20190529: 20190529
CI_DRM_6917:7ca2b123ae999133223b882e3190955897df8b03@git://anongit.freedesktop.org/gfx-ci/linux
IGT_5191:63e30122cadaf2798ae2bd44a56cee81a27fbc40@git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_14447:807439de93492cd02c3b104effc28780aea605b8@git://anongit.freedesktop.org/gfx-ci/linux== Linux commits ==
Quoted 7 lines
807439de9349drm/i915: Allow set context SSEU on platforms after gen 11== Logs ==
For more details see:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14447/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: ✓ Fi.CI.BAT: success for drm/i915: Allow set context SSEU on platforms after gen 11
Quoted 122 lines · Stuart
Quoted 114 lines · Patchwork
== Series Details ==
Series: drm/i915: Allow set context SSEU on platforms after gen 11
URL : https://patchwork.freedesktop.org/series/66870/
State : success== Summary ==
CI Bug Log - changes from
CI_DRM_6917->Patchwork_14447
====================================================Summary
-------**SUCCESS**
No regressions found.
External URL:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14447/Known issues
------------Here are the changes found in
Patchwork_14447that come from known
issues:### IGT changes ###
#### Issues hit ####
* igt@debugfs_test@read_all_entries:
- fi-icl-u3: [PASS][1] -> [DMESG-WARN][2] ([fdo#107724])
+1 similar issue
[1]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6917/fi-icl-u3/igt@debugfs_test@read_all_entries.html
[2]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14447/fi-icl-u3/igt@debugfs_test@read_all_entries.html* igt@i915_module_load@reload:
- fi-icl-u3: [PASS][3] -> [DMESG-WARN][4] ([fdo#107724]
/ [fdo#111214])
[3]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6917/fi-icl-u3/igt@[email protected]
[4]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14447/fi-icl-u3/igt@[email protected]* igt@i915_selftest@live_hangcheck:
- fi-icl-u3: [PASS][5] -> [INCOMPLETE][6] ([fdo#107713]
/ [fdo#108569])
[5]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6917/fi-icl-u3/igt@i915_selftest@live_hangcheck.html
[6]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14447/fi-icl-u3/igt@i915_selftest@live_hangcheck.html* igt@kms_chamelium@dp-edid-read:
- fi-icl-u2: [PASS][7] -> [FAIL][8] ([fdo#109483] /
[fdo#109635 ])
[7]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6917/fi-icl-u2/igt@[email protected]
[8]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14447/fi-icl-u2/igt@[email protected]* igt@kms_frontbuffer_tracking@basic:
- fi-icl-u2: [PASS][9] -> [FAIL][10] ([fdo#103167])
[9]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6917/fi-icl-u2/igt@[email protected]
[10]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14447/fi-icl-u2/igt@[email protected]#### Possible fixes ####
* igt@gem_ctx_create@basic-files:
- {fi-tgl-u}: [INCOMPLETE][11] ([fdo#111735]) ->
[PASS][12]
[11]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6917/fi-tgl-u/igt@[email protected]
[12]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14447/fi-tgl-u/igt@[email protected]* igt@gem_exec_suspend@basic-s3:
- fi-blb-e6850: [INCOMPLETE][13] ([fdo#107718]) ->
[PASS][14]
[13]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6917/fi-blb-e6850/igt@[email protected]
[14]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14447/fi-blb-e6850/igt@[email protected]* igt@gem_mmap_gtt@basic-write-no-prefault:
- fi-icl-u3: [DMESG-WARN][15] ([fdo#107724]) ->
[PASS][16] +1 similar issue
[15]:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6917/fi-icl-u3/igt@[email protected]
[16]:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14447/fi-icl-u3/igt@[email protected]{name}: This element is suppressed. This means it is ignored when
computing
the status of the difference (SUCCESS, WARNING, or
FAILURE).[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
[fdo#109483]: https://bugs.freedesktop.org/show_bug.cgi?id=109483
[fdo#109635 ]: https://bugs.freedesktop.org/show_bug.cgi?id=109635
[fdo#111214]: https://bugs.freedesktop.org/show_bug.cgi?id=111214
[fdo#111735]: https://bugs.freedesktop.org/show_bug.cgi?id=111735Quoted 6 lines
Participating hosts (53 -> 47)
------------------------------Additional (1): fi-bxt-dsi
Missing (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan
fi-icl-y fi-byt-clapper fi-bdw-samus
Quoted 5 lines
Hi Martin,
Is there an easy way to tell if these missing machines are a result of changes made to the patches here vs something else in the test infrastructure?
Thanks for asking!
Sometimes, some machines fail to boot for reasons unrelated to the patch series. We introduced the ci@boot test to be able to tell them apart, but this is WIP (https://bugs.freedesktop.org/show_bug.cgi?id=111208)...
In the mean time, the best you can do is look at the result grid... Sorry!
Martin
Quoted 30 lines
Thanks,
StuartQuoted 26 lines
Build changes
-------------* CI: CI-20190529 -> None
* Linux:CI_DRM_6917->Patchwork_14447CI-20190529: 20190529
CI_DRM_6917:7ca2b123ae999133223b882e3190955897df8b03@git://anongit.freedesktop.org/gfx-ci/linux
IGT_5191:63e30122cadaf2798ae2bd44a56cee81a27fbc40@git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_14447:807439de93492cd02c3b104effc28780aea605b8@git://anongit.freedesktop.org/gfx-ci/linux== Linux commits ==
807439de9349drm/i915: Allow set context SSEU on platforms after gen 11== Logs ==
For more details see:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14447/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 2 lines · Stuart Summers
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110559
What's the planned usage here? TGL HW only supports slice-level power-gating and with only 1 slice on TGL we don't really have a choice of what to program, do we?
Daniele
Quoted 12 lines
Cc Tvrtko Ursulin <[email protected]>Signed-off-by Stuart Summers <[email protected]>--- drivers/gpu/drm/i915/gem/i915_gem_context.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/i915/gem/i915_gem_context.c +0
-0
drivers/gpu/drm/i915/gem/i915_gem_context.c static int set_sseu(struct i915_gem_context *ctx, · line 1316
Quoted 8 lines
drivers/gpu/drm/i915/gem/i915_gem_context.c +1
-1@@ -1310,7 +1310,7 @@ static int set_sseu(struct i915_gem_context *ctx,if (args->size <sizeof (user_sseu))return -EINVAL ; -if (!IS_GEN (i915,11 )) +if (INTEL_GEN (i915) <11 )return -ENODEV ; if (copy_from_user(&user_sseu, u64_to_user_ptr(args->value),
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 9 lines · Daniele Ceraolo Spurio
Quoted 2 lines · Stuart Summers
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110559
What's the planned usage here? TGL HW only supports slice-level power-gating and with only 1 slice on TGL we don't really have a choice
of what to program, do we?
Well, we do claim powergate support on TGL, so I assumed we'd want to enable this path. Maybe I'm missing something though. Had a similar response to Tvrtko.
Thanks,
Stuart
Quoted 19 lines
Daniele
Quoted 16 lines
Cc Tvrtko Ursulin <[email protected]>Signed-off-by Stuart Summers <[email protected]>--- drivers/gpu/drm/i915/gem/i915_gem_context.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/i915/gem/i915_gem_context.c +0
-0@@ -1310,7 +1310,7 @@ static int set_sseu(struct i915_gem_context *ctx, if (args->size < sizeof(user_sseu)) return -EINVAL;
Quoted 6 lines
Quoted 6 lines
drivers/gpu/drm/i915/gem/i915_gem_context.c +1
-1-if (!IS_GEN (i915,11 )) +if (INTEL_GEN (i915) <11 )return -ENODEV ;if (copy_from_user(&user_sseu,
u64_to_user_ptr(args->value),
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 1 line · Stuart Summers
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110559
Unless there was some discussion I missed we can't just turn it on to work around a SKIP in IGT. Feature was deliberately limited to Icelake and even there just to a sub-set of possible configurations.
Regards,
Tvrtko
Quoted 12 lines
Cc Tvrtko Ursulin <[email protected]>Signed-off-by Stuart Summers <[email protected]>--- drivers/gpu/drm/i915/gem/i915_gem_context.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/i915/gem/i915_gem_context.c +0
-0
drivers/gpu/drm/i915/gem/i915_gem_context.c static int set_sseu(struct i915_gem_context *ctx, · line 1316
Quoted 8 lines
drivers/gpu/drm/i915/gem/i915_gem_context.c +1
-1@@ -1310,7 +1310,7 @@ static int set_sseu(struct i915_gem_context *ctx,if (args->size <sizeof (user_sseu))return -EINVAL ; -if (!IS_GEN (i915,11 )) +if (INTEL_GEN (i915) <11 )return -ENODEV ; if (copy_from_user(&user_sseu, u64_to_user_ptr(args->value),
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 8 lines · Tvrtko Ursulin
Quoted 1 line · Stuart Summers
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110559
Unless there was some discussion I missed we can't just turn it on to
work around a SKIP in IGT. Feature was deliberately limited to Icelake
and even there just to a sub-set of possible configurations.
No conversation was missed, or at least none I was a part of. Is there a reason we don't allow this on future platforms?
We do claim powergate support on TGL, so I assumed it would be good to take this path on that platform. Maybe I'm misunderstanding something here though.
Thanks,
Stuart
Quoted 21 lines
Regards,
Tvrtko
Quoted 16 lines
Cc Tvrtko Ursulin <[email protected]>Signed-off-by Stuart Summers <[email protected]>--- drivers/gpu/drm/i915/gem/i915_gem_context.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/i915/gem/i915_gem_context.c +0
-0@@ -1310,7 +1310,7 @@ static int set_sseu(struct i915_gem_context *ctx, if (args->size < sizeof(user_sseu)) return -EINVAL;
Quoted 6 lines
Quoted 6 lines
drivers/gpu/drm/i915/gem/i915_gem_context.c +1
-1-if (!IS_GEN (i915,11 )) +if (INTEL_GEN (i915) <11 )return -ENODEV ;if (copy_from_user(&user_sseu,
u64_to_user_ptr(args->value),
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoting Summers, Stuart (2019-09-20 22:09:46)
Quoted 10 lines · Tvrtko Ursulin
Quoted 8 lines · Stuart Summers
Quoted 1 line
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110559
Unless there was some discussion I missed we can't just turn it on to
work around a SKIP in IGT. Feature was deliberately limited to Icelake
and even there just to a sub-set of possible configurations.
Quoted 6 lines
No conversation was missed, or at least none I was a part of. Is there a reason we don't allow this on future platforms?
We do claim powergate support on TGL, so I assumed it would be good to take this path on that platform. Maybe I'm misunderstanding something here though.
The current interface is purely to work around a silicon issue on icl. It was not developed into a fully reconfigurable sseu interface mostly due to a lack of demonstrable need and a lack of appreciation of the tradeoffs between different system users (along with the claim that this is all meant to be handled by instructions in the command stream...). Another team did try to autoadjust sseu but also did not produce the rationale nor attempt to integrate with the existing code. -Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 22 lines · Chris Wilson
Quoting Summers, Stuart (2019-09-20 22:09:46)
Quoted 15 lines · Tvrtko Ursulin
Quoted 9 lines · Stuart Summers
Quoted 1 line
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110559
Unless there was some discussion I missed we can't just turn it on
to
work around a SKIP in IGT. Feature was deliberately limited to Icelake
and even there just to a sub-set of possible configurations.No conversation was missed, or at least none I was a part of. Is there
a reason we don't allow this on future platforms?Quoted 5 lines
We do claim powergate support on TGL, so I assumed it would be good to
take this path on that platform. Maybe I'm misunderstanding something
here though.
Quoted 10 lines
The current interface is purely to work around a silicon issue on icl.
It was not developed into a fully reconfigurable sseu interface mostly
due to a lack of demonstrable need and a lack of appreciation of the tradeoffs between different system users (along with the claim that this
is all meant to be handled by instructions in the command stream...). Another team did try to autoadjust sseu but also did not produce the rationale nor attempt to integrate with the existing code.
Ok that makes sense then and thanks for the explanations here. Please consider my patch dropped :)
-Stuart
Quoted 1 line
-Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Replying with some more information for benefit of archives.
Quoted 18 lines · Chris Wilson
Quoting Summers, Stuart (2019-09-20 22:09:46)
Quoted 10 lines · Tvrtko Ursulin
Quoted 8 lines · Stuart Summers
Quoted 1 line
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110559
Unless there was some discussion I missed we can't just turn it on to
work around a SKIP in IGT. Feature was deliberately limited to Icelake
and even there just to a sub-set of possible configurations.Quoted 6 lines
No conversation was missed, or at least none I was a part of. Is there a reason we don't allow this on future platforms?
We do claim powergate support on TGL, so I assumed it would be good to take this path on that platform. Maybe I'm misunderstanding something here though.
Quoted 5 lines
The current interface is purely to work around a silicon issue on icl. It was not developed into a fully reconfigurable sseu interface mostly due to a lack of demonstrable need and a lack of appreciation of the tradeoffs between different system users (along with the claim that this is all meant to be handled by instructions in the command stream...).
For the record and from my memory, the demonstrated need pre-gen11 was from the media transcoding side where it benefited performance for some workload types. What wasn't clear was the best strategy of striking a balance between increased cost of context switching (between contexts with different sseu configs) and performance benefit of going with reduced sseu. Again from memory, the best option looked to be a hybrid solution of not re-configuring SSEU on every context switch, but done periodically from an external entity, based on workload types input. As such it did not align completely with the per-context controls.
Quoted 2 lines
Another team did try to autoadjust sseu but also did not produce the rationale nor attempt to integrate with the existing code.
I forgot about this one, wonder what happened there. This was also for pre-gen11 but with demonstrated performance-per-Watt benefit for some 3d workloads on Android. This was known as "Dynamic SSEU".
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.IGT: success for drm/i915: Allow set context SSEU on platforms after gen 11
In reply to Stuart Summers== Series Details ==
== Series Details ==
Series: drm/i915: Allow set context SSEU on platforms after gen 11
URL : https://patchwork.freedesktop.org/series/66870/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6917_full -> Patchwork_14447_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_14447_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_schedule@independent-bsd2:
- shard-iclb: [PASS][1] -> [SKIP][2] ([fdo#109276]) +11 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6917/shard-iclb4/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14447/shard-iclb7/igt@[email protected]
* igt@gem_exec_schedule@preempt-other-chain-bsd:
- shard-iclb: [PASS][3] -> [SKIP][4] ([fdo#111325]) +10 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6917/shard-iclb5/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14447/shard-iclb4/igt@[email protected]
* igt@gem_softpin@noreloc-s3:
- shard-apl: [PASS][5] -> [DMESG-WARN][6] ([fdo#108566]) +1 similar issue
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6917/shard-apl8/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14447/shard-apl3/igt@[email protected]
* igt@i915_pm_rpm@debugfs-read:
- shard-skl: [PASS][7] -> [INCOMPLETE][8] ([fdo#107807])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6917/shard-skl5/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14447/shard-skl4/igt@[email protected]
* igt@kms_cursor_edge_walk@pipe-b-64x64-left-edge:
- shard-apl: [PASS][9] -> [INCOMPLETE][10] ([fdo#103927]) +1 similar issue
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6917/shard-apl2/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14447/shard-apl2/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render:
- shard-iclb: [PASS][11] -> [FAIL][12] ([fdo#103167]) +4 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6917/shard-iclb5/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14447/shard-iclb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [PASS][13] -> [FAIL][14] ([fdo#108145] / [fdo#110403])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6917/shard-skl5/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14447/shard-skl3/igt@[email protected]
* igt@kms_plane_lowres@pipe-a-tiling-y:
- shard-iclb: [PASS][15] -> [FAIL][16] ([fdo#103166])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6917/shard-iclb6/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14447/shard-iclb8/igt@[email protected]
* igt@kms_psr@psr2_basic:
- shard-iclb: [PASS][17] -> [SKIP][18] ([fdo#109441]) +1 similar issue
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6917/shard-iclb2/igt@kms_psr@psr2_basic.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14447/shard-iclb7/igt@kms_psr@psr2_basic.html
* igt@kms_setmode@basic:
- shard-apl: [PASS][19] -> [FAIL][20] ([fdo#99912])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6917/shard-apl4/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14447/shard-apl4/igt@[email protected]
- shard-hsw: [PASS][21] -> [FAIL][22] ([fdo#99912])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6917/shard-hsw5/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14447/shard-hsw1/igt@[email protected]
#### Possible fixes ####
* igt@gem_ctx_isolation@rcs0-s3:
- shard-apl: [DMESG-WARN][23] ([fdo#108566]) -> [PASS][24] +1 similar issue
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6917/shard-apl2/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14447/shard-apl8/igt@[email protected]
* igt@gem_ctx_shared@exec-single-timeline-bsd:
- shard-iclb: [SKIP][25] ([fdo#110841]) -> [PASS][26]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6917/shard-iclb4/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14447/shard-iclb7/igt@[email protected]
* igt@gem_exec_balancer@smoke:
- shard-iclb: [SKIP][27] ([fdo#110854]) -> [PASS][28]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6917/shard-iclb5/igt@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14447/shard-iclb4/igt@[email protected]
* igt@gem_exec_schedule@out-order-bsd:
- shard-iclb: [SKIP][29] ([fdo#111325]) -> [PASS][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6917/shard-iclb1/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14447/shard-iclb8/igt@[email protected]
* igt@gem_mmap_gtt@hang:
- shard-iclb: [FAIL][31] ([fdo#109677]) -> [PASS][32]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6917/shard-iclb1/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14447/shard-iclb8/igt@[email protected]
* igt@kms_atomic_interruptible@atomic-setmode:
- shard-apl: [INCOMPLETE][33] ([fdo#103927]) -> [PASS][34]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6917/shard-apl6/igt@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14447/shard-apl3/igt@[email protected]
* igt@kms_flip@flip-vs-modeset-interruptible:
- shard-iclb: [INCOMPLETE][35] ([fdo#107713]) -> [PASS][36]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6917/shard-iclb7/igt@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14447/shard-iclb3/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-render:
- shard-iclb: [FAIL][37] ([fdo#103167]) -> [PASS][38] +1 similar issue
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6917/shard-iclb8/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-render.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14447/shard-iclb7/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-render.html
* igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-indfb-draw-mmap-gtt:
- shard-iclb: [INCOMPLETE][39] ([fdo#106978] / [fdo#107713]) -> [PASS][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6917/shard-iclb7/igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-indfb-draw-mmap-gtt.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14447/shard-iclb6/igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-indfb-draw-mmap-gtt.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- shard-skl: [INCOMPLETE][41] ([fdo#104108]) -> [PASS][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6917/shard-skl2/igt@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14447/shard-skl5/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
- shard-skl: [FAIL][43] ([fdo#108145] / [fdo#110403]) -> [PASS][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6917/shard-skl1/igt@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14447/shard-skl2/igt@[email protected]
* igt@kms_psr2_su@frontbuffer:
- shard-iclb: [SKIP][45] ([fdo#109642] / [fdo#111068]) -> [PASS][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6917/shard-iclb5/igt@[email protected]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14447/shard-iclb2/igt@[email protected]
* igt@kms_psr@psr2_primary_mmap_cpu:
- shard-iclb: [SKIP][47] ([fdo#109441]) -> [PASS][48] +3 similar issues
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6917/shard-iclb5/igt@kms_psr@psr2_primary_mmap_cpu.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14447/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html
* igt@perf_pmu@busy-double-start-bcs0:
- shard-skl: [FAIL][49] -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6917/shard-skl7/igt@[email protected]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14447/shard-skl10/igt@[email protected]
* igt@prime_busy@hang-bsd2:
- shard-iclb: [SKIP][51] ([fdo#109276]) -> [PASS][52] +18 similar issues
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6917/shard-iclb5/igt@[email protected]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14447/shard-iclb2/igt@[email protected]
* igt@tools_test@tools_test:
- shard-skl: [SKIP][53] ([fdo#109271]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6917/shard-skl3/igt@tools_test@tools_test.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14447/shard-skl9/igt@tools_test@tools_test.html
#### Warnings ####
* igt@gem_ctx_isolation@vcs1-nonpriv:
- shard-iclb: [SKIP][55] ([fdo#109276]) -> [FAIL][56] ([fdo#111329])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6917/shard-iclb7/igt@[email protected]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14447/shard-iclb1/igt@[email protected]
* igt@gem_mocs_settings@mocs-settings-bsd2:
- shard-iclb: [SKIP][57] ([fdo#109276]) -> [FAIL][58] ([fdo#111330]) +1 similar issue
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6917/shard-iclb5/igt@[email protected]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14447/shard-iclb2/igt@[email protected]
* igt@kms_dp_dsc@basic-dsc-enable-edp:
- shard-iclb: [SKIP][59] ([fdo#109349]) -> [DMESG-WARN][60] ([fdo#107724])
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6917/shard-iclb5/igt@[email protected]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14447/shard-iclb2/igt@[email protected]
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
[fdo#106978]: https://bugs.freedesktop.org/show_bug.cgi?id=106978
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#107807]: https://bugs.freedesktop.org/show_bug.cgi?id=107807
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109349]: https://bugs.freedesktop.org/show_bug.cgi?id=109349
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#109677]: https://bugs.freedesktop.org/show_bug.cgi?id=109677
[fdo#110403]: https://bugs.freedesktop.org/show_bug.cgi?id=110403
[fdo#110841]: https://bugs.freedesktop.org/show_bug.cgi?id=110841
[fdo#110854]: https://bugs.freedesktop.org/show_bug.cgi?id=110854
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111325]: https://bugs.freedesktop.org/show_bug.cgi?id=111325
[fdo#111329]: https://bugs.freedesktop.org/show_bug.cgi?id=111329
[fdo#111330]: https://bugs.freedesktop.org/show_bug.cgi?id=111330
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
Participating hosts (10 -> 10)
------------------------------
No changes in participating hosts
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_6917 -> Patchwork_14447
CI-20190529: 20190529
CI_DRM_6917: 7ca2b123ae999133223b882e3190955897df8b03 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5191: 63e30122cadaf2798ae2bd44a56cee81a27fbc40 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_14447: 807439de93492cd02c3b104effc28780aea605b8 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14447/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx