Skip to contentSkip to conversation

dt-bindings: net: dsa: brcm,sf2: Drop unneeded "#address-cells/#size-cells"

PATCH Applied Rob Herring 5 participants 5 messages Apr 4, 2023 – Apr 6, 2023

Subsystems (4)
lore
Share & tools
lore

Rob Herring

author maintainer
#0 lore raw

PATCH 1/1 dt-bindings: net: dsa: brcm,sf2: Drop unneeded "#address-cells/#size-cells"

There's no need for "#address-cells/#size-cells" in the brcm,sf2 node as no immediate child nodes have an address. What was probably intended was to put them in the 'ports' node, but that's not necessary as that is covered by ethernet-switch.yaml via dsa.yaml.

---
 .../devicetree/bindings/net/dsa/brcm,sf2.yaml          | 10 ----------
 1 file changed, 10 deletions(-)
Documentation/devicetree/bindings/net/dsa/brcm,sf2.yaml +0 -10
index eed16e216fb6..72623cfc8c2d 100644
@@ -76,12 +76,6 @@ properties:
       supports reporting the number of packets in-flight in a switch queue
     type: boolean
 
-  "#address-cells":
-    const: 1
-
-  "#size-cells":
-    const: 0
-
   ports:
     type: object
 
@@ -99,8 +93,6 @@ properties:
 required:
   - reg
   - interrupts
-  - "#address-cells"
-  - "#size-cells"
 
 allOf:
   - $ref: "dsa.yaml#"
@@ -145,8 +137,6 @@ examples:
   - |
     switch@f0b00000 {
             compatible = "brcm,bcm7445-switch-v4.0";
-            #address-cells = <1>;
-            #size-cells = <0>;
             reg = <0xf0b00000 0x40000>,
                   <0xf0b40000 0x110>,
                   <0xf0b40340 0x30>,
Signature · 1 line
2.39.2
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 7 lines · Rob Herring

There's no need for "#address-cells/#size-cells" in the brcm,sf2 node as no immediate child nodes have an address. What was probably intended was to put them in the 'ports' node, but that's not necessary as that is covered by ethernet-switch.yaml via dsa.yaml.

---

Reviewed-by on v1 1/1
#2 lore raw
In reply to Rob Herring
Quoted 6 lines · Rob Herring

There's no need for "#address-cells/#size-cells" in the brcm,sf2 node as no immediate child nodes have an address. What was probably intended was to put them in the 'ports' node, but that's not necessary as that is covered by ethernet-switch.yaml via dsa.yaml.

Signature · 1 line
Florian
maintainer
#3 lore raw
In reply to Rob Herring
Quoted 4 lines · On Tue, 4 Apr 2023 15:41:52 -0500 Rob Herring wrote:

There's no need for "#address-cells/#size-cells" in the brcm,sf2 node as no immediate child nodes have an address. What was probably intended was to put them in the 'ports' node, but that's not necessary as that is covered by ethernet-switch.yaml via dsa.yaml.

There was an application fuzz on this one, FWIW.
Hope I'm not messing up...

#4 lore raw
In reply to Rob Herring
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:

Hello:

This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:

Quoted 8 lines · On Tue, 4 Apr 2023 15:41:52 -0500 you wrote:

There's no need for "#address-cells/#size-cells" in the brcm,sf2 node as no immediate child nodes have an address. What was probably intended was to put them in the 'ports' node, but that's not necessary as that is covered by ethernet-switch.yaml via dsa.yaml.

[...]

Here is the summary with links:
- dt-bindings: net: dsa: brcm,sf2: Drop unneeded "#address-cells/#size-cells"

    https://git.kernel.org/netdev/net-next/c/f03789766905

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html