Skip to contentSkip to conversation

ARM: davinci: driver-model improvements

PATCH RESEND New Bartosz Golaszewski 6 participants 42 messages Jul 29, 2019 – Nov 13, 2019

Subsystems (5)
lore
Share & tools
lore
#0 lore raw

v2 cover ARM: davinci: driver-model improvements

From: Bartosz Golaszewski <[email protected]>

NOTE: emac conversion is already upstream, so dropped it from this series. No other changes.

The following series contains all the patches for davinci that have been sent to the mailing list recently rebased on top of v2019.07 and retested on da850-lcdk and da850-evm. I collected all the review and test tags too.

Patches 1-4 fix build warnings due to legacy interfaces usage. Patches 5-8 add support for driver model to the davinci NAND driver. Patches 9-12 enable driver-model support in SPL for davinci. Last patch enables the driver model for NAND in SPL.

v1 -> v2:
- fixed a build error on da850_am18xx due to missing CONFIG_DM_ETH=y

Bartosz Golaszewski (13):
davinci: remove CONFIG_DM_I2C_COMPAT from defconfigs
sandbox: remove CONFIG_DM_I2C_COMPAT from defconfigs
i2c: remove i2c driver-model compatibility layer
omapl138_lcdk_defconfig: don't build support for SPI
nand: davinci: make davinci_nand_init() static
nand: davinci: add support for driver model
davinci: omapl138-lcdk: enable driver model for NAND
davinci: da850-evm: enable driver model for NAND
davinci: omapl138-lcdk: enable SPL_SYS_MALLOC_SIMPLE
davinci: omapl138-lcdk: enable CONFIG_USE_TINY_PRINTF
davinci: omapl138-lcdk: remove unneeded includes
davinci: omapl138-lcdk: enable driver-model in SPL
configs: omapl138_lcdk: enable NAND self-init in SPL

 Makefile                                      |   7 -
 arch/arm/dts/da850-evm-u-boot.dtsi            |   4 +
 arch/arm/dts/da850-lcdk-u-boot.dtsi           |   4 +
 arch/arm/include/asm/ti-common/davinci_nand.h |   2 -
 board/davinci/da8xxevm/omapl138_lcdk.c        |  18 ++-
 configs/da850_am18xxevm_defconfig             |   1 -
 configs/da850evm_defconfig                    |   1 +
 configs/da850evm_direct_nor_defconfig         |   1 +
 configs/da850evm_nand_defconfig               |   1 +
 configs/omapl138_lcdk_defconfig               |  15 +-
 configs/sandbox64_defconfig                   |   1 -
 configs/sandbox_defconfig                     |   1 -
 configs/sandbox_flattree_defconfig            |   1 -
 configs/sandbox_noblk_defconfig               |   1 -
 configs/sandbox_spl_defconfig                 |   1 -
 configs/tools-only_defconfig                  |   1 -
 drivers/i2c/Kconfig                           |  13 +-
 drivers/i2c/Makefile                          |   1 -
 drivers/i2c/i2c-uclass-compat.c               | 128 ------------------
 drivers/mtd/nand/raw/davinci_nand.c           |  48 ++++++-
 include/_exports.h                            |   3 +-
 include/configs/am3517_evm.h                  |   1 -
 include/configs/da850evm.h                    |   4 +
 include/configs/omapl138_lcdk.h               |   8 --
 include/exports.h                             |   3 +-
 include/i2c.h                                 |  80 -----------
 26 files changed, 89 insertions(+), 260 deletions(-)
 delete mode 100644 drivers/i2c/i2c-uclass-compat.c
Signature · 1 line
2.21.0
#1 lore raw

PATCH RESEND v2 1/13 davinci: remove CONFIG_DM_I2C_COMPAT from defconfigs

From: Bartosz Golaszewski <[email protected]>

This option is no longer used on any davinci board but still selected in defconfigs which causes the following warning:

===================== WARNING ====================== This board uses CONFIG_DM_I2C_COMPAT. Please remove (possibly in a subsequent patch in your series) before sending patches to the mailing list.
====================================================

Remove all references to CONFIG_DM_I2C_COMPAT from davinci.

---
 configs/da850_am18xxevm_defconfig | 1 -
 configs/omapl138_lcdk_defconfig   | 1 -
 include/configs/am3517_evm.h      | 1 -
 include/configs/omapl138_lcdk.h   | 8 --------
 4 files changed, 11 deletions(-)
configs/da850_am18xxevm_defconfig +0 -1
index f7054b4a1e..bc6199822e 100644
@@ -43,7 +43,6 @@ CONFIG_DM=y
 CONFIG_SPL_DM=y
 CONFIG_DA8XX_GPIO=y
 CONFIG_DM_I2C=y
-CONFIG_DM_I2C_COMPAT=y
 CONFIG_SYS_I2C_DAVINCI=y
 CONFIG_MTD_DEVICE=y
 CONFIG_DM_SPI_FLASH=y
configs/omapl138_lcdk_defconfig +0 -1
index 466ae860cd..b5d41bd3f6 100644
@@ -36,7 +36,6 @@ CONFIG_ENV_IS_IN_NAND=y
 CONFIG_NET_RANDOM_ETHADDR=y
 CONFIG_DM=y
 CONFIG_DM_I2C=y
-CONFIG_DM_I2C_COMPAT=y
 CONFIG_SYS_I2C_DAVINCI=y
 CONFIG_DM_MMC=y
 CONFIG_NAND=y
include/configs/am3517_evm.h +0 -1
index 2e8481890f..c2c5c1f668 100644
@@ -14,7 +14,6 @@
 
 #include <configs/ti_omap3_common.h>
 
-#undef CONFIG_DM_I2C_COMPAT
 #define CONFIG_REVISION_TAG
 
 /* Hardware drivers */
include/configs/omapl138_lcdk.h +0 -8
index da615e5063..db4a663c53 100644
@@ -16,14 +16,6 @@
 #undef CONFIG_USE_SPIFLASH
 #undef	CONFIG_SYS_USE_NOR
 
-/*
-* Disable DM_* for SPL build and can be re-enabled after adding
-* DM support in SPL
-*/
-#ifdef CONFIG_SPL_BUILD
-#undef CONFIG_DM_I2C
-#undef CONFIG_DM_I2C_COMPAT
-#endif
 /*
  * SoC Configuration
  */
Signature · 1 line
2.21.0
#2 lore raw

PATCH RESEND v2 1/13 davinci: remove CONFIG_DM_I2C_COMPAT from defconfigs

Quoted 13 lines · Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

This option is no longer used on any davinci board but still selected in defconfigs which causes the following warning:

===================== WARNING ====================== This board uses CONFIG_DM_I2C_COMPAT. Please remove (possibly in a subsequent patch in your series) before sending patches to the mailing list.
====================================================

Remove all references to CONFIG_DM_I2C_COMPAT from davinci.

Quoted 8 lines
---
 configs/da850_am18xxevm_defconfig | 1 -
 configs/omapl138_lcdk_defconfig   | 1 -
 include/configs/am3517_evm.h      | 1 -
 include/configs/omapl138_lcdk.h   | 8 --------
 4 files changed, 11 deletions(-)

This breaks da850_am18xxevm as dvevm_read_mac_address() in arch/arm/mach-davinci/misc.c has not been updated for the i2c case. I suspect board/atmel/common/mac_eeprom.c::at91_set_ethaddr() could be adapted easily enough and if you don't have a chance to do so, I'll take a pass at that.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190729/e05a1aaa/attachment.sig>
#3 lore raw

PATCH RESEND v2 1/13 davinci: remove CONFIG_DM_I2C_COMPAT from defconfigs

Quoted 24 lines · Tom Rini
Quoted 13 lines · Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

This option is no longer used on any davinci board but still selected in defconfigs which causes the following warning:

===================== WARNING ====================== This board uses CONFIG_DM_I2C_COMPAT. Please remove (possibly in a subsequent patch in your series) before sending patches to the mailing list.
====================================================

Remove all references to CONFIG_DM_I2C_COMPAT from davinci.

Quoted 8 lines
---
 configs/da850_am18xxevm_defconfig | 1 -
 configs/omapl138_lcdk_defconfig   | 1 -
 include/configs/am3517_evm.h      | 1 -
 include/configs/omapl138_lcdk.h   | 8 --------
 4 files changed, 11 deletions(-)
Quoted 5 lines

This breaks da850_am18xxevm as dvevm_read_mac_address() in arch/arm/mach-davinci/misc.c has not been updated for the i2c case. I suspect board/atmel/common/mac_eeprom.c::at91_set_ethaddr() could be adapted easily enough and if you don't have a chance to do so, I'll take a pass at that.

I submitted a patch to remove da850_am18xxevm since it's been orphaned for a while, and I don't have the hardware to support it as that variation wasn't a board made by Logic PD. I would argue that we apply the patch to remove the da850_am18xxevm, then we can apply his patches to remove CONFIG_DM_I2C_COMPAT.

adam

Quoted 3 lines

--
Tom

#4 lore raw

PATCH RESEND v2 1/13 davinci: remove CONFIG_DM_I2C_COMPAT from defconfigs

In reply to Bartosz Golaszewski
Quoted 11 lines · Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

This option is no longer used on any davinci board but still selected in defconfigs which causes the following warning:

===================== WARNING ====================== This board uses CONFIG_DM_I2C_COMPAT. Please remove (possibly in a subsequent patch in your series) before sending patches to the mailing list.
====================================================

Quoted 4 lines

Remove all references to CONFIG_DM_I2C_COMPAT from davinci.

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190729/23a68ffd/attachment.sig>
#5 lore raw

PATCH RESEND v2 2/13 sandbox: remove CONFIG_DM_I2C_COMPAT from defconfigs

In reply to Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

There are no more "real" users of CONFIG_DM_I2C_COMPAT and we'll soon remove it altogether. Stop building it in sandbox mode.

---
 Makefile                           | 2 +-
 configs/sandbox64_defconfig        | 1 -
 configs/sandbox_defconfig          | 1 -
 configs/sandbox_flattree_defconfig | 1 -
 configs/sandbox_noblk_defconfig    | 1 -
 configs/sandbox_spl_defconfig      | 1 -
 configs/tools-only_defconfig       | 1 -
 7 files changed, 1 insertion(+), 7 deletions(-)
Makefile +1 -1
index 704579bec1..252525bf0a 100644
@@ -936,7 +936,7 @@ ifneq ($(CONFIG_DM_SPI)$(CONFIG_OF_CONTROL),yy)
 endif
 endif
 endif
-ifeq ($(CONFIG_DM_I2C_COMPAT)$(CONFIG_SANDBOX),y)
+ifeq ($(CONFIG_DM_I2C_COMPAT),y)
 	@echo >&2 "===================== WARNING ======================"
 	@echo >&2 "This board uses CONFIG_DM_I2C_COMPAT. Please remove"
 	@echo >&2 "(possibly in a subsequent patch in your series)"
configs/sandbox64_defconfig +0 -1
index 827b8761cd..c177ff8ad5 100644
@@ -89,7 +89,6 @@ CONFIG_BOARD=y
 CONFIG_BOARD_SANDBOX=y
 CONFIG_PM8916_GPIO=y
 CONFIG_SANDBOX_GPIO=y
-CONFIG_DM_I2C_COMPAT=y
 CONFIG_I2C_CROS_EC_TUNNEL=y
 CONFIG_I2C_CROS_EC_LDO=y
 CONFIG_DM_I2C_GPIO=y
configs/sandbox_defconfig +0 -1
index 62594e3c21..aa09c4571a 100644
@@ -107,7 +107,6 @@ CONFIG_PM8916_GPIO=y
 CONFIG_SANDBOX_GPIO=y
 CONFIG_DM_HWSPINLOCK=y
 CONFIG_HWSPINLOCK_SANDBOX=y
-CONFIG_DM_I2C_COMPAT=y
 CONFIG_I2C_CROS_EC_TUNNEL=y
 CONFIG_I2C_CROS_EC_LDO=y
 CONFIG_DM_I2C_GPIO=y
configs/sandbox_flattree_defconfig +0 -1
index 2429ae4621..a70793b7ad 100644
@@ -75,7 +75,6 @@ CONFIG_BOARD=y
 CONFIG_BOARD_SANDBOX=y
 CONFIG_PM8916_GPIO=y
 CONFIG_SANDBOX_GPIO=y
-CONFIG_DM_I2C_COMPAT=y
 CONFIG_I2C_CROS_EC_TUNNEL=y
 CONFIG_I2C_CROS_EC_LDO=y
 CONFIG_DM_I2C_GPIO=y
configs/sandbox_noblk_defconfig +0 -1
index da9229fc79..381bad2003 100644
@@ -81,7 +81,6 @@ CONFIG_BOARD=y
 CONFIG_BOARD_SANDBOX=y
 CONFIG_PM8916_GPIO=y
 CONFIG_SANDBOX_GPIO=y
-CONFIG_DM_I2C_COMPAT=y
 CONFIG_I2C_CROS_EC_TUNNEL=y
 CONFIG_I2C_CROS_EC_LDO=y
 CONFIG_DM_I2C_GPIO=y
configs/sandbox_spl_defconfig +0 -1
index 27034cfaa9..c40a79cc73 100644
@@ -95,7 +95,6 @@ CONFIG_BOARD=y
 CONFIG_BOARD_SANDBOX=y
 CONFIG_PM8916_GPIO=y
 CONFIG_SANDBOX_GPIO=y
-CONFIG_DM_I2C_COMPAT=y
 CONFIG_I2C_CROS_EC_TUNNEL=y
 CONFIG_I2C_CROS_EC_LDO=y
 CONFIG_DM_I2C_GPIO=y
configs/tools-only_defconfig +0 -1
index aa73661a92..4808b49850 100644
@@ -12,7 +12,6 @@ CONFIG_DEFAULT_DEVICE_TREE="sandbox"
 CONFIG_IP_DEFRAG=y
 # CONFIG_UDP_FUNCTION_FASTBOOT is not set
 CONFIG_SANDBOX_GPIO=y
-CONFIG_DM_I2C_COMPAT=y
 CONFIG_PCI=y
 CONFIG_DM_PCI=y
 CONFIG_PCI_SANDBOX=y
Signature · 1 line
2.21.0
#6 lore raw

PATCH RESEND v2 2/13 sandbox: remove CONFIG_DM_I2C_COMPAT from defconfigs

Quoted 7 lines · Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

There are no more "real" users of CONFIG_DM_I2C_COMPAT and we'll soon remove it altogether. Stop building it in sandbox mode.

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190729/2378beb7/attachment.sig>
#7 lore raw

PATCH RESEND v2 3/13 i2c: remove i2c driver-model compatibility layer

In reply to Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

There are no more users of the compatibility layer for i2c. Remove the driver and all references to it.

---
 Makefile                        |   7 --
 drivers/i2c/Kconfig             |  13 +---
 drivers/i2c/Makefile            |   1 -
 drivers/i2c/i2c-uclass-compat.c | 128 --------------------------------
 include/_exports.h              |   3 +-
 include/exports.h               |   3 +-
 include/i2c.h                   |  80 --------------------
 7 files changed, 3 insertions(+), 232 deletions(-)
 delete mode 100644 drivers/i2c/i2c-uclass-compat.c
Makefile +0 -7
index 252525bf0a..bff5a402a7 100644
@@ -936,13 +936,6 @@ ifneq ($(CONFIG_DM_SPI)$(CONFIG_OF_CONTROL),yy)
 endif
 endif
 endif
-ifeq ($(CONFIG_DM_I2C_COMPAT),y)
-	@echo >&2 "===================== WARNING ======================"
-	@echo >&2 "This board uses CONFIG_DM_I2C_COMPAT. Please remove"
-	@echo >&2 "(possibly in a subsequent patch in your series)"
-	@echo >&2 "before sending patches to the mailing list."
-	@echo >&2 "===================================================="
-endif
 ifeq ($(CONFIG_MMC),y)
 ifneq ($(CONFIG_DM_MMC)$(CONFIG_OF_CONTROL)$(CONFIG_BLK),yyy)
 	@echo >&2 "===================== WARNING ======================"
drivers/i2c/Kconfig +1 -12
index 4772db3837..03d2fed341 100644
@@ -12,18 +12,7 @@ config DM_I2C
 	  write and speed, is implemented with the bus drivers operations,
 	  which provide methods for bus setting and data transfer. Each chip
 	  device (bus child) info is kept as parent platdata. The interface
-	  is defined in include/i2c.h. When i2c bus driver supports the i2c
-	  uclass, but the device drivers not, then DM_I2C_COMPAT config can
-	  be used as compatibility layer.
-
-config DM_I2C_COMPAT
-	bool "Enable I2C compatibility layer"
-	depends on DM
-	help
-	  Enable old-style I2C functions for compatibility with existing code.
-	  This option can be enabled as a temporary measure to avoid needing
-	  to convert all code for a board in a single commit. It should not
-	  be enabled for any board in an official release.
+	  is defined in include/i2c.h.
 
 config I2C_CROS_EC_TUNNEL
 	tristate "Chrome OS EC tunnel I2C bus"
drivers/i2c/Makefile +0 -1
index dc40055efb..c2f75d8755 100644
@@ -3,7 +3,6 @@
 # (C) Copyright 2000-2007
 # Wolfgang Denk, DENX Software Engineering, wd at denx.de.
 obj-$(CONFIG_DM_I2C) += i2c-uclass.o
-obj-$(CONFIG_DM_I2C_COMPAT) += i2c-uclass-compat.o
 obj-$(CONFIG_DM_I2C_GPIO) += i2c-gpio.o
 obj-$(CONFIG_$(SPL_)I2C_CROS_EC_TUNNEL) += cros_ec_tunnel.o
 obj-$(CONFIG_$(SPL_)I2C_CROS_EC_LDO) += cros_ec_ldo.o
drivers/i2c/i2c-uclass-compat.c deleted +0 -128

128 lines not on this page · raw message

include/_exports.h +1 -2
index c15050e30b..0dee05f077 100644
@@ -40,8 +40,7 @@
 	EXPORT_FUNC(simple_strtol, long, simple_strtol,
 		    const char *, char **, unsigned int)
 	EXPORT_FUNC(strcmp, int, strcmp, const char *cs, const char *ct)
-#if defined(CONFIG_CMD_I2C) && \
-		(!defined(CONFIG_DM_I2C) || defined(CONFIG_DM_I2C_COMPAT))
+#if defined(CONFIG_CMD_I2C) && !defined(CONFIG_DM_I2C)
 	EXPORT_FUNC(i2c_write, int, i2c_write, uchar, uint, int , uchar * , int)
 	EXPORT_FUNC(i2c_read, int, i2c_read, uchar, uint, int , uchar * , int)
 #else
include/exports.h +1 -2
index a4b862f191..bf8d53c6b0 100644
@@ -32,8 +32,7 @@ long simple_strtol(const char *cp, char **endp, unsigned int base);
 int strcmp(const char *cs, const char *ct);
 unsigned long ustrtoul(const char *cp, char **endp, unsigned int base);
 unsigned long long ustrtoull(const char *cp, char **endp, unsigned int base);
-#if defined(CONFIG_CMD_I2C) && \
-		(!defined(CONFIG_DM_I2C) || defined(CONFIG_DM_I2C_COMPAT))
+#if defined(CONFIG_CMD_I2C) && !defined(CONFIG_DM_I2C)
 int i2c_write (uchar, uint, int , uchar* , int);
 int i2c_read (uchar, uint, int , uchar* , int);
 #endif
include/i2c.h +0 -80

86 lines not on this page · raw message

Signature · 1 line
2.21.0
#8 lore raw

PATCH RESEND v2 3/13 i2c: remove i2c driver-model compatibility layer

Quoted 7 lines · Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

There are no more users of the compatibility layer for i2c. Remove the driver and all references to it.

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190729/2c8a01b2/attachment.sig>
#9 lore raw

PATCH RESEND v2 4/13 omapl138_lcdk_defconfig: don't build support for SPI

In reply to Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

The following warning is emited when building u-boot for da850-lcdk:

===================== WARNING ====================== This board does not use CONFIG_DM_SPI. Please update the board before v2019.04 for no dm conversion
and v2019.07 for partially dm converted drivers. Failure to update can lead to driver/board removal See doc/driver-model/MIGRATION.txt for more info.
====================================================
===================== WARNING ====================== This board does not use CONFIG_DM_SPI_FLASH. Please update the board to use CONFIG_SPI_FLASH before the v2019.07 release. Failure to update by the deadline may result in board removal. See doc/driver-model/MIGRATION.txt for more info.
====================================================

While we could fix it by selecting CONFIG_DM_SPI, there's no need to build it at all as SPI is disabled on da850-lcdk. Remove all unneeded options from the defconfig.

---
 configs/omapl138_lcdk_defconfig | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)
configs/omapl138_lcdk_defconfig +1 -5
index b5d41bd3f6..7752308564 100644
@@ -26,6 +26,7 @@ CONFIG_CRC32_VERIFY=y
 # CONFIG_CMD_FLASH is not set
 # CONFIG_CMD_GPIO is not set
 CONFIG_CMD_NAND=y
+# CONFIG_CMD_SPI is not set
 # CONFIG_CMD_SETEXPR is not set
 CONFIG_CMD_MTDPARTS=y
 CONFIG_CMD_DIAG=y
@@ -44,14 +45,9 @@ CONFIG_SYS_NAND_BUSWIDTH_16BIT=y
 CONFIG_SYS_NAND_U_BOOT_LOCATIONS=y
 CONFIG_SYS_NAND_U_BOOT_OFFS=0x28000
 CONFIG_SPL_NAND_SIMPLE=y
-CONFIG_SPI_FLASH=y
 CONFIG_SF_DEFAULT_SPEED=30000000
-CONFIG_SPI_FLASH_STMICRO=y
-CONFIG_SPI_FLASH_WINBOND=y
 CONFIG_DM_ETH=y
 CONFIG_MII=y
 CONFIG_DRIVER_TI_EMAC=y
 CONFIG_DM_SERIAL=y
 CONFIG_SYS_NS16550=y
-CONFIG_SPI=y
-CONFIG_DAVINCI_SPI=y
Signature · 1 line
2.21.0
#10 lore raw

PATCH RESEND v2 4/13 omapl138_lcdk_defconfig: don't build support for SPI

Quoted 18 lines · Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

The following warning is emited when building u-boot for da850-lcdk:

===================== WARNING ====================== This board does not use CONFIG_DM_SPI. Please update the board before v2019.04 for no dm conversion
and v2019.07 for partially dm converted drivers. Failure to update can lead to driver/board removal See doc/driver-model/MIGRATION.txt for more info.
====================================================
===================== WARNING ====================== This board does not use CONFIG_DM_SPI_FLASH. Please update the board to use CONFIG_SPI_FLASH before the v2019.07 release. Failure to update by the deadline may result in board removal. See doc/driver-model/MIGRATION.txt for more info.
====================================================

Quoted 6 lines

While we could fix it by selecting CONFIG_DM_SPI, there's no need to build it at all as SPI is disabled on da850-lcdk. Remove all unneeded options from the defconfig.

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190729/ae7c8691/attachment.sig>
#11 lore raw

PATCH RESEND v2 5/13 nand: davinci: make davinci_nand_init() static

In reply to Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

This function is only used within the driver itself. No need to export it.

---
 arch/arm/include/asm/ti-common/davinci_nand.h | 2 --
 drivers/mtd/nand/raw/davinci_nand.c           | 2 +-
 2 files changed, 1 insertion(+), 3 deletions(-)
arch/arm/include/asm/ti-common/davinci_nand.h +0 -2
index e26381c7fd..28842c3b15 100644
@@ -95,6 +95,4 @@ struct davinci_emif_regs {
 #define DAVINCI_ABCR_ASIZE_16BIT			1
 #define DAVINCI_ABCR_ASIZE_8BIT				0
 
-void davinci_nand_init(struct nand_chip *nand);
-
 #endif
drivers/mtd/nand/raw/davinci_nand.c +1 -1
index cfa9b535c8..e1c4498cb9 100644
@@ -730,7 +730,7 @@ static int nand_davinci_dev_ready(struct mtd_info *mtd)
 	return __raw_readl(&davinci_emif_regs->nandfsr) & 0x1;
 }
 
-void davinci_nand_init(struct nand_chip *nand)
+static void davinci_nand_init(struct nand_chip *nand)
 {
 #if defined CONFIG_KEYSTONE_RBL_NAND
 	int i;
Signature · 1 line
2.21.0
#12 lore raw

PATCH RESEND v2 5/13 nand: davinci: make davinci_nand_init() static

Quoted 6 lines · Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

This function is only used within the driver itself. No need to export it.

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190729/eb7a16eb/attachment.sig>
#13 lore raw

PATCH RESEND v2 6/13 nand: davinci: add support for driver model

In reply to Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

Extend the davinci NAND driver to support the driver model. For now this doesn't add any device-tree parsing due to the fact that we can't access the actual nand node on the device-tree - it's a subnode of the aemif device and we don't have an aemif driver on davinci at the moment.

---
 drivers/mtd/nand/raw/davinci_nand.c | 46 ++++++++++++++++++++++++++++-
 1 file changed, 45 insertions(+), 1 deletion(-)
drivers/mtd/nand/raw/davinci_nand.c +45 -1
index e1c4498cb9..33c2f16be8 100644
@@ -31,6 +31,7 @@
 #include <common.h>
 #include <asm/io.h>
 #include <nand.h>
+#include <dm/uclass.h>
 #include <asm/ti-common/davinci_nand.h>
 
 /* Definitions for 4-bit hardware ECC */
@@ -785,10 +786,53 @@ static void davinci_nand_init(struct nand_chip *nand)
 	nand->dev_ready = nand_davinci_dev_ready;
 }
 
-int board_nand_init(struct nand_chip *chip) __attribute__((weak));
+#ifdef CONFIG_SYS_NAND_SELF_INIT
+static int davinci_nand_probe(struct udevice *dev)
+{
+	struct nand_chip *nand = dev_get_priv(dev);
+	struct mtd_info *mtd = nand_to_mtd(nand);
+	int ret;
+
+	nand->IO_ADDR_R = (void __iomem *)CONFIG_SYS_NAND_BASE;
+	nand->IO_ADDR_W = (void __iomem *)CONFIG_SYS_NAND_BASE;
+
+	davinci_nand_init(nand);
+
+	ret = nand_scan(mtd, CONFIG_SYS_NAND_MAX_CHIPS);
+	if (ret)
+		return ret;
+
+	return nand_register(0, mtd);
+}
+
+static const struct udevice_id davinci_nand_ids[] = {
+	{ .compatible = "ti,davinci-nand" },
+	{ }
+};
+
+U_BOOT_DRIVER(davinci_nand) = {
+	.name		= "davinci-nand",
+	.id		= UCLASS_MTD,
+	.of_match	= davinci_nand_ids,
+	.probe		= davinci_nand_probe,
+	.priv_auto_alloc_size = sizeof(struct nand_chip),
+};
+
+void board_nand_init(void)
+{
+	struct udevice *dev;
+	int ret;
 
+	ret = uclass_get_device_by_driver(UCLASS_MTD,
+					  DM_GET_DRIVER(davinci_nand), &dev);
+	if (ret && ret != -ENODEV)
+		pr_err("Failed to initialize %s: %d\n", dev->name, ret);
+}
+#else
+int board_nand_init(struct nand_chip *chip) __attribute__((weak));
 int board_nand_init(struct nand_chip *chip)
 {
 	davinci_nand_init(chip);
 	return 0;
 }
+#endif /* CONFIG_SYS_NAND_SELF_INIT */
Signature · 1 line
2.21.0
#14 lore raw

PATCH RESEND v2 6/13 nand: davinci: add support for driver model

Quoted 8 lines · Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

Extend the davinci NAND driver to support the driver model. For now this doesn't add any device-tree parsing due to the fact that we can't access the actual nand node on the device-tree - it's a subnode of the aemif device and we don't have an aemif driver on davinci at the moment.

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190729/f8d3fe6e/attachment.sig>
#15 lore raw

PATCH RESEND v2 7/13 davinci: omapl138-lcdk: enable driver model for NAND

In reply to Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

Enable the driver-model on da850-lcdk. We need to add a dummy nand node to the device tree, as the real nand node is a sub-node of the aemif device.

On linux the aemif driver populates all its child nodes, but we can't do it in u-boot currently.

---
 arch/arm/dts/da850-lcdk-u-boot.dtsi | 4 ++++
 configs/omapl138_lcdk_defconfig     | 1 +
 include/configs/omapl138_lcdk.h     | 4 ++++
 3 files changed, 9 insertions(+)
arch/arm/dts/da850-lcdk-u-boot.dtsi +4 -0
index 80dda8ef58..541f4ca200 100644
@@ -9,4 +9,8 @@
 	aliases {
 		i2c0 = &i2c0;
 	};
+
+	nand {
+		compatible = "ti,davinci-nand";
+	};
 };
configs/omapl138_lcdk_defconfig +1 -0
index 7752308564..fa4ce692ff 100644
@@ -39,6 +39,7 @@ CONFIG_DM=y
 CONFIG_DM_I2C=y
 CONFIG_SYS_I2C_DAVINCI=y
 CONFIG_DM_MMC=y
+CONFIG_MTD=y
 CONFIG_NAND=y
 CONFIG_NAND_DAVINCI=y
 CONFIG_SYS_NAND_BUSWIDTH_16BIT=y
include/configs/omapl138_lcdk.h +4 -0
index db4a663c53..20fd7ff713 100644
@@ -168,6 +168,10 @@
 #define CONFIG_SPL_NAND_DRIVERS
 #define CONFIG_SPL_NAND_ECC
 #define CONFIG_SPL_NAND_LOAD
+
+#ifndef CONFIG_SPL_BUILD
+#define CONFIG_SYS_NAND_SELF_INIT
+#endif
 #endif
 
 #ifdef CONFIG_SYS_USE_NOR
Signature · 1 line
2.21.0
#16 lore raw

PATCH RESEND v2 7/13 davinci: omapl138-lcdk: enable driver model for NAND

Quoted 10 lines · Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

Enable the driver-model on da850-lcdk. We need to add a dummy nand node to the device tree, as the real nand node is a sub-node of the aemif device.

On linux the aemif driver populates all its child nodes, but we can't do it in u-boot currently.

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190729/764d3fc3/attachment.sig>
#17 lore raw

PATCH RESEND v2 8/13 davinci: da850-evm: enable driver model for NAND

In reply to Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

Enable the driver-model on da850-evm. We need to add a dummy nand node to the device tree, as the real nand node is a sub-node of the aemif device.

On linux the aemif driver populates all its child nodes, but we can't do it in u-boot currently.

---
 arch/arm/dts/da850-evm-u-boot.dtsi    | 4 ++++
 configs/da850evm_defconfig            | 1 +
 configs/da850evm_direct_nor_defconfig | 1 +
 configs/da850evm_nand_defconfig       | 1 +
 include/configs/da850evm.h            | 4 ++++
 5 files changed, 11 insertions(+)
arch/arm/dts/da850-evm-u-boot.dtsi +4 -0
index 1683f3472e..d9e8b9926a 100644
@@ -10,6 +10,10 @@
 	soc at 1c00000 {
 		u-boot,dm-spl;
 	};
+
+	nand {
+		compatible = "ti,davinci-nand";
+	};
 };
 
 &flash {
configs/da850evm_defconfig +1 -0
index 99300cb297..7de1d2ffc4 100644
@@ -52,6 +52,7 @@ CONFIG_DA8XX_GPIO=y
 CONFIG_DM_I2C=y
 CONFIG_SYS_I2C_DAVINCI=y
 CONFIG_DM_MMC=y
+CONFIG_MTD=y
 CONFIG_MTD_DEVICE=y
 CONFIG_DM_SPI_FLASH=y
 CONFIG_SPI_FLASH=y
configs/da850evm_direct_nor_defconfig +1 -0
index dcb4d96d0d..e3c2d13986 100644
@@ -42,6 +42,7 @@ CONFIG_DA8XX_GPIO=y
 CONFIG_DM_I2C=y
 CONFIG_SYS_I2C_DAVINCI=y
 # CONFIG_MMC is not set
+CONFIG_MTD=y
 CONFIG_MTD_NOR_FLASH=y
 CONFIG_FLASH_CFI_DRIVER=y
 CONFIG_SYS_FLASH_PROTECTION=y
configs/da850evm_nand_defconfig +1 -0
index 7065205783..96602e514a 100644
@@ -49,6 +49,7 @@ CONFIG_DM_GPIO=y
 CONFIG_DA8XX_GPIO=y
 CONFIG_DM_I2C=y
 CONFIG_DM_MMC=y
+CONFIG_MTD=y
 CONFIG_NAND=y
 CONFIG_NAND_DAVINCI=y
 CONFIG_SYS_NAND_U_BOOT_LOCATIONS=y
include/configs/da850evm.h +4 -0
index 2dab17afab..ff536131ba 100644
@@ -174,6 +174,10 @@
 #define CONFIG_SPL_NAND_DRIVERS
 #define CONFIG_SPL_NAND_ECC
 #define CONFIG_SPL_NAND_LOAD
+
+#ifndef CONFIG_SPL_BUILD
+#define CONFIG_SYS_NAND_SELF_INIT
+#endif
 #endif
 
 /*
Signature · 1 line
2.21.0
#18 lore raw

PATCH RESEND v2 8/13 davinci: da850-evm: enable driver model for NAND

Quoted 7 lines · Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

Enable the driver-model on da850-evm. We need to add a dummy nand node to the device tree, as the real nand node is a sub-node of the aemif device.

Quoted 5 lines

On linux the aemif driver populates all its child nodes, but we can't do it in u-boot currently.

The current state of master currently has nand booting broken on the da850evm_nand_defconfig, so I'll welcome this patch since it seems to fix the broken booting. I haven't bisected it because there is this pending fix.

adam

Quoted 77 lines
---
 arch/arm/dts/da850-evm-u-boot.dtsi    | 4 ++++
 configs/da850evm_defconfig            | 1 +
 configs/da850evm_direct_nor_defconfig | 1 +
 configs/da850evm_nand_defconfig       | 1 +
 include/configs/da850evm.h            | 4 ++++
 5 files changed, 11 insertions(+)
arch/arm/dts/da850-evm-u-boot.dtsi +4 -0
index 1683f3472e..d9e8b9926a 100644
@@ -10,6 +10,10 @@
        soc at 1c00000 {
                u-boot,dm-spl;
        };
+
+       nand {
+               compatible = "ti,davinci-nand";
+       };
 };
 
 &flash {
configs/da850evm_defconfig +1 -0
index 99300cb297..7de1d2ffc4 100644
@@ -52,6 +52,7 @@ CONFIG_DA8XX_GPIO=y
 CONFIG_DM_I2C=y
 CONFIG_SYS_I2C_DAVINCI=y
 CONFIG_DM_MMC=y
+CONFIG_MTD=y
 CONFIG_MTD_DEVICE=y
 CONFIG_DM_SPI_FLASH=y
 CONFIG_SPI_FLASH=y
configs/da850evm_direct_nor_defconfig +1 -0
index dcb4d96d0d..e3c2d13986 100644
@@ -42,6 +42,7 @@ CONFIG_DA8XX_GPIO=y
 CONFIG_DM_I2C=y
 CONFIG_SYS_I2C_DAVINCI=y
 # CONFIG_MMC is not set
+CONFIG_MTD=y
 CONFIG_MTD_NOR_FLASH=y
 CONFIG_FLASH_CFI_DRIVER=y
 CONFIG_SYS_FLASH_PROTECTION=y
configs/da850evm_nand_defconfig +1 -0
index 7065205783..96602e514a 100644
@@ -49,6 +49,7 @@ CONFIG_DM_GPIO=y
 CONFIG_DA8XX_GPIO=y
 CONFIG_DM_I2C=y
 CONFIG_DM_MMC=y
+CONFIG_MTD=y
 CONFIG_NAND=y
 CONFIG_NAND_DAVINCI=y
 CONFIG_SYS_NAND_U_BOOT_LOCATIONS=y
include/configs/da850evm.h +4 -1
index 2dab17afab..ff536131ba 100644
@@ -174,6 +174,10 @@
 #define CONFIG_SPL_NAND_DRIVERS
 #define CONFIG_SPL_NAND_ECC
 #define CONFIG_SPL_NAND_LOAD
+
+#ifndef CONFIG_SPL_BUILD
+#define CONFIG_SYS_NAND_SELF_INIT
+#endif
 #endif
 
 /*
--

2.21.0

#19 lore raw

PATCH RESEND v2 8/13 davinci: da850-evm: enable driver model for NAND

In reply to Bartosz Golaszewski
Quoted 11 lines · Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

Enable the driver-model on da850-evm. We need to add a dummy nand node to the device tree, as the real nand node is a sub-node of the aemif device.

On linux the aemif driver populates all its child nodes, but we can't do it in u-boot currently.

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190729/ec5a6a21/attachment.sig>
#20 lore raw

PATCH RESEND v2 9/13 davinci: omapl138-lcdk: enable SPL_SYS_MALLOC_SIMPLE

In reply to Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

We're working towards enabling the driver model in SPL for da850-lcdk. Enable SPL_SYS_MALLOC_SIMPLE in defconfig to reduce SPL size.

---
 configs/omapl138_lcdk_defconfig | 1 +
 1 file changed, 1 insertion(+)
configs/omapl138_lcdk_defconfig +1 -0
index fa4ce692ff..bfb88e397a 100644
@@ -18,6 +18,7 @@ CONFIG_VERSION_VARIABLE=y
 # CONFIG_DISPLAY_CPUINFO is not set
 CONFIG_BOARD_EARLY_INIT_F=y
 CONFIG_SPL_TEXT_BASE=0x80000000
+CONFIG_SPL_SYS_MALLOC_SIMPLE=y
 CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR=0xb5
 CONFIG_SPL_NAND_SUPPORT=y
 CONFIG_HUSH_PARSER=y
Signature · 1 line
2.21.0
#21 lore raw

PATCH RESEND v2 9/13 davinci: omapl138-lcdk: enable SPL_SYS_MALLOC_SIMPLE

Quoted 6 lines · Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

We're working towards enabling the driver model in SPL for da850-lcdk. Enable SPL_SYS_MALLOC_SIMPLE in defconfig to reduce SPL size.

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190729/05fc5e3b/attachment.sig>
#22 lore raw

PATCH RESEND v2 10/13 davinci: omapl138-lcdk: enable CONFIG_USE_TINY_PRINTF

In reply to Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

We're working towards enabling the driver-model in SPL for da850-lcdk. Enable CONFIG_USE_TINY_PRINTF in defconfig to reduce SPL size.

---
 configs/omapl138_lcdk_defconfig | 1 +
 1 file changed, 1 insertion(+)
configs/omapl138_lcdk_defconfig +1 -0
index bfb88e397a..c4eebb3612 100644
@@ -53,3 +53,4 @@ CONFIG_MII=y
 CONFIG_DRIVER_TI_EMAC=y
 CONFIG_DM_SERIAL=y
 CONFIG_SYS_NS16550=y
+CONFIG_USE_TINY_PRINTF=y
Signature · 1 line
2.21.0
#23 lore raw

PATCH RESEND v2 10/13 davinci: omapl138-lcdk: enable CONFIG_USE_TINY_PRINTF

Quoted 6 lines · Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

We're working towards enabling the driver-model in SPL for da850-lcdk. Enable CONFIG_USE_TINY_PRINTF in defconfig to reduce SPL size.

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190729/324c42e5/attachment.sig>
#24 lore raw

PATCH RESEND v2 11/13 davinci: omapl138-lcdk: remove unneeded includes

In reply to Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

There's no SPI on da850-lcdk. Remove unnecessary includes.

---
 board/davinci/da8xxevm/omapl138_lcdk.c | 2 --
 1 file changed, 2 deletions(-)
board/davinci/da8xxevm/omapl138_lcdk.c +0 -2
index dd11551428..7f8c28b953 100644
@@ -11,8 +11,6 @@
 #include <common.h>
 #include <i2c.h>
 #include <net.h>
-#include <spi.h>
-#include <spi_flash.h>
 #include <asm/arch/hardware.h>
 #include <asm/ti-common/davinci_nand.h>
 #include <asm/io.h>
Signature · 1 line
2.21.0
#25 lore raw

PATCH RESEND v2 11/13 davinci: omapl138-lcdk: remove unneeded includes

Quoted 5 lines · Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

There's no SPI on da850-lcdk. Remove unnecessary includes.

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190729/04920698/attachment.sig>
#26 lore raw

PATCH RESEND v2 12/13 davinci: omapl138-lcdk: enable driver-model in SPL

In reply to Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

Enable CONFIG_SPL_DM and enable the driver model for serial by defining an appropriate device in the board file for da850-lcdk.

---
 board/davinci/da8xxevm/omapl138_lcdk.c | 16 ++++++++++++++++
 configs/omapl138_lcdk_defconfig        |  5 +++++
 2 files changed, 21 insertions(+)
board/davinci/da8xxevm/omapl138_lcdk.c +16 -0
index 7f8c28b953..578d928443 100644
@@ -14,6 +14,8 @@
 #include <asm/arch/hardware.h>
 #include <asm/ti-common/davinci_nand.h>
 #include <asm/io.h>
+#include <ns16550.h>
+#include <dm/platdata.h>
 #include <linux/errno.h>
 #include <asm/mach-types.h>
 #include <asm/arch/davinci_misc.h>
@@ -355,3 +357,17 @@ int board_mmc_init(bd_t *bis)
 }
 #endif
 #endif
+
+#ifdef CONFIG_SPL_BUILD
+static const struct ns16550_platdata serial_pdata = {
+	.base = DAVINCI_UART2_BASE,
+	.reg_shift = 2,
+	.clock = 228000000,
+	.fcr = UART_FCR_DEFVAL,
+};
+
+U_BOOT_DEVICE(omapl138_uart) = {
+	.name = "ns16550_serial",
+	.platdata = &serial_pdata,
+};
+#endif
configs/omapl138_lcdk_defconfig +5 -0
index c4eebb3612..26b4950f8f 100644
@@ -33,10 +33,13 @@ CONFIG_CMD_MTDPARTS=y
 CONFIG_CMD_DIAG=y
 CONFIG_CMD_UBI=y
 CONFIG_OF_CONTROL=y
+CONFIG_SPL_OF_CONTROL=y
 CONFIG_DEFAULT_DEVICE_TREE="da850-lcdk"
+CONFIG_SPL_OF_PLATDATA=y
 CONFIG_ENV_IS_IN_NAND=y
 CONFIG_NET_RANDOM_ETHADDR=y
 CONFIG_DM=y
+CONFIG_SPL_DM=y
 CONFIG_DM_I2C=y
 CONFIG_SYS_I2C_DAVINCI=y
 CONFIG_DM_MMC=y
@@ -51,6 +54,8 @@ CONFIG_SF_DEFAULT_SPEED=30000000
 CONFIG_DM_ETH=y
 CONFIG_MII=y
 CONFIG_DRIVER_TI_EMAC=y
+CONFIG_SPECIFY_CONSOLE_INDEX=y
 CONFIG_DM_SERIAL=y
 CONFIG_SYS_NS16550=y
 CONFIG_USE_TINY_PRINTF=y
+# CONFIG_SPL_OF_LIBFDT is not set
Signature · 1 line
2.21.0
#27 lore raw

PATCH RESEND v2 12/13 davinci: omapl138-lcdk: enable driver-model in SPL

Quoted 6 lines · Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

Enable CONFIG_SPL_DM and enable the driver model for serial by defining an appropriate device in the board file for da850-lcdk.

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190729/9d38143f/attachment.sig>
#28 lore raw

PATCH RESEND v2 12/13 davinci: omapl138-lcdk: enable driver-model in SPL

In reply to Bartosz Golaszewski

Hi,

Quoted 5 lines · Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

Enable CONFIG_SPL_DM and enable the driver model for serial by defining an appropriate device in the board file for da850-lcdk.

This breaks booting from MMC on omapl138_lcdk. You didn't add a U_BOOT_DEVICE for the mmc node.

Thanks,
Faiz

#29 lore raw

PATCH RESEND v2 12/13 davinci: omapl138-lcdk: enable driver-model in SPL

czw., 26 wrz 2019 o 01:21 Faiz Abbas <[email protected]> napisaÅ‚(a):

Quoted 10 lines

Hi,

Quoted 5 lines · Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

Enable CONFIG_SPL_DM and enable the driver model for serial by defining an appropriate device in the board file for da850-lcdk.

Quoted 5 lines

This breaks booting from MMC on omapl138_lcdk. You didn't add a U_BOOT_DEVICE for the mmc node.

Thanks,
Faiz

Just letting you know I haven't forgotten about this. I finally got some time to work on it this week, but it turned out to be non-trivial, as for some reason the set_cmd mmc callback is not being properly assigned in SPL with driver-model and I couldn't find out why so far. Next week I'm at ELCE, but I'll be back at it on Thursday. I'm not sure if you want to revert the offending patch for now or this can wait for another week?

Best regards,
Bartosz Golaszewski

#30 lore raw

PATCH RESEND v2 12/13 davinci: omapl138-lcdk: enable driver-model in SPL

Hi Barotz,

Quoted 14 lines · Bartosz Golaszewski

czw., 26 wrz 2019 o 01:21 Faiz Abbas <[email protected]> napisaÅ‚(a):

Quoted 13 lines

Hi,

Quoted 5 lines · Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

Enable CONFIG_SPL_DM and enable the driver model for serial by defining an appropriate device in the board file for da850-lcdk.

This breaks booting from MMC on omapl138_lcdk. You didn't add a U_BOOT_DEVICE for the mmc node.

Quoted 8 lines
Quoted 2 lines

Thanks,
Faiz

Just letting you know I haven't forgotten about this. I finally got some time to work on it this week, but it turned out to be non-trivial, as for some reason the set_cmd mmc callback is not being properly assigned in SPL with driver-model and I couldn't find out why so far.

I will try to look at it as well.

Next week I'm at ELCE, but I'll be back at it on Thursday.

I'm at ELC as well. Will be nice to meet up with you and discuss this if you want.

Thanks,
Faiz

#31 lore raw

PATCH RESEND v2 12/13 davinci: omapl138-lcdk: enable driver-model in SPL

pt., 25 paź 2019 o 19:25 Rizvi, Mohammad Faiz Abbas <[email protected]> napisał(a):

Quoted 3 lines

Hi Barotz,

It's Bartosz - it's literally on the next line of the e-mail too. :)

Quoted 24 lines · Bartosz Golaszewski
Quoted 14 lines

czw., 26 wrz 2019 o 01:21 Faiz Abbas <[email protected]> napisał(a):

Quoted 13 lines

Hi,

Quoted 5 lines · Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

Enable CONFIG_SPL_DM and enable the driver model for serial by defining an appropriate device in the board file for da850-lcdk.

This breaks booting from MMC on omapl138_lcdk. You didn't add a U_BOOT_DEVICE for the mmc node.

Quoted 8 lines
Quoted 2 lines

Thanks,
Faiz

Just letting you know I haven't forgotten about this. I finally got some time to work on it this week, but it turned out to be non-trivial, as for some reason the set_cmd mmc callback is not being properly assigned in SPL with driver-model and I couldn't find out why so far.

Quoted 7 lines

I will try to look at it as well.

Next week I'm at ELCE, but I'll be back at it on Thursday.

I'm at ELC as well. Will be nice to meet up with you and discuss this if you want.

Sure, I'll be doing a talk on Wednesday, may be a good time to catch me afterwards.

Bartosz

Quoted 5 lines

Thanks,
Faiz

#32 lore raw

PATCH RESEND v2 12/13 davinci: omapl138-lcdk: enable driver-model in SPL

In reply to Bartosz Golaszewski

pt., 25 paź 2019 o 18:10 Bartosz Golaszewski <[email protected]> napisał(a):

Quoted 26 lines

czw., 26 wrz 2019 o 01:21 Faiz Abbas <[email protected]> napisał(a):

Quoted 10 lines

Hi,

Quoted 5 lines · Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

Enable CONFIG_SPL_DM and enable the driver model for serial by defining an appropriate device in the board file for da850-lcdk.

Quoted 5 lines

This breaks booting from MMC on omapl138_lcdk. You didn't add a U_BOOT_DEVICE for the mmc node.

Thanks,
Faiz

Just letting you know I haven't forgotten about this. I finally got some time to work on it this week, but it turned out to be non-trivial, as for some reason the set_cmd mmc callback is not being properly assigned in SPL with driver-model and I couldn't find out why so far. Next week I'm at ELCE, but I'll be back at it on Thursday. I'm not sure if you want to revert the offending patch for now or this can wait for another week?

Quoted 2 lines

Best regards,
Bartosz Golaszewski

I've been working on this some more this week and noticed that in SPL for some reason the bind function of the mmc driver is not called (despite the driver being probed fine), but so far I've been unable to figure out why exactly. This is the reason for the failure as the mmc is not properly setup but the mmc core thinks it is and tries using it.

I've tried both using a U_BOOT_DEVICE() defined in the board file or adding the mmc node to arch/arm/dts/da850-lcdk-u-boot.dtsi.

Adam: you know davinci's SPL pretty well - do you have any suggestions?

Bart

#33 lore raw

PATCH RESEND v2 12/13 davinci: omapl138-lcdk: enable driver-model in SPL

Quoted 38 lines · Bartosz Golaszewski

pt., 25 paź 2019 o 18:10 Bartosz Golaszewski <[email protected]> napisał(a):

Quoted 26 lines

czw., 26 wrz 2019 o 01:21 Faiz Abbas <[email protected]> napisał(a):

Quoted 10 lines

Hi,

Quoted 5 lines · Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

Enable CONFIG_SPL_DM and enable the driver model for serial by defining an appropriate device in the board file for da850-lcdk.

Quoted 5 lines

This breaks booting from MMC on omapl138_lcdk. You didn't add a U_BOOT_DEVICE for the mmc node.

Thanks,
Faiz

Just letting you know I haven't forgotten about this. I finally got some time to work on it this week, but it turned out to be non-trivial, as for some reason the set_cmd mmc callback is not being properly assigned in SPL with driver-model and I couldn't find out why so far. Next week I'm at ELCE, but I'll be back at it on Thursday. I'm not sure if you want to revert the offending patch for now or this can wait for another week?

Quoted 2 lines

Best regards,
Bartosz Golaszewski

I've been working on this some more this week and noticed that in SPL for some reason the bind function of the mmc driver is not called (despite the driver being probed fine), but so far I've been unable to figure out why exactly. This is the reason for the failure as the mmc is not properly setup but the mmc core thinks it is and tries using it.

Quoted 4 lines

I've tried both using a U_BOOT_DEVICE() defined in the board file or adding the mmc node to arch/arm/dts/da850-lcdk-u-boot.dtsi.

Adam: you know davinci's SPL pretty well - do you have any suggestions?

I am not sure that I know it well. It's just one of several TI platforms that I support for Logic PD.

Two thoughts I had: There are aliases setup for various peripherals but I am not seeing one for mmc0 = &mmc1. I a not sure if it will help or not but it is different I see.

There is also a function void board_boot_order (u32 *spl_boot_list) which can force the system to boot from a given device (ie, MMC1). It's an optional function, but it's a quick and dirty option to try.

What are the jumper settings to boot from SD, I have an lcdk I can try when I have some time. It's not an official board I can support, but I can tinker when I'm off the clock.

adam

Quoted 2 lines

Bart

#34 lore raw

PATCH RESEND v2 12/13 davinci: omapl138-lcdk: enable driver-model in SPL

pt., 8 lis 2019 o 17:14 Adam Ford <[email protected]> napisał(a):

Quoted 44 lines
Quoted 41 lines · Bartosz Golaszewski

pt., 25 paź 2019 o 18:10 Bartosz Golaszewski <[email protected]> napisał(a):

Quoted 26 lines

czw., 26 wrz 2019 o 01:21 Faiz Abbas <[email protected]> napisał(a):

Quoted 10 lines

Hi,

Quoted 5 lines · Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

Enable CONFIG_SPL_DM and enable the driver model for serial by defining an appropriate device in the board file for da850-lcdk.

Quoted 5 lines

This breaks booting from MMC on omapl138_lcdk. You didn't add a U_BOOT_DEVICE for the mmc node.

Thanks,
Faiz

Just letting you know I haven't forgotten about this. I finally got some time to work on it this week, but it turned out to be non-trivial, as for some reason the set_cmd mmc callback is not being properly assigned in SPL with driver-model and I couldn't find out why so far. Next week I'm at ELCE, but I'll be back at it on Thursday. I'm not sure if you want to revert the offending patch for now or this can wait for another week?

Quoted 2 lines

Best regards,
Bartosz Golaszewski

I've been working on this some more this week and noticed that in SPL for some reason the bind function of the mmc driver is not called (despite the driver being probed fine), but so far I've been unable to figure out why exactly. This is the reason for the failure as the mmc is not properly setup but the mmc core thinks it is and tries using it.

I've tried both using a U_BOOT_DEVICE() defined in the board file or adding the mmc node to arch/arm/dts/da850-lcdk-u-boot.dtsi.

Quoted 9 lines
Quoted 1 line

Adam: you know davinci's SPL pretty well - do you have any suggestions?

I am not sure that I know it well. It's just one of several TI platforms that I support for Logic PD.

Two thoughts I had: There are aliases setup for various peripherals but I am not seeing one for mmc0 = &mmc1. I a not sure if it will help or not but it is different I see.

I'm having the same problem even when I'm defining the device using U_BOOT_DEVICE() in the relevant board file.

Quoted 4 lines

There is also a function void board_boot_order (u32 *spl_boot_list) which can force the system to boot from a given device (ie, MMC1). It's an optional function, but it's a quick and dirty option to try.

Thanks, I'll take a look at that.

Quoted 4 lines

What are the jumper settings to boot from SD, I have an lcdk I can try when I have some time. It's not an official board I can support, but I can tinker when I'm off the clock.

When looking at the board with the ethernet port in the upper-right corner the jumpers should be like this:

    ---^----

You can flash the .ais image onto an SD card with the following command:

    dd if=u-boot.ais of=<sdcard> seek=117 bs=512 conv=fsync

Thanks!
Bart

#35 lore raw

PATCH RESEND v2 12/13 davinci: omapl138-lcdk: enable driver-model in SPL

pt., 8 lis 2019 o 18:33 Bartosz Golaszewski
<[email protected]> napisał(a):

Quoted 59 lines

pt., 8 lis 2019 o 17:14 Adam Ford <[email protected]> napisał(a):

Quoted 44 lines
Quoted 41 lines · Bartosz Golaszewski

pt., 25 paź 2019 o 18:10 Bartosz Golaszewski <[email protected]> napisał(a):

Quoted 26 lines

czw., 26 wrz 2019 o 01:21 Faiz Abbas <[email protected]> napisał(a):

Quoted 10 lines

Hi,

Quoted 5 lines · Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

Enable CONFIG_SPL_DM and enable the driver model for serial by defining an appropriate device in the board file for da850-lcdk.

Quoted 5 lines

This breaks booting from MMC on omapl138_lcdk. You didn't add a U_BOOT_DEVICE for the mmc node.

Thanks,
Faiz

Just letting you know I haven't forgotten about this. I finally got some time to work on it this week, but it turned out to be non-trivial, as for some reason the set_cmd mmc callback is not being properly assigned in SPL with driver-model and I couldn't find out why so far. Next week I'm at ELCE, but I'll be back at it on Thursday. I'm not sure if you want to revert the offending patch for now or this can wait for another week?

Quoted 2 lines

Best regards,
Bartosz Golaszewski

I've been working on this some more this week and noticed that in SPL for some reason the bind function of the mmc driver is not called (despite the driver being probed fine), but so far I've been unable to figure out why exactly. This is the reason for the failure as the mmc is not properly setup but the mmc core thinks it is and tries using it.

I've tried both using a U_BOOT_DEVICE() defined in the board file or adding the mmc node to arch/arm/dts/da850-lcdk-u-boot.dtsi.

Quoted 9 lines
Quoted 1 line

Adam: you know davinci's SPL pretty well - do you have any suggestions?

I am not sure that I know it well. It's just one of several TI platforms that I support for Logic PD.

Two thoughts I had: There are aliases setup for various peripherals but I am not seeing one for mmc0 = &mmc1. I a not sure if it will help or not but it is different I see.

I'm having the same problem even when I'm defining the device using U_BOOT_DEVICE() in the relevant board file.

Quoted 6 lines
Quoted 4 lines

There is also a function void board_boot_order (u32 *spl_boot_list) which can force the system to boot from a given device (ie, MMC1). It's an optional function, but it's a quick and dirty option to try.

Thanks, I'll take a look at that.

It's still the same, no matter what order I specify here.

One thing that bothers me is: if I manually call mmc_bind() from probe instead of the bind() callback, it fails with ENOMEM on memory allocation when creating the block device. I'm wondering if it has something to do with the simple malloc we're using now.

Bart

Quoted 17 lines
Quoted 5 lines

What are the jumper settings to boot from SD, I have an lcdk I can try when I have some time. It's not an official board I can support, but I can tinker when I'm off the clock.

When looking at the board with the ethernet port in the upper-right corner the jumpers should be like this:

    ---^----

You can flash the .ais image onto an SD card with the following command:

    dd if=u-boot.ais of=<sdcard> seek=117 bs=512 conv=fsync

Thanks!
Bart

#36 lore raw

PATCH RESEND v2 12/13 davinci: omapl138-lcdk: enable driver-model in SPL

Quoted 67 lines · Bartosz Golaszewski

pt., 8 lis 2019 o 18:33 Bartosz Golaszewski
<[email protected]> napisał(a):

Quoted 64 lines

pt., 8 lis 2019 o 17:14 Adam Ford <[email protected]> napisał(a):

Quoted 44 lines
Quoted 41 lines · Bartosz Golaszewski

pt., 25 paź 2019 o 18:10 Bartosz Golaszewski <[email protected]> napisał(a):

Quoted 26 lines

czw., 26 wrz 2019 o 01:21 Faiz Abbas <[email protected]> napisał(a):

Quoted 10 lines

Hi,

Quoted 5 lines · Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

Enable CONFIG_SPL_DM and enable the driver model for serial by defining an appropriate device in the board file for da850-lcdk.

Quoted 5 lines

This breaks booting from MMC on omapl138_lcdk. You didn't add a U_BOOT_DEVICE for the mmc node.

Thanks,
Faiz

Just letting you know I haven't forgotten about this. I finally got some time to work on it this week, but it turned out to be non-trivial, as for some reason the set_cmd mmc callback is not being properly assigned in SPL with driver-model and I couldn't find out why so far. Next week I'm at ELCE, but I'll be back at it on Thursday. I'm not sure if you want to revert the offending patch for now or this can wait for another week?

Quoted 2 lines

Best regards,
Bartosz Golaszewski

I've been working on this some more this week and noticed that in SPL for some reason the bind function of the mmc driver is not called (despite the driver being probed fine), but so far I've been unable to figure out why exactly. This is the reason for the failure as the mmc is not properly setup but the mmc core thinks it is and tries using it.

I've tried both using a U_BOOT_DEVICE() defined in the board file or adding the mmc node to arch/arm/dts/da850-lcdk-u-boot.dtsi.

Quoted 9 lines
Quoted 1 line

Adam: you know davinci's SPL pretty well - do you have any suggestions?

I am not sure that I know it well. It's just one of several TI platforms that I support for Logic PD.

Two thoughts I had: There are aliases setup for various peripherals but I am not seeing one for mmc0 = &mmc1. I a not sure if it will help or not but it is different I see.

I'm having the same problem even when I'm defining the device using U_BOOT_DEVICE() in the relevant board file.

Quoted 4 lines

There is also a function void board_boot_order (u32 *spl_boot_list) which can force the system to boot from a given device (ie, MMC1). It's an optional function, but it's a quick and dirty option to try.

Quoted 8 lines
Quoted 1 line

Thanks, I'll take a look at that.

It's still the same, no matter what order I specify here.

One thing that bothers me is: if I manually call mmc_bind() from probe instead of the bind() callback, it fails with ENOMEM on memory allocation when creating the block device. I'm wondering if it has something to do with the simple malloc we're using now.

Over the weekend, I sent a series of patches. One of them, [1], was to increase the size of the available RAM before relocation. I believe i doubled the amount from 1k to 2k.

Can you see if the ENMOM error still exists?

[1] - https://patchwork.ozlabs.org/patch/1192574/

adam

Quoted 20 lines

Bart

Quoted 17 lines
Quoted 5 lines

What are the jumper settings to boot from SD, I have an lcdk I can try when I have some time. It's not an official board I can support, but I can tinker when I'm off the clock.

When looking at the board with the ethernet port in the upper-right corner the jumpers should be like this:

    ---^----

You can flash the .ais image onto an SD card with the following command:

    dd if=u-boot.ais of=<sdcard> seek=117 bs=512 conv=fsync

Thanks!
Bart

#37 lore raw

PATCH RESEND v2 12/13 davinci: omapl138-lcdk: enable driver-model in SPL

pon., 11 lis 2019 o 13:58 Adam Ford <[email protected]> napisał(a):

Quoted 78 lines · Bartosz Golaszewski
Quoted 67 lines

pt., 8 lis 2019 o 18:33 Bartosz Golaszewski
<[email protected]> napisał(a):

Quoted 64 lines

pt., 8 lis 2019 o 17:14 Adam Ford <[email protected]> napisał(a):

Quoted 44 lines
Quoted 41 lines · Bartosz Golaszewski

pt., 25 paź 2019 o 18:10 Bartosz Golaszewski <[email protected]> napisał(a):

Quoted 26 lines

czw., 26 wrz 2019 o 01:21 Faiz Abbas <[email protected]> napisał(a):

Quoted 10 lines

Hi,

Quoted 5 lines · Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

Enable CONFIG_SPL_DM and enable the driver model for serial by defining an appropriate device in the board file for da850-lcdk.

Quoted 5 lines

This breaks booting from MMC on omapl138_lcdk. You didn't add a U_BOOT_DEVICE for the mmc node.

Thanks,
Faiz

Just letting you know I haven't forgotten about this. I finally got some time to work on it this week, but it turned out to be non-trivial, as for some reason the set_cmd mmc callback is not being properly assigned in SPL with driver-model and I couldn't find out why so far. Next week I'm at ELCE, but I'll be back at it on Thursday. I'm not sure if you want to revert the offending patch for now or this can wait for another week?

Quoted 2 lines

Best regards,
Bartosz Golaszewski

I've been working on this some more this week and noticed that in SPL for some reason the bind function of the mmc driver is not called (despite the driver being probed fine), but so far I've been unable to figure out why exactly. This is the reason for the failure as the mmc is not properly setup but the mmc core thinks it is and tries using it.

I've tried both using a U_BOOT_DEVICE() defined in the board file or adding the mmc node to arch/arm/dts/da850-lcdk-u-boot.dtsi.

Quoted 9 lines
Quoted 1 line

Adam: you know davinci's SPL pretty well - do you have any suggestions?

I am not sure that I know it well. It's just one of several TI platforms that I support for Logic PD.

Two thoughts I had: There are aliases setup for various peripherals but I am not seeing one for mmc0 = &mmc1. I a not sure if it will help or not but it is different I see.

I'm having the same problem even when I'm defining the device using U_BOOT_DEVICE() in the relevant board file.

Quoted 4 lines

There is also a function void board_boot_order (u32 *spl_boot_list) which can force the system to boot from a given device (ie, MMC1). It's an optional function, but it's a quick and dirty option to try.

Quoted 8 lines
Quoted 1 line

Thanks, I'll take a look at that.

It's still the same, no matter what order I specify here.

One thing that bothers me is: if I manually call mmc_bind() from probe instead of the bind() callback, it fails with ENOMEM on memory allocation when creating the block device. I'm wondering if it has something to do with the simple malloc we're using now.

Quoted 6 lines

Over the weekend, I sent a series of patches. One of them, [1], was to increase the size of the available RAM before relocation. I believe i doubled the amount from 1k to 2k.

Can you see if the ENMOM error still exists?

Hi Adam,

thanks a lot, this helps with memory. I can even boot from mmc if I manually call mmc_bind() from probe, but the bind callback is still not called even with DM_FLAG_PRE_RELOC added to mmc driver's flags.

I'm still working on it though, must be some minor detail.

Bart

Quoted 23 lines

[1] - https://patchwork.ozlabs.org/patch/1192574/

adam

Quoted 20 lines

Bart

Quoted 17 lines
Quoted 5 lines

What are the jumper settings to boot from SD, I have an lcdk I can try when I have some time. It's not an official board I can support, but I can tinker when I'm off the clock.

When looking at the board with the ethernet port in the upper-right corner the jumpers should be like this:

    ---^----

You can flash the .ais image onto an SD card with the following command:

    dd if=u-boot.ais of=<sdcard> seek=117 bs=512 conv=fsync

Thanks!
Bart

#38 lore raw

PATCH RESEND v2 12/13 davinci: omapl138-lcdk: enable driver-model in SPL

śr., 13 lis 2019 o 11:52 Bartosz Golaszewski <[email protected]> napisał(a):

Quoted 87 lines

pon., 11 lis 2019 o 13:58 Adam Ford <[email protected]> napisał(a):

Quoted 78 lines · Bartosz Golaszewski
Quoted 67 lines

pt., 8 lis 2019 o 18:33 Bartosz Golaszewski
<[email protected]> napisał(a):

Quoted 64 lines

pt., 8 lis 2019 o 17:14 Adam Ford <[email protected]> napisał(a):

Quoted 44 lines
Quoted 41 lines · Bartosz Golaszewski

pt., 25 paź 2019 o 18:10 Bartosz Golaszewski <[email protected]> napisał(a):

Quoted 26 lines

czw., 26 wrz 2019 o 01:21 Faiz Abbas <[email protected]> napisał(a):

Quoted 10 lines

Hi,

Quoted 5 lines · Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

Enable CONFIG_SPL_DM and enable the driver model for serial by defining an appropriate device in the board file for da850-lcdk.

Quoted 5 lines

This breaks booting from MMC on omapl138_lcdk. You didn't add a U_BOOT_DEVICE for the mmc node.

Thanks,
Faiz

Just letting you know I haven't forgotten about this. I finally got some time to work on it this week, but it turned out to be non-trivial, as for some reason the set_cmd mmc callback is not being properly assigned in SPL with driver-model and I couldn't find out why so far. Next week I'm at ELCE, but I'll be back at it on Thursday. I'm not sure if you want to revert the offending patch for now or this can wait for another week?

Quoted 2 lines

Best regards,
Bartosz Golaszewski

I've been working on this some more this week and noticed that in SPL for some reason the bind function of the mmc driver is not called (despite the driver being probed fine), but so far I've been unable to figure out why exactly. This is the reason for the failure as the mmc is not properly setup but the mmc core thinks it is and tries using it.

I've tried both using a U_BOOT_DEVICE() defined in the board file or adding the mmc node to arch/arm/dts/da850-lcdk-u-boot.dtsi.

Quoted 9 lines
Quoted 1 line

Adam: you know davinci's SPL pretty well - do you have any suggestions?

I am not sure that I know it well. It's just one of several TI platforms that I support for Logic PD.

Two thoughts I had: There are aliases setup for various peripherals but I am not seeing one for mmc0 = &mmc1. I a not sure if it will help or not but it is different I see.

I'm having the same problem even when I'm defining the device using U_BOOT_DEVICE() in the relevant board file.

Quoted 4 lines

There is also a function void board_boot_order (u32 *spl_boot_list) which can force the system to boot from a given device (ie, MMC1). It's an optional function, but it's a quick and dirty option to try.

Quoted 8 lines
Quoted 1 line

Thanks, I'll take a look at that.

It's still the same, no matter what order I specify here.

One thing that bothers me is: if I manually call mmc_bind() from probe instead of the bind() callback, it fails with ENOMEM on memory allocation when creating the block device. I'm wondering if it has something to do with the simple malloc we're using now.

Quoted 6 lines

Over the weekend, I sent a series of patches. One of them, [1], was to increase the size of the available RAM before relocation. I believe i doubled the amount from 1k to 2k.

Can you see if the ENMOM error still exists?

Quoted 8 lines

Hi Adam,

thanks a lot, this helps with memory. I can even boot from mmc if I manually call mmc_bind() from probe, but the bind callback is still not called even with DM_FLAG_PRE_RELOC added to mmc driver's flags.

I'm still working on it though, must be some minor detail.

I noticed that calling mmc_bind() from probe() actually results in davinci_mmc_bind() being called. Is this expected? Because all the latter function does is call mmc_bind() again. This doesn't seem right
- should someone else call mmc_bind in SPL maybe?

Quoted 25 lines

Bart

Quoted 23 lines

[1] - https://patchwork.ozlabs.org/patch/1192574/

adam

Quoted 20 lines

Bart

Quoted 17 lines
Quoted 5 lines

What are the jumper settings to boot from SD, I have an lcdk I can try when I have some time. It's not an official board I can support, but I can tinker when I'm off the clock.

When looking at the board with the ethernet port in the upper-right corner the jumpers should be like this:

    ---^----

You can flash the .ais image onto an SD card with the following command:

    dd if=u-boot.ais of=<sdcard> seek=117 bs=512 conv=fsync

Thanks!
Bart

#39 lore raw

PATCH RESEND v2 12/13 davinci: omapl138-lcdk: enable driver-model in SPL

In reply to Bartosz Golaszewski

Hi Bartosz,

Quoted 27 lines · Bartosz Golaszewski

pt., 25 paź 2019 o 18:10 Bartosz Golaszewski <[email protected]> napisał(a):

Quoted 26 lines

czw., 26 wrz 2019 o 01:21 Faiz Abbas <[email protected]> napisał(a):

Quoted 10 lines

Hi,

Quoted 5 lines · Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

Enable CONFIG_SPL_DM and enable the driver model for serial by defining an appropriate device in the board file for da850-lcdk.

Quoted 5 lines

This breaks booting from MMC on omapl138_lcdk. You didn't add a U_BOOT_DEVICE for the mmc node.

Thanks,
Faiz

Just letting you know I haven't forgotten about this. I finally got some time to work on it this week, but it turned out to be non-trivial, as for some reason the set_cmd mmc callback is not being properly assigned in SPL with driver-model and I couldn't find out why so far. Next week I'm at ELCE, but I'll be back at it on Thursday. I'm not sure if you want to revert the offending patch for now or this can wait for another week?

Quoted 7 lines
Quoted 2 lines

Best regards,
Bartosz Golaszewski

I've been working on this some more this week and noticed that in SPL for some reason the bind function of the mmc driver is not called (despite the driver being probed fine), but so far I've been unable to figure out why exactly.

I suspect you need to set DM_FLAG_PRE_RELOC for the bind to be called. Can you try setting this flag?

Thanks,
Faiz

#40 lore raw

PATCH RESEND v2 13/13 configs: omapl138_lcdk: enable NAND self-init in SPL

In reply to Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

Now that we have enabled the driver-model in SPL, we can remove the code disabling NAND self-init in SPL from the config include for omapl138-lcdk.

---
 include/configs/omapl138_lcdk.h | 4 ----
 1 file changed, 4 deletions(-)
include/configs/omapl138_lcdk.h +0 -4
index 20fd7ff713..db4a663c53 100644
@@ -168,10 +168,6 @@
 #define CONFIG_SPL_NAND_DRIVERS
 #define CONFIG_SPL_NAND_ECC
 #define CONFIG_SPL_NAND_LOAD
-
-#ifndef CONFIG_SPL_BUILD
-#define CONFIG_SYS_NAND_SELF_INIT
-#endif
 #endif
 
 #ifdef CONFIG_SYS_USE_NOR
Signature · 1 line
2.21.0
#41 lore raw

PATCH RESEND v2 13/13 configs: omapl138_lcdk: enable NAND self-init in SPL

Quoted 7 lines · Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

Now that we have enabled the driver-model in SPL, we can remove the code disabling NAND self-init in SPL from the config include for omapl138-lcdk.

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190729/56119cb1/attachment.sig>