Skip to contentSkip to conversation

drm/nouveau/devinit: Move assignment outside if condition

PATCH New [email protected] 1 participant 1 message Jul 11, 2023 1 message not in the archive

Subsystems (3)
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

PATCH 1/1 drm/nouveau/devinit: Move assignment outside if condition

Fixes the following checkpatch errors:

ERROR: do not use assignment in if condition

---
 drivers/gpu/drm/nouveau/nvkm/subdev/devinit/nv05.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/nouveau/nvkm/subdev/devinit/nv05.c +2 -1
index 1410befd2285..8185e10efc49 100644
@@ -61,7 +61,8 @@ nv05_devinit_meminit(struct nvkm_devinit *init)
     }
 
     strap = (nvkm_rd32(device, 0x101000) & 0x0000003c) >> 2;
-    if ((data = bmp_mem_init_table(bios))) {
+    data = bmp_mem_init_table(bios);
+    if (data) {
         ramcfg[0] = nvbios_rd08(bios, data + 2 * strap + 0);
         ramcfg[1] = nvbios_rd08(bios, data + 2 * strap + 1);
     } else {