Skip to contentSkip to conversation

Wrong shift in dce_v8_0_afmt_update_ACR() under dce_v8_0.c?

DISCUSSION Alexandre Demers 2 participants 2 messages Aug 8, 2016 – Aug 9, 2016 1 message not in the archive

lore
Share & tools
lore
#0 lore raw

Hi,

While looking into dce_v8_0.c, I stumbled upon something that might be wrong dce_v8_0_afmt_update_ACR(). We can read:

WREG32(mmHDMI_ACR_32_0 + offset, (acr.cts_32khz << HDMI_ACR_44_0__HDMI_ACR_CTS_44__SHIFT));

However, I'm mostly sure it should be (luckily, the shift is of the same value):

WREG32(mmHDMI_ACR_32_0 + offset, (acr.cts_32khz << HDMI_ACR_32_0__HDMI_ACR_CTS_32__SHIFT));

Cheers

Signature · 6 lines
Alexandre Demers

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): cd6f0c44-3307-ced9-aac6-fe6cbb8842ea-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org

#2 lore raw
Quoted 5 lines · Alexandre Demers

Hi,

While looking into dce_v8_0.c, I stumbled upon something that might be wrong dce_v8_0_afmt_update_ACR(). We can read:

Quoted 8 lines

WREG32(mmHDMI_ACR_32_0 + offset, (acr.cts_32khz << HDMI_ACR_44_0__HDMI_ACR_CTS_44__SHIFT));

However, I'm mostly sure it should be (luckily, the shift is of the same value):

WREG32(mmHDMI_ACR_32_0 + offset, (acr.cts_32khz << HDMI_ACR_32_0__HDMI_ACR_CTS_32__SHIFT));

Yeah, copy/paste error.

Alex

Quoted 10 lines

Cheers

--
Alexandre Demers

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx