Skip to contentSkip to conversation

drm/radeon: drop confusing message about backlight control

PATCH In review Alex Deucher 2 participants 2 messages Jul 27, 2016 – Jul 28, 2016 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/radeon: drop confusing message about backlight control

The message is harmless and confusing. On PX systems, there is one ATIF method, but potentially multiple GPUs leading to an error on the GPU with no backlight control.

---
 drivers/gpu/drm/radeon/radeon_acpi.c | 7 -------
 1 file changed, 7 deletions(-)
drivers/gpu/drm/radeon/radeon_acpi.c +0 -7
index 59acd0e..31c9a92 100644
@@ -741,13 +741,6 @@ int radeon_acpi_init(struct radeon_device *rdev)
 		}
 
 		atif->encoder_for_bl = target;
-		if (!target) {
-			/* Brightness change notification is enabled, but we
-			 * didn't find a backlight controller, this should
-			 * never happen.
-			 */
-			DRM_ERROR("Cannot find a backlight controller\n");
-		}
 	}
 
 	if (atif->functions.sbios_requests && !atif->functions.system_params) {
Signature · 6 lines
2.5.5

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 1469652299-3117-1-git-send-email-alexander.deucher-5C7GfCeVMHo@public.gmane.org

Reviewed-by
#2 lore raw

Alexandre Demers

Quoted 19 lines · Alex Deucher

The message is harmless and confusing. On PX systems, there is one ATIF method, but potentially multiple GPUs leading to an error on the GPU with no backlight control.

---
  drivers/gpu/drm/radeon/radeon_acpi.c | 7 -------
  1 file changed, 7 deletions(-)
drivers/gpu/drm/radeon/radeon_acpi.c +0 -0
index 59acd0e..31c9a92 100644
@@ -741,13 +741,6 @@ int radeon_acpi_init(struct radeon_device *rdev)
  		}
 
  		atif->encoder_for_bl = target;

drivers/gpu/drm/radeon/radeon_acpi.c int radeon_acpi_init(struct radeon_device *rdev) · line 746

Quoted 10 lines
drivers/gpu/drm/radeon/radeon_acpi.c +0 -7
-		if (!target) {
-			/* Brightness change notification is enabled, but we
-			 * didn't find a backlight controller, this should
-			 * never happen.
-			 */
-			DRM_ERROR("Cannot find a backlight controller\n");
-		}
  	}
 
  	if (atif->functions.sbios_requests && !atif->functions.system_params) {

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx