Skip to contentSkip to conversation

ARM: tegra: add "jedec,spi-nor" flash compatible binding

PATCH Applied Rafał Miłecki 4 participants 5 messages Aug 16, 2015 – Feb 6, 2019

Subsystems (3)
Device tree bindings Memory technology devices (MTD) Tegra architecture support
lore
Share & tools
lore

Rafał Miłecki

author
#0 lore raw

PATCH 1/1 ARM: tegra: add "jedec,spi-nor" flash compatible binding

Starting with commit 8947e396a829 ("Documentation: dt: mtd: replace "nor-jedec" binding with "jedec, spi-nor"") we have "jedec,spi-nor" binding indicating support for JEDEC identification.

Use it for all flashes that are supposed to support READ ID op according to the datasheets.

Signed-off-by Rafa? Mi?ecki <[email protected]>
---
 arch/arm/boot/dts/tegra114-dalmore.dts    | 2 +-
 arch/arm/boot/dts/tegra124-jetson-tk1.dts | 2 +-
 arch/arm/boot/dts/tegra124-nyan.dtsi      | 2 +-
 arch/arm/boot/dts/tegra124-venice2.dts    | 2 +-
 arch/arm/boot/dts/tegra20-trimslice.dts   | 2 +-
 arch/arm/boot/dts/tegra30-beaver.dts      | 2 +-
 arch/arm/boot/dts/tegra30-cardhu.dtsi     | 2 +-
 7 files changed, 7 insertions(+), 7 deletions(-)
arch/arm/boot/dts/tegra114-dalmore.dts +1 -1
index 8b7aa0d..5de23de 100644
@@ -1082,7 +1082,7 @@
 		status = "okay";
 		spi-max-frequency = <25000000>;
 		spi-flash at 0 {
-			compatible = "winbond,w25q32dw";
+			compatible = "winbond,w25q32dw", "jedec,spi-nor";
 			reg = <0>;
 			spi-max-frequency = <20000000>;
 		};
arch/arm/boot/dts/tegra124-jetson-tk1.dts +1 -1
index bd43ed6..44097c6 100644
@@ -1611,7 +1611,7 @@
 		status = "okay";
 		spi-max-frequency = <25000000>;
 		spi-flash at 0 {
-			compatible = "winbond,w25q32dw";
+			compatible = "winbond,w25q32dw", "jedec,spi-nor";
 			reg = <0>;
 			spi-max-frequency = <20000000>;
 		};
arch/arm/boot/dts/tegra124-nyan.dtsi +1 -1
index a9aec23..7d26f49 100644
@@ -343,7 +343,7 @@
 		spi-max-frequency = <25000000>;
 
 		flash at 0 {
-			compatible = "winbond,w25q32dw";
+			compatible = "winbond,w25q32dw", "jedec,spi-nor";
 			spi-max-frequency = <25000000>;
 			reg = <0>;
 		};
arch/arm/boot/dts/tegra124-venice2.dts +1 -1
index 79e724b..4decb3c 100644
@@ -866,7 +866,7 @@
 		status = "okay";
 		spi-max-frequency = <25000000>;
 		spi-flash at 0 {
-			compatible = "winbond,w25q32dw";
+			compatible = "winbond,w25q32dw", "jedec,spi-nor";
 			reg = <0>;
 			spi-max-frequency = <20000000>;
 		};
arch/arm/boot/dts/tegra20-trimslice.dts +1 -1
index d99af4e..c4cff8b 100644
@@ -282,7 +282,7 @@
 		status = "okay";
 		spi-max-frequency = <48000000>;
 		spi-flash at 0 {
-			compatible = "winbond,w25q80bl";
+			compatible = "winbond,w25q80bl", "jedec,spi-nor";
 			reg = <0>;
 			spi-max-frequency = <48000000>;
 		};
arch/arm/boot/dts/tegra30-beaver.dts +1 -1
index 3dede39..c9d230c 100644
@@ -1884,7 +1884,7 @@
 		status = "okay";
 		spi-max-frequency = <25000000>;
 		spi-flash at 1 {
-			compatible = "winbond,w25q32";
+			compatible = "winbond,w25q32", "jedec,spi-nor";
 			reg = <1>;
 			spi-max-frequency = <20000000>;
 		};
arch/arm/boot/dts/tegra30-cardhu.dtsi +1 -1
index bb1ca15..df7f845 100644
@@ -354,7 +354,7 @@
 		status = "okay";
 		spi-max-frequency = <25000000>;
 		spi-flash at 1 {
-			compatible = "winbond,w25q32";
+			compatible = "winbond,w25q32", "jedec,spi-nor";
 			reg = <1>;
 			spi-max-frequency = <20000000>;
 		};
Signature · 1 line
1.8.4.5
author
#1 lore raw

PATCH 1/1 ARM: tegra: add "jedec,spi-nor" flash compatible binding

Quoted 6 lines · Rafa? Mi?ecki

Starting with commit 8947e396a829 ("Documentation: dt: mtd: replace "nor-jedec" binding with "jedec, spi-nor"") we have "jedec,spi-nor" binding indicating support for JEDEC identification.

Use it for all flashes that are supposed to support READ ID op according to the datasheets.

Hi, for some reason it seems this patch wasn't applied. I didn't get any comment and it was sent to all e-mails listed in MAINTAINERS in TEGRA ARCHITECTURE SUPPORT
which I hope it enough.

Could someone pick it, please? FWIW you can find it in the patchwork:
http://patchwork.ozlabs.org/patch/507676/

#2 lore raw

PATCH 1/1 ARM: tegra: add "jedec,spi-nor" flash compatible binding

In reply to Rafał Miłecki
Quoted 8 lines · Rafa? Mi?ecki

Starting with commit 8947e396a829 ("Documentation: dt: mtd: replace "nor-jedec" binding with "jedec, spi-nor"") we have "jedec,spi-nor" binding indicating support for JEDEC identification.

Use it for all flashes that are supposed to support READ ID op according to the datasheets.

Signed-off-by Rafa? Mi?ecki <[email protected]>
Quoted 9 lines
---
 arch/arm/boot/dts/tegra114-dalmore.dts    | 2 +-
 arch/arm/boot/dts/tegra124-jetson-tk1.dts | 2 +-
 arch/arm/boot/dts/tegra124-nyan.dtsi      | 2 +-
 arch/arm/boot/dts/tegra124-venice2.dts    | 2 +-
 arch/arm/boot/dts/tegra20-trimslice.dts   | 2 +-
 arch/arm/boot/dts/tegra30-beaver.dts      | 2 +-
 arch/arm/boot/dts/tegra30-cardhu.dtsi     | 2 +-
 7 files changed, 7 insertions(+), 7 deletions(-)

FWIW:

Acked-by Brian Norris <[email protected]>
maintainer Acked-by on v1 1/1
#3 lore raw
In reply to Rafał Miłecki
Quoted 102 lines · Rafał Miłecki

Starting with commit 8947e396a829 ("Documentation: dt: mtd: replace "nor-jedec" binding with "jedec, spi-nor"") we have "jedec,spi-nor" binding indicating support for JEDEC identification.

Use it for all flashes that are supposed to support READ ID op according to the datasheets.

Signed-off-by Rafał Miłecki <[email protected]>
---
 arch/arm/boot/dts/tegra114-dalmore.dts    | 2 +-
 arch/arm/boot/dts/tegra124-jetson-tk1.dts | 2 +-
 arch/arm/boot/dts/tegra124-nyan.dtsi      | 2 +-
 arch/arm/boot/dts/tegra124-venice2.dts    | 2 +-
 arch/arm/boot/dts/tegra20-trimslice.dts   | 2 +-
 arch/arm/boot/dts/tegra30-beaver.dts      | 2 +-
 arch/arm/boot/dts/tegra30-cardhu.dtsi     | 2 +-
 7 files changed, 7 insertions(+), 7 deletions(-)
arch/arm/boot/dts/tegra114-dalmore.dts +1 -1
index 8b7aa0d..5de23de 100644
@@ -1082,7 +1082,7 @@
 		status = "okay";
 		spi-max-frequency = <25000000>;
 		spi-flash@0 {
-			compatible = "winbond,w25q32dw";
+			compatible = "winbond,w25q32dw", "jedec,spi-nor";
 			reg = <0>;
 			spi-max-frequency = <20000000>;
 		};
arch/arm/boot/dts/tegra124-jetson-tk1.dts +1 -1
index bd43ed6..44097c6 100644
@@ -1611,7 +1611,7 @@
 		status = "okay";
 		spi-max-frequency = <25000000>;
 		spi-flash@0 {
-			compatible = "winbond,w25q32dw";
+			compatible = "winbond,w25q32dw", "jedec,spi-nor";
 			reg = <0>;
 			spi-max-frequency = <20000000>;
 		};
arch/arm/boot/dts/tegra124-nyan.dtsi +1 -1
index a9aec23..7d26f49 100644
@@ -343,7 +343,7 @@
 		spi-max-frequency = <25000000>;
 
 		flash@0 {
-			compatible = "winbond,w25q32dw";
+			compatible = "winbond,w25q32dw", "jedec,spi-nor";
 			spi-max-frequency = <25000000>;
 			reg = <0>;
 		};
arch/arm/boot/dts/tegra124-venice2.dts +1 -1
index 79e724b..4decb3c 100644
@@ -866,7 +866,7 @@
 		status = "okay";
 		spi-max-frequency = <25000000>;
 		spi-flash@0 {
-			compatible = "winbond,w25q32dw";
+			compatible = "winbond,w25q32dw", "jedec,spi-nor";
 			reg = <0>;
 			spi-max-frequency = <20000000>;
 		};
arch/arm/boot/dts/tegra20-trimslice.dts +1 -1
index d99af4e..c4cff8b 100644
@@ -282,7 +282,7 @@
 		status = "okay";
 		spi-max-frequency = <48000000>;
 		spi-flash@0 {
-			compatible = "winbond,w25q80bl";
+			compatible = "winbond,w25q80bl", "jedec,spi-nor";
 			reg = <0>;
 			spi-max-frequency = <48000000>;
 		};
arch/arm/boot/dts/tegra30-beaver.dts +1 -1
index 3dede39..c9d230c 100644
@@ -1884,7 +1884,7 @@
 		status = "okay";
 		spi-max-frequency = <25000000>;
 		spi-flash@1 {
-			compatible = "winbond,w25q32";
+			compatible = "winbond,w25q32", "jedec,spi-nor";
 			reg = <1>;
 			spi-max-frequency = <20000000>;
 		};
arch/arm/boot/dts/tegra30-cardhu.dtsi +0 -0
index bb1ca15..df7f845 100644

arch/arm/boot/dts/tegra30-cardhu.dtsi line 360

Quoted 8 lines
arch/arm/boot/dts/tegra30-cardhu.dtsi +1 -1
@@ -354,7 +354,7 @@
 		status = "okay";
 		spi-max-frequency = <25000000>;
 		spi-flash@1 {
-			compatible = "winbond,w25q32";
+			compatible = "winbond,w25q32", "jedec,spi-nor";
 			reg = <1>;
 			spi-max-frequency = <20000000>;
 		};

Looks like this one got lost, but still applies cleanly so ...

Acked-by Jon Hunter <[email protected]>

Cheers
Jon

Signature · 1 line
nvpublic
Applied
#4 lore raw
In reply to Rafał Miłecki
Quoted 8 lines · Rafał Miłecki

Starting with commit 8947e396a829 ("Documentation: dt: mtd: replace "nor-jedec" binding with "jedec, spi-nor"") we have "jedec,spi-nor" binding indicating support for JEDEC identification.

Use it for all flashes that are supposed to support READ ID op according to the datasheets.

Signed-off-by Rafał Miłecki <[email protected]>
Quoted 9 lines
---
 arch/arm/boot/dts/tegra114-dalmore.dts    | 2 +-
 arch/arm/boot/dts/tegra124-jetson-tk1.dts | 2 +-
 arch/arm/boot/dts/tegra124-nyan.dtsi      | 2 +-
 arch/arm/boot/dts/tegra124-venice2.dts    | 2 +-
 arch/arm/boot/dts/tegra20-trimslice.dts   | 2 +-
 arch/arm/boot/dts/tegra30-beaver.dts      | 2 +-
 arch/arm/boot/dts/tegra30-cardhu.dtsi     | 2 +-
 7 files changed, 7 insertions(+), 7 deletions(-)

Applied, thanks.

Thierry

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel