crypto: qat - use kcalloc_node() instead of kzalloc_node()
Subsystems (2)
PATCH 1/1 crypto: qat - use kcalloc_node() instead of kzalloc_node()
As noted in the "Deprecated Interfaces, Language Features, Attributes, and Conventions" documentation [1], size calculations (especially multiplication) should not be performed in memory allocator (or similar) function arguments due to the risk of them overflowing. This could lead to values wrapping around and a smaller allocation being made than the caller was expecting. Using those allocations could lead to linear overflows of heap memory and other misbehaviors.
So, use the purpose specific kcalloc_node() function instead of the argument count * size in the kzalloc_node() function.
--- drivers/crypto/intel/qat/qat_common/adf_isr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/crypto/intel/qat/qat_common/adf_isr.c +1 -1
@@ -272,7 +272,7 @@ static int adf_isr_alloc_msix_vectors_data(struct adf_accel_dev *accel_dev)if (!accel_dev->pf.vf_info) msix_num_entries += hw_data->num_banks; - irqs =kzalloc_node (msix_num_entries *sizeof (*irqs), + irqs =kcalloc_node (msix_num_entries,sizeof (*irqs),GFP_KERNEL ,dev_to_node (&GET_DEV (accel_dev)));if (!irqs)return -ENOMEM ;
--
2.25.1
Quoted 8 lines · Erick Archer
As noted in the "Deprecated Interfaces, Language Features, Attributes, and Conventions" documentation [1], size calculations (especially multiplication) should not be performed in memory allocator (or similar) function arguments due to the risk of them overflowing. This could lead to values wrapping around and a smaller allocation being made than the caller was expecting. Using those allocations could lead to linear overflows of heap memory and other misbehaviors.
Quoted 6 lines
So, use the purpose specific
kcalloc_node()function instead of the argument count * size in thekzalloc_node()function.
Thanks!
Signature · 1 line
Gustavo
Quoted 20 lines
--- drivers/crypto/intel/qat/qat_common/adf_isr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/crypto/intel/qat/qat_common/adf_isr.c +1
-2@@ -272,7 +272,7 @@ static int adf_isr_alloc_msix_vectors_data(struct adf_accel_dev *accel_dev)if (!accel_dev->pf.vf_info) msix_num_entries += hw_data->num_banks; - irqs =kzalloc_node (msix_num_entries *sizeof (*irqs), + irqs =kcalloc_node (msix_num_entries,sizeof (*irqs),GFP_KERNEL ,dev_to_node (&GET_DEV (accel_dev)));if (!irqs)return -ENOMEM ; --2.25.1
Quoted 8 lines · Erick Archer
As noted in the "Deprecated Interfaces, Language Features, Attributes, and Conventions" documentation [1], size calculations (especially multiplication) should not be performed in memory allocator (or similar) function arguments due to the risk of them overflowing. This could lead to values wrapping around and a smaller allocation being made than the caller was expecting. Using those allocations could lead to linear overflows of heap memory and other misbehaviors.
Quoted 6 lines
So, use the purpose specific
kcalloc_node()function instead of the argument count * size in thekzalloc_node()function.
Herbert Xu
maintainerQuoted 11 lines · Erick Archer
As noted in the "Deprecated Interfaces, Language Features, Attributes, and Conventions" documentation [1], size calculations (especially multiplication) should not be performed in memory allocator (or similar) function arguments due to the risk of them overflowing. This could lead to values wrapping around and a smaller allocation being made than the caller was expecting. Using those allocations could lead to linear overflows of heap memory and other misbehaviors.
So, use the purpose specific
kcalloc_node()function instead of the argument count * size in thekzalloc_node()function.
Quoted 6 lines
Signed-off-by Erick Archer <[email protected]>--- drivers/crypto/intel/qat/qat_common/adf_isr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Patch applied. Thanks.
Signature · 3 lines
Email: Herbert Xu <[email protected]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt