IB/hfi1: Avoid -Wflex-array-member-not-at-end warning
Subsystems (2)
PATCH 1/1 IB/hfi1: Avoid -Wflex-array-member-not-at-end warning
-Wflex-array-member-not-at-end was introduced in GCC-14, and we are getting ready to enable it, globally.
Move the conflicting declaration to the end of the structure. Notice that struct opa_mad_notice_attr is a flexible structure --a structure that contains a flexible-array member.
Fix the following warning:
drivers/infiniband/hw/hfi1/mad.c:23:36: warning: structure containing a flexible array member is not at the end of another structure [-Wflex-array-member-not-at-end]
--- drivers/infiniband/hw/hfi1/mad.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/infiniband/hw/hfi1/mad.c +3 -1
@@ -20,12 +20,14 @@struct trap_node {struct list_head list; -struct opa_mad_notice_attr data;__be64 tid;int len;u32 retry;u8 in_use;u8 repress; + +/* Must be last --ends in a flexible-array member. */ +struct opa_mad_notice_attr data; };static int smp_length_check (u32 data_size,u32 request_len)
Signature · 1 line
2.43.0
Quoted 7 lines · Gustavo A. R. Silva
-Wflex-array-member-not-at-end was introduced in GCC-14, and we are getting ready to enable it, globally.
Move the conflicting declaration to the end of the structure. Notice that
struct opa_mad_notice_attris a flexible structure --a structure that contains a flexible-array member.
Quoted 5 lines
Fix the following warning:
drivers/infiniband/hw/hfi1/mad.c:23:36: warning: structure containing a flexible array member is not at the end of another structure [-Wflex-array-member-not-at-end]Signed-off-by Gustavo A. R. Silva <[email protected]>
Thanks,
Zhu Yanjun
Quoted 24 lines
--- drivers/infiniband/hw/hfi1/mad.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)drivers/infiniband/hw/hfi1/mad.c +3
-1@@ -20,12 +20,14 @@struct trap_node {struct list_head list; -struct opa_mad_notice_attr data;__be64 tid;int len;u32 retry;u8 in_use;u8 repress; + +/* Must be last --ends in a flexible-array member. */ +struct opa_mad_notice_attr data; };static int smp_length_check (u32 data_size,u32 request_len)