RDMA/cxgb4: Delete an unnecessary check before kfree() in c4iw_rdev_open()
Subsystems (3)
PATCH 1/1 RDMA/cxgb4: Delete an unnecessary check before kfree() in c4iw_rdev_open()
From: Markus Elfring <[email protected]>
Date: Tue, 10 Jun 2025 14:14:09 +0200
It can be known that the function “kfree” performs a null pointer check for its input parameter.
It is therefore not needed to repeat such a check before its call.
Thus remove a redundant pointer check.
The source code was transformed by using the Coccinelle software.
--- drivers/infiniband/hw/cxgb4/device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/infiniband/hw/cxgb4/device.c +1 -1
@@ -905,7 +905,7 @@ static int c4iw_rdev_open(struct c4iw_rdev *rdev)return 0 ; err_free_status_page_and_wr_log: -if (c4iw_wr_log && rdev->wr_log) +if (c4iw_wr_log)kfree (rdev->wr_log);free_page ((unsigned long )rdev->status_page); destroy_ocqp_pool:
Signature · 1 line
2.49.0
Quoted 21 lines · Markus Elfring
From: Markus Elfring <[email protected]>
Date: Tue, 10 Jun 2025 14:14:09 +0200It can be known that the function “kfree” performs a null pointer check for its input parameter.
It is therefore not needed to repeat such a check before its call.Thus remove a redundant pointer check.
The source code was transformed by using the Coccinelle software.
Signed-off-by Markus Elfring <[email protected]>--- drivers/infiniband/hw/cxgb4/device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/infiniband/hw/cxgb4/device.c +0
-0
drivers/infiniband/hw/cxgb4/device.c static int c4iw_rdev_open(struct c4iw_rdev *rdev) · line 908
Quoted 5 lines
drivers/infiniband/hw/cxgb4/device.c +1
-1@@ -905,7 +905,7 @@ static int c4iw_rdev_open(struct c4iw_rdev *rdev)return 0 ; err_free_status_page_and_wr_log: -if (c4iw_wr_log && rdev->wr_log) +if (c4iw_wr_log)
This is not needed too, fixed locally.
Quoted 7 lines
drivers/infiniband/hw/cxgb4/device.c +0
-0kfree (rdev->wr_log);free_page ((unsigned long )rdev->status_page); destroy_ocqp_pool:Signature · 1 line
2.49.0
Leon Romanovsky
AppliedQuoted 9 lines · Markus Elfring
It can be known that the function “kfree” performs a null pointer check for its input parameter.
It is therefore not needed to repeat such a check before its call.Thus remove a redundant pointer check.
The source code was transformed by using the Coccinelle software.
[...]
Applied, thanks!
[1/1] RDMA/cxgb4: Delete an unnecessary check before kfree() in c4iw_rdev_open()
https://git.kernel.org/rdma/rdma/c/fd383bf8b6954d
Best regards,
Signature · 1 line
Leon Romanovsky <[email protected]>