Skip to contentSkip to conversation

mtd: spinand: winbond: Add support for W25N01GV

PATCH Applied Robert Marko 3 participants 4 messages Oct 6, 2018 – Nov 11, 2018

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mtd: spinand: winbond: Add support for W25N01GV

W25N01GV is a single die version of the already supported W25M02GV with half the capacity. Everything else is the same so introduce support for W25N01GV.

Datasheet:http://www.winbond.com/resource-files/w25n01gv%20revl%20050918%20unsecured.pdf

Tested on 8devices Jalapeno dev board under OpenWrt running 4.19-rc5.

---
 drivers/mtd/nand/spi/winbond.c | 8 ++++++++
 1 file changed, 8 insertions(+)
drivers/mtd/nand/spi/winbond.c +8 -0
@@ -84,6 +84,14 @@ static const struct spinand_info winbond
 		     0,
 		     SPINAND_ECCINFO(&w25m02gv_ooblayout, NULL),
 		     SPINAND_SELECT_TARGET(w25m02gv_select_target)),
+	SPINAND_INFO("W25N01GV", 0xAA,
+		     NAND_MEMORG(1, 2048, 64, 64, 1024, 1, 1, 1),
+		     NAND_ECCREQ(1, 512),
+		     SPINAND_INFO_OP_VARIANTS(&read_cache_variants,
+					      &write_cache_variants,
+					      &update_cache_variants),
+		     0,
+		     SPINAND_ECCINFO(&w25m02gv_ooblayout, NULL)),
 };
 
 /**
Reviewed-by on v1 1/1
#1 lore raw

+Miquel

Hi Robert,

Please Cc the NAND mantainers when you send a NAND related patch (in case you don't know about it already, scripts/get_maintainer.pl should help you find who to Cc).

Quoted 9 lines · On Sat, 6 Oct 2018 17:36:42 +0200 Robert Marko <[email protected]> wrote:

W25N01GV is a single die version of the already supported W25M02GV with half the capacity. Everything else is the same so introduce support for W25N01GV.

Datasheet:http://www.winbond.com/resource-files/w25n01gv%20revl%20050918%20unsecured.pdf

Tested on 8devices Jalapeno dev board under OpenWrt running 4.19-rc5.

Looks good.

Quoted 25 lines
---
 drivers/mtd/nand/spi/winbond.c | 8 ++++++++
 1 file changed, 8 insertions(+)
drivers/mtd/nand/spi/winbond.c +8 -0
@@ -84,6 +84,14 @@ static const struct spinand_info winbond
 		     0,
 		     SPINAND_ECCINFO(&w25m02gv_ooblayout, NULL),
 		     SPINAND_SELECT_TARGET(w25m02gv_select_target)),
+	SPINAND_INFO("W25N01GV", 0xAA,
+		     NAND_MEMORG(1, 2048, 64, 64, 1024, 1, 1, 1),
+		     NAND_ECCREQ(1, 512),
+		     SPINAND_INFO_OP_VARIANTS(&read_cache_variants,
+					      &write_cache_variants,
+					      &update_cache_variants),
+		     0,
+		     SPINAND_ECCINFO(&w25m02gv_ooblayout, NULL)),
 };
 
 /**

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

#2 lore raw
Quoted 8 lines · Boris Brezillon

+Miquel

Hi Robert,

Please Cc the NAND mantainers when you send a NAND related patch (in case you don't know about it already, scripts/get_maintainer.pl should help you find who to Cc).

Sorry, I knew about scripts/get_maintainer.pl but completelly forgot about it this time.

Quoted 44 lines
Quoted 11 lines · On Sat, 6 Oct 2018 17:36:42 +0200 Robert Marko <[email protected]> wrote:

W25N01GV is a single die version of the already supported W25M02GV with half the capacity. Everything else is the same so introduce support for W25N01GV.

Datasheet:
http://www.winbond.com/resource-files/w25n01gv%20revl%20050918%20unsecured.pdf

Tested on 8devices Jalapeno dev board under OpenWrt running 4.19- rc5.

Looks good.

Quoted 25 lines
---
 drivers/mtd/nand/spi/winbond.c | 8 ++++++++
 1 file changed, 8 insertions(+)
drivers/mtd/nand/spi/winbond.c +8 -0
@@ -84,6 +84,14 @@ static const struct spinand_info winbond
 		     0,
 		     SPINAND_ECCINFO(&w25m02gv_ooblayout, NULL),
 		     SPINAND_SELECT_TARGET(w25m02gv_select_target)),
+	SPINAND_INFO("W25N01GV", 0xAA,
+		     NAND_MEMORG(1, 2048, 64, 64, 1024, 1, 1, 1),
+		     NAND_ECCREQ(1, 512),
+		     SPINAND_INFO_OP_VARIANTS(&read_cache_variants,
+					      &write_cache_variants,
+					      &update_cache_variants),
+		     0,
+		     SPINAND_ECCINFO(&w25m02gv_ooblayout, NULL)),
 };
 
 /**

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

maintainer Applied
#3 lore raw
In reply to Boris Brezillon

Hi Robert,

Boris Brezillon <[email protected]> wrote on Fri, 12 Oct 2018 11:04:12 +0200:

Quoted 17 lines

+Miquel

Hi Robert,

Please Cc the NAND mantainers when you send a NAND related patch (in case you don't know about it already, scripts/get_maintainer.pl should help you find who to Cc).

Quoted 6 lines · On Sat, 6 Oct 2018 17:36:42 +0200 Robert Marko <[email protected]> wrote:

W25N01GV is a single die version of the already supported W25M02GV with half the capacity. Everything else is the same so introduce support for W25N01GV.

Datasheet:http://www.winbond.com/resource-files/w25n01gv%20revl%20050918%20unsecured.pdf

Quoted 7 lines
Quoted 3 lines

Tested on 8devices Jalapeno dev board under OpenWrt running 4.19-rc5.

Looks good.

Applied to nand/next.

Thanks,
Miquèl