scsi: qedi: possible ABBA deadlock in qedi_process_tmf_resp() and qedi_process_cmd_cleanup_resp()
Hello,
My static analysis tool reports a possible ABBA deadlock in the qedi driver in Linux 5.16:
qedi_process_tmf_resp() spin_lock(&session->back_lock); --> Line 201 (Lock A) spin_lock(&qedi_conn->tmf_work_lock); --> Line 230 (Lock B)
qedi_process_cmd_cleanup_resp() spin_lock_bh(&qedi_conn->tmf_work_lock); --> Line 752 (Lock B) spin_lock_bh(&conn->session->back_lock); --> Line 784 (Lock A)
When qedi_process_tmf_resp() and qedi_process_cmd_cleanup_resp() are concurrently executed, the deadlock can occur.
I am not quite sure whether this possible deadlock is real and how to fix it if it is real. Any feedback would be appreciated, thanks :)
Best wishes,
Jia-Ju Bai
Quoted 8 lines · Jia-Ju Bai
Hello,
My static analysis tool reports a possible ABBA deadlock in the qedi driver in Linux 5.16:
qedi_process_tmf_resp()spin_lock(&session->back_lock); --> Line 201 (Lock A)spin_lock(&qedi_conn->tmf_work_lock); --> Line 230 (Lock B)
Quoted 9 lines
qedi_process_cmd_cleanup_resp()spin_lock_bh(&qedi_conn->tmf_work_lock); --> Line 752 (Lock B)spin_lock_bh(&conn->session->back_lock); --> Line 784 (Lock A)When
qedi_process_tmf_resp()andqedi_process_cmd_cleanup_resp()are concurrently executed, the deadlock can occur.I am not quite sure whether this possible deadlock is real and how to fix it if it is real. Any feedback would be appreciated, thanks :)
That looks like a valid deadlock. I'll send a patch. Thanks.
Quoted 5 lines
Reported-by TOTE Robot <[email protected]>Best wishes,
Jia-Ju Bai