Skip to contentSkip to conversation

net/netvsc: disable before changing RSS parameters

PATCH Applied Stephen Hemminger 2 participants 6 messages Nov 25, 2019 – Dec 10, 2019 Network drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net/netvsc: disable before changing RSS parameters

In order to change RSS parameters, the host requires that RSS is disable first.

Fixes 92d23a57cafe ("net/netvsc: support configuring RSS parameters")
---
 drivers/net/netvsc/hn_ethdev.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
drivers/net/netvsc/hn_ethdev.c +14 -0
index 164e9ad174a7..575780ee5f26 100644
@@ -291,6 +291,13 @@ static int hn_rss_reta_update(struct rte_eth_dev *dev,
 			hv->rss_ind[i] = reta_conf[idx].reta[shift];
 	}
 
+	err = hn_rndis_conf_rss(hv, NDIS_RSS_FLAG_DISABLE);
+	if (err) {
+		PMD_DRV_LOG(NOTICE,
+			"rss disable failed");
+		return err;
+	}
+
 	err = hn_rndis_conf_rss(hv, 0);
 	if (err) {
 		PMD_DRV_LOG(NOTICE,
@@ -578,6 +585,13 @@ static int hn_dev_configure(struct rte_eth_dev *dev)
 			return err;
 		}
 
+		err = hn_rndis_conf_rss(hv, NDIS_RSS_FLAG_DISABLE);
+		if (err) {
+			PMD_DRV_LOG(NOTICE,
+				"rss disable failed");
+			return err;
+		}
+
 		err = hn_rndis_conf_rss(hv, 0);
 		if (err) {
 			PMD_DRV_LOG(NOTICE,
Signature · 1 line
2.20.1
#2 lore raw

v2 cover bugfix to netvsc PMD in 19.11

In reply to Stephen Hemminger

This is a resend of earlier bug fix and an additional fix for RSS flags

Stephen Hemminger (2):
net/netvsc: fix RSS offload flag net/netvsc: disable before changing RSS parameters

 drivers/net/netvsc/hn_ethdev.c | 17 ++++++++++++++++-
 1 file changed, 16 insertions(+), 1 deletion(-)
Signature · 1 line
2.20.1
#3 lore raw

PATCH v2 1/2 net/netvsc: fix RSS offload flag

The change to add OFFLOAD_RSS_HASH broke use of netvsc PMD with testpmd. The netvsc driver fails during configure step:

	Configuring Port 1 (socket 0)
	hn_dev_configure(): unsupported RX offload: 0x80000
Fixes 5d308972954c ("ethdev: add mbuf RSS update as an offload")
---
 drivers/net/netvsc/hn_ethdev.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/net/netvsc/hn_ethdev.c +2 -1
index 164e9ad174a7..5ef7a452cc69 100644
@@ -42,7 +42,8 @@
 			    DEV_TX_OFFLOAD_VLAN_INSERT)
 
 #define HN_RX_OFFLOAD_CAPS (DEV_RX_OFFLOAD_CHECKSUM | \
-			    DEV_RX_OFFLOAD_VLAN_STRIP)
+			    DEV_RX_OFFLOAD_VLAN_STRIP | \
+			    DEV_RX_OFFLOAD_RSS_HASH)
 
 int hn_logtype_init;
 int hn_logtype_driver;
Signature · 1 line
2.20.1
#4 lore raw

PATCH v2 2/2 net/netvsc: disable before changing RSS parameters

In reply to Stephen Hemminger

In order to change RSS parameters, the host requires that RSS is disable first.

Fixes 92d23a57cafe ("net/netvsc: support configuring RSS parameters")
---
 drivers/net/netvsc/hn_ethdev.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
drivers/net/netvsc/hn_ethdev.c +14 -0
index 5ef7a452cc69..159116f7f691 100644
@@ -292,6 +292,13 @@ static int hn_rss_reta_update(struct rte_eth_dev *dev,
 			hv->rss_ind[i] = reta_conf[idx].reta[shift];
 	}
 
+	err = hn_rndis_conf_rss(hv, NDIS_RSS_FLAG_DISABLE);
+	if (err) {
+		PMD_DRV_LOG(NOTICE,
+			"rss disable failed");
+		return err;
+	}
+
 	err = hn_rndis_conf_rss(hv, 0);
 	if (err) {
 		PMD_DRV_LOG(NOTICE,
@@ -579,6 +586,13 @@ static int hn_dev_configure(struct rte_eth_dev *dev)
 			return err;
 		}
 
+		err = hn_rndis_conf_rss(hv, NDIS_RSS_FLAG_DISABLE);
+		if (err) {
+			PMD_DRV_LOG(NOTICE,
+				"rss disable failed");
+			return err;
+		}
+
 		err = hn_rndis_conf_rss(hv, 0);
 		if (err) {
 			PMD_DRV_LOG(NOTICE,
Signature · 1 line
2.20.1
Tested-by Dexuan Cui Tested-by Abhishek Marathe on the v2 series
#5 lore raw

Re: [dpdk-dev] [PATCH v2 0/2] bugfix to netvsc PMD in 19.11

In reply to Stephen Hemminger
Quoted 10 lines · Stephen Hemminger

This is a resend of earlier bug fix and an additional fix for RSS flags

Stephen Hemminger (2):
net/netvsc: fix RSS offload flag net/netvsc: disable before changing RSS parameters

 drivers/net/netvsc/hn_ethdev.c | 17 ++++++++++++++++-
 1 file changed, 16 insertions(+), 1 deletion(-)

Series applied to dpdk-next-net/master, thanks.

(sign-off/tested tags for 2/2 updated as suggested,

)