Skip to contentSkip to conversation

drm: Expose "FB_DAMAGE_CLIPS" property to atomic aware user-space only

PATCH In review Deepak Singh Rawat 2 participants 8 messages Apr 15, 2019 – Apr 17, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm: Expose "FB_DAMAGE_CLIPS" property to atomic aware user-space only

Plane property "FB_DAMAGE_CLIPS" can only be used by atomic aware user-space, so no point exposing it otherwise.

Fixes d3b21767821e ("drm: Add a new plane property to send damage during plane update")
---
 drivers/gpu/drm/drm_mode_config.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/gpu/drm/drm_mode_config.c +3 -2
index 4a1c2023ccf0..1a346ae1599d 100644
@@ -297,8 +297,9 @@ static int drm_mode_create_standard_properties(struct drm_device *dev)
 		return -ENOMEM;
 	dev->mode_config.prop_crtc_id = prop;
 
-	prop = drm_property_create(dev, DRM_MODE_PROP_BLOB, "FB_DAMAGE_CLIPS",
-				   0);
+	prop = drm_property_create(dev,
+			DRM_MODE_PROP_ATOMIC | DRM_MODE_PROP_BLOB,
+			"FB_DAMAGE_CLIPS", 0);
 	if (!prop)
 		return -ENOMEM;
 	dev->mode_config.prop_fb_damage_clips = prop;
Signature · 6 lines
2.21.0

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Reviewed-by on v1 1/1
#1 lore raw
Quoted 5 lines · Deepak Singh Rawat

Plane property "FB_DAMAGE_CLIPS" can only be used by atomic aware user-space, so no point exposing it otherwise.

Fixes d3b21767821e ("drm: Add a new plane property to send damage during plane update")

Makes sense, probably good if we add Cc: [email protected] too

btw, want drm-misc commit rights to push this? Assuming you'd then push vmware drm patches in general ofc. See

https://drm.pages.freedesktop.org/maintainer-tools/getting-started.html

Cheers, Daniel

Quoted 27 lines
---
 drivers/gpu/drm/drm_mode_config.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/gpu/drm/drm_mode_config.c +3 -2
index 4a1c2023ccf0..1a346ae1599d 100644
@@ -297,8 +297,9 @@ static int drm_mode_create_standard_properties(struct drm_device *dev)
 		return -ENOMEM;
 	dev->mode_config.prop_crtc_id = prop;
 
-	prop = drm_property_create(dev, DRM_MODE_PROP_BLOB, "FB_DAMAGE_CLIPS",
-				   0);
+	prop = drm_property_create(dev,
+			DRM_MODE_PROP_ATOMIC | DRM_MODE_PROP_BLOB,
+			"FB_DAMAGE_CLIPS", 0);
 	if (!prop)
 		return -ENOMEM;
 	dev->mode_config.prop_fb_damage_clips = prop;
Signature · 6 lines
2.21.0

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Signature · 7 lines
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
#2 lore raw
Quoted 9 lines · Daniel Vetter
Quoted 6 lines · Deepak Singh Rawat

Plane property "FB_DAMAGE_CLIPS" can only be used by atomic aware user-space, so no point exposing it otherwise.

Fixes d3b21767821e ("drm: Add a new plane property to send damage

during plane update")

Makes sense, probably good if we add Cc: [email protected] too

Hi Daniel, thanks for the review. Sure.

Quoted 6 lines

btw, want drm-misc commit rights to push this? Assuming you'd then push
vmware drm patches in general ofc. See

Yes I think it would be a good idea if I can have drm-mics commit rights. I think for occasional vmwgfx patches it would be ideal for us to use drm-mics on the other hand if had some major changes better to follow pull request way.

How to apply for drm-mics commit rights?

Quoted 2 lines

https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdrm.pages.freedesktop.org%2Fmaintainer-tools%2Fgetting-started.html&data=02%7C01%7Cdrawat%40vmware.com%7C6c643d95324e44d8783108d6c23f0938%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C636909973336030830&sdata=PMdonBtvx%2B2bMweQJTRu1b7IjmL0lSd2KKSIBV1ngTk%3D&reserved=0

Quoted 29 lines

Cheers, Daniel

Quoted 26 lines
---
 drivers/gpu/drm/drm_mode_config.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/gpu/drm/drm_mode_config.c +3 -2
index 4a1c2023ccf0..1a346ae1599d 100644
@@ -297,8 +297,9 @@ static int
 drm_mode_create_standard_properties(struct drm_device *dev)
 		return -ENOMEM;
 	dev->mode_config.prop_crtc_id = prop;
 
-	prop = drm_property_create(dev, DRM_MODE_PROP_BLOB,
 "FB_DAMAGE_CLIPS",
-				   0);
+	prop = drm_property_create(dev,
+			DRM_MODE_PROP_ATOMIC | DRM_MODE_PROP_BLOB,
+			"FB_DAMAGE_CLIPS", 0);
 	if (!prop)
drivers/gpu/drm/drm_mode_config.c +0 -0
 		return -ENOMEM;
 	dev->mode_config.prop_fb_damage_clips = prop;
Signature · 1 line
2.21.0
Quoted 4 lines
Quoted 4 lines

_______________________________________________
dri-devel mailing list
[email protected]

https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Fdri-devel&data=02%7C01%7Cdrawat%40vmware.com%7C6c643d95324e44d8783108d6c23f0938%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C636909973336030830&sdata=QJCrLbtFUv7%2FiRAYOb2R%2Bab4w3l5CWae2K7t9Ya6dZw%3D&reserved=0

Quoted 2 lines

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#3 lore raw
Quoted 21 lines · Deepak Singh Rawat
Quoted 9 lines · Daniel Vetter
Quoted 6 lines · Deepak Singh Rawat

Plane property "FB_DAMAGE_CLIPS" can only be used by atomic aware user-space, so no point exposing it otherwise.

Fixes d3b21767821e ("drm: Add a new plane property to send damage

during plane update")

Makes sense, probably good if we add Cc: [email protected] too

Hi Daniel, thanks for the review. Sure.

Quoted 6 lines

btw, want drm-misc commit rights to push this? Assuming you'd then push
vmware drm patches in general ofc. See

Quoted 6 lines

Yes I think it would be a good idea if I can have drm-mics commit rights. I think for occasional vmwgfx patches it would be ideal for us to use drm-mics on the other hand if had some major changes better to follow pull request way.

How to apply for drm-mics commit rights?

https://www.freedesktop.org/wiki/AccountRequests/

you need an ssh account for drm-misc. Reply with the bug report here and I'll ack - drm-misc maintainers already acked. -Daniel

Quoted 41 lines
Quoted 3 lines

https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdrm.pages.freedesktop.org%2Fmaintainer-tools%2Fgetting-started.html&data=02%7C01%7Cdrawat%40vmware.com%7C6c643d95324e44d8783108d6c23f0938%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C636909973336030830&sdata=PMdonBtvx%2B2bMweQJTRu1b7IjmL0lSd2KKSIBV1ngTk%3D&reserved=0

Quoted 29 lines

Cheers, Daniel

Quoted 26 lines
---
 drivers/gpu/drm/drm_mode_config.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/gpu/drm/drm_mode_config.c +3 -2
index 4a1c2023ccf0..1a346ae1599d 100644
@@ -297,8 +297,9 @@ static int
 drm_mode_create_standard_properties(struct drm_device *dev)
            return -ENOMEM;
    dev->mode_config.prop_crtc_id = prop;
 
-   prop = drm_property_create(dev, DRM_MODE_PROP_BLOB,
 "FB_DAMAGE_CLIPS",
-                              0);
+   prop = drm_property_create(dev,
+                   DRM_MODE_PROP_ATOMIC | DRM_MODE_PROP_BLOB,
+                   "FB_DAMAGE_CLIPS", 0);
    if (!prop)
            return -ENOMEM;
    dev->mode_config.prop_fb_damage_clips = prop;

--
2.21.0

Quoted 4 lines
Quoted 4 lines

_______________________________________________
dri-devel mailing list
[email protected]

https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Fdri-devel&data=02%7C01%7Cdrawat%40vmware.com%7C6c643d95324e44d8783108d6c23f0938%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C636909973336030830&sdata=QJCrLbtFUv7%2FiRAYOb2R%2Bab4w3l5CWae2K7t9Ya6dZw%3D&reserved=0

Quoted 2 lines
Signature · 7 lines
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
#4 lore raw
Quoted 38 lines · Daniel Vetter

On Tue, Apr 16, 2019 at 6:21 PM Deepak Singh Rawat <[email protected]

Quoted 35 lines

wrote:

Quoted 6 lines · Daniel Vetter
Quoted 4 lines · Deepak Singh Rawat

Plane property "FB_DAMAGE_CLIPS" can only be used by atomic aware
user-space, so no point exposing it otherwise.

Quoted 7 lines
Quoted 4 lines
Fixes d3b21767821e ("drm: Add a new plane property to send

damage
during plane update")

Makes sense, probably good if we add Cc: [email protected] too

Hi Daniel, thanks for the review. Sure.

Quoted 7 lines

btw, want drm-misc commit rights to push this? Assuming you'd then
push
vmware drm patches in general ofc. See

Yes I think it would be a good idea if I can have drm-mics commit rights. I think for occasional vmwgfx patches it would be ideal for us
to use drm-mics on the other hand if had some major changes better to
follow pull request way.

How to apply for drm-mics commit rights?

https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.freedesktop.org%2Fwiki%2FAccountRequests%2F&amp;data=02%7C01%7Cdrawat%40vmware.com%7C8e0fc2a84e8d43a6ee7d08d6c2978af4%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C636910353461126728&amp;sdata=T4RrZ7vdhhu3t0sn2jhU2axEVl7cr5x2JgOgJzVoEl8%3D&amp;reserved=0

Quoted 4 lines

you need an ssh account for drm-misc. Reply with the bug report here and I'll ack - drm-misc maintainers already acked. -Daniel

If you mean ssh on annarchy.freedesktop.org, I already have one with username - drawat

Quoted 6 lines
Quoted 6 lines
Quoted 4 lines

https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdrm.pages.freedesktop.org%2Fmaintainer-tools%2Fgetting-started.html&amp;data=02%7C01%7Cdrawat%40vmware.com%7C8e0fc2a84e8d43a6ee7d08d6c2978af4%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C636910353461126728&amp;sdata=ZLOBkqM%2BFVKlutvu4u3kFyW8b%2FKp2fV5UFtfaW0wVZc%3D&amp;reserved=0

Quoted 29 lines
Quoted 29 lines
Quoted 29 lines

Cheers, Daniel

Quoted 26 lines
---
 drivers/gpu/drm/drm_mode_config.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/gpu/drm/drm_mode_config.c +3 -2
index 4a1c2023ccf0..1a346ae1599d 100644
@@ -297,8 +297,9 @@ static int
 drm_mode_create_standard_properties(struct drm_device *dev)
            return -ENOMEM;
    dev->mode_config.prop_crtc_id = prop;
 
-   prop = drm_property_create(dev, DRM_MODE_PROP_BLOB,
 "FB_DAMAGE_CLIPS",
-                              0);
+   prop = drm_property_create(dev,
+                   DRM_MODE_PROP_ATOMIC | DRM_MODE_PROP_BLOB,
+                   "FB_DAMAGE_CLIPS", 0);
    if (!prop)
            return -ENOMEM;
    dev->mode_config.prop_fb_damage_clips = prop;

--
2.21.0

Quoted 6 lines
Quoted 6 lines
Quoted 4 lines
Quoted 4 lines

_______________________________________________
dri-devel mailing list
[email protected]

https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Fdri-devel&amp;data=02%7C01%7Cdrawat%40vmware.com%7C8e0fc2a84e8d43a6ee7d08d6c2978af4%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C636910353461126728&amp;sdata=6zQnD6klo9k3%2FvVP0mOUQeuwgoSZ3q7o0OChNNaoG%2BQ%3D&amp;reserved=0

Quoted 4 lines
Quoted 2 lines
Quoted 2 lines

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#5 lore raw
Quoted 40 lines · Deepak Singh Rawat
Quoted 38 lines · Daniel Vetter

On Tue, Apr 16, 2019 at 6:21 PM Deepak Singh Rawat <[email protected]

Quoted 35 lines

wrote:

Quoted 6 lines · Daniel Vetter
Quoted 4 lines · Deepak Singh Rawat

Plane property "FB_DAMAGE_CLIPS" can only be used by atomic aware
user-space, so no point exposing it otherwise.

Quoted 7 lines
Quoted 4 lines
Fixes d3b21767821e ("drm: Add a new plane property to send

damage
during plane update")

Makes sense, probably good if we add Cc: [email protected] too

Hi Daniel, thanks for the review. Sure.

Quoted 7 lines

btw, want drm-misc commit rights to push this? Assuming you'd then
push
vmware drm patches in general ofc. See

Yes I think it would be a good idea if I can have drm-mics commit rights. I think for occasional vmwgfx patches it would be ideal for us
to use drm-mics on the other hand if had some major changes better to
follow pull request way.

How to apply for drm-mics commit rights?

Quoted 8 lines

https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.freedesktop.org%2Fwiki%2FAccountRequests%2F&amp;data=02%7C01%7Cdrawat%40vmware.com%7C8e0fc2a84e8d43a6ee7d08d6c2978af4%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C636910353461126728&amp;sdata=T4RrZ7vdhhu3t0sn2jhU2axEVl7cr5x2JgOgJzVoEl8%3D&amp;reserved=0

Quoted 4 lines

you need an ssh account for drm-misc. Reply with the bug report here and I'll ack - drm-misc maintainers already acked. -Daniel

If you mean ssh on annarchy.freedesktop.org, I already have one with username - drawat

You're added. Please check out the dim toturial and pls ask any questions here or on irc or wherever - drm(-misc) maintainers are happy to help out.
-Daniel

Quoted 49 lines
Quoted 7 lines
Quoted 7 lines
Quoted 5 lines

https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdrm.pages.freedesktop.org%2Fmaintainer-tools%2Fgetting-started.html&amp;data=02%7C01%7Cdrawat%40vmware.com%7C8e0fc2a84e8d43a6ee7d08d6c2978af4%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C636910353461126728&amp;sdata=ZLOBkqM%2BFVKlutvu4u3kFyW8b%2FKp2fV5UFtfaW0wVZc%3D&amp;reserved=0

Quoted 29 lines
Quoted 29 lines
Quoted 29 lines

Cheers, Daniel

Quoted 26 lines
---
 drivers/gpu/drm/drm_mode_config.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/gpu/drm/drm_mode_config.c +3 -2
index 4a1c2023ccf0..1a346ae1599d 100644
@@ -297,8 +297,9 @@ static int
 drm_mode_create_standard_properties(struct drm_device *dev)
            return -ENOMEM;
    dev->mode_config.prop_crtc_id = prop;
 
-   prop = drm_property_create(dev, DRM_MODE_PROP_BLOB,
 "FB_DAMAGE_CLIPS",
-                              0);
+   prop = drm_property_create(dev,
+                   DRM_MODE_PROP_ATOMIC | DRM_MODE_PROP_BLOB,
+                   "FB_DAMAGE_CLIPS", 0);
    if (!prop)
            return -ENOMEM;
    dev->mode_config.prop_fb_damage_clips = prop;

--
2.21.0

Quoted 6 lines
Quoted 6 lines
Quoted 4 lines
Quoted 4 lines

_______________________________________________
dri-devel mailing list
[email protected]

https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Fdri-devel&amp;data=02%7C01%7Cdrawat%40vmware.com%7C8e0fc2a84e8d43a6ee7d08d6c2978af4%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C636910353461126728&amp;sdata=6zQnD6klo9k3%2FvVP0mOUQeuwgoSZ3q7o0OChNNaoG%2BQ%3D&amp;reserved=0

Quoted 4 lines
Quoted 2 lines
Quoted 2 lines
Signature · 7 lines
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
#6 lore raw
Quoted 11 lines
Quoted 5 lines

If you mean ssh on annarchy.freedesktop.org, I already have one with
username - drawat

You're added. Please check out the dim toturial and pls ask any questions here or on irc or wherever - drm(-misc) maintainers are happy to help out.
-Daniel

Hi I followed the instruction at
https://drm.pages.freedesktop.org/maintainer-tools/getting-started.html
and submitted my patch, I see that drm-tip has a lot of commits with
myself as author(https://cgit.freedesktop.org/drm/drm-tip/log/). Is this expected? Or did I messed up something.

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#7 lore raw
Quoted 13 lines · Deepak Singh Rawat
Quoted 12 lines
Quoted 6 lines

If you mean ssh on annarchy.freedesktop.org, I already have one with
username - drawat

You're added. Please check out the dim toturial and pls ask any questions here or on irc or wherever - drm(-misc) maintainers are happy to help out.
-Daniel

Quoted 5 lines

Hi I followed the instruction at
https://drm.pages.freedesktop.org/maintainer-tools/getting-started.html
and submitted my patch, I see that drm-tip has a lot of commits with
myself as author(https://cgit.freedesktop.org/drm/drm-tip/log/). Is this expected? Or did I messed up something.

Every time one of the branches managed by dim is pushed, dim also rebuilds drm-tip. Which means all the merge commits will be authored by you. drm-tip is only used for integration testing, it never lands anywhere. If you look now, all the top commits are already by someone else - whoever pushed last.

tldr; looks all good.
-Daniel

Signature · 7 lines
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel