Add power domain support for MT8188
Subsystems (2)
v2 cover Add power domain support for MT8188
Base on tag: next-20220927, linux-next/master
The power domain driver manages to power up/down MediaTek MT8188 chip.
changes since v1:
- add more description to this series
- remove change-id
- align as the same indention
- remove redundant parentheses
Garmin.Chang (2):
dt-bindings: power: Add MT8188 power domains
soc: mediatek: pm-domains: Add support for mt8188
.../power/mediatek,power-controller.yaml | 2 + drivers/soc/mediatek/mt8188-pm-domains.h | 623 ++++++++++++++++++ drivers/soc/mediatek/mtk-pm-domains.c | 5 + .../dt-bindings/power/mediatek,mt8188-power.h | 44 ++ include/linux/soc/mediatek/infracfg.h | 121 ++++ 5 files changed, 795 insertions(+) create mode 100644 drivers/soc/mediatek/mt8188-pm-domains.h create mode 100644 include/dt-bindings/power/mediatek,mt8188-power.h
Signature · 1 line
2.18.0
PATCH v2 1/2 dt-bindings: power: Add MT8188 power domains
Add power domains dt-bindings for MT8188.
--- .../power/mediatek,power-controller.yaml | 2 + .../dt-bindings/power/mediatek,mt8188-power.h | 44 +++++++++++++++++++ 2 files changed, 46 insertions(+) create mode 100644 include/dt-bindings/power/mediatek,mt8188-power.h
Documentation/devicetree/bindings/power/mediatek,power-controller.yaml +2 -0
@@ -28,6 +28,7 @@ properties: - mediatek,mt8173-power-controller - mediatek,mt8183-power-controller - mediatek,mt8186-power-controller + - mediatek,mt8188-power-controller - mediatek,mt8192-power-controller - mediatek,mt8195-power-controller
@@ -84,6 +85,7 @@ $defs: "include/dt-bindings/power/mt8167-power.h" - for MT8167 type power domain. "include/dt-bindings/power/mt8173-power.h" - for MT8173 type power domain. "include/dt-bindings/power/mt8183-power.h" - for MT8183 type power domain. + "include/dt-bindings/power/mediatek,mt8188-power.h" - for MT8188 type power domain. "include/dt-bindings/power/mt8192-power.h" - for MT8192 type power domain. "include/dt-bindings/power/mt8195-power.h" - for MT8195 type power domain. maxItems: 1
include/dt-bindings/power/mediatek,mt8188-power.h new file +44 -0
44 lines not on this page · raw message
Signature · 1 line
2.18.0
Re: [PATCH v2 1/2] dt-bindings: power: Add MT8188 power domains
Quoted 3 lines · Garmin.Chang
Add power domains dt-bindings for MT8188.
Signed-off-by Garmin.Chang <[email protected]>
Best regards,
Krzysztof
Re: [PATCH v2 1/2] dt-bindings: power: Add MT8188 power domains
In reply to Garmin.ChangIl 28/09/22 10:43, Garmin.Chang ha scritto:
Quoted 4 lines
Add power domains dt-bindings for MT8188.
Signed-off-by Garmin.Chang <[email protected]>
PATCH v2 2/2 soc: mediatek: pm-domains: Add support for mt8188
In reply to Garmin.ChangAdd domain control data including bus protection data size change due to more protection steps in mt8188.
--- drivers/soc/mediatek/mt8188-pm-domains.h | 623 +++++++++++++++++++++++ drivers/soc/mediatek/mtk-pm-domains.c | 5 + include/linux/soc/mediatek/infracfg.h | 121 +++++ 3 files changed, 749 insertions(+) create mode 100644 drivers/soc/mediatek/mt8188-pm-domains.h
drivers/soc/mediatek/mt8188-pm-domains.h new file +623 -0
@@ -0,0 +1,623 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +/* +* Copyright (c) 2022 MediaTek Inc. +* Author: Garmin Chang <[email protected]> +*/ + +#ifndef __SOC_MEDIATEK_MT8188_PM_DOMAINS_H +#define __SOC_MEDIATEK_MT8188_PM_DOMAINS_H + +#include "mtk-pm-domains.h" +#include <dt-bindings/power/mediatek,mt8188-power.h> + +/* +* MT8188 power domain support +*/ + +static const struct scpsys_domain_data scpsys_domain_data_mt8188[] = { + [MT8188_POWER_DOMAIN_MFG0 ] = { + .name ="mfg0" , + .sta_mask =BIT (1 ), + .ctl_offs =0x300 , + .pwr_sta_offs =0x174 , + .pwr_sta2nd_offs =0x178 , + .sram_pdn_bits =BIT (8 ), + .sram_pdn_ack_bits =BIT (12 ), + .caps =MTK_SCPD_KEEP_DEFAULT_OFF |MTK_SCPD_DOMAIN_SUPPLY , + }, + [MT8188_POWER_DOMAIN_MFG1 ] = { + .name ="mfg1" , + .sta_mask =BIT (2 ), + .ctl_offs =0x304 , + .pwr_sta_offs =0x174 , + .pwr_sta2nd_offs =0x178 , + .sram_pdn_bits =BIT (8 ), + .sram_pdn_ack_bits =BIT (12 ), + .bp_infracfg = { +BUS_PROT_WR (MT8188_TOP_AXI_PROT_EN_MFG1_STEP1 , +MT8188_TOP_AXI_PROT_EN_SET , +MT8188_TOP_AXI_PROT_EN_CLR , +MT8188_TOP_AXI_PROT_EN_STA ), +BUS_PROT_WR (MT8188_TOP_AXI_PROT_EN_2_MFG1_STEP2 , +MT8188_TOP_AXI_PROT_EN_2_SET , +MT8188_TOP_AXI_PROT_EN_2_CLR , +MT8188_TOP_AXI_PROT_EN_2_STA ), +BUS_PROT_WR (MT8188_TOP_AXI_PROT_EN_1_MFG1_STEP3 , +MT8188_TOP_AXI_PROT_EN_1_SET , +MT8188_TOP_AXI_PROT_EN_1_CLR , +MT8188_TOP_AXI_PROT_EN_1_STA ), +BUS_PROT_WR (MT8188_TOP_AXI_PROT_EN_2_MFG1_STEP4 , +MT8188_TOP_AXI_PROT_EN_2_SET , +MT8188_TOP_AXI_PROT_EN_2_CLR , +MT8188_TOP_AXI_PROT_EN_2_STA ), +BUS_PROT_WR (MT8188_TOP_AXI_PROT_EN_MFG1_STEP5 , +MT8188_TOP_AXI_PROT_EN_SET , +MT8188_TOP_AXI_PROT_EN_CLR , +MT8188_TOP_AXI_PROT_EN_STA ), +BUS_PROT_WR (MT8188_TOP_AXI_PROT_EN_SUB_INFRA_VDNR_MFG1_STEP6 , +MT8188_TOP_AXI_PROT_EN_SUB_INFRA_VDNR_SET , +MT8188_TOP_AXI_PROT_EN_SUB_INFRA_VDNR_CLR , +MT8188_TOP_AXI_PROT_EN_SUB_INFRA_VDNR_STA ), + }, + .caps =MTK_SCPD_KEEP_DEFAULT_OFF , + }, + [MT8188_POWER_DOMAIN_MFG2 ] = { + .name ="mfg2" , + .sta_mask =BIT (3 ), + .ctl_offs =0x308 , + .pwr_sta_offs =0x174 , + .pwr_sta2nd_offs =0x178 , + .sram_pdn_bits =BIT (8 ), + .sram_pdn_ack_bits =BIT (12 ), + .caps =MTK_SCPD_KEEP_DEFAULT_OFF , + }, + [MT8188_POWER_DOMAIN_MFG3 ] = { + .name ="mfg3" , + .sta_mask =BIT (4 ), + .ctl_offs =0x30C , + .pwr_sta_offs =0x174 , + .pwr_sta2nd_offs =0x178 , + .sram_pdn_bits =BIT (8 ), + .sram_pdn_ack_bits =BIT (12 ), + .caps =MTK_SCPD_KEEP_DEFAULT_OFF , + }, + [MT8188_POWER_DOMAIN_MFG4 ] = { + .name ="mfg4" , + .sta_mask =BIT (5 ), + .ctl_offs =0x310 , + .pwr_sta_offs =0x174 , + .pwr_sta2nd_offs =0x178 , + .sram_pdn_bits =BIT (8 ), + .sram_pdn_ack_bits =BIT (12 ), + .caps =MTK_SCPD_KEEP_DEFAULT_OFF , + }, + [MT8188_POWER_DOMAIN_PEXTP_MAC_P0 ] = { + .name ="pextp_mac_p0" , + .sta_mask =BIT (10 ), + .ctl_offs =0x324 , + .pwr_sta_offs =0x174 , + .pwr_sta2nd_offs =0x178 , + .sram_pdn_bits =BIT (8 ), + .sram_pdn_ack_bits =BIT (12 ), + .bp_infracfg = { +BUS_PROT_WR (MT8188_TOP_AXI_PROT_EN_PEXTP_MAC_P0_STEP1 , +MT8188_TOP_AXI_PROT_EN_SET , +MT8188_TOP_AXI_PROT_EN_CLR , +MT8188_TOP_AXI_PROT_EN_STA ), +BUS_PROT_WR (MT8188_TOP_AXI_PROT_EN_INFRA_VDNR_PEXTP_MAC_P0_STEP2 , +MT8188_TOP_AXI_PROT_EN_INFRA_VDNR_SET , +MT8188_TOP_AXI_PROT_EN_INFRA_VDNR_CLR , +MT8188_TOP_AXI_PROT_EN_INFRA_VDNR_STA ), + }, + .caps =MTK_SCPD_KEEP_DEFAULT_OFF , + }, + [MT8188_POWER_DOMAIN_PEXTP_PHY_TOP ] = { + .name ="pextp_phy_top" , + .sta_mask =BIT (12 ), + .ctl_offs =0x328 , + .pwr_sta_offs =0x174 , + .pwr_sta2nd_offs =0x178 , + .caps =MTK_SCPD_KEEP_DEFAULT_OFF , + }, + [MT8188_POWER_DOMAIN_CSIRX_TOP ] = { + .name ="pextp_csirx_top" , + .sta_mask =BIT (17 ), + .ctl_offs =0x3C4 , + .pwr_sta_offs =0x174 , + .pwr_sta2nd_offs =0x178 , + .caps =MTK_SCPD_KEEP_DEFAULT_OFF , + }, + [MT8188_POWER_DOMAIN_ETHER ] = { + .name ="ether" , + .sta_mask =BIT (1 ), + .ctl_offs =0x338 , + .pwr_sta_offs =0x16C , + .pwr_sta2nd_offs =0x170 , + .sram_pdn_bits =BIT (8 ), + .sram_pdn_ack_bits =BIT (12 ), + .bp_infracfg = { +BUS_PROT_WR (MT8188_TOP_AXI_PROT_EN_INFRA_VDNR_ETHER_STEP1 , +MT8188_TOP_AXI_PROT_EN_INFRA_VDNR_SET , +MT8188_TOP_AXI_PROT_EN_INFRA_VDNR_CLR , +MT8188_TOP_AXI_PROT_EN_INFRA_VDNR_STA ), + }, + .caps =MTK_SCPD_KEEP_DEFAULT_OFF |MTK_SCPD_ACTIVE_WAKEUP , + }, + [MT8188_POWER_DOMAIN_HDMI_TX ] = { + .name ="hdmi_tx" , + .sta_mask =BIT (18 ), + .ctl_offs =0x37C , + .pwr_sta_offs =0x16C , + .pwr_sta2nd_offs =0x170 , + .sram_pdn_bits =BIT (8 ), + .sram_pdn_ack_bits =BIT (12 ), + .bp_infracfg = { +BUS_PROT_WR (MT8188_TOP_AXI_PROT_EN_INFRA_VDNR_HDMI_TX_STEP1 , +MT8188_TOP_AXI_PROT_EN_INFRA_VDNR_SET , +MT8188_TOP_AXI_PROT_EN_INFRA_VDNR_CLR , +MT8188_TOP_AXI_PROT_EN_INFRA_VDNR_STA ), + }, + .caps =MTK_SCPD_KEEP_DEFAULT_OFF |MTK_SCPD_ACTIVE_WAKEUP , + }, + [MT8188_POWER_DOMAIN_ADSP_AO ] = { + .name ="adsp_ao" , + .sta_mask =BIT (10 ), + .ctl_offs =0x35C , + .pwr_sta_offs =0x16C , + .pwr_sta2nd_offs =0x170 , + .bp_infracfg = { +BUS_PROT_WR (MT8188_TOP_AXI_PROT_EN_2_ADSP_AO_STEP1 , +MT8188_TOP_AXI_PROT_EN_2_SET , +MT8188_TOP_AXI_PROT_EN_2_CLR , +MT8188_TOP_AXI_PROT_EN_2_STA ), +BUS_PROT_WR (MT8188_TOP_AXI_PROT_EN_2_ADSP_AO_STEP2 , +MT8188_TOP_AXI_PROT_EN_2_SET , +MT8188_TOP_AXI_PROT_EN_2_CLR , +MT8188_TOP_AXI_PROT_EN_2_STA ), + }, + .caps =MTK_SCPD_ALWAYS_ON , + }, + [MT8188_POWER_DOMAIN_ADSP_INFRA ] = { + .name ="adsp_infra" , + .sta_mask =BIT (9 ), + .ctl_offs =0x358 , + .pwr_sta_offs =0x16C , + .pwr_sta2nd_offs =0x170 , + .sram_pdn_bits =BIT (8 ), + .sram_pdn_ack_bits =BIT (12 ), + .bp_infracfg = { +BUS_PROT_WR (MT8188_TOP_AXI_PROT_EN_2_ADSP_INFRA_STEP1 , +MT8188_TOP_AXI_PROT_EN_2_SET , +MT8188_TOP_AXI_PROT_EN_2_CLR , +MT8188_TOP_AXI_PROT_EN_2_STA ), +BUS_PROT_WR (MT8188_TOP_AXI_PROT_EN_2_ADSP_INFRA_STEP2 , +MT8188_TOP_AXI_PROT_EN_2_SET , +MT8188_TOP_AXI_PROT_EN_2_CLR , +MT8188_TOP_AXI_PROT_EN_2_STA ), + }, + .caps =MTK_SCPD_SRAM_ISO , + }, + [MT8188_POWER_DOMAIN_ADSP ] = { + .name ="adsp" , + .sta_mask =BIT (8 ), + .ctl_offs =0x354 , + .pwr_sta_offs =0x16C , + .pwr_sta2nd_offs =0x170 , + .sram_pdn_bits =BIT (8 ), + .sram_pdn_ack_bits =BIT (12 ), + .bp_infracfg = { +BUS_PROT_WR (MT8188_TOP_AXI_PROT_EN_2_ADSP_STEP1 , +MT8188_TOP_AXI_PROT_EN_2_SET , +MT8188_TOP_AXI_PROT_EN_2_CLR , +MT8188_TOP_AXI_PROT_EN_2_STA ), +BUS_PROT_WR (MT8188_TOP_AXI_PROT_EN_2_ADSP_STEP2 , +MT8188_TOP_AXI_PROT_EN_2_SET , +MT8188_TOP_AXI_PROT_EN_2_CLR , +MT8188_TOP_AXI_PROT_EN_2_STA ), + }, + .caps =MTK_SCPD_KEEP_DEFAULT_OFF |MTK_SCPD_SRAM_ISO |MTK_SCPD_ACTIVE_WAKEUP , + }, + [MT8188_POWER_DOMAIN_AUDIO ] = { + .name ="audio" , + .sta_mask =BIT (6 ), + .ctl_offs =0x34C , + .pwr_sta_offs =0x16C , + .pwr_sta2nd_offs =0x170 , + .sram_pdn_bits =BIT (8 ), + .sram_pdn_ack_bits =BIT (12 ), + .bp_infracfg = { +BUS_PROT_WR (MT8188_TOP_AXI_PROT_EN_2_AUDIO_STEP1 , +MT8188_TOP_AXI_PROT_EN_2_SET , +MT8188_TOP_AXI_PROT_EN_2_CLR , +MT8188_TOP_AXI_PROT_EN_2_STA ), +BUS_PROT_WR (MT8188_TOP_AXI_PROT_EN_2_AUDIO_STEP2 , +MT8188_TOP_AXI_PROT_EN_2_SET , +MT8188_TOP_AXI_PROT_EN_2_CLR , +MT8188_TOP_AXI_PROT_EN_2_STA ), + }, + .caps =MTK_SCPD_KEEP_DEFAULT_OFF |MTK_SCPD_ACTIVE_WAKEUP , + }, + [MT8188_POWER_DOMAIN_AUDIO_ASRC ] = { + .name ="audio_asrc" , + .sta_mask =BIT (7 ), + .ctl_offs =0x350 , + .pwr_sta_offs =0x16C , + .pwr_sta2nd_offs =0x170 , + .sram_pdn_bits =BIT (8 ), + .sram_pdn_ack_bits =BIT (12 ), + .bp_infracfg = { +BUS_PROT_WR (MT8188_TOP_AXI_PROT_EN_2_AUDIO_ASRC_STEP1 , +MT8188_TOP_AXI_PROT_EN_2_SET , +MT8188_TOP_AXI_PROT_EN_2_CLR , +MT8188_TOP_AXI_PROT_EN_2_STA ), +BUS_PROT_WR (MT8188_TOP_AXI_PROT_EN_2_AUDIO_ASRC_STEP2 , +MT8188_TOP_AXI_PROT_EN_2_SET , +MT8188_TOP_AXI_PROT_EN_2_CLR , +MT8188_TOP_AXI_PROT_EN_2_STA ), + }, + .caps =MTK_SCPD_KEEP_DEFAULT_OFF , + }, + [MT8188_POWER_DOMAIN_VPPSYS0 ] = { + .name ="vppsys0" , + .sta_mask =BIT (11 ), + .ctl_offs =0x360 , + .pwr_sta_offs =0x16C , + .pwr_sta2nd_offs =0x170 , + .sram_pdn_bits =BIT (8 ), + .sram_pdn_ack_bits =BIT (12 ), + .bp_infracfg = { +BUS_PROT_WR (MT8188_TOP_AXI_PROT_EN_VPPSYS0_STEP1 , +MT8188_TOP_AXI_PROT_EN_SET , +MT8188_TOP_AXI_PROT_EN_CLR , +MT8188_TOP_AXI_PROT_EN_STA ), +BUS_PROT_WR (MT8188_TOP_AXI_PROT_EN_MM_2_VPPSYS0_STEP2 , +MT8188_TOP_AXI_PROT_EN_MM_2_SET , +MT8188_TOP_AXI_PROT_EN_MM_2_CLR , +MT8188_TOP_AXI_PROT_EN_MM_2_STA ), +BUS_PROT_WR (MT8188_TOP_AXI_PROT_EN_VPPSYS0_STEP3 , +MT8188_TOP_AXI_PROT_EN_SET , +MT8188_TOP_AXI_PROT_EN_CLR , +MT8188_TOP_AXI_PROT_EN_STA ), +BUS_PROT_WR (MT8188_TOP_AXI_PROT_EN_MM_2_VPPSYS0_STEP4 , +MT8188_TOP_AXI_PROT_EN_MM_2_SET , +MT8188_TOP_AXI_PROT_EN_MM_2_CLR , +MT8188_TOP_AXI_PROT_EN_MM_2_STA ), +BUS_PROT_WR (MT8188_TOP_AXI_PROT_EN_SUB_INFRA_VDNR_VPPSYS0_STEP5 , +MT8188_TOP_AXI_PROT_EN_SUB_INFRA_VDNR_SET , +MT8188_TOP_AXI_PROT_EN_SUB_INFRA_VDNR_CLR , +MT8188_TOP_AXI_PROT_EN_SUB_INFRA_VDNR_STA ), + }, + }, + [MT8188_POWER_DOMAIN_VDOSYS0 ] = { + .name ="vdosys0" , + .sta_mask =BIT (13 ), + .ctl_offs =0x368 , + .pwr_sta_offs =0x16C , + .pwr_sta2nd_offs =0x170 , + .sram_pdn_bits =BIT (8 ), + .sram_pdn_ack_bits =BIT (12 ), + .bp_infracfg = { +BUS_PROT_WR (MT8188_TOP_AXI_PROT_EN_MM_VDOSYS0_STEP1 , +MT8188_TOP_AXI_PROT_EN_MM_SET , +MT8188_TOP_AXI_PROT_EN_MM_CLR , +MT8188_TOP_AXI_PROT_EN_MM_STA ), +BUS_PROT_WR (MT8188_TOP_AXI_PROT_EN_VDOSYS0_STEP2 , +MT8188_TOP_AXI_PROT_EN_SET , +MT8188_TOP_AXI_PROT_EN_CLR , +MT8188_TOP_AXI_PROT_EN_STA ), +BUS_PROT_WR (MT8188_TOP_AXI_PROT_EN_SUB_INFRA_VDNR_VDOSYS0_STEP3 , +MT8188_TOP_AXI_PROT_EN_SUB_INFRA_VDNR_SET , +MT8188_TOP_AXI_PROT_EN_SUB_INFRA_VDNR_CLR , +MT8188_TOP_AXI_PROT_EN_SUB_INFRA_VDNR_STA ), + }, + }, + [MT8188_POWER_DOMAIN_VDOSYS1 ] = { + .name ="vdosys1" , + .sta_mask =BIT (14 ), + .ctl_offs =0x36C , + .pwr_sta_offs =0x16C , + .pwr_sta2nd_offs =0x170 , + .sram_pdn_bits =BIT (8 ), + .sram_pdn_ack_bits =BIT (12 ), + .bp_infracfg = { +BUS_PROT_WR (MT8188_TOP_AXI_PROT_EN_MM_VDOSYS1_STEP1 , +MT8188_TOP_AXI_PROT_EN_MM_SET , +MT8188_TOP_AXI_PROT_EN_MM_CLR , +MT8188_TOP_AXI_PROT_EN_MM_STA ), +BUS_PROT_WR (MT8188_TOP_AXI_PROT_EN_MM_VDOSYS1_STEP2 , +MT8188_TOP_AXI_PROT_EN_MM_SET , +MT8188_TOP_AXI_PROT_EN_MM_CLR , +MT8188_TOP_AXI_PROT_EN_MM_STA ), +BUS_PROT_WR (MT8188_TOP_AXI_PROT_EN_MM_2_VDOSYS1_STEP3 , +MT8188_TOP_AXI_PROT_EN_MM_2_SET , +MT8188_TOP_AXI_PROT_EN_MM_2_CLR , +MT8188_TOP_AXI_PROT_EN_MM_2_STA ), + }, + }, + [MT8188_POWER_DOMAIN_DP_TX ] = { + .name ="dp_tx" , + .sta_mask =BIT (16 ), + .ctl_offs =0x374 , + .pwr_sta_offs =0x16C , + .pwr_sta2nd_offs =0x170 , + .sram_pdn_bits =BIT (8 ), + .sram_pdn_ack_bits =BIT (12 ), + .bp_infracfg = { +BUS_PROT_WR (MT8188_TOP_AXI_PROT_EN_INFRA_VDNR_DP_TX_STEP1 , +MT8188_TOP_AXI_PROT_EN_INFRA_VDNR_SET , +MT8188_TOP_AXI_PROT_EN_INFRA_VDNR_CLR , +MT8188_TOP_AXI_PROT_EN_INFRA_VDNR_STA ), + }, + .caps =MTK_SCPD_KEEP_DEFAULT_OFF , + }, + [MT8188_POWER_DOMAIN_EDP_TX ] = { + .name ="edp_tx" , + .sta_mask =BIT (17 ), + .ctl_offs =0x378 , + .pwr_sta_offs =0x16C , + .pwr_sta2nd_offs =0x170 , + .sram_pdn_bits =BIT (8 ), + .sram_pdn_ack_bits =BIT (12 ), + .bp_infracfg = { +BUS_PROT_WR (MT8188_TOP_AXI_PROT_EN_INFRA_VDNR_EDP_TX_STEP1 , +MT8188_TOP_AXI_PROT_EN_INFRA_VDNR_SET , +MT8188_TOP_AXI_PROT_EN_INFRA_VDNR_CLR , +MT8188_TOP_AXI_PROT_EN_INFRA_VDNR_STA ), + }, + .caps =MTK_SCPD_KEEP_DEFAULT_OFF , + }, + [MT8188_POWER_DOMAIN_VPPSYS1 ] = { + .name ="vppsys1" , + .sta_mask =BIT (12 ), + .ctl_offs =0x364 , + .pwr_sta_offs =0x16C , + .pwr_sta2nd_offs =0x170 , + .sram_pdn_bits =BIT (8 ), + .sram_pdn_ack_bits =BIT (12 ), + .bp_infracfg = { +BUS_PROT_WR (MT8188_TOP_AXI_PROT_EN_MM_VPPSYS1_STEP1 , +MT8188_TOP_AXI_PROT_EN_MM_SET , +MT8188_TOP_AXI_PROT_EN_MM_CLR , +MT8188_TOP_AXI_PROT_EN_MM_STA ), +BUS_PROT_WR (MT8188_TOP_AXI_PROT_EN_MM_VPPSYS1_STEP2 , +MT8188_TOP_AXI_PROT_EN_MM_SET , +MT8188_TOP_AXI_PROT_EN_MM_CLR , +MT8188_TOP_AXI_PROT_EN_MM_STA ), +BUS_PROT_WR (MT8188_TOP_AXI_PROT_EN_MM_2_VPPSYS1_STEP3 , +MT8188_TOP_AXI_PROT_EN_MM_2_SET , +MT8188_TOP_AXI_PROT_EN_MM_2_CLR , +MT8188_TOP_AXI_PROT_EN_MM_2_STA ), + }, + }, + [MT8188_POWER_DOMAIN_WPE ] = { + .name ="wpe" , + .sta_mask =BIT (15 ), + .ctl_offs =0x370 , + .pwr_sta_offs =0x16C , + .pwr_sta2nd_offs =0x170 , + .sram_pdn_bits =BIT (8 ), + .sram_pdn_ack_bits =BIT (12 ), + .bp_infracfg = { +BUS_PROT_WR (MT8188_TOP_AXI_PROT_EN_MM_2_WPE_STEP1 , +MT8188_TOP_AXI_PROT_EN_MM_2_SET , +MT8188_TOP_AXI_PROT_EN_MM_2_CLR , +MT8188_TOP_AXI_PROT_EN_MM_2_STA ), +BUS_PROT_WR (MT8188_TOP_AXI_PROT_EN_MM_2_WPE_STEP2 , +MT8188_TOP_AXI_PROT_EN_MM_2_SET , +MT8188_TOP_AXI_PROT_EN_MM_2_CLR , +MT8188_TOP_AXI_PROT_EN_MM_2_STA ), + }, + .caps =MTK_SCPD_KEEP_DEFAULT_OFF , + }, + [MT8188_POWER_DOMAIN_VDEC0 ] = { + .name ="vdec0" , + .sta_mask =BIT (19 ), + .ctl_offs =0x380 , + .pwr_sta_offs =0x16C , + .pwr_sta2nd_offs =0x170 , + .sram_pdn_bits =BIT (8 ), + .sram_pdn_ack_bits =BIT (12 ), + .bp_infracfg = { +BUS_PROT_WR (MT8188_TOP_AXI_PROT_EN_MM_VDEC0_STEP1 , +MT8188_TOP_AXI_PROT_EN_MM_SET , +MT8188_TOP_AXI_PROT_EN_MM_CLR , +MT8188_TOP_AXI_PROT_EN_MM_STA ), +BUS_PROT_WR (MT8188_TOP_AXI_PROT_EN_MM_2_VDEC0_STEP2 , +MT8188_TOP_AXI_PROT_EN_MM_2_SET , +MT8188_TOP_AXI_PROT_EN_MM_2_CLR , +MT8188_TOP_AXI_PROT_EN_MM_2_STA ), + }, + .caps =MTK_SCPD_KEEP_DEFAULT_OFF , + }, + [MT8188_POWER_DOMAIN_VDEC1 ] = { + .name ="vdec1" , + .sta_mask =BIT (20 ), + .ctl_offs =0x384 , + .pwr_sta_offs =0x16C , + .pwr_sta2nd_offs =0x170 , + .sram_pdn_bits =BIT (8 ), + .sram_pdn_ack_bits =BIT (12 ), + .bp_infracfg = { +BUS_PROT_WR (MT8188_TOP_AXI_PROT_EN_MM_VDEC1_STEP1 , +MT8188_TOP_AXI_PROT_EN_MM_SET , +MT8188_TOP_AXI_PROT_EN_MM_CLR , +MT8188_TOP_AXI_PROT_EN_MM_STA ), +BUS_PROT_WR (MT8188_TOP_AXI_PROT_EN_MM_VDEC1_STEP2 , +MT8188_TOP_AXI_PROT_EN_MM_SET , +MT8188_TOP_AXI_PROT_EN_MM_CLR , +MT8188_TOP_AXI_PROT_EN_MM_STA ), + }, + .caps =MTK_SCPD_KEEP_DEFAULT_OFF , + }, + [MT8188_POWER_DOMAIN_VENC ] = { + .name ="venc" , + .sta_mask =BIT (22 ), + .ctl_offs =0x38C , + .pwr_sta_offs =0x16C , + .pwr_sta2nd_offs =0x170 , + .sram_pdn_bits =BIT (8 ), + .sram_pdn_ack_bits =BIT (12 ), + .bp_infracfg = { +BUS_PROT_WR (MT8188_TOP_AXI_PROT_EN_MM_VENC_STEP1 , +MT8188_TOP_AXI_PROT_EN_MM_SET , +MT8188_TOP_AXI_PROT_EN_MM_CLR , +MT8188_TOP_AXI_PROT_EN_MM_STA ), +BUS_PROT_WR (MT8188_TOP_AXI_PROT_EN_MM_VENC_STEP2 , +MT8188_TOP_AXI_PROT_EN_MM_SET , +MT8188_TOP_AXI_PROT_EN_MM_CLR , +MT8188_TOP_AXI_PROT_EN_MM_STA ), +BUS_PROT_WR (MT8188_TOP_AXI_PROT_EN_MM_2_VENC_STEP3 , +MT8188_TOP_AXI_PROT_EN_MM_2_SET , +MT8188_TOP_AXI_PROT_EN_MM_2_CLR , +MT8188_TOP_AXI_PROT_EN_MM_2_STA ), + }, + .caps =MTK_SCPD_KEEP_DEFAULT_OFF , + }, + [MT8188_POWER_DOMAIN_IMG_VCORE ] = { + .name ="vcore" , + .sta_mask =BIT (28 ), + .ctl_offs =0x3A4 , + .pwr_sta_offs =0x16C , + .pwr_sta2nd_offs =0x170 , + .bp_infracfg = { +BUS_PROT_WR (MT8188_TOP_AXI_PROT_EN_MM_IMG_VCORE_STEP1 , +MT8188_TOP_AXI_PROT_EN_MM_SET , +MT8188_TOP_AXI_PROT_EN_MM_CLR , +MT8188_TOP_AXI_PROT_EN_MM_STA ), +BUS_PROT_WR (MT8188_TOP_AXI_PROT_EN_MM_IMG_VCORE_STEP2 , +MT8188_TOP_AXI_PROT_EN_MM_SET , +MT8188_TOP_AXI_PROT_EN_MM_CLR , +MT8188_TOP_AXI_PROT_EN_MM_STA ), +BUS_PROT_WR (MT8188_TOP_AXI_PROT_EN_MM_2_IMG_VCORE_STEP3 , +MT8188_TOP_AXI_PROT_EN_MM_2_SET , +MT8188_TOP_AXI_PROT_EN_MM_2_CLR , +MT8188_TOP_AXI_PROT_EN_MM_2_STA ), + }, + .caps =MTK_SCPD_KEEP_DEFAULT_OFF |MTK_SCPD_DOMAIN_SUPPLY , + }, + [MT8188_POWER_DOMAIN_IMG_MAIN ] = { + .name ="img_main" , + .sta_mask =BIT (29 ), + .ctl_offs =0x3A8 , + .pwr_sta_offs =0x16C , + .pwr_sta2nd_offs =0x170 , + .sram_pdn_bits =BIT (8 ), + .sram_pdn_ack_bits =BIT (12 ), + .bp_infracfg = { +BUS_PROT_WR (MT8188_TOP_AXI_PROT_EN_MM_2_IMG_MAIN_STEP1 , +MT8188_TOP_AXI_PROT_EN_MM_2_SET , +MT8188_TOP_AXI_PROT_EN_MM_2_CLR , +MT8188_TOP_AXI_PROT_EN_MM_2_STA ), +BUS_PROT_WR (MT8188_TOP_AXI_PROT_EN_MM_2_IMG_MAIN_STEP2 , +MT8188_TOP_AXI_PROT_EN_MM_2_SET , +MT8188_TOP_AXI_PROT_EN_MM_2_CLR , +MT8188_TOP_AXI_PROT_EN_MM_2_STA ), + }, + .caps =MTK_SCPD_KEEP_DEFAULT_OFF , + }, + [MT8188_POWER_DOMAIN_DIP ] = { + .name ="dip" , + .sta_mask =BIT (30 ), + .ctl_offs =0x3AC , + .pwr_sta_offs =0x16C , + .pwr_sta2nd_offs =0x170 , + .sram_pdn_bits =BIT (8 ), + .sram_pdn_ack_bits =BIT (12 ), + .caps =MTK_SCPD_KEEP_DEFAULT_OFF , + }, + [MT8188_POWER_DOMAIN_IPE ] = { + .name ="ipe" , + .sta_mask =BIT (31 ), + .ctl_offs =0x3B0 , + .pwr_sta_offs =0x16C , + .pwr_sta2nd_offs =0x170 , + .sram_pdn_bits =BIT (8 ), + .sram_pdn_ack_bits =BIT (12 ), + .caps =MTK_SCPD_KEEP_DEFAULT_OFF , + }, + [MT8188_POWER_DOMAIN_CAM_VCORE ] = { + .name ="cam_vcore" , + .sta_mask =BIT (27 ), + .ctl_offs =0x3A0 , + .pwr_sta_offs =0x16C , + .pwr_sta2nd_offs =0x170 , + .bp_infracfg = { +BUS_PROT_WR (MT8188_TOP_AXI_PROT_EN_MM_CAM_VCORE_STEP1 , +MT8188_TOP_AXI_PROT_EN_MM_SET , +MT8188_TOP_AXI_PROT_EN_MM_CLR , +MT8188_TOP_AXI_PROT_EN_MM_STA ), +BUS_PROT_WR (MT8188_TOP_AXI_PROT_EN_2_CAM_VCORE_STEP2 , +MT8188_TOP_AXI_PROT_EN_2_SET , +MT8188_TOP_AXI_PROT_EN_2_CLR , +MT8188_TOP_AXI_PROT_EN_2_STA ), +BUS_PROT_WR (MT8188_TOP_AXI_PROT_EN_1_CAM_VCORE_STEP3 , +MT8188_TOP_AXI_PROT_EN_1_SET , +MT8188_TOP_AXI_PROT_EN_1_CLR , +MT8188_TOP_AXI_PROT_EN_1_STA ), +BUS_PROT_WR (MT8188_TOP_AXI_PROT_EN_MM_CAM_VCORE_STEP4 , +MT8188_TOP_AXI_PROT_EN_MM_SET , +MT8188_TOP_AXI_PROT_EN_MM_CLR , +MT8188_TOP_AXI_PROT_EN_MM_STA ), +BUS_PROT_WR (MT8188_TOP_AXI_PROT_EN_MM_2_CAM_VCORE_STEP5 , +MT8188_TOP_AXI_PROT_EN_MM_2_SET , +MT8188_TOP_AXI_PROT_EN_MM_2_CLR , +MT8188_TOP_AXI_PROT_EN_MM_2_STA ), + }, + .caps =MTK_SCPD_KEEP_DEFAULT_OFF |MTK_SCPD_DOMAIN_SUPPLY , + }, + [MT8188_POWER_DOMAIN_CAM_MAIN ] = { + .name ="cam_main" , + .sta_mask =BIT (24 ), + .ctl_offs =0x394 , + .pwr_sta_offs =0x16C , + .pwr_sta2nd_offs =0x170 , + .sram_pdn_bits =BIT (8 ), + .sram_pdn_ack_bits =BIT (12 ), + .bp_infracfg = { +BUS_PROT_WR (MT8188_TOP_AXI_PROT_EN_MM_2_CAM_MAIN_STEP1 , +MT8188_TOP_AXI_PROT_EN_MM_2_SET , +MT8188_TOP_AXI_PROT_EN_MM_2_CLR , +MT8188_TOP_AXI_PROT_EN_MM_2_STA ), +BUS_PROT_WR (MT8188_TOP_AXI_PROT_EN_2_CAM_MAIN_STEP2 , +MT8188_TOP_AXI_PROT_EN_2_SET , +MT8188_TOP_AXI_PROT_EN_2_CLR , +MT8188_TOP_AXI_PROT_EN_2_STA ), +BUS_PROT_WR (MT8188_TOP_AXI_PROT_EN_MM_2_CAM_MAIN_STEP3 , +MT8188_TOP_AXI_PROT_EN_MM_2_SET , +MT8188_TOP_AXI_PROT_EN_MM_2_CLR , +MT8188_TOP_AXI_PROT_EN_MM_2_STA ), +BUS_PROT_WR (MT8188_TOP_AXI_PROT_EN_2_CAM_MAIN_STEP4 , +MT8188_TOP_AXI_PROT_EN_2_SET , +MT8188_TOP_AXI_PROT_EN_2_CLR , +MT8188_TOP_AXI_PROT_EN_2_STA ), + }, + .caps =MTK_SCPD_KEEP_DEFAULT_OFF , + }, + [MT8188_POWER_DOMAIN_CAM_SUBA ] = { + .name ="cam_suba" , + .sta_mask =BIT (25 ), + .ctl_offs =0x398 , + .pwr_sta_offs =0x16C , + .pwr_sta2nd_offs =0x170 , + .sram_pdn_bits =BIT (8 ), + .sram_pdn_ack_bits =BIT (12 ), + .caps =MTK_SCPD_KEEP_DEFAULT_OFF , + }, + [MT8188_POWER_DOMAIN_CAM_SUBB ] = { + .name ="cam_subb" , + .sta_mask =BIT (26 ), + .ctl_offs =0x39C , + .pwr_sta_offs =0x16C , + .pwr_sta2nd_offs =0x170 , + .sram_pdn_bits =BIT (8 ), + .sram_pdn_ack_bits =BIT (12 ), + .caps =MTK_SCPD_KEEP_DEFAULT_OFF , + }, +}; + +static const struct scpsys_soc_data mt8188_scpsys_data = { + .domains_data = scpsys_domain_data_mt8188, + .num_domains =ARRAY_SIZE (scpsys_domain_data_mt8188), +}; + +#endif /* __SOC_MEDIATEK_MT8188_PM_DOMAINS_H */
drivers/soc/mediatek/mtk-pm-domains.c +5 -0
@@ -21,6 +21,7 @@#include "mt8173-pm-domains.h" #include "mt8183-pm-domains.h" #include "mt8186-pm-domains.h" +#include "mt8188-pm-domains.h" #include "mt8192-pm-domains.h" #include "mt8195-pm-domains.h"
@@ -579,6 +580,10 @@ static const struct of_device_id scpsys_of_match[] = { .compatible = "mediatek,mt8186-power-controller", .data = &mt8186_scpsys_data, }, + { + .compatible = "mediatek,mt8188-power-controller", + .data = &mt8188_scpsys_data, + }, { .compatible = "mediatek,mt8192-power-controller", .data = &mt8192_scpsys_data,
include/linux/soc/mediatek/infracfg.h +121 -0
127 lines not on this page · raw message
Signature · 1 line
2.18.0
AngeloGioacchino Del Regno
maintainerRe: [PATCH v2 2/2] soc: mediatek: pm-domains: Add support for mt8188
Il 28/09/22 10:43, Garmin.Chang ha scritto:
Quoted 69 lines
Add domain control data including bus protection data size change due to more protection steps in mt8188.
Signed-off-by Garmin.Chang <[email protected]>--- drivers/soc/mediatek/mt8188-pm-domains.h | 623 +++++++++++++++++++++++ drivers/soc/mediatek/mtk-pm-domains.c | 5 + include/linux/soc/mediatek/infracfg.h | 121 +++++ 3 files changed, 749 insertions(+)create mode 100644
drivers/soc/mediatek/mt8188-pm-domains.hdrivers/soc/mediatek/mt8188-pm-domains.h new file +52
-0@@ -0,0 +1,623 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +/* +* Copyright (c) 2022 MediaTek Inc. +* Author: Garmin Chang <[email protected]> +*/ + +#ifndef __SOC_MEDIATEK_MT8188_PM_DOMAINS_H +#define __SOC_MEDIATEK_MT8188_PM_DOMAINS_H + +#include "mtk-pm-domains.h" +#include <dt-bindings/power/mediatek,mt8188-power.h> + +/* + * MT8188 power domain support + */ + +static const struct scpsys_domain_data scpsys_domain_data_mt8188[] = { + [MT8188_POWER_DOMAIN_MFG0] = { + .name = "mfg0", + .sta_mask = BIT(1), + .ctl_offs = 0x300, + .pwr_sta_offs = 0x174, + .pwr_sta2nd_offs = 0x178, + .sram_pdn_bits = BIT(8), + .sram_pdn_ack_bits = BIT(12), + .caps = MTK_SCPD_KEEP_DEFAULT_OFF | MTK_SCPD_DOMAIN_SUPPLY, + }, + [MT8188_POWER_DOMAIN_MFG1] = { + .name = "mfg1", + .sta_mask = BIT(2), + .ctl_offs = 0x304, + .pwr_sta_offs = 0x174, + .pwr_sta2nd_offs = 0x178, + .sram_pdn_bits = BIT(8), + .sram_pdn_ack_bits = BIT(12), + .bp_infracfg = { + BUS_PROT_WR(MT8188_TOP_AXI_PROT_EN_MFG1_STEP1, + MT8188_TOP_AXI_PROT_EN_SET, + MT8188_TOP_AXI_PROT_EN_CLR, + MT8188_TOP_AXI_PROT_EN_STA), + BUS_PROT_WR(MT8188_TOP_AXI_PROT_EN_2_MFG1_STEP2, + MT8188_TOP_AXI_PROT_EN_2_SET, + MT8188_TOP_AXI_PROT_EN_2_CLR, + MT8188_TOP_AXI_PROT_EN_2_STA), + BUS_PROT_WR(MT8188_TOP_AXI_PROT_EN_1_MFG1_STEP3, + MT8188_TOP_AXI_PROT_EN_1_SET, + MT8188_TOP_AXI_PROT_EN_1_CLR, + MT8188_TOP_AXI_PROT_EN_1_STA), + BUS_PROT_WR(MT8188_TOP_AXI_PROT_EN_2_MFG1_STEP4, + MT8188_TOP_AXI_PROT_EN_2_SET, + MT8188_TOP_AXI_PROT_EN_2_CLR, + MT8188_TOP_AXI_PROT_EN_2_STA),
drivers/soc/mediatek/mt8188-pm-domains.h line 62
Quoted 10 lines
drivers/soc/mediatek/mt8188-pm-domains.h new file +10
-0+BUS_PROT_WR (MT8188_TOP_AXI_PROT_EN_MFG1_STEP5 , +MT8188_TOP_AXI_PROT_EN_SET , +MT8188_TOP_AXI_PROT_EN_CLR , +MT8188_TOP_AXI_PROT_EN_STA ), +BUS_PROT_WR (MT8188_TOP_AXI_PROT_EN_SUB_INFRA_VDNR_MFG1_STEP6 , +MT8188_TOP_AXI_PROT_EN_SUB_INFRA_VDNR_SET , +MT8188_TOP_AXI_PROT_EN_SUB_INFRA_VDNR_CLR , + MT8188_TOP_AXI_PROT_EN_SUB_INFRA_VDNR_STA), + }, + .caps = MTK_SCPD_KEEP_DEFAULT_OFF,
Please add MTK_SCPD_DOMAIN_SUPPLY cap to MFG1 as well.
For more information, please look at:13bde169c6fe ("soc: mediatek: mtk-pm-domains: Allow probing vreg supply on two MFGs")
Regards,
Angelo
Re: [PATCH v2 2/2] soc: mediatek: pm-domains: Add support for mt8188
Quoted 97 lines · AngeloGioacchino Del Regno
Il 28/09/22 10:43, Garmin.Chang ha scritto:
Quoted 88 lines
Add domain control data including bus protection data size change due to more protection steps in mt8188.
Signed-off-by Garmin.Chang <[email protected]>--- drivers/soc/mediatek/mt8188-pm-domains.h | 623 +++++++++++++++++++++++ drivers/soc/mediatek/mtk-pm-domains.c | 5 + include/linux/soc/mediatek/infracfg.h | 121 +++++ 3 files changed, 749 insertions(+)create mode 100644
drivers/soc/mediatek/mt8188-pm-domains.hdrivers/soc/mediatek/mt8188-pm-domains.h new file +17
-0@@ -0,0 +1,623 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +/* +* Copyright (c) 2022 MediaTek Inc. +* Author: Garmin Chang <[email protected]> +*/ + +#ifndef __SOC_MEDIATEK_MT8188_PM_DOMAINS_H +#define __SOC_MEDIATEK_MT8188_PM_DOMAINS_H + +#include "mtk-pm-domains.h" +#include <dt-bindings/power/mediatek,mt8188-power.h> + +/* +* MT8188 power domain support +*/ + +static const struct scpsys_domain_data scpsys_domain_data_mt8188[]= {
drivers/soc/mediatek/mt8188-pm-domains.h new file +9
-0+ [MT8188_POWER_DOMAIN_MFG0 ] = { + .name ="mfg0" , + .sta_mask =BIT (1 ), + .ctl_offs =0x300 , + .pwr_sta_offs =0x174 , + .pwr_sta2nd_offs =0x178 , + .sram_pdn_bits =BIT (8 ), + .sram_pdn_ack_bits =BIT (12 ), + .caps = MTK_SCPD_KEEP_DEFAULT_OFF |
MTK_SCPD_DOMAIN_SUPPLY,drivers/soc/mediatek/mt8188-pm-domains.h new file +15
-0+ }, + [MT8188_POWER_DOMAIN_MFG1] = { + .name = "mfg1", + .sta_mask = BIT(2), + .ctl_offs = 0x304, + .pwr_sta_offs = 0x174, + .pwr_sta2nd_offs = 0x178, + .sram_pdn_bits = BIT(8), + .sram_pdn_ack_bits = BIT(12), + .bp_infracfg = { +BUS_PROT_WR (MT8188_TOP_AXI_PROT_EN_MFG1_STEP1 , +MT8188_TOP_AXI_PROT_EN_SET , +MT8188_TOP_AXI_PROT_EN_CLR , +MT8188_TOP_AXI_PROT_EN_STA ), + BUS_PROT_WR(MT8188_TOP_AXI_PROT_EN_2_MFG1_STEP2,
drivers/soc/mediatek/mt8188-pm-domains.h new file +4
-0+ MT8188_TOP_AXI_PROT_EN_2_SET, +MT8188_TOP_AXI_PROT_EN_2_CLR , + MT8188_TOP_AXI_PROT_EN_2_STA), + BUS_PROT_WR(MT8188_TOP_AXI_PROT_EN_1_MFG1_STEP3,
drivers/soc/mediatek/mt8188-pm-domains.h new file +4
-0+ MT8188_TOP_AXI_PROT_EN_1_SET, +MT8188_TOP_AXI_PROT_EN_1_CLR , + MT8188_TOP_AXI_PROT_EN_1_STA), + BUS_PROT_WR(MT8188_TOP_AXI_PROT_EN_2_MFG1_STEP4,
drivers/soc/mediatek/mt8188-pm-domains.h new file +8
-0+ MT8188_TOP_AXI_PROT_EN_2_SET, +MT8188_TOP_AXI_PROT_EN_2_CLR , + MT8188_TOP_AXI_PROT_EN_2_STA), +BUS_PROT_WR (MT8188_TOP_AXI_PROT_EN_MFG1_STEP5 , +MT8188_TOP_AXI_PROT_EN_SET , +MT8188_TOP_AXI_PROT_EN_CLR , +MT8188_TOP_AXI_PROT_EN_STA ), + BUS_PROT_WR(MT8188_TOP_AXI_PROT_EN_SUB_INFRA_VD
NR_MFG1_STEP6,drivers/soc/mediatek/mt8188-pm-domains.h new file +1
-0+MT8188_TOP_AXI_PROT_EN_SUB_INFRA_VD
NR_SET,drivers/soc/mediatek/mt8188-pm-domains.h new file +1
-0+MT8188_TOP_AXI_PROT_EN_SUB_INFRA_VD
NR_CLR,drivers/soc/mediatek/mt8188-pm-domains.h new file +1
-0+MT8188_TOP_AXI_PROT_EN_SUB_INFRA_VD
NR_STA),drivers/soc/mediatek/mt8188-pm-domains.h
Quoted 2 lines
drivers/soc/mediatek/mt8188-pm-domains.h new file +2
-0+ }, + .caps = MTK_SCPD_KEEP_DEFAULT_OFF,Please add
MTK_SCPD_DOMAIN_SUPPLYcap to MFG1 as well. For more information, please look at:13bde169c6fe("soc: mediatek: mtk-pm-domains: Allow probing vreg supply on two MFGs")
Quoted 3 lines
Regards,
Angelo
Thank you for your suggestion.
Accroding to /sys/kernel/debug/pm_genpd/pm_genpd_summary, mfg0 is the parent of mfg1 and mfg1 is the parent of mfg2, mfg3 and mfg4. Before the devices power on mfg2, mfg3 and mfg4, system will power on mfg1 first. Also before the devices power on mfg1, system will power on mfg0 first.
Because mfg0 is the root of mfg1, mfg2, mfg3 and mfg4 and MTK_SCPD_DOMAIN_SUPPLY is configured on mfg0, so MTK_SCPD_DOMAIN_SUPPLY is also applied on mfg1, mfg2, mfg3 and mfg4.
Thanks,
Best Regards,
Garmin
Re: [PATCH v2 2/2] soc: mediatek: pm-domains: Add support for mt8188
Quoted 116 lines · garmin.chang
Quoted 98 lines · AngeloGioacchino Del Regno
Il 28/09/22 10:43, Garmin.Chang ha scritto:
Quoted 89 lines
Add domain control data including bus protection data size change due to more protection steps in mt8188.
Signed-off-by Garmin.Chang <[email protected]>--- drivers/soc/mediatek/mt8188-pm-domains.h | 623 +++++++++++++++++++++++ drivers/soc/mediatek/mtk-pm-domains.c | 5 + include/linux/soc/mediatek/infracfg.h | 121 +++++ 3 files changed, 749 insertions(+)create mode 100644
drivers/soc/mediatek/mt8188-pm-domains.hdrivers/soc/mediatek/mt8188-pm-domains.h new file +17
-0@@ -0,0 +1,623 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +/* +* Copyright (c) 2022 MediaTek Inc. +* Author: Garmin Chang <[email protected]> +*/ + +#ifndef __SOC_MEDIATEK_MT8188_PM_DOMAINS_H +#define __SOC_MEDIATEK_MT8188_PM_DOMAINS_H + +#include "mtk-pm-domains.h" +#include <dt-bindings/power/mediatek,mt8188-power.h> + +/* +* MT8188 power domain support +*/ + +static const struct scpsys_domain_datascpsys_domain_data_mt8188[]
= {drivers/soc/mediatek/mt8188-pm-domains.h new file +9
-0+ [MT8188_POWER_DOMAIN_MFG0 ] = { + .name ="mfg0" , + .sta_mask =BIT (1 ), + .ctl_offs =0x300 , + .pwr_sta_offs =0x174 , + .pwr_sta2nd_offs =0x178 , + .sram_pdn_bits =BIT (8 ), + .sram_pdn_ack_bits =BIT (12 ), + .caps = MTK_SCPD_KEEP_DEFAULT_OFF |
MTK_SCPD_DOMAIN_SUPPLY,drivers/soc/mediatek/mt8188-pm-domains.h new file +15
-0+ }, + [MT8188_POWER_DOMAIN_MFG1] = { + .name = "mfg1", + .sta_mask = BIT(2), + .ctl_offs = 0x304, + .pwr_sta_offs = 0x174, + .pwr_sta2nd_offs = 0x178, + .sram_pdn_bits = BIT(8), + .sram_pdn_ack_bits = BIT(12), + .bp_infracfg = { +BUS_PROT_WR (MT8188_TOP_AXI_PROT_EN_MFG1_STEP1 , +MT8188_TOP_AXI_PROT_EN_SET , +MT8188_TOP_AXI_PROT_EN_CLR , +MT8188_TOP_AXI_PROT_EN_STA ), + BUS_PROT_WR(MT8188_TOP_AXI_PROT_EN_2_MFG1_STEP2,
drivers/soc/mediatek/mt8188-pm-domains.h new file +4
-0+ MT8188_TOP_AXI_PROT_EN_2_SET, +MT8188_TOP_AXI_PROT_EN_2_CLR , + MT8188_TOP_AXI_PROT_EN_2_STA), + BUS_PROT_WR(MT8188_TOP_AXI_PROT_EN_1_MFG1_STEP3,
drivers/soc/mediatek/mt8188-pm-domains.h new file +4
-0+ MT8188_TOP_AXI_PROT_EN_1_SET, +MT8188_TOP_AXI_PROT_EN_1_CLR , + MT8188_TOP_AXI_PROT_EN_1_STA), + BUS_PROT_WR(MT8188_TOP_AXI_PROT_EN_2_MFG1_STEP4,
drivers/soc/mediatek/mt8188-pm-domains.h new file +8
-0+ MT8188_TOP_AXI_PROT_EN_2_SET, +MT8188_TOP_AXI_PROT_EN_2_CLR , + MT8188_TOP_AXI_PROT_EN_2_STA), +BUS_PROT_WR (MT8188_TOP_AXI_PROT_EN_MFG1_STEP5 , +MT8188_TOP_AXI_PROT_EN_SET , +MT8188_TOP_AXI_PROT_EN_CLR , +MT8188_TOP_AXI_PROT_EN_STA ), + BUS_PROT_WR(MT8188_TOP_AXI_PROT_EN_SUB_INFRA_VD
NR_MFG1_STEP6,drivers/soc/mediatek/mt8188-pm-domains.h new file +1
-0+MT8188_TOP_AXI_PROT_EN_SUB_INFRA_VD
NR_SET,drivers/soc/mediatek/mt8188-pm-domains.h new file +1
-0+MT8188_TOP_AXI_PROT_EN_SUB_INFRA_VD
NR_CLR,drivers/soc/mediatek/mt8188-pm-domains.h new file +1
-0+MT8188_TOP_AXI_PROT_EN_SUB_INFRA_VD
NR_STA),drivers/soc/mediatek/mt8188-pm-domains.h
Quoted 2 lines
drivers/soc/mediatek/mt8188-pm-domains.h new file +2
-0+ }, + .caps = MTK_SCPD_KEEP_DEFAULT_OFF,Please add
MTK_SCPD_DOMAIN_SUPPLYcap to MFG1 as well. For more information, please look at:13bde169c6fe("soc: mediatek: mtk-pm-domains: Allow probing vreg supply on two MFGs")Quoted 3 lines
Regards,
AngeloThank you for your suggestion.
Accroding to
/sys/kernel/debug/pm_genpd/pm_genpd_summary, mfg0 is the parent of mfg1 and mfg1 is the parent of mfg2, mfg3 and mfg4. Before the devices power on mfg2, mfg3 and mfg4, system will power on mfg1 first. Also before the devices power on mfg1, system will power on
mfg0 first.
Because mfg0 is the root of mfg1, mfg2, mfg3 and mfg4 andMTK_SCPD_DOMAIN_SUPPLYis configured on mfg0, soMTK_SCPD_DOMAIN_SUPPLY
is also applied on mfg1, mfg2, mfg3 and mfg4.
Quoted 3 lines
Thanks,
Best Regards,
Garmin
I will apply 13bde169c6fe ("soc: mediatek: mtk-pm-domains: Allow probing vreg supply on two MFGs") in next verion.
Quoted 3 lines
Thanks,
Best Regards,
Garmin