Skip to contentSkip to conversation

rpi_4_defconfig: add missing CONFIG_ARCH_FIXUP_FDT_MEMORY

PATCH New Corentin Labbe 3 participants 7 messages Mar 31, 2020 – May 12, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 rpi_4_defconfig: add missing CONFIG_ARCH_FIXUP_FDT_MEMORY

As discussed at https://lore.kernel.org/linux-arm-kernel/b726290c-1038-3771-5187-6ac370bc92c9 at arm.com/T/ the defconfig for rpi4 miss CONFIG_ARCH_FIXUP_FDT_MEMORY.
Without it, booting with an initrd fail.

---
 configs/rpi_4_defconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
configs/rpi_4_defconfig +1 -1
index 6d148dab07..8540b3c927 100644
@@ -7,7 +7,7 @@ CONFIG_ENV_SIZE=0x4000
 CONFIG_NR_DRAM_BANKS=2
 CONFIG_DISTRO_DEFAULTS=y
 CONFIG_OF_BOARD_SETUP=y
-# CONFIG_ARCH_FIXUP_FDT_MEMORY is not set
+CONFIG_ARCH_FIXUP_FDT_MEMORY=y
 CONFIG_MISC_INIT_R=y
 # CONFIG_DISPLAY_CPUINFO is not set
 # CONFIG_DISPLAY_BOARDINFO is not set
Signature · 1 line
2.24.1
#1 lore raw

PATCH 1/1 rpi_4_defconfig: add missing CONFIG_ARCH_FIXUP_FDT_MEMORY

Quoted 15 lines · Corentin Labbe

As discussed at https://lore.kernel.org/linux-arm-kernel/b726290c-1038-3771-5187-6ac370bc92c9 at arm.com/T/ the defconfig for rpi4 miss CONFIG_ARCH_FIXUP_FDT_MEMORY.
Without it, booting with an initrd fail.

---
 configs/rpi_4_defconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
configs/rpi_4_defconfig +0 -0
index 6d148dab07..8540b3c927 100644

configs/rpi_4_defconfig CONFIG_ENV_SIZE=0x4000 · line 13

Quoted 8 lines
configs/rpi_4_defconfig +1 -1
@@ -7,7 +7,7 @@ CONFIG_ENV_SIZE=0x4000
 CONFIG_NR_DRAM_BANKS=2
 CONFIG_DISTRO_DEFAULTS=y
 CONFIG_OF_BOARD_SETUP=y
-# CONFIG_ARCH_FIXUP_FDT_MEMORY is not set
+CONFIG_ARCH_FIXUP_FDT_MEMORY=y
 CONFIG_MISC_INIT_R=y
 # CONFIG_DISPLAY_CPUINFO is not set
 # CONFIG_DISPLAY_BOARDINFO is not set

Hello

gentle ping

Regards

#2 lore raw

PATCH 1/1 rpi_4_defconfig: add missing CONFIG_ARCH_FIXUP_FDT_MEMORY

Hi Corentin,

Quoted 10 lines · LABBE Corentin
Quoted 9 lines · Corentin Labbe

As discussed at https://lore.kernel.org/linux-arm-kernel/b726290c-1038-3771-5187-6ac370bc92c9 at arm.com/T/ the defconfig for rpi4 miss CONFIG_ARCH_FIXUP_FDT_MEMORY.
Without it, booting with an initrd fail.

---
 configs/rpi_4_defconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 15 lines
Quoted 6 lines
configs/rpi_4_defconfig +0 -0
index 6d148dab07..8540b3c927 100644

configs/rpi_4_defconfig CONFIG_ENV_SIZE=0x4000 · line 13

Quoted 8 lines
configs/rpi_4_defconfig +1 -1
@@ -7,7 +7,7 @@ CONFIG_ENV_SIZE=0x4000
 CONFIG_NR_DRAM_BANKS=2
 CONFIG_DISTRO_DEFAULTS=y
 CONFIG_OF_BOARD_SETUP=y
-# CONFIG_ARCH_FIXUP_FDT_MEMORY is not set
+CONFIG_ARCH_FIXUP_FDT_MEMORY=y
 CONFIG_MISC_INIT_R=y
 # CONFIG_DISPLAY_CPUINFO is not set
 # CONFIG_DISPLAY_BOARDINFO is not set

Patch looks good, but is there any reason why you don't enable it for rpi_4_32b_defconfig and rpi_arm64_defconfig?

Regards,
Matthias

#3 lore raw

PATCH 1/1 rpi_4_defconfig: add missing CONFIG_ARCH_FIXUP_FDT_MEMORY

Quoted 29 lines · Matthias Brugger

Hi Corentin,

Quoted 10 lines · LABBE Corentin
Quoted 9 lines · Corentin Labbe

As discussed at https://lore.kernel.org/linux-arm-kernel/b726290c-1038-3771-5187-6ac370bc92c9 at arm.com/T/ the defconfig for rpi4 miss CONFIG_ARCH_FIXUP_FDT_MEMORY.
Without it, booting with an initrd fail.

---
 configs/rpi_4_defconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 15 lines
Quoted 6 lines
configs/rpi_4_defconfig +0 -0
index 6d148dab07..8540b3c927 100644

configs/rpi_4_defconfig CONFIG_ENV_SIZE=0x4000 · line 13

Quoted 8 lines
configs/rpi_4_defconfig +1 -1
@@ -7,7 +7,7 @@ CONFIG_ENV_SIZE=0x4000
 CONFIG_NR_DRAM_BANKS=2
 CONFIG_DISTRO_DEFAULTS=y
 CONFIG_OF_BOARD_SETUP=y
-# CONFIG_ARCH_FIXUP_FDT_MEMORY is not set
+CONFIG_ARCH_FIXUP_FDT_MEMORY=y
 CONFIG_MISC_INIT_R=y
 # CONFIG_DISPLAY_CPUINFO is not set
 # CONFIG_DISPLAY_BOARDINFO is not set
Quoted 3 lines

Patch looks good, but is there any reason why you don't enable it for rpi_4_32b_defconfig and rpi_arm64_defconfig?

And please add me to the recipients list, otherwise this patches most probably get lost.

Regards,
Matthias

#4 lore raw

PATCH 1/1 rpi_4_defconfig: add missing CONFIG_ARCH_FIXUP_FDT_MEMORY

Hi Corentin,

Quoted 30 lines · Matthias Brugger
Quoted 29 lines · Matthias Brugger

Hi Corentin,

Quoted 25 lines · LABBE Corentin
Quoted 23 lines · Corentin Labbe

As discussed at https://lore.kernel.org/linux-arm-kernel/b726290c-1038-3771-5187-6ac370bc92c9 at arm.com/T/ the defconfig for rpi4 miss CONFIG_ARCH_FIXUP_FDT_MEMORY.
Without it, booting with an initrd fail.

---
 configs/rpi_4_defconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
configs/rpi_4_defconfig +1 -1
index 6d148dab07..8540b3c927 100644
@@ -7,7 +7,7 @@ CONFIG_ENV_SIZE=0x4000
 CONFIG_NR_DRAM_BANKS=2
 CONFIG_DISTRO_DEFAULTS=y
 CONFIG_OF_BOARD_SETUP=y
-# CONFIG_ARCH_FIXUP_FDT_MEMORY is not set
+CONFIG_ARCH_FIXUP_FDT_MEMORY=y
 CONFIG_MISC_INIT_R=y
 # CONFIG_DISPLAY_CPUINFO is not set
 # CONFIG_DISPLAY_BOARDINFO is not set
Quoted 7 lines
Quoted 3 lines

Patch looks good, but is there any reason why you don't enable it for rpi_4_32b_defconfig and rpi_arm64_defconfig?

And please add me to the recipients list, otherwise this patches most probably get lost.

Are you planning to send a new version of the patch which enables the option for all configs?

Regards,
Matthias

#5 lore raw

PATCH 1/1 rpi_4_defconfig: add missing CONFIG_ARCH_FIXUP_FDT_MEMORY

Quoted 37 lines · Matthias Brugger

Hi Corentin,

Quoted 34 lines · Matthias Brugger
Quoted 32 lines · Matthias Brugger

Hi Corentin,

Quoted 10 lines · LABBE Corentin
Quoted 9 lines · Corentin Labbe

As discussed at https://lore.kernel.org/linux-arm-kernel/b726290c-1038-3771-5187-6ac370bc92c9 at arm.com/T/ the defconfig for rpi4 miss CONFIG_ARCH_FIXUP_FDT_MEMORY.
Without it, booting with an initrd fail.

---
 configs/rpi_4_defconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 15 lines
Quoted 6 lines
configs/rpi_4_defconfig +0 -0
index 6d148dab07..8540b3c927 100644

configs/rpi_4_defconfig CONFIG_ENV_SIZE=0x4000 · line 13

Quoted 8 lines
configs/rpi_4_defconfig +1 -1
@@ -7,7 +7,7 @@ CONFIG_ENV_SIZE=0x4000
 CONFIG_NR_DRAM_BANKS=2
 CONFIG_DISTRO_DEFAULTS=y
 CONFIG_OF_BOARD_SETUP=y
-# CONFIG_ARCH_FIXUP_FDT_MEMORY is not set
+CONFIG_ARCH_FIXUP_FDT_MEMORY=y
 CONFIG_MISC_INIT_R=y
 # CONFIG_DISPLAY_CPUINFO is not set
 # CONFIG_DISPLAY_BOARDINFO is not set

Patch looks good, but is there any reason why you don't enable it for rpi_4_32b_defconfig and rpi_arm64_defconfig?

Quoted 7 lines
Quoted 3 lines

And please add me to the recipients list, otherwise this patches most probably get lost.

Are you planning to send a new version of the patch which enables the option for all configs?

Yes, I will.
But note that I didnt tested rpi_4_32b_defconfig.
And I am currently unable to test it.
If you want it to be tested, could you apply this patch as is, and I will submit the rpi_4_32b_defconfig later.

Regards

#6 lore raw

PATCH 1/1 rpi_4_defconfig: add missing CONFIG_ARCH_FIXUP_FDT_MEMORY

Quoted 42 lines · LABBE Corentin
Quoted 41 lines · Matthias Brugger

Hi Corentin,

Quoted 37 lines · Matthias Brugger
Quoted 29 lines · Matthias Brugger

Hi Corentin,

Quoted 10 lines · LABBE Corentin
Quoted 9 lines · Corentin Labbe

As discussed at https://lore.kernel.org/linux-arm-kernel/b726290c-1038-3771-5187-6ac370bc92c9 at arm.com/T/ the defconfig for rpi4 miss CONFIG_ARCH_FIXUP_FDT_MEMORY.
Without it, booting with an initrd fail.

---
 configs/rpi_4_defconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 15 lines
Quoted 6 lines
configs/rpi_4_defconfig +0 -0
index 6d148dab07..8540b3c927 100644

configs/rpi_4_defconfig CONFIG_ENV_SIZE=0x4000 · line 13

Quoted 8 lines
configs/rpi_4_defconfig +1 -1
@@ -7,7 +7,7 @@ CONFIG_ENV_SIZE=0x4000
 CONFIG_NR_DRAM_BANKS=2
 CONFIG_DISTRO_DEFAULTS=y
 CONFIG_OF_BOARD_SETUP=y
-# CONFIG_ARCH_FIXUP_FDT_MEMORY is not set
+CONFIG_ARCH_FIXUP_FDT_MEMORY=y
 CONFIG_MISC_INIT_R=y
 # CONFIG_DISPLAY_CPUINFO is not set
 # CONFIG_DISPLAY_BOARDINFO is not set
Quoted 3 lines

Patch looks good, but is there any reason why you don't enable it for rpi_4_32b_defconfig and rpi_arm64_defconfig?

And please add me to the recipients list, otherwise this patches most probably get lost.

Quoted 9 lines
Quoted 3 lines

Are you planning to send a new version of the patch which enables the option for all configs?

Yes, I will.
But note that I didnt tested rpi_4_32b_defconfig.
And I am currently unable to test it.
If you want it to be tested, could you apply this patch as is, and I will submit the rpi_4_32b_defconfig later.

Ok, please don't forget to submit/test configs/rpi_arm64_defconfig as well.

Regards,
Matthias