Add support for Amazon's Annapurna Labs EDAC for L1/L2
Subsystems (2)
v7 cover Add support for Amazon's Annapurna Labs EDAC for L1/L2
This series adds L1 cache and L2 cache error detection and correction support for Amazon's Annapurna Labs SoCs.
Alpine SoCs supports L1 and L2 single bit correction and two bits detection capability based on ARM implementation.
The CPU cores in the SoC are the same and all of them support ECC.
Changes since v6:
-----------------
- Add ARM64 dependency
- Add COMPILE_TEST
Changes since v5:
-----------------
- Use top-level machine compatible to bind the EDAC device
- Remove DT bindings
- Add initcall to create platform device and register the edac driver
- follow 'next-level-cache' phandle to create CPU topology for L2 driver
- Change the driver to be tristate
- Move register read to function flow
- EXPORT_SYMBOL_GPL of_find_next_cache_node
Changes since v4:
-----------------
- Added include for cpumask.h in al_l2_edac.c
- Fix RAMID error print according to ARM TRM
- Use for_each_possible_cpu() to parse information for DT.
- Add missing of_node_put() call.
Changes since v3:
-----------------
- Added include for smp.h sysreg.h
- Use scnprintf instead of snprintf
- Move write_sysreg_s after valid check to minimize the window between read/write.
- Use IS_ERR_OR_NULL instead of IS_ERR, because edac_device_alloc_ctl_info may return NULL.
Changes since v2:
-----------------
- Use BIT for single bit instead of GENMASK
- Use BIT_ULL and GENMASK_ULL for 64bit vector
- Fix the mod_name/ctrl_name.
Changes since v1:
-----------------
- Split into two drivers
- Get cpu-mask according to l2-cache handler from devicetree
- Remove parameter casting
- Use GENMASK() in bit mask
- Use FIELD_GET()
- Update define description PLRU_RAM -> PF_RAM
- Use sys_reg() and read_sysreg_s()
- Remove all write/read wrappers
- Check fatal field to set if the error correctable or not
- Remove un-relevant information from error prints.
- Update smp_call_function_single() call function to wait
- remove usage of get_online_cpus/put_online_cpus
- Use on_each_cpu() and smp_call_function_any() instead of loop with for_each_cpu.
- use buffer for error prints and pass to edac API
- Remove edac_op_state set
- Add for loop to report on repeated errors of the same type
- Fix error name of the TLB to be L2_TLB as written in ARM TRM
- Minor change in Kconfig
- Minor changes in commit message
Hanna Hawa (3):
edac: Add support for Amazon's Annapurna Labs L1 EDAC
of: EXPORT_SYMBOL_GPL of_find_next_cache_node
edac: Add support for Amazon's Annapurna Labs L2 EDAC
MAINTAINERS | 10 ++ drivers/edac/Kconfig | 16 +++ drivers/edac/Makefile | 2 + drivers/edac/al_l1_edac.c | 190 +++++++++++++++++++++++++++++ drivers/edac/al_l2_edac.c | 251 ++++++++++++++++++++++++++++++++++++++ drivers/of/base.c | 1 + 6 files changed, 470 insertions(+) create mode 100644 drivers/edac/al_l1_edac.c create mode 100644 drivers/edac/al_l2_edac.c
Signature · 1 line
2.17.1
PATCH v7 1/3 edac: Add support for Amazon's Annapurna Labs L1 EDAC
Adds support for Amazon's Annapurna Labs L1 EDAC driver to detect and report L1 errors.
--- MAINTAINERS | 5 + drivers/edac/Kconfig | 8 ++ drivers/edac/Makefile | 1 + drivers/edac/al_l1_edac.c | 190 ++++++++++++++++++++++++++++++++++++++ 4 files changed, 204 insertions(+) create mode 100644 drivers/edac/al_l1_edac.c
MAINTAINERS +5 -0
@@ -743,6 +743,11 @@ F: drivers/tty/serial/altera_jtaguart.c F: include/linux/altera_uart.h F: include/linux/altera_jtaguart.h +AMAZON ANNAPURNA LABS L1 EDAC +M: Hanna Hawa <[email protected]> +S: Maintained +F: drivers/edac/al_l1_edac.c + AMAZON ANNAPURNA LABS THERMAL MMIO DRIVER M: Talel Shenhar <[email protected]> S: Maintained
drivers/edac/Kconfig +8 -0
@@ -74,6 +74,14 @@ config EDAC_GHES In doubt, say 'Y'. +config EDAC_AL_L1 + tristate "Amazon's Annapurna Labs L1 EDAC" + depends on (ARM64 && ARCH_ALPINE) || COMPILE_TEST + help + Support for L1 error detection and correction + for Amazon's Annapurna Labs SoCs. + This driver detects errors of L1 caches. + config EDAC_AMD64 tristate "AMD64 (Opteron, Athlon64)" depends on AMD_NB && EDAC_DECODE_MCE
drivers/edac/Makefile +1 -0
@@ -22,6 +22,7 @@ obj-$(CONFIG_EDAC_GHES) += ghes_edac.o edac_mce_amd-y := mce_amd.o obj-$(CONFIG_EDAC_DECODE_MCE) += edac_mce_amd.o +obj-$(CONFIG_EDAC_AL_L1) += al_l1_edac.o obj-$(CONFIG_EDAC_AMD76X) += amd76x_edac.o obj-$(CONFIG_EDAC_CPC925) += cpc925_edac.o obj-$(CONFIG_EDAC_I5000) += i5000_edac.o
drivers/edac/al_l1_edac.c new file +190 -0
190 lines not on this page · raw message
Signature · 1 line
2.17.1
Re: [PATCH v7 1/3] edac: Add support for Amazon's Annapurna Labs L1 EDAC
Hi Hanna,
(This was still on my list. I've not seen a newer version, its not in next, and it still applies, so:)
Quoted 9 lines · Hanna Hawa
Adds support for Amazon's Annapurna Labs L1 EDAC driver to detect and report L1 errors.
drivers/edac/al_l1_edac.c new file +0
-0
drivers/edac/al_l1_edac.c line 9
Quoted 5 lines
drivers/edac/al_l1_edac.c new file +4
-0@@ -0,0 +1,190 @@ +#include <asm/sysreg.h> +#include <linux/bitfield.h> +#include <linux/of.h> +#include <linux/smp.h>
You need <linux/platform_device.h> for platform_device_register_simple().
[...]
drivers/edac/al_l1_edac.c line 91
Quoted 9 lines
drivers/edac/al_l1_edac.c new file +8
-0+static void al_l1_edac_cpumerrsr_read_status (void *arg) +{ +for (i =0 ; i < repeat; i++) { +if (fatal) +edac_device_handle_ue (edac_dev,0 ,0 , msg); +else +edac_device_handle_ce (edac_dev,0 ,0 , msg); + }
What serialises these? You kick this off from on_each_cpu(), what stops two CPUs calling this at the same time? 'edac_dev->counters.ce_count += count;' will go wrong in this case.
I think you need a spinlock around the edac_device_* calls that take edac_dev so that only one occurs at a time.
Quoted 21 lines
drivers/edac/al_l1_edac.c new file +21
-0+} + +static void al_l1_edac_check (struct edac_device_ctl_info *edac_dev) +{ +on_each_cpu (al_l1_edac_cpumerrsr_read_status, edac_dev,1 ); +} + +static int al_l1_edac_probe (struct platform_device *pdev) +{ +struct edac_device_ctl_info *edac_dev; +struct device *dev = &pdev->dev; +int ret; + + edac_dev =edac_device_alloc_ctl_info (0 ,DRV_NAME ,1 ,"L" ,1 ,1 ,NULL , +0 ,edac_device_alloc_index ()); +if (!edac_dev) +return -ENOMEM ; + + edac_dev->edac_check = al_l1_edac_check; + edac_dev->dev = dev; + edac_dev->mod_name =DRV_NAME ;
drivers/edac/al_l1_edac.c line 122
Quoted 10 lines
drivers/edac/al_l1_edac.c new file +10
-0+ edac_dev->dev_name =dev_name (dev); + edac_dev->ctl_name ="L1_cache" ; +platform_set_drvdata (pdev, edac_dev); + + ret =edac_device_add_device (edac_dev); +if (ret) + goto err; + +return 0 ; +err:
(this goto has one user, meaning you can remove it by restructuring the code)
drivers/edac/al_l1_edac.c line 143
Quoted 12 lines
drivers/edac/al_l1_edac.c new file +11
-0+dev_err (dev,"Failed to add L1 edac device (%d)\n" , ret); +edac_device_free_ctl_info (edac_dev); + +return ret; +} + +static const struct of_device_id al_l1_edac_of_match[] = { + { .compatible ="al,alpine-v2" }, + { .compatible ="amazon,alpine-v3" }, + {} +};
Unusually these are machine compatibles. It may be worth a comment that these are the platforms which are known to have Cortex-A57/A72 configured with this support, and access to the registers enabled by firmware.
Quoted 1 line
+MODULE_DEVICE_TABLE(of,
al_l1_edac_of_match);
[..]
drivers/edac/al_l1_edac.c line 159
Quoted 4 lines
drivers/edac/al_l1_edac.c new file +4
-0+static int __init al_l1_init (void ) +{ +struct device_node *root =of_find_node_by_path ("/" ); +int ret;
root could be NULL here.
Quoted 7 lines
drivers/edac/al_l1_edac.c new file +7
-0+if (!of_match_node (al_l1_edac_of_match, root)) +return 0 ; + + ret =platform_driver_register (&al_l1_edac_driver); +if (ret) { +pr_err ("Failed to register %s (%d)\n" ,DRV_NAME , ret); +return ret;
drivers/edac/al_l1_edac.c line 177
Quoted 10 lines
drivers/edac/al_l1_edac.c new file +10
-0+ } + + edac_l1_device =platform_device_register_simple (DRV_NAME ,-1 ,NULL ,0 ); +if (IS_ERR (edac_l1_device)) { +pr_err ("Failed to register EDAC AL L1 platform device\n" ); +return PTR_ERR (edac_l1_device); + } + +return 0 ; +}
With the edac_device_handle_ce() race fixed:
Thanks,
James
Re: [PATCH v7 1/3] edac: Add support for Amazon's Annapurna Labs L1 EDAC
Quoted 4 lines · James Morse
Hi Hanna,
(This was still on my list. I've not seen a newer version, its not in next, and it still applies, so:)
Thank you.
Quoted 12 lines · Hanna Hawa
Quoted 9 lines
Adds support for Amazon's Annapurna Labs L1 EDAC driver to detect and report L1 errors.
drivers/edac/al_l1_edac.c new file +0
-0@@ -0,0 +1,190 @@
Quoted 6 lines
drivers/edac/al_l1_edac.c line 9
Quoted 4 lines
drivers/edac/al_l1_edac.c new file +4
-0+#include <asm/sysreg.h> +#include <linux/bitfield.h> +#include <linux/of.h> +#include <linux/smp.h> You need <
linux/platform_device.h> forplatform_device_register_simple().
Will be added in next PS.
Quoted 16 lines
[...]
drivers/edac/al_l1_edac.c line 91
Quoted 9 lines
drivers/edac/al_l1_edac.c new file +8
-0+static void al_l1_edac_cpumerrsr_read_status (void *arg) +{ +for (i =0 ; i < repeat; i++) { +if (fatal) +edac_device_handle_ue (edac_dev,0 ,0 , msg); +else +edac_device_handle_ce (edac_dev,0 ,0 , msg); + }What serialises these? You kick this off from
on_each_cpu(), what stops two CPUs calling this at the same time? 'edac_dev->counters.ce_count+= count;' will go wrong in this case.
Quoted 2 lines
I think you need a spinlock around the edac_device_* calls that take
edac_devso that only one occurs at a time.
Agree with you, will add spinlock in next PS.
Quoted 27 lines
Quoted 27 lines
drivers/edac/al_l1_edac.c new file +25
-0+} + +static void al_l1_edac_check (struct edac_device_ctl_info *edac_dev) +{ +on_each_cpu (al_l1_edac_cpumerrsr_read_status, edac_dev,1 ); +} + +static int al_l1_edac_probe (struct platform_device *pdev) +{ +struct edac_device_ctl_info *edac_dev; +struct device *dev = &pdev->dev; +int ret; + + edac_dev =edac_device_alloc_ctl_info (0 ,DRV_NAME ,1 ,"L" ,1 ,1 ,NULL , +0 ,edac_device_alloc_index ()); +if (!edac_dev) +return -ENOMEM ; + + edac_dev->edac_check = al_l1_edac_check; + edac_dev->dev = dev; + edac_dev->mod_name =DRV_NAME ; + edac_dev->dev_name =dev_name (dev); + edac_dev->ctl_name ="L1_cache" ; +platform_set_drvdata (pdev, edac_dev); +
Quoted 8 lines
drivers/edac/al_l1_edac.c line 122
Quoted 6 lines
drivers/edac/al_l1_edac.c new file +6
-0+ ret =edac_device_add_device (edac_dev); +if (ret) + goto err; + +return 0 ; +err:(this goto has one user, meaning you can remove it by restructuring the code)
Will be fixed in next PS.
Quoted 9 lines
Quoted 8 lines
drivers/edac/al_l1_edac.c new file +6
-0+dev_err (dev,"Failed to add L1 edac device (%d)\n" , ret); +edac_device_free_ctl_info (edac_dev); + +return ret; +} +
Quoted 9 lines
drivers/edac/al_l1_edac.c line 143
Quoted 5 lines
drivers/edac/al_l1_edac.c new file +5
-0+static const struct of_device_id al_l1_edac_of_match[] = { + { .compatible ="al,alpine-v2" }, + { .compatible ="amazon,alpine-v3" }, + {} +};Unusually these are machine compatibles. It may be worth a comment that these are the platforms which are known to have Cortex-A57/A72 configured with this support, and access to the registers enabled by firmware.
Will be added.
Quoted 4 lines
Quoted 3 lines
+MODULE_DEVICE_TABLE(of,
al_l1_edac_of_match);
Quoted 8 lines
[..]
drivers/edac/al_l1_edac.c line 159
Quoted 4 lines
drivers/edac/al_l1_edac.c new file +4
-0+static int __init al_l1_init (void ) +{ +struct device_node *root =of_find_node_by_path ("/" ); +int ret;root could be NULL here.
Will be fixed.
Quoted 21 lines
Quoted 9 lines
drivers/edac/al_l1_edac.c new file +7
-0+if (!of_match_node (al_l1_edac_of_match, root)) +return 0 ; + + ret =platform_driver_register (&al_l1_edac_driver); +if (ret) { +pr_err ("Failed to register %s (%d)\n" ,DRV_NAME , ret); +return ret;drivers/edac/al_l1_edac.c line 177
Quoted 10 lines
drivers/edac/al_l1_edac.c new file +10
-0+ } + + edac_l1_device =platform_device_register_simple (DRV_NAME ,-1 ,NULL ,0 ); +if (IS_ERR (edac_l1_device)) { +pr_err ("Failed to register EDAC AL L1 platform device\n" ); +return PTR_ERR (edac_l1_device); + } + +return 0 ; +}With the
edac_device_handle_ce()race fixed:
Quoted 1 line
Reviewed-by James Morse <[email protected]>
Thanks,
Hanna
Quoted 6 lines
Thanks,
James
PATCH v7 2/3 of: EXPORT_SYMBOL_GPL of_find_next_cache_node
In reply to Hanna HawaMake of_find_next_cache_node() available for modules.
--- drivers/of/base.c | 1 + 1 file changed, 1 insertion(+)
drivers/of/base.c +1 -0
@@ -2172,6 +2172,7 @@ struct device_node *of_find_next_cache_node(const struct device_node *np)return NULL ; } +EXPORT_SYMBOL_GPL (of_find_next_cache_node);/** * of_find_last_cache_level - Find the level at which the last cache is
Signature · 1 line
2.17.1
Re: [PATCH v7 2/3] of: EXPORT_SYMBOL_GPL of_find_next_cache_node
Quoted 7 lines · Hanna Hawa
Make
of_find_next_cache_node()available for modules.Signed-off-by Hanna Hawa <[email protected]>--- drivers/of/base.c | 1 + 1 file changed, 1 insertion(+)
PATCH v7 3/3 edac: Add support for Amazon's Annapurna Labs L2 EDAC
In reply to Hanna HawaAdds support for Amazon's Annapurna Labs L2 EDAC driver to detect and report L2 errors.
--- MAINTAINERS | 5 + drivers/edac/Kconfig | 8 ++ drivers/edac/Makefile | 1 + drivers/edac/al_l2_edac.c | 251 ++++++++++++++++++++++++++++++++++++++ 4 files changed, 265 insertions(+) create mode 100644 drivers/edac/al_l2_edac.c
MAINTAINERS +5 -0
@@ -748,6 +748,11 @@ M: Hanna Hawa <[email protected]> S: Maintained F: drivers/edac/al_l1_edac.c +AMAZON ANNAPURNA LABS L2 EDAC +M: Hanna Hawa <[email protected]> +S: Maintained +F: drivers/edac/al_l2_edac.c + AMAZON ANNAPURNA LABS THERMAL MMIO DRIVER M: Talel Shenhar <[email protected]> S: Maintained
drivers/edac/Kconfig +8 -0
@@ -82,6 +82,14 @@ config EDAC_AL_L1 for Amazon's Annapurna Labs SoCs. This driver detects errors of L1 caches. +config EDAC_AL_L2 + tristate "Amazon's Annapurna Labs L2 EDAC" + depends on (ARM64 && ARCH_ALPINE) || COMPILE_TEST + help + Support for L2 error detection and correction + for Amazon's Annapurna Labs SoCs. + This driver detects errors of L2 caches. + config EDAC_AMD64 tristate "AMD64 (Opteron, Athlon64)" depends on AMD_NB && EDAC_DECODE_MCE
drivers/edac/Makefile +1 -0
@@ -23,6 +23,7 @@ edac_mce_amd-y := mce_amd.o obj-$(CONFIG_EDAC_DECODE_MCE) += edac_mce_amd.o obj-$(CONFIG_EDAC_AL_L1) += al_l1_edac.o +obj-$(CONFIG_EDAC_AL_L2) += al_l2_edac.o obj-$(CONFIG_EDAC_AMD76X) += amd76x_edac.o obj-$(CONFIG_EDAC_CPC925) += cpc925_edac.o obj-$(CONFIG_EDAC_I5000) += i5000_edac.o
drivers/edac/al_l2_edac.c new file +251 -0
251 lines not on this page · raw message
Signature · 1 line
2.17.1
Re: [PATCH v7 3/3] edac: Add support for Amazon's Annapurna Labs L2 EDAC
Hi Hanna,
Quoted 9 lines · Hanna Hawa
Adds support for Amazon's Annapurna Labs L2 EDAC driver to detect and report L2 errors.
MAINTAINERS +0
-0
MAINTAINERS M: Hanna Hawa <[email protected]> · line 754
Quoted 7 lines
MAINTAINERS +4
-0@@ -748,6 +748,11 @@ M: Hanna Hawa <[email protected]> S: Maintained F: drivers/edac/al_l1_edac.c +AMAZON ANNAPURNA LABS L2 EDAC +M: Hanna Hawa <[email protected]> +S: Maintained +F: drivers/edac/al_l2_edac.c
(Why not add the file to the previous section? All this does is come up with an email address based on the file)
Quoted 19 lines
drivers/edac/al_l2_edac.c new file +12
-0@@ -0,0 +1,251 @@ +static int al_l2_edac_probe (struct platform_device *pdev) +{ +for_each_possible_cpu (i) { +struct device_node *cpu; +struct device_node *cpu_cache; +struct al_l2_cache *l2_cache; +bool found = false; + + cpu =of_get_cpu_node (i,NULL ); +if (!cpu) +continue ; +
drivers/edac/al_l2_edac.c line 159
Quoted 10 lines
drivers/edac/al_l2_edac.c new file +10
-0+ cpu_cache =of_find_next_cache_node (cpu); +list_for_each_entry (l2_cache, &al_l2->l2_caches, list_node) { +if (l2_cache->of_node == cpu_cache) { + found = true; +break ; + } + } + +if (found) { +cpumask_set_cpu (i, &l2_cache->cluster_cpus);
of_node_put(cpu_cache); ?
(I can see why you might keep the reference in the else block)
Quoted 6 lines
drivers/edac/al_l2_edac.c new file +6
-0+ }else { + l2_cache =devm_kzalloc (dev,sizeof (*l2_cache), +GFP_KERNEL ); + l2_cache->of_node = cpu_cache; +list_add (&l2_cache->list_node, &al_l2->l2_caches); +cpumask_set_cpu (i, &l2_cache->cluster_cpus);
drivers/edac/al_l2_edac.c line 175
Quoted 10 lines
drivers/edac/al_l2_edac.c new file +10
-0+ } + +of_node_put (cpu); + } + +if (list_empty (&al_l2->l2_caches)) { +dev_err (dev,"L2 Cache list is empty for EDAC device\n" ); + ret = -EINVAL ; + goto err; + }
You are doing this at probe time to create a static list of which CPUs map onto the L2 caches. cacheinfo does something very similar, but it looks like you can't use it as its only populated for online CPUs, and you'd need to walk multiple CPUs cacheinfo leaves to find the same information. The alternative is more complicated.
drivers/edac/al_l2_edac.c line 178
Quoted 2 lines
drivers/edac/al_l2_edac.c new file +2
-0+ ret =edac_device_add_device (edac_dev); +if (ret)
Any references held in the al_l2->l2_caches list leak here.
Quoted 5 lines
drivers/edac/al_l2_edac.c new file +5
-0+ goto err; + +return 0 ; + +err:
drivers/edac/al_l2_edac.c line 192
Quoted 10 lines
drivers/edac/al_l2_edac.c new file +8
-0+dev_err (dev,"Failed to add L2 edac device (%d)\n" , ret); +edac_device_free_ctl_info (edac_dev); + +return ret; +} +static int al_l2_edac_remove (struct platform_device *pdev) +{ +struct edac_device_ctl_info *edac_dev =platform_get_drvdata (pdev);
Do you need to roll over the al_l2->l2_caches list to of_node_put() the l2_cache's ?
Quoted 5 lines
drivers/edac/al_l2_edac.c new file +5
-0+edac_device_del_device (edac_dev->dev); +edac_device_free_ctl_info (edac_dev); + +return 0 ; +}
[..]
drivers/edac/al_l2_edac.c line 204
Quoted 5 lines
drivers/edac/al_l2_edac.c new file +5
-0+static const struct of_device_id al_l2_edac_of_match[] = { + { .compatible ="al,alpine-v2" }, + { .compatible ="amazon,alpine-v3" }, + {} +};
Same comment on these being machine compatibles and what property that applies to.
The code to match the platform and create the platform_device is identical, is there any way it can be shared?
I'm guessing the two-files is because these can be built as independent modules. Would anyone ever have one, but not the other? The L1 support is optional, but you've listed the same set of platforms in both cases here, so do we need to support one but not the other today?
Thanks,
James
Re: [PATCH v7 3/3] edac: Add support for Amazon's Annapurna Labs L2 EDAC
Quoted 15 lines · James Morse
Hi Hanna,
Quoted 12 lines · Hanna Hawa
Adds support for Amazon's Annapurna Labs L2 EDAC driver to detect and report L2 errors.
MAINTAINERS +0
-0@@ -748,6 +748,11 @@ M: Hanna Hawa <[email protected]> S: Maintained F: drivers/edac/al_l1_edac.c
Quoted 7 lines
MAINTAINERS M: Hanna Hawa <[email protected]> · line 754
Quoted 4 lines
MAINTAINERS +4
-0+AMAZON ANNAPURNA LABS L2 EDAC +M: Hanna Hawa <[email protected]> +S: Maintained +F: drivers/edac/al_l2_edac.c(Why not add the file to the previous section? All this does is come up with an email address based on the file)
Added new section as this separated driver.
Quoted 34 lines
Quoted 21 lines
drivers/edac/al_l2_edac.c new file +12
-0@@ -0,0 +1,251 @@ +static int al_l2_edac_probe (struct platform_device *pdev) +{ +for_each_possible_cpu (i) { +struct device_node *cpu; +struct device_node *cpu_cache; +struct al_l2_cache *l2_cache; +bool found = false; + + cpu =of_get_cpu_node (i,NULL ); +if (!cpu) +continue ; +drivers/edac/al_l2_edac.c line 159
Quoted 10 lines
drivers/edac/al_l2_edac.c new file +10
-0+ cpu_cache =of_find_next_cache_node (cpu); +list_for_each_entry (l2_cache, &al_l2->l2_caches, list_node) { +if (l2_cache->of_node == cpu_cache) { + found = true; +break ; + } + } + +if (found) { +cpumask_set_cpu (i, &l2_cache->cluster_cpus);of_node_put(cpu_cache); ?
Quoted 1 line
(I can see why you might keep the reference in the else block)
Will be added in next PS.
Quoted 44 lines
Quoted 8 lines
drivers/edac/al_l2_edac.c new file +6
-0+ }else { + l2_cache =devm_kzalloc (dev,sizeof (*l2_cache), +GFP_KERNEL ); + l2_cache->of_node = cpu_cache; +list_add (&l2_cache->list_node, &al_l2->l2_caches); +cpumask_set_cpu (i, &l2_cache->cluster_cpus);drivers/edac/al_l2_edac.c line 175
Quoted 10 lines
drivers/edac/al_l2_edac.c new file +10
-0+ } + +of_node_put (cpu); + } + +if (list_empty (&al_l2->l2_caches)) { +dev_err (dev,"L2 Cache list is empty for EDAC device\n" ); + ret = -EINVAL ; + goto err; + }You are doing this at probe time to create a static list of which CPUs map onto the L2 caches. cacheinfo does something very similar, but it looks like you can't use it as its only populated for online CPUs, and you'd need to walk multiple CPUs cacheinfo leaves to find the same information. The alternative is more complicated.
drivers/edac/al_l2_edac.c line 178
Quoted 2 lines
drivers/edac/al_l2_edac.c new file +2
-0+ ret =edac_device_add_device (edac_dev); +if (ret)Any references held in the
al_l2->l2_cacheslist leak here.Quoted 10 lines
drivers/edac/al_l2_edac.c new file +10
-0+ goto err; + +return 0 ; + +err: +dev_err (dev,"Failed to add L2 edac device (%d)\n" , ret); +edac_device_free_ctl_info (edac_dev); + +return ret; +}
Quoted 5 lines
drivers/edac/al_l2_edac.c line 192
Quoted 3 lines
drivers/edac/al_l2_edac.c new file +3
-0+static int al_l2_edac_remove (struct platform_device *pdev) +{ +struct edac_device_ctl_info *edac_dev =platform_get_drvdata (pdev);Do you need to roll over the
al_l2->l2_cacheslist toof_node_put()the l2_cache's ?
will add loop after for_each_possible_cpu() to call of_node_put() on each l2_cache.
Quoted 10 lines
Quoted 7 lines
drivers/edac/al_l2_edac.c new file +5
-0+edac_device_del_device (edac_dev->dev); +edac_device_free_ctl_info (edac_dev); + +return 0 ; +}[..]
Quoted 7 lines
drivers/edac/al_l2_edac.c line 204
Quoted 5 lines
drivers/edac/al_l2_edac.c new file +5
-0+static const struct of_device_id al_l2_edac_of_match[] = { + { .compatible ="al,alpine-v2" }, + { .compatible ="amazon,alpine-v3" }, + {} +};Same comment on these being machine compatibles and what property that applies to.
Fix comments from your review from L1 driver.
Quoted 8 lines
The code to match the platform and create the
platform_deviceis identical, is there any way it can be shared?I'm guessing the two-files is because these can be built as independent modules. Would anyone ever have one, but not the other? The L1 support is optional, but you've listed the same set of platforms in both cases here, so do we need to support one but not the other today?
It's not related to that platform will have one, but not the other. The two drivers are not related to each other, I agree with you that there is identical code in matching platform. But this is not good reason to combine the two drivers.
Thanks,
Hanna
Quoted 6 lines
Thanks,
James