Skip to contentSkip to conversation

iotests: 205: support only raw format

PATCH In review Vladimir Sementsov-Ogievskiy 3 participants 3 messages Feb 5, 2018

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 iotests: 205: support only raw format

The test is about qmp interface to NBD server, so there no reasons to run it for various disk formats. Also it actually do not support luks format, so, disable all format except raw.

---
 tests/qemu-iotests/205 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tests/qemu-iotests/205 +1 -1
index 10388920dc..a78ff37104 100644
@@ -153,4 +153,4 @@ class TestNbdServerRemove(iotests.QMPTestCase):
 
 
 if __name__ == '__main__':
-    iotests.main()
+    iotests.main(supported_fmts=['raw'])
Signature · 1 line
2.11.1
#1 lore raw
Quoted 14 lines · Vladimir Sementsov-Ogievskiy

The test is about qmp interface to NBD server, so there no reasons to run it for various disk formats. Also it actually do not support luks format, so, disable all format except raw.

---
 tests/qemu-iotests/205 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tests/qemu-iotests/205 +0 -0
index 10388920dc..a78ff37104 100644

tests/qemu-iotests/205 class TestNbdServerRemove(iotests.QMPTestCase): · line 156

Quoted 5 lines
tests/qemu-iotests/205 +1 -1
@@ -153,4 +153,4 @@ class TestNbdServerRemove(iotests.QMPTestCase):
 
 
 if __name__ == '__main__':
-    iotests.main()
+    iotests.main(supported_fmts=['raw'])

Isn't that stricter than necessary? The test works with qcow2; it was just luks that was special (because we weren't passing in proper secrets). At any rate, I'm adding Dan in case he has a quick idea of what it would take to get luks working, rather than just disabling it.

Signature · 3 lines
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org
#2 lore raw
Quoted 17 lines · Eric Blake
Quoted 16 lines · Vladimir Sementsov-Ogievskiy

The test is about qmp interface to NBD server, so there no reasons to run it for various disk formats. Also it actually do not support luks format, so, disable all format except raw.

---
 tests/qemu-iotests/205 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tests/qemu-iotests/205 +0 -0
index 10388920dc..a78ff37104 100644
@@ -153,4 +153,4 @@ class TestNbdServerRemove(iotests.QMPTestCase):
 
 
Quoted 8 lines

tests/qemu-iotests/205 class TestNbdServerRemove(iotests.QMPTestCase): · line 156

Quoted 3 lines
tests/qemu-iotests/205 +1 -1
 if __name__ == '__main__':
-    iotests.main()
+    iotests.main(supported_fmts=['raw'])

Isn't that stricter than necessary? The test works with qcow2; it was just luks that was special (because we weren't passing in proper secrets). At any rate, I'm adding Dan in case he has a quick idea of what it would take to get luks working, rather than just disabling it.

For shell based tests it is not too difficult as I've got much fo the support work done. This is a python tests though, so would need some prep work first. The key is that you need to be able to add extra args to QEMU to define the secret with --object, and use the full blockdev options based syntax for -drive.

I'm not expecting you todo that unless you're actively interested in it, so no objection to just disabling it

I will point out though there is an 'unsupported_fmts' arg to the python tests, so a flexible fix would be to invert your patch todo

unsupported_fmts=['luks']

Regards,
Daniel

Signature · 3 lines
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|