mmc: core: Fix ambiguous TRIM and DISCARD arg
PATCH 1/1 mmc: core: Fix ambiguous TRIM and DISCARD arg
Clean up the MMC_TRIM_ARGS define that became ambiguous with DISCARD introduction.
While at it fix one usage where MMC_TRIM_ARGS falsely included DISCARD, too.
---
Previously submitted as mmc: core: Do not require secure trim for discard
drivers/mmc/core/core.c | 10 ++++++++-- include/linux/mmc/mmc.h | 2 +- 2 files changed, 9 insertions(+), 3 deletions(-)
drivers/mmc/core/core.c +8 -2
@@ -1478,6 +1478,11 @@ void mmc_init_erase(struct mmc_card *card) card->pref_erase =0 ; } +static bool is_trim_arg (unsigned int arg) +{ +return (arg &MMC_TRIM_OR_DISCARD_ARGS ) && arg !=MMC_DISCARD_ARG ; +} +static unsigned int mmc_mmc_erase_timeout (struct mmc_card *card,unsigned int arg,unsigned int qty) {
@@ -1760,7 +1765,7 @@ int mmc_erase(struct mmc_card *card, unsigned int from, unsigned int nr, !(card->ext_csd.sec_feature_support & EXT_CSD_SEC_ER_EN))return -EOPNOTSUPP ; -if (mmc_card_mmc (card) && (arg &MMC_TRIM_ARGS ) && +if (mmc_card_mmc (card) &&is_trim_arg (arg) && !(card->ext_csd.sec_feature_support &EXT_CSD_SEC_GB_CL_EN ))return -EOPNOTSUPP ;
@@ -1790,7 +1795,8 @@ int mmc_erase(struct mmc_card *card, unsigned int from, unsigned int nr,* identified by the card->eg_boundary flag. */ rem = card->erase_size - (from % card->erase_size); -if ((arg &MMC_TRIM_ARGS ) && (card->eg_boundary) && (nr > rem)) { +if ((arg &MMC_TRIM_OR_DISCARD_ARGS ) && (card->eg_boundary) && + (nr > rem)) { err =mmc_do_erase (card, from, from + rem -1 , arg); from += rem;if ((err) || (to <= from))
include/linux/mmc/mmc.h +1 -1
@@ -451,7 +451,7 @@ static inline bool mmc_ready_for_data(u32 status)#define MMC_SECURE_TRIM1_ARG 0x80000001#define MMC_SECURE_TRIM2_ARG 0x80008000#define MMC_SECURE_ARGS 0x80000000 -#define MMC_TRIM_ARGS 0x00008001 +#define MMC_TRIM_OR_DISCARD_ARGS 0x00008003#define mmc_driver_type_mask (n) (1 << (n))
Signature · 5 lines
2.37.3 Hyperstone GmbH | Reichenaustr. 39a | 78467 Konstanz Managing Director: Dr. Jan Peter Berns. Commercial register of local courts: Freiburg HRB381782
Quoted 7 lines · Christian Löhle
Clean up the
MMC_TRIM_ARGSdefine that became ambiguous with DISCARD introduction.
While at it fix one usage whereMMC_TRIM_ARGSfalsely included DISCARD, too.Fixes b3bf915308ca ("mmc: core: new discard feature support at eMMC v4.5")
A blank line is unusual here
Quoted 1 line
Signed-off-by Christian Loehle <[email protected]>
One nitpick below otherwise:
Quoted 32 lines
---
Previously submitted as mmc: core: Do not require secure trim for discarddrivers/mmc/core/core.c | 10 ++++++++-- include/linux/mmc/mmc.h | 2 +- 2 files changed, 9 insertions(+), 3 deletions(-)drivers/mmc/core/core.c +6
-1@@ -1478,6 +1478,11 @@ void mmc_init_erase(struct mmc_card *card) card->pref_erase =0 ; } +static bool is_trim_arg (unsigned int arg) +{ +return (arg &MMC_TRIM_OR_DISCARD_ARGS ) && arg !=MMC_DISCARD_ARG ; +} +static unsigned int mmc_mmc_erase_timeout (struct mmc_card *card,unsigned int arg,unsigned int qty) {@@ -1760,7 +1765,7 @@ int mmc_erase(struct mmc_card *card, unsigned int from, unsigned int nr, !(card->ext_csd.sec_feature_support & EXT_CSD_SEC_ER_EN))return -EOPNOTSUPP ; -if (mmc_card_mmc (card) && (arg &MMC_TRIM_ARGS ) && +if (mmc_card_mmc (card) &&is_trim_arg (arg) && !(card->ext_csd.sec_feature_support &EXT_CSD_SEC_GB_CL_EN ))return -EOPNOTSUPP ;
drivers/mmc/core/core.c int mmc_erase(struct mmc_card *card, unsigned int from, unsigned int nr, · line 1799
Quoted 6 lines
drivers/mmc/core/core.c +2
-1@@ -1790,7 +1795,8 @@ int mmc_erase(struct mmc_card *card, unsigned int from, unsigned int nr,* identified by the card->eg_boundary flag. */ rem = card->erase_size - (from % card->erase_size); -if ((arg &MMC_TRIM_ARGS ) && (card->eg_boundary) && (nr > rem)) { +if ((arg &MMC_TRIM_OR_DISCARD_ARGS ) && (card->eg_boundary) && + (nr > rem)) {
Parenthesis are not needed around "card->eg_boundary)" nor "nr > rem" If you take them out, then the line doesn't need wrapping either.
Quoted 16 lines
drivers/mmc/core/core.c +0
-0err =mmc_do_erase (card, from, from + rem -1 , arg); from += rem;if ((err) || (to <= from))include/linux/mmc/mmc.h +1
-1@@ -451,7 +451,7 @@ static inline bool mmc_ready_for_data(u32 status)#define MMC_SECURE_TRIM1_ARG 0x80000001#define MMC_SECURE_TRIM2_ARG 0x80008000#define MMC_SECURE_ARGS 0x80000000 -#define MMC_TRIM_ARGS 0x00008001 +#define MMC_TRIM_OR_DISCARD_ARGS 0x00008003#define mmc_driver_type_mask (n) (1 << (n))